@starci/eslint-canon-fe 1.3.1 → 1.4.0

package/file-layout.mjs

@@ -22,7 +22,7 @@ const TWO_FILE_TIERS = /\/src\/components\/(pages|layouts)\/([^/]+)\/(.+)$/
 const TWO_FILE_TIERS_WITH_CATEGORY = /\/src\/components\/(overlays)\/[^/]+\/([^/]+)\/(.+)$/
 
 /** The two halves, and the twin test of each, are the whole of what a surface folder may hold. */
-const ALLOWED_IN_SURFACE_FOLDER = /^(?:component|index)(?:\.test)?\.tsx?$/
+const ALLOWED_IN_SURFACE_FOLDER = /^(?:component|index)(?:\.spec)?\.tsx?$/
 
 /** Folders that are not component code, whatever they are nested inside. */
 const NON_COMPONENT_FOLDERS = /\/src\/components\/.*\/(constants|utils|types|hooks)\//
@@ -240,9 +240,9 @@ const ROUTE_TREE_EXEMPT = /^(?:api\/|_)/
  *
  * The name is deliberately not required to match `page` or `layout`. A route's tests split by
  * CONCERN - what the screen renders, who may reach it, where the boundary sits - and forcing them
- * into one `page.test.tsx` would buy nothing but a longer file.
+ * into one `page.spec.tsx` would buy nothing but a longer file.
  */
-const ROUTE_TREE_TEST = /\.test\.(?:tsx?|jsx?)$/
+const ROUTE_TREE_TEST = /\.spec\.(?:tsx?|jsx?)$/
 
 /**
  * A file under `app/` names which page renders at which URL, and does nothing else.
@@ -362,6 +362,35 @@ export const noShellTier = {
   },
 }
 
+// -- FILE-9 --------------------------------------------------------------------------------------
+
+const UNIT_TEST_FILE = /\.(test|spec)\.[cm]?[jt]sx?$/
+const SEPARATE_FRONTEND_TEST_TREE = /\/(?:src\/tests|tests?\/unit|e2e)(?:\/|$)/
+
+/** Frontend units are `.spec.` twins beside the source they exercise. */
+export const unitTestColocated = {
+  meta: {
+    type: "problem",
+    docs: { description: "Frontend unit tests are colocated `.spec.` files; frontend owns no separate test tree." },
+    schema: [],
+    messages: {
+      suffix: "`{{name}}` uses the generic `.test.` suffix. A frontend unit is a colocated `.spec.` twin beside its production owner.",
+      bucket: "`{{path}}` files a frontend unit in a separate test bucket. Move the cases beside their production owner; only backend E2E owns a separate test tree.",
+    },
+  },
+  create(context) {
+    const file = normalizePath(context.filename || context.getFilename())
+    const match = file.match(UNIT_TEST_FILE)
+    if (!match) return {}
+    return {
+      Program(node) {
+        if (match[1] === "test") context.report({ node, messageId: "suffix", data: { name: file.slice(file.lastIndexOf("/") + 1) } })
+        if (SEPARATE_FRONTEND_TEST_TREE.test(file)) context.report({ node, messageId: "bucket", data: { path: file } })
+      },
+    }
+  },
+}
+
 export const rules = {
   "no-shell-tier": noShellTier,
   "source-tier-marker-matches-folder": sourceTierMarkerMatchesFolder,
@@ -371,6 +400,7 @@ export const rules = {
   "export-matches-folder": exportMatchesFolder,
   "no-runtime-namespace": noRuntimeNamespace,
   "monorepo-tier-belongs-to-its-side": monorepoTierBelongsToItsSide,
+  "unit-test-colocated": unitTestColocated,
 }
 
 /**

package/naming.mjs

@@ -44,7 +44,7 @@ export const preferArrowExport = {
 // -- NAMING-2 --------------------------------------------------------------------------------------
 
 /** Something a reader triggers is named `onX`, so the name survives being passed. */
-export const handlerOnPrefix = {
+export const handlerOnPrefix = {
   meta: {
     type: "suggestion",
     docs: { description: "Handlers are named `onX`, not `handleX`." },
@@ -70,7 +70,35 @@ export const handlerOnPrefix = {
       },
     }
   },
-}
+}
+
+// -- machine-only identity -------------------------------------------------------------------------
+
+/** A const introduces a value; it does not merely give an existing identifier a second name. */
+export const noDirectConstAlias = {
+  meta: {
+    type: "problem",
+    docs: { description: "A const must not be a direct identifier-to-identifier alias." },
+    schema: [],
+    messages: {
+      alias:
+        "`const {{alias}} = {{original}}` gives one value two names without adding behavior. Use `{{original}}` directly, or make `{{alias}}` the result of the transformation it claims to represent.",
+    },
+  },
+  create(context) {
+    return {
+      VariableDeclarator(node) {
+        if (node.parent?.kind !== "const") return
+        if (node.id?.type !== "Identifier" || node.init?.type !== "Identifier") return
+        context.report({
+          node: node.id,
+          messageId: "alias",
+          data: { alias: node.id.name, original: node.init.name },
+        })
+      },
+    }
+  },
+}
 
 /** The rules this law contributes to the plugin. */
 // -- NAMING-3 --------------------------------------------------------------------------------------
@@ -134,11 +162,12 @@ export const noSecondLanguageInPath = {
   },
 }
 
-export const rules = {
-  "prefer-arrow-export": preferArrowExport,
-  "handler-on-prefix": handlerOnPrefix,
-  "no-second-language-in-path": noSecondLanguageInPath,
-}
+export const rules = {
+  "prefer-arrow-export": preferArrowExport,
+  "handler-on-prefix": handlerOnPrefix,
+  "no-second-language-in-path": noSecondLanguageInPath,
+  "no-direct-const-alias": noDirectConstAlias,
+}
 
 /**
  * The level this law asks for, as the plugin's own opinion.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@starci/eslint-canon-fe",
-  "version": "1.3.1",
+  "version": "1.4.0",
   "description": "The StarCi front-end lint canon: every rule its laws publish, gathered as one flat-config plugin.",
   "type": "module",
   "license": "UNLICENSED",