@starci/eslint-canon-be 3.8.20 → 3.9.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (164) hide show
  1. package/CHANGELOG.md +8 -0
  2. package/package.json +1 -1
  3. package/runtime/bundle.json +192 -0
  4. package/runtime/engine/by-code-unit.mjs +6 -6
  5. package/runtime/engine/model-config.mjs +98 -76
  6. package/runtime/engine/orca-config.mjs +22 -17
  7. package/runtime/engine/release-config.mjs +22 -18
  8. package/runtime/engine/removed-vocabulary.mjs +21 -20
  9. package/runtime/engine/resources-config.mjs +42 -35
  10. package/runtime/engine/runtime-root.mjs +11 -13
  11. package/runtime/engine/secrets.mjs +170 -102
  12. package/runtime/engine/sonar-config.mjs +16 -13
  13. package/runtime/engine/temp-root.mjs +3 -9
  14. package/runtime/knowledge/hfs/canon-pins.yaml +10 -10
  15. package/runtime/knowledge/hfs/rules.yaml +6 -6
  16. package/runtime/knowledge/hfs/slots.yaml +2 -2
  17. package/runtime/knowledge/sonar-gate.yaml +1 -1
  18. package/runtime/packages/hfs/templates/app/package-scripts/package.json +1 -1
  19. package/runtime/scripts/api/git/cat-file.mjs +0 -1
  20. package/runtime/scripts/api/git/config-get.mjs +1 -2
  21. package/runtime/scripts/api/git/diff.mjs +0 -1
  22. package/runtime/scripts/api/git/lib.mjs +32 -32
  23. package/runtime/scripts/api/git/ls-files.mjs +0 -1
  24. package/runtime/scripts/api/git/ls-tree.mjs +0 -1
  25. package/runtime/scripts/api/git/merge-base.mjs +2 -3
  26. package/runtime/scripts/api/git/remote.mjs +0 -1
  27. package/runtime/scripts/api/git/rev-parse-query.mjs +0 -1
  28. package/runtime/scripts/api/git/show.mjs +0 -1
  29. package/runtime/scripts/hfs/allows.mjs +37 -38
  30. package/runtime/scripts/hfs/architecture/ast-walks.mjs +180 -163
  31. package/runtime/scripts/hfs/architecture/automatic-gates.mjs +80 -73
  32. package/runtime/scripts/hfs/architecture/backend-app-files.mjs +88 -77
  33. package/runtime/scripts/hfs/architecture/backend.mjs +378 -357
  34. package/runtime/scripts/hfs/architecture/background-unowned.mjs +201 -187
  35. package/runtime/scripts/hfs/architecture/canon-clones.mjs +260 -209
  36. package/runtime/scripts/hfs/architecture/canon-jsx-clones.mjs +149 -116
  37. package/runtime/scripts/hfs/architecture/client-reaches-server.mjs +72 -68
  38. package/runtime/scripts/hfs/architecture/clones.mjs +212 -217
  39. package/runtime/scripts/hfs/architecture/config-unread.mjs +7 -9
  40. package/runtime/scripts/hfs/architecture/config.mjs +302 -268
  41. package/runtime/scripts/hfs/architecture/connection-map.mjs +258 -225
  42. package/runtime/scripts/hfs/architecture/constructor-deps.mjs +80 -71
  43. package/runtime/scripts/hfs/architecture/context-coupling.mjs +82 -77
  44. package/runtime/scripts/hfs/architecture/context-map.mjs +267 -234
  45. package/runtime/scripts/hfs/architecture/context-owner.mjs +73 -61
  46. package/runtime/scripts/hfs/architecture/context-platform-tables.mjs +47 -43
  47. package/runtime/scripts/hfs/architecture/context-transaction.mjs +54 -52
  48. package/runtime/scripts/hfs/architecture/contract-fixture-guard.mjs +113 -104
  49. package/runtime/scripts/hfs/architecture/contracts-readonly.mjs +288 -270
  50. package/runtime/scripts/hfs/architecture/contracts.mjs +408 -393
  51. package/runtime/scripts/hfs/architecture/cross-app-duplicate.mjs +50 -51
  52. package/runtime/scripts/hfs/architecture/dead-exports-bindings.mjs +143 -119
  53. package/runtime/scripts/hfs/architecture/dead-exports.mjs +286 -228
  54. package/runtime/scripts/hfs/architecture/default-deny.mjs +129 -110
  55. package/runtime/scripts/hfs/architecture/doc-language.mjs +24 -19
  56. package/runtime/scripts/hfs/architecture/entity-registry.mjs +20 -22
  57. package/runtime/scripts/hfs/architecture/entrypoint.mjs +47 -45
  58. package/runtime/scripts/hfs/architecture/error-codes.mjs +37 -35
  59. package/runtime/scripts/hfs/architecture/error-masked.mjs +55 -59
  60. package/runtime/scripts/hfs/architecture/fe-slot-allows.mjs +24 -23
  61. package/runtime/scripts/hfs/architecture/feature-shape.mjs +40 -38
  62. package/runtime/scripts/hfs/architecture/framework-pinned.mjs +21 -21
  63. package/runtime/scripts/hfs/architecture/frontend-block-render.mjs +106 -98
  64. package/runtime/scripts/hfs/architecture/frontend-grammar.mjs +153 -150
  65. package/runtime/scripts/hfs/architecture/frontend-routing.mjs +161 -149
  66. package/runtime/scripts/hfs/architecture/frontend-world-render.mjs +343 -305
  67. package/runtime/scripts/hfs/architecture/frontend-world.mjs +340 -294
  68. package/runtime/scripts/hfs/architecture/frontend.mjs +174 -184
  69. package/runtime/scripts/hfs/architecture/function-spec-providers.mjs +124 -106
  70. package/runtime/scripts/hfs/architecture/hfs-graph.mjs +52 -48
  71. package/runtime/scripts/hfs/architecture/hooks-are-hooks.mjs +81 -71
  72. package/runtime/scripts/hfs/architecture/i18n-keys.mjs +155 -141
  73. package/runtime/scripts/hfs/architecture/identity.mjs +141 -125
  74. package/runtime/scripts/hfs/architecture/index.mjs +272 -272
  75. package/runtime/scripts/hfs/architecture/injection-token-exported.mjs +45 -43
  76. package/runtime/scripts/hfs/architecture/jwt-ast.mjs +195 -176
  77. package/runtime/scripts/hfs/architecture/machine-ast.mjs +163 -155
  78. package/runtime/scripts/hfs/architecture/managed-scripts.mjs +19 -20
  79. package/runtime/scripts/hfs/architecture/module-per-transport.mjs +177 -172
  80. package/runtime/scripts/hfs/architecture/next-data-contract.mjs +100 -78
  81. package/runtime/scripts/hfs/architecture/next-data-inference.mjs +170 -154
  82. package/runtime/scripts/hfs/architecture/next-data-key.mjs +311 -275
  83. package/runtime/scripts/hfs/architecture/next-data-symbols.mjs +17 -17
  84. package/runtime/scripts/hfs/architecture/next-data.mjs +351 -334
  85. package/runtime/scripts/hfs/architecture/operation-contract-roots.mjs +39 -37
  86. package/runtime/scripts/hfs/architecture/owners.mjs +97 -98
  87. package/runtime/scripts/hfs/architecture/package-shape.mjs +56 -55
  88. package/runtime/scripts/hfs/architecture/presentation.mjs +138 -130
  89. package/runtime/scripts/hfs/architecture/reachability.mjs +258 -241
  90. package/runtime/scripts/hfs/architecture/register-once.mjs +152 -139
  91. package/runtime/scripts/hfs/architecture/registration.mjs +301 -267
  92. package/runtime/scripts/hfs/architecture/required-files.mjs +172 -167
  93. package/runtime/scripts/hfs/architecture/route-files-thin.mjs +85 -77
  94. package/runtime/scripts/hfs/architecture/schema-owner.mjs +206 -181
  95. package/runtime/scripts/hfs/architecture/server-action.mjs +48 -48
  96. package/runtime/scripts/hfs/architecture/side-boundary.mjs +2 -5
  97. package/runtime/scripts/hfs/architecture/source-names-shape.mjs +261 -259
  98. package/runtime/scripts/hfs/architecture/source-names.mjs +304 -278
  99. package/runtime/scripts/hfs/architecture/sql-keys.mjs +277 -194
  100. package/runtime/scripts/hfs/architecture/sql-owner.mjs +236 -194
  101. package/runtime/scripts/hfs/architecture/sql-returning.mjs +46 -45
  102. package/runtime/scripts/hfs/architecture/sql-token-forms.mjs +86 -74
  103. package/runtime/scripts/hfs/architecture/sql-tokens.mjs +456 -341
  104. package/runtime/scripts/hfs/architecture/staged-consumers.mjs +35 -30
  105. package/runtime/scripts/hfs/architecture/surface.mjs +64 -74
  106. package/runtime/scripts/hfs/architecture/symbols.mjs +209 -216
  107. package/runtime/scripts/hfs/architecture/test-world-files.mjs +165 -155
  108. package/runtime/scripts/hfs/architecture/tiers.mjs +161 -154
  109. package/runtime/scripts/hfs/architecture/transport-owner.mjs +155 -149
  110. package/runtime/scripts/hfs/architecture/type-context.mjs +255 -250
  111. package/runtime/scripts/hfs/architecture/typescript.mjs +358 -318
  112. package/runtime/scripts/hfs/architecture/unit-spec-providers.mjs +110 -92
  113. package/runtime/scripts/hfs/declaration-shape.mjs +140 -103
  114. package/runtime/scripts/hfs/declaration-slots.mjs +64 -61
  115. package/runtime/scripts/hfs/edition-slots.mjs +43 -40
  116. package/runtime/scripts/hfs/linear-text.mjs +20 -20
  117. package/runtime/scripts/hfs/param-names.mjs +6 -11
  118. package/runtime/scripts/hfs/path-findings.mjs +120 -100
  119. package/runtime/scripts/hfs/repo-identity.mjs +55 -42
  120. package/runtime/scripts/hfs/rule-catalog.mjs +353 -257
  121. package/runtime/scripts/hfs/rule-params-shape.mjs +60 -47
  122. package/runtime/scripts/hfs/rules/database-migrations.mjs +428 -388
  123. package/runtime/scripts/hfs/rules/fe-no-tests.mjs +37 -36
  124. package/runtime/scripts/hfs/rules/read.mjs +19 -15
  125. package/runtime/scripts/hfs/rules/secrets.mjs +1 -1
  126. package/runtime/scripts/hfs/rules/spec-placement.mjs +12 -13
  127. package/runtime/scripts/hfs/slot-app-view.mjs +69 -74
  128. package/runtime/scripts/hfs/slot-classify.mjs +42 -38
  129. package/runtime/scripts/hfs/slot-errors.mjs +8 -7
  130. package/runtime/scripts/hfs/slot-imports.mjs +70 -63
  131. package/runtime/scripts/hfs/slot-manifest-shape.mjs +74 -52
  132. package/runtime/scripts/hfs/slot-match.mjs +122 -111
  133. package/runtime/scripts/hfs/slot-path.mjs +0 -2
  134. package/runtime/scripts/hfs/slot-required.mjs +65 -59
  135. package/runtime/scripts/hfs/slot-semantic-problems.mjs +138 -112
  136. package/runtime/scripts/hfs/slot-side-problems.mjs +23 -19
  137. package/runtime/scripts/hfs/slots.mjs +175 -152
  138. package/runtime/scripts/hfs/test-world-slot.mjs +0 -1
  139. package/runtime/scripts/hfs/trailing-slashes.mjs +4 -4
  140. package/runtime/scripts/hfs/typescript-programs.mjs +66 -69
  141. package/runtime/scripts/hfs/view.mjs +38 -40
  142. package/runtime/scripts/lib/dockerfile.mjs +131 -114
  143. package/runtime/scripts/lib/env.mjs +3 -6
  144. package/runtime/scripts/lib/event-contract.mjs +73 -78
  145. package/runtime/scripts/lib/git.mjs +15 -16
  146. package/runtime/scripts/lib/glob.mjs +23 -14
  147. package/runtime/scripts/lib/grammar-lint.mjs +33 -37
  148. package/runtime/scripts/lib/i18n.mjs +32 -35
  149. package/runtime/scripts/lib/in-order.mjs +57 -38
  150. package/runtime/scripts/lib/json-clone.mjs +45 -36
  151. package/runtime/scripts/lib/json.mjs +26 -14
  152. package/runtime/scripts/lib/language.mjs +133 -129
  153. package/runtime/scripts/lib/list.mjs +9 -14
  154. package/runtime/scripts/lib/mutation-fence.mjs +10 -5
  155. package/runtime/scripts/lib/path-key.mjs +53 -38
  156. package/runtime/scripts/lib/read-text.mjs +30 -17
  157. package/runtime/scripts/lib/regex.mjs +1 -2
  158. package/runtime/scripts/lib/same-text.mjs +0 -1
  159. package/runtime/scripts/lib/sops-envelope.mjs +148 -120
  160. package/runtime/scripts/lib/stack-services.mjs +128 -129
  161. package/runtime/scripts/lib/ts-analysis.mjs +28 -26
  162. package/runtime/scripts/lib/ts-ast.mjs +36 -42
  163. package/runtime/scripts/lib/walk.mjs +33 -27
  164. package/runtime/scripts/lib/yaml-cached.mjs +4 -4
@@ -13,135 +13,136 @@ import { fileURLToPath } from 'node:url';
13
13
  import { loadTypescript } from '../../lib/package-at.mjs';
14
14
  import { isConstVariable } from '../../lib/ts-ast.mjs';
15
15
  import { lexicalChecker, unwrapExpression } from '../../lib/ts-analysis.mjs';
16
-
17
16
  const HERE = path.dirname(fileURLToPath(import.meta.url));
18
17
  const MIGRATION_PLAIN = /[a-z0-9]+(?:-[a-z0-9]+)*/;
19
18
  const MIGRATION_CONTRACT_TAIL = /contract_[a-z0-9]+(?:[-_][a-z0-9]+)*/;
20
19
  const MIGRATION_SLUG = [MIGRATION_PLAIN.source, MIGRATION_CONTRACT_TAIL.source, `${MIGRATION_PLAIN.source}_${MIGRATION_CONTRACT_TAIL.source}`].join('|');
21
- const MIGRATION_NAME = new RegExp(String.raw`^(\d{14})_(${MIGRATION_SLUG})\.sql$`);
20
+ const MIGRATION_NAME = new RegExp(String.raw `^(\d{14})_(${MIGRATION_SLUG})\.sql$`);
22
21
  export const isMigrationName = (name) => MIGRATION_NAME.test(name);
23
22
  const RESTAMP_HEADER = /^-- starci:restamp (\d{14}) (\d{14})(?:\r?\n|$)/;
24
23
  const withoutRestampHeader = (text) => text?.replace(RESTAMP_HEADER, '') ?? null;
25
-
26
24
  /** `<ts14>` -> the UTC instant it names, or null when the digits are no real time (month 13, day 32, ...). */
27
25
  export function migrationStamp(text) {
28
- const [year, month, day, hour, minute, second] = [Number(text.slice(0, 4)), ...[4, 6, 8, 10, 12].map((at) => Number(text.slice(at, at + 2)))];
29
- const stamp = Date.UTC(year, month - 1, day, hour, minute, second);
30
- const date = new Date(stamp);
31
- return date.getUTCFullYear() === year && date.getUTCMonth() === month - 1 && date.getUTCDate() === day
32
- && date.getUTCHours() === hour && date.getUTCMinutes() === minute && date.getUTCSeconds() === second ? stamp : null;
26
+ const [year, month, day, hour, minute, second] = [Number(text.slice(0, 4)), ...[4, 6, 8, 10, 12].map((at) => Number(text.slice(at, at + 2)))];
27
+ const stamp = Date.UTC(year, month - 1, day, hour, minute, second);
28
+ const date = new Date(stamp);
29
+ return date.getUTCFullYear() === year && date.getUTCMonth() === month - 1 && date.getUTCDate() === day
30
+ && date.getUTCHours() === hour && date.getUTCMinutes() === minute && date.getUTCSeconds() === second ? stamp : null;
33
31
  }
34
-
35
32
  /** The three git reads L02 makes: (args, {cwd}) -> {ok, stdout}. */
36
33
  export function defaultGit(args, { cwd }) {
37
- const [verb, ...rest] = args;
38
- const env = withoutGitLocalEnv(process.env);
39
- if (verb === 'merge-base') { const sha = mergeBase(cwd, rest[0], rest[1]); return { ok: sha !== null, stdout: sha ?? '' }; }
40
- let call = show;
41
- if (verb === 'ls-tree') call = lsTree;
42
- const result = call(rest, { cwd, env, maxBuffer: 64 * 1024 * 1024 });
43
- return { ok: !result.error && result.status === 0, stdout: result.stdout };
44
- }
45
-
34
+ const [verb, ...rest] = args;
35
+ const env = withoutGitLocalEnv(process.env);
36
+ if (verb === 'merge-base') {
37
+ const sha = mergeBase(cwd, rest[0], rest[1]);
38
+ return { ok: sha !== null, stdout: sha ?? '' };
39
+ }
40
+ let call = show;
41
+ if (verb === 'ls-tree')
42
+ call = lsTree;
43
+ const result = call(rest, { cwd, env, maxBuffer: 64 * 1024 * 1024 });
44
+ return { ok: !result.error && result.status === 0, stdout: result.stdout };
45
+ }
46
46
  const runGit = (git, repoRoot, args) => Promise.resolve(git(args, { cwd: repoRoot }))
47
- .then((result) => ({ ok: result?.ok === true, stdout: String(result?.stdout ?? '') }));
48
-
47
+ .then((result) => ({ ok: result?.ok === true, stdout: String(result?.stdout ?? '') }));
49
48
  async function baseShaOf(git, repoRoot, base) {
50
- let found = null;
51
- await findInOrder(base ? [base] : ['origin/main', 'main'], async (ref) => {
52
- const result = await runGit(git, repoRoot, ['merge-base', 'HEAD', ref]);
53
- if (result.ok && result.stdout.trim()) found = { ref, sha: result.stdout.trim() };
54
- return found !== null;
55
- });
56
- return found;
57
- }
58
-
49
+ let found = null;
50
+ await findInOrder(base ? [base] : ['origin/main', 'main'], async (ref) => {
51
+ const result = await runGit(git, repoRoot, ['merge-base', 'HEAD', ref]);
52
+ if (result.ok && result.stdout.trim())
53
+ found = { ref, sha: result.stdout.trim() };
54
+ return found !== null;
55
+ });
56
+ return found;
57
+ }
59
58
  async function migrationFilesAt(git, repoRoot, sha) {
60
- const result = await runGit(git, repoRoot, ['ls-tree', '-r', '--name-only', '-z', sha, '--', MIGRATIONS_DIR]);
61
- if (!result.ok) return [];
62
- const prefix = `${MIGRATIONS_DIR}/`;
63
- return result.stdout.split('\0').filter((entry) => entry.startsWith(prefix));
59
+ const result = await runGit(git, repoRoot, ['ls-tree', '-r', '--name-only', '-z', sha, '--', MIGRATIONS_DIR]);
60
+ if (!result.ok)
61
+ return [];
62
+ const prefix = `${MIGRATIONS_DIR}/`;
63
+ return result.stdout.split('\0').filter((entry) => entry.startsWith(prefix));
64
64
  }
65
-
66
65
  async function baseFileText(git, repoRoot, sha, file) {
67
- // `./` reads the path from the app root, which is a folder of a larger repository when the app is nested in one (an example of the runtime).
68
- const result = await runGit(git, repoRoot, ['show', `${sha}:./${file}`]);
69
- return result.ok ? result.stdout : null;
66
+ // `./` reads the path from the app root, which is a folder of a larger repository when the app is nested in one (an example of the runtime).
67
+ const result = await runGit(git, repoRoot, ['show', `${sha}:./${file}`]);
68
+ return result.ok ? result.stdout : null;
70
69
  }
71
-
72
70
  function localMigrationFindings(local) {
73
- const findings = [];
74
- const stamps = new Map();
75
- for (const entry of local) {
76
- if (!entry.match) {
77
- findings.push(found(DB_MIGRATION_SHAPE, entry.file, `${entry.file} is not named <ts14>_<kebab>.sql; a migration is created by \`npm run db:new\` (starci app db new), never renamed by hand`, { expected: '<ts14>_<kebab>.sql' }));
78
- continue;
71
+ const findings = [];
72
+ const stamps = new Map();
73
+ for (const entry of local) {
74
+ if (!entry.match) {
75
+ findings.push(found(DB_MIGRATION_SHAPE, entry.file, `${entry.file} is not named <ts14>_<kebab>.sql; a migration is created by \`npm run db:new\` (starci app db new), never renamed by hand`, { expected: '<ts14>_<kebab>.sql' }));
76
+ continue;
77
+ }
78
+ const stamp = migrationStamp(entry.match[1]);
79
+ if (stamp === null) {
80
+ findings.push(found(DB_MIGRATION_SHAPE, entry.file, `${entry.file} carries ${entry.match[1]}, which is no valid UTC time; a migration stamp must name a valid UTC instant`, { stamp: entry.match[1] }));
81
+ continue;
82
+ }
83
+ if (stamps.has(stamp))
84
+ findings.push(found(DB_MIGRATION_SHAPE, entry.file, `${entry.file} shares stamp ${entry.match[1]} with ${stamps.get(stamp)}; stamps are strictly increasing`, { stamp: entry.match[1], other: stamps.get(stamp) }));
85
+ stamps.set(stamp, entry.file);
79
86
  }
80
- const stamp = migrationStamp(entry.match[1]);
81
- if (stamp === null) {
82
- findings.push(found(DB_MIGRATION_SHAPE, entry.file, `${entry.file} carries ${entry.match[1]}, which is no valid UTC time; a migration stamp must name a valid UTC instant`, { stamp: entry.match[1] }));
83
- continue;
84
- }
85
- if (stamps.has(stamp)) findings.push(found(DB_MIGRATION_SHAPE, entry.file, `${entry.file} shares stamp ${entry.match[1]} with ${stamps.get(stamp)}; stamps are strictly increasing`, { stamp: entry.match[1], other: stamps.get(stamp) }));
86
- stamps.set(stamp, entry.file);
87
- }
88
- return findings;
87
+ return findings;
89
88
  }
90
-
91
89
  /** HEAD owns the append boundary. Archived names retire the old chain, so a replacement baseline starts afresh. */
92
90
  function migrationHistory(files, retired, localNames) {
93
- const prefix = `${MIGRATIONS_DIR}/`;
94
- const onHead = new Set(files.filter(isActiveMigration).map((file) => file.slice(prefix.length)));
95
- const retiredNames = new Set([...retired, ...files.filter((file) => file.startsWith(`${MIGRATIONS_ARCHIVE_DIR}/`)).map((file) => file.slice(MIGRATIONS_ARCHIVE_DIR.length + 1))].filter((name) => !localNames.has(name)));
96
- const stamps = [...onHead].filter((name) => !retiredNames.has(name)).map((name) => MIGRATION_NAME.exec(name)?.[1]).filter(Boolean).map(migrationStamp).filter((stamp) => stamp !== null);
97
- return { onHead, latest: stamps.length ? Math.max(...stamps) : null };
91
+ const prefix = `${MIGRATIONS_DIR}/`;
92
+ const onHead = new Set(files.filter(isActiveMigration).map((file) => file.slice(prefix.length)));
93
+ const retiredNames = new Set([...retired, ...files.filter((file) => file.startsWith(`${MIGRATIONS_ARCHIVE_DIR}/`)).map((file) => file.slice(MIGRATIONS_ARCHIVE_DIR.length + 1))].filter((name) => !localNames.has(name)));
94
+ const stamps = [...onHead].filter((name) => !retiredNames.has(name)).map((name) => MIGRATION_NAME.exec(name)?.[1]).filter((stamp) => Boolean(stamp)).map(migrationStamp).filter((stamp) => stamp !== null);
95
+ return { onHead, latest: stamps.length ? Math.max(...stamps) : null };
98
96
  }
99
-
100
97
  function migrationOrderingFindings(local, history, restamped = new Set()) {
101
- return local.flatMap((entry) => {
102
- const stamp = entry.match ? migrationStamp(entry.match[1]) : null;
103
- if (history.onHead.has(entry.name) || restamped.has(entry.name) || stamp === null || history.latest === null || stamp > history.latest) return [];
104
- return [found(DB_MIGRATION_SHAPE, entry.file, `${entry.file} is stamped ${entry.match[1]}, not after every migration already in repository history (latest active ${new Date(history.latest).toISOString()}); a new migration sorts after the committed active chain`, { stamp: entry.match[1], latest: new Date(history.latest).toISOString() })];
105
- });
98
+ return local.flatMap((entry) => {
99
+ const stamp = entry.match ? migrationStamp(entry.match[1]) : null;
100
+ if (history.onHead.has(entry.name) || restamped.has(entry.name) || stamp === null || history.latest === null || stamp > history.latest)
101
+ return [];
102
+ return [found(DB_MIGRATION_SHAPE, entry.file, `${entry.file} is stamped ${entry.match[1]}, not after every migration already in repository history (latest active ${new Date(history.latest).toISOString()}); a new migration sorts after the committed active chain`, { stamp: entry.match[1], latest: new Date(history.latest).toISOString() })];
103
+ });
106
104
  }
107
-
108
105
  /** A restamp changes only the version, and its header proves the explicit old->new map against repository SQL. */
109
106
  async function verifiedRestamps(local, files, repoRoot, git, sha) {
110
- const prefix = `${MIGRATIONS_DIR}/`;
111
- const active = files.filter(isActiveMigration).map((file) => file.slice(prefix.length));
112
- const claims = local.map((entry) => ({ ...entry, header: RESTAMP_HEADER.exec(readText(repoRoot, entry.file) ?? '') })).filter((entry) => entry.header);
113
- const accepted = [];
114
- await eachInOrder(claims, async (entry) => {
115
- const [, oldStamp, newStamp] = entry.header;
116
- if (!entry.match || entry.match[1] !== newStamp || migrationStamp(oldStamp) === null || oldStamp === newStamp) return;
117
- if (claims.filter((claim) => claim.header[1] === oldStamp).length !== 1) return;
118
- const names = active.filter((name) => name.startsWith(`${oldStamp}_`) && name.slice(14) === entry.name.slice(14));
119
- if (names.length !== 1 || local.some((candidate) => candidate.name === names[0])) return;
120
- const committed = await baseFileText(git, repoRoot, sha, `${prefix}${names[0]}`);
121
- if (committed === null || !sameText(withoutRestampHeader(readText(repoRoot, entry.file)), withoutRestampHeader(committed))) return;
122
- accepted.push({ source: names[0], destination: entry.name });
123
- });
124
- return accepted;
125
- }
126
-
107
+ const prefix = `${MIGRATIONS_DIR}/`;
108
+ const active = files.filter(isActiveMigration).map((file) => file.slice(prefix.length));
109
+ const claims = local.map((entry) => ({ ...entry, header: RESTAMP_HEADER.exec(readText(repoRoot, entry.file) ?? '') })).filter((entry) => entry.header);
110
+ const accepted = [];
111
+ await eachInOrder(claims, async (entry) => {
112
+ const [, oldStamp, newStamp] = entry.header;
113
+ if (!entry.match || entry.match[1] !== newStamp || migrationStamp(oldStamp) === null || oldStamp === newStamp)
114
+ return;
115
+ if (claims.filter((claim) => claim.header[1] === oldStamp).length !== 1)
116
+ return;
117
+ const names = active.filter((name) => name.startsWith(`${oldStamp}_`) && name.slice(14) === entry.name.slice(14));
118
+ if (names.length !== 1 || local.some((candidate) => candidate.name === names[0]))
119
+ return;
120
+ const committed = await baseFileText(git, repoRoot, sha, `${prefix}${names[0]}`);
121
+ if (committed === null || !sameText(withoutRestampHeader(readText(repoRoot, entry.file)), withoutRestampHeader(committed)))
122
+ return;
123
+ accepted.push({ source: names[0], destination: entry.name });
124
+ });
125
+ return accepted;
126
+ }
127
127
  async function baseMigrationEntryFindings(entry, repoRoot, git, baseSha, onBase) {
128
- if (!entry.match) return [];
129
- if (onBase.has(entry.name)) {
130
- const committed = await baseFileText(git, repoRoot, baseSha.sha, entry.file);
131
- const current = readText(repoRoot, entry.file);
132
- if (!sameText(current, committed)) return [found(DB_MIGRATION_SHAPE, entry.file, `${entry.file} differs from its content on ${baseSha.ref}; a migration on the base branch is immutable - write a new migration`, { base: baseSha.ref })];
133
- }
134
- return [];
135
- }
136
-
128
+ if (!entry.match)
129
+ return [];
130
+ if (onBase.has(entry.name)) {
131
+ const committed = await baseFileText(git, repoRoot, baseSha.sha, entry.file);
132
+ const current = readText(repoRoot, entry.file);
133
+ if (!sameText(current, committed))
134
+ return [found(DB_MIGRATION_SHAPE, entry.file, `${entry.file} differs from its content on ${baseSha.ref}; a migration on the base branch is immutable - write a new migration`, { base: baseSha.ref })];
135
+ }
136
+ return [];
137
+ }
137
138
  function removedMigrationFindings(local, retired, baseNames, baseSha) {
138
- const findings = [];
139
- for (const name of baseNames) {
140
- if (!local.some((entry) => entry.name === name) && !retired.has(name)) findings.push(found(DB_MIGRATION_SHAPE, `${MIGRATIONS_DIR}/${name}`, `${MIGRATIONS_DIR}/${name} exists on ${baseSha.ref} but is gone here; a migration on the base branch is immutable - restore it`, { base: baseSha.ref }));
141
- }
142
- return findings;
139
+ const findings = [];
140
+ for (const name of baseNames) {
141
+ if (!local.some((entry) => entry.name === name) && !retired.has(name))
142
+ findings.push(found(DB_MIGRATION_SHAPE, `${MIGRATIONS_DIR}/${name}`, `${MIGRATIONS_DIR}/${name} exists on ${baseSha.ref} but is gone here; a migration on the base branch is immutable - restore it`, { base: baseSha.ref }));
143
+ }
144
+ return findings;
143
145
  }
144
-
145
146
  /**
146
147
  * L02 findings for names, stamps, ordering and immutability of db/migrations/*.sql. `archived` are the files of
147
148
  * db/migrations/archive/ (app.db.migrations.archive): never judged, and a migration moved there at a baseline
@@ -149,341 +150,380 @@ function removedMigrationFindings(local, retired, baseNames, baseSha) {
149
150
  * on archived migrations, remote branches and the wall clock do not constrain a replacement baseline.
150
151
  */
151
152
  export async function migrationShapeFindings({ repoRoot, migrations, archived = [], git, base }) {
152
- const prefix = `${MIGRATIONS_DIR}/`;
153
- const local = migrations.map((file) => {
154
- const name = file.startsWith(prefix) ? file.slice(prefix.length) : file;
155
- return { file, name, match: MIGRATION_NAME.exec(name) };
156
- });
157
- const findings = localMigrationFindings(local);
158
- const retired = new Set(archived.map((file) => file.slice(MIGRATIONS_ARCHIVE_DIR.length + 1)));
159
- const headFiles = await migrationFilesAt(git, repoRoot, 'HEAD');
160
- const baseSha = await baseShaOf(git, repoRoot, base);
161
- const baseFiles = baseSha ? await migrationFilesAt(git, repoRoot, baseSha.sha) : [];
162
- const restamps = await verifiedRestamps(local, baseSha ? baseFiles : headFiles, repoRoot, git, baseSha?.sha ?? 'HEAD');
163
- for (const restamp of restamps) retired.add(restamp.source);
164
- const history = migrationHistory(headFiles, retired, new Set(local.map((entry) => entry.name)));
165
- findings.push(...migrationOrderingFindings(local, history, new Set(restamps.map((entry) => entry.destination))));
166
- if (!baseSha) return findings;
167
- const baseNames = baseFiles.filter(isActiveMigration).map((file) => file.slice(prefix.length));
168
- const onBase = new Set(baseNames);
169
- await eachInOrder(local, async (entry) => {
170
- findings.push(...await baseMigrationEntryFindings(entry, repoRoot, git, baseSha, onBase));
171
- });
172
- findings.push(...removedMigrationFindings(local, retired, baseNames, baseSha));
173
- return findings;
174
- }
175
-
153
+ const prefix = `${MIGRATIONS_DIR}/`;
154
+ const local = migrations.map((file) => {
155
+ const name = file.startsWith(prefix) ? file.slice(prefix.length) : file;
156
+ return { file, name, match: MIGRATION_NAME.exec(name) };
157
+ });
158
+ const findings = localMigrationFindings(local);
159
+ const retired = new Set(archived.map((file) => file.slice(MIGRATIONS_ARCHIVE_DIR.length + 1)));
160
+ const headFiles = await migrationFilesAt(git, repoRoot, 'HEAD');
161
+ const baseSha = await baseShaOf(git, repoRoot, base);
162
+ const baseFiles = baseSha ? await migrationFilesAt(git, repoRoot, baseSha.sha) : [];
163
+ const restamps = await verifiedRestamps(local, baseSha ? baseFiles : headFiles, repoRoot, git, baseSha?.sha ?? 'HEAD');
164
+ for (const restamp of restamps)
165
+ retired.add(restamp.source);
166
+ const history = migrationHistory(headFiles, retired, new Set(local.map((entry) => entry.name)));
167
+ findings.push(...migrationOrderingFindings(local, history, new Set(restamps.map((entry) => entry.destination))));
168
+ if (!baseSha)
169
+ return findings;
170
+ const baseNames = baseFiles.filter(isActiveMigration).map((file) => file.slice(prefix.length));
171
+ const onBase = new Set(baseNames);
172
+ await eachInOrder(local, async (entry) => {
173
+ findings.push(...await baseMigrationEntryFindings(entry, repoRoot, git, baseSha, onBase));
174
+ });
175
+ findings.push(...removedMigrationFindings(local, retired, baseNames, baseSha));
176
+ return findings;
177
+ }
176
178
  const sqlName = (token) => token && ['word', 'ident'].includes(token.t) ? token.v : null;
177
179
  const sqlWord = (token, value) => token?.t === 'word' && token.v === value;
178
-
179
180
  function commentEnd(text, start) {
180
- if (text.startsWith('--', start)) {
181
- const end = text.indexOf('\n', start + 2);
182
- return end === -1 ? text.length : end;
183
- }
184
- if (!text.startsWith('/*', start)) return null;
185
- let depth = 1;
186
- let index = start + 2;
187
- while (index < text.length && depth > 0) {
188
- if (text.startsWith('/*', index)) { depth += 1; index += 2; }
189
- else if (text.startsWith('*/', index)) { depth -= 1; index += 2; }
190
- else index += 1;
191
- }
192
- return index;
193
- }
194
-
181
+ if (text.startsWith('--', start)) {
182
+ const end = text.indexOf('\n', start + 2);
183
+ return end === -1 ? text.length : end;
184
+ }
185
+ if (!text.startsWith('/*', start))
186
+ return null;
187
+ let depth = 1;
188
+ let index = start + 2;
189
+ while (index < text.length && depth > 0) {
190
+ if (text.startsWith('/*', index)) {
191
+ depth += 1;
192
+ index += 2;
193
+ }
194
+ else if (text.startsWith('*/', index)) {
195
+ depth -= 1;
196
+ index += 2;
197
+ }
198
+ else
199
+ index += 1;
200
+ }
201
+ return index;
202
+ }
195
203
  function quotedToken(text, start, quote, escaped = false) {
196
- let index = start + 1;
197
- let value = '';
198
- while (index < text.length) {
199
- if (text[index] === quote && text[index + 1] === quote) { value += quote; index += 2; }
200
- else if (text[index] === quote) return { value, end: index + 1 };
201
- else if (escaped && text[index] === '\\') { value += text[index + 1] ?? ''; index += 2; }
202
- else { value += text[index]; index += 1; }
203
- }
204
- return { value, end: index };
205
- }
206
-
204
+ let index = start + 1;
205
+ let value = '';
206
+ while (index < text.length) {
207
+ if (text[index] === quote && text[index + 1] === quote) {
208
+ value += quote;
209
+ index += 2;
210
+ }
211
+ else if (text[index] === quote)
212
+ return { value, end: index + 1 };
213
+ else if (escaped && text[index] === '\\') {
214
+ value += text[index + 1] ?? '';
215
+ index += 2;
216
+ }
217
+ else {
218
+ value += text[index];
219
+ index += 1;
220
+ }
221
+ }
222
+ return { value, end: index };
223
+ }
207
224
  function sqlTokenAt(text, index) {
208
- const char = text[index];
209
- if (char === "'" || char === '"') {
210
- const token = quotedToken(text, index, char);
211
- return { t: char === '"' ? 'ident' : 'string', v: token.value, end: token.end };
212
- }
213
- if (/[eE]/.test(char) && text[index + 1] === "'") {
214
- const token = quotedToken(text, index + 1, "'", true);
215
- return { t: 'string', v: token.value, end: token.end };
216
- }
217
- const tag = char === '$' ? /^\$(?:[A-Za-z_]\w*)?\$/.exec(text.slice(index))?.[0] : null;
218
- if (tag) {
219
- const end = text.indexOf(tag, index + tag.length);
220
- return { t: 'body', v: text.slice(index + tag.length, end === -1 ? text.length : end), end: end === -1 ? text.length : end + tag.length };
221
- }
222
- const word = /^[A-Za-z_][A-Za-z0-9_$]*/.exec(text.slice(index))?.[0];
223
- if (word) return { t: 'word', v: word.toLowerCase(), end: index + word.length };
224
- const number = /^\d+(?:\.\d+)?/.exec(text.slice(index))?.[0];
225
- if (number) return { t: 'number', v: number, end: index + number.length };
226
- return { t: 'punct', v: char, end: index + 1 };
227
- }
228
-
225
+ const char = text[index];
226
+ if (char === "'" || char === '"') {
227
+ const token = quotedToken(text, index, char);
228
+ return { t: char === '"' ? 'ident' : 'string', v: token.value, end: token.end };
229
+ }
230
+ if (/[eE]/.test(char) && text[index + 1] === "'") {
231
+ const token = quotedToken(text, index + 1, "'", true);
232
+ return { t: 'string', v: token.value, end: token.end };
233
+ }
234
+ const tag = char === '$' ? /^\$(?:[A-Za-z_]\w*)?\$/.exec(text.slice(index))?.[0] : null;
235
+ if (tag) {
236
+ const end = text.indexOf(tag, index + tag.length);
237
+ return { t: 'body', v: text.slice(index + tag.length, end === -1 ? text.length : end), end: end === -1 ? text.length : end + tag.length };
238
+ }
239
+ const word = /^[A-Za-z_][A-Za-z0-9_$]*/.exec(text.slice(index))?.[0];
240
+ if (word)
241
+ return { t: 'word', v: word.toLowerCase(), end: index + word.length };
242
+ const number = /^\d+(?:\.\d+)?/.exec(text.slice(index))?.[0];
243
+ if (number)
244
+ return { t: 'number', v: number, end: index + number.length };
245
+ return { t: 'punct', v: char, end: index + 1 };
246
+ }
229
247
  /** Synchronous SQL tokens; literal values stay internal and must never be copied to a finding. */
230
248
  export function databaseSqlTokens(text) {
231
- const tokens = [];
232
- let index = 0;
233
- let line = 1;
234
- while (index < text.length) {
235
- if (/\s/.test(text[index])) {
236
- if (text[index] === '\n') line += 1;
237
- index += 1;
238
- continue;
249
+ const tokens = [];
250
+ let index = 0;
251
+ let line = 1;
252
+ while (index < text.length) {
253
+ if (/\s/.test(text[index])) {
254
+ if (text[index] === '\n')
255
+ line += 1;
256
+ index += 1;
257
+ continue;
258
+ }
259
+ const end = commentEnd(text, index);
260
+ if (end !== null) {
261
+ line += text.slice(index, end).split('\n').length - 1;
262
+ index = end;
263
+ continue;
264
+ }
265
+ const token = sqlTokenAt(text, index);
266
+ tokens.push({ t: token.t, v: token.v, line, index });
267
+ line += text.slice(index, token.end).split('\n').length - 1;
268
+ index = token.end;
239
269
  }
240
- const end = commentEnd(text, index);
241
- if (end !== null) { line += text.slice(index, end).split('\n').length - 1; index = end; continue; }
242
- const token = sqlTokenAt(text, index);
243
- tokens.push({ t: token.t, v: token.v, line, index });
244
- line += text.slice(index, token.end).split('\n').length - 1;
245
- index = token.end;
246
- }
247
- return tokens;
248
- }
249
-
270
+ return tokens;
271
+ }
250
272
  /** Split executable SQL, retaining function bodies as opaque tokens until their language is known. */
251
273
  export function databaseSqlStatements(tokens) {
252
- const statements = [];
253
- let current = [];
254
- for (const token of tokens) {
255
- if (token.t === 'punct' && token.v === ';') {
256
- if (current.length) statements.push(current);
257
- current = [];
274
+ const statements = [];
275
+ let current = [];
276
+ for (const token of tokens) {
277
+ if (token.t === 'punct' && token.v === ';') {
278
+ if (current.length)
279
+ statements.push(current);
280
+ current = [];
281
+ }
282
+ else
283
+ current.push(token);
258
284
  }
259
- else current.push(token);
260
- }
261
- if (current.length) statements.push(current);
262
- return statements;
285
+ if (current.length)
286
+ statements.push(current);
287
+ return statements;
263
288
  }
264
-
265
289
  function executableStatementTokens(statement, depth) {
266
- const isDo = sqlWord(statement[0], 'do');
267
- const functionAt = statement.findIndex((token) => sqlWord(token, 'function') || sqlWord(token, 'procedure'));
268
- const isFunction = sqlWord(statement[0], 'create') && functionAt > 0 && functionAt < 4;
269
- if (!isDo && !isFunction) return statement;
270
- const languageAt = statement.findIndex((token) => sqlWord(token, 'language'));
271
- const language = statement[languageAt + 1]?.v ?? 'sql';
272
- if (languageAt !== -1 && !['sql', 'plpgsql'].includes(language)) return statement;
273
- return statement.flatMap((token, index) => {
274
- const body = token.t === 'body' || (token.t === 'string' && (isDo || sqlWord(statement[index - 1], 'as')));
275
- if (!body) return [token];
276
- return databaseExecutableTokens(token.v, depth + 1).map((child) => ({ ...child, line: child.line + token.line - 1 }));
277
- });
278
- }
279
-
290
+ const isDo = sqlWord(statement[0], 'do');
291
+ const functionAt = statement.findIndex((token) => sqlWord(token, 'function') || sqlWord(token, 'procedure'));
292
+ const isFunction = sqlWord(statement[0], 'create') && functionAt > 0 && functionAt < 4;
293
+ if (!isDo && !isFunction)
294
+ return statement;
295
+ const languageAt = statement.findIndex((token) => sqlWord(token, 'language'));
296
+ const language = statement[languageAt + 1]?.v ?? 'sql';
297
+ if (languageAt !== -1 && !['sql', 'plpgsql'].includes(language))
298
+ return statement;
299
+ return statement.flatMap((token, index) => {
300
+ const body = token.t === 'body' || (token.t === 'string' && (isDo || sqlWord(statement[index - 1], 'as')));
301
+ if (!body)
302
+ return [token];
303
+ return databaseExecutableTokens(token.v, depth + 1).map((child) => ({ ...child, line: child.line + token.line - 1 }));
304
+ });
305
+ }
280
306
  /** SQL and PL/pgSQL bodies are scanned; comments, data literals and other function languages are opaque. */
281
307
  export function databaseExecutableTokens(text, depth = 0) {
282
- const tokens = databaseSqlTokens(text);
283
- if (depth > 8) return tokens;
284
- return databaseSqlStatements(tokens).flatMap((statement) => [...executableStatementTokens(statement, depth), { t: 'punct', v: ';' }]);
308
+ const tokens = databaseSqlTokens(text);
309
+ if (depth > 8)
310
+ return tokens;
311
+ return databaseSqlStatements(tokens).flatMap((statement) => [...executableStatementTokens(statement, depth), { t: 'punct', v: ';' }]);
285
312
  }
286
-
287
313
  function nameAt(tokens, index) {
288
- const first = sqlName(tokens[index]);
289
- if (first === null) return null;
290
- const parts = [first];
291
- let next = index + 1;
292
- while (tokens[next]?.v === '.' && sqlName(tokens[next + 1]) !== null) { parts.push(sqlName(tokens[next + 1])); next += 2; }
293
- return { name: parts.join('.'), leaf: parts.at(-1), next };
294
- }
295
-
314
+ const first = sqlName(tokens[index]);
315
+ if (first === null)
316
+ return null;
317
+ const parts = [first];
318
+ let next = index + 1;
319
+ while (tokens[next]?.v === '.' && sqlName(tokens[next + 1]) !== null) {
320
+ parts.push(sqlName(tokens[next + 1]));
321
+ next += 2;
322
+ }
323
+ return { name: parts.join('.'), leaf: parts.at(-1), next };
324
+ }
296
325
  const skipWords = (tokens, index, words) => {
297
- let next = index;
298
- while (words.some((word) => sqlWord(tokens[next], word))) next += 1;
299
- return next;
326
+ let next = index;
327
+ while (words.some((word) => sqlWord(tokens[next], word)))
328
+ next += 1;
329
+ return next;
300
330
  };
301
-
302
331
  function dropObjects(tokens, start) {
303
- const kind = tokens[start + 1]?.v;
304
- if (!['table', 'role', 'user', 'schema', 'type', 'view', 'materialized', 'sequence', 'function', 'procedure', 'index', 'policy', 'trigger'].includes(kind)) return [];
305
- let index = skipWords(tokens, start + 2, ['view', 'if', 'exists', 'concurrently']);
306
- const objects = [];
307
- while (index < tokens.length) {
308
- const object = nameAt(tokens, index);
309
- if (!object) break;
310
- objects.push({ ...object, kind, line: tokens[start].line });
311
- if (tokens[object.next]?.v !== ',') break;
312
- index = object.next + 1;
313
- }
314
- return objects;
315
- }
316
-
332
+ const kind = tokens[start + 1]?.v;
333
+ if (!['table', 'role', 'user', 'schema', 'type', 'view', 'materialized', 'sequence', 'function', 'procedure', 'index', 'policy', 'trigger'].includes(kind))
334
+ return [];
335
+ let index = skipWords(tokens, start + 2, ['view', 'if', 'exists', 'concurrently']);
336
+ const objects = [];
337
+ while (index < tokens.length) {
338
+ const object = nameAt(tokens, index);
339
+ if (!object)
340
+ break;
341
+ objects.push({ ...object, kind, line: tokens[start].line });
342
+ if (tokens[object.next]?.v !== ',')
343
+ break;
344
+ index = object.next + 1;
345
+ }
346
+ return objects;
347
+ }
317
348
  function columnAlterObject(tokens, index, table, line) {
318
- let next = index + 1;
319
- if (sqlWord(tokens[next], 'column')) next += 1;
320
- const column = nameAt(tokens, next);
321
- if (!column) return null;
322
- const tail = tokens.slice(column.next);
323
- const type = sqlWord(tail[0], 'type') || (sqlWord(tail[0], 'set') && sqlWord(tail[1], 'data') && sqlWord(tail[2], 'type'));
324
- const notNull = sqlWord(tail[0], 'set') && sqlWord(tail[1], 'not') && sqlWord(tail[2], 'null');
325
- const defaultSet = tokens.some((token, at) => sqlWord(token, 'alter') && sqlName(tokens[at + 1 + Number(sqlWord(tokens[at + 1], 'column'))]) === column.leaf
326
- && sqlWord(tokens[at + 2 + Number(sqlWord(tokens[at + 1], 'column'))], 'set') && sqlWord(tokens[at + 3 + Number(sqlWord(tokens[at + 1], 'column'))], 'default'));
327
- if (!type && !(notNull && !defaultSet)) return null;
328
- return { name: `${table.name}.${column.name}`, leaf: column.leaf, table: table.leaf, kind: 'column', line };
329
- }
330
-
349
+ let next = index + 1;
350
+ if (sqlWord(tokens[next], 'column'))
351
+ next += 1;
352
+ const column = nameAt(tokens, next);
353
+ if (!column)
354
+ return null;
355
+ const tail = tokens.slice(column.next);
356
+ const type = sqlWord(tail[0], 'type') || (sqlWord(tail[0], 'set') && sqlWord(tail[1], 'data') && sqlWord(tail[2], 'type'));
357
+ const notNull = sqlWord(tail[0], 'set') && sqlWord(tail[1], 'not') && sqlWord(tail[2], 'null');
358
+ const defaultSet = tokens.some((token, at) => sqlWord(token, 'alter') && sqlName(tokens[at + 1 + Number(sqlWord(tokens[at + 1], 'column'))]) === column.leaf
359
+ && sqlWord(tokens[at + 2 + Number(sqlWord(tokens[at + 1], 'column'))], 'set') && sqlWord(tokens[at + 3 + Number(sqlWord(tokens[at + 1], 'column'))], 'default'));
360
+ if (!type && !(notNull && !defaultSet))
361
+ return null;
362
+ return { name: `${table.name}.${column.name}`, leaf: column.leaf, table: table.leaf, kind: 'column', line };
363
+ }
331
364
  function alteredColumn(table, column, line) {
332
- return { name: `${table.name}.${column.name}`, leaf: column.leaf, table: table.leaf, kind: 'column', line };
365
+ return { name: `${table.name}.${column.name}`, leaf: column.leaf, table: table.leaf, kind: 'column', line };
333
366
  }
334
-
335
367
  function tableActionObject(body, index, table, line) {
336
- if (sqlWord(body[index], 'drop')) {
337
- const constraint = sqlWord(body[index + 1], 'constraint');
338
- const at = skipWords(body, index + 1, ['column', 'constraint', 'if', 'exists']);
339
- if (sqlWord(body[at], 'default') || sqlWord(body[at], 'not')) return null;
340
- const column = nameAt(body, at);
341
- return column ? { ...alteredColumn(table, column, line), kind: constraint ? 'constraint' : 'column' } : null;
342
- }
343
- if (sqlWord(body[index], 'rename')) {
344
- const column = sqlWord(body[index + 1], 'column') ? nameAt(body, index + 2) : null;
345
- return column ? alteredColumn(table, column, line) : { ...table, kind: 'table', line };
346
- }
347
- return sqlWord(body[index], 'alter') ? columnAlterObject(body, index, table, line) : null;
348
- }
349
-
368
+ if (sqlWord(body[index], 'drop')) {
369
+ const constraint = sqlWord(body[index + 1], 'constraint');
370
+ const at = skipWords(body, index + 1, ['column', 'constraint', 'if', 'exists']);
371
+ if (sqlWord(body[at], 'default') || sqlWord(body[at], 'not'))
372
+ return null;
373
+ const column = nameAt(body, at);
374
+ return column ? { ...alteredColumn(table, column, line), kind: constraint ? 'constraint' : 'column' } : null;
375
+ }
376
+ if (sqlWord(body[index], 'rename')) {
377
+ const column = sqlWord(body[index + 1], 'column') ? nameAt(body, index + 2) : null;
378
+ return column ? alteredColumn(table, column, line) : { ...table, kind: 'table', line };
379
+ }
380
+ return sqlWord(body[index], 'alter') ? columnAlterObject(body, index, table, line) : null;
381
+ }
350
382
  function alterObjects(tokens, start) {
351
- const table = nameAt(tokens, skipWords(tokens, start + 2, ['if', 'exists', 'only']));
352
- if (!table) return [];
353
- const body = tokens.slice(table.next);
354
- return body.map((token, index) => tableActionObject(body, index, table, tokens[start].line)).filter(Boolean);
383
+ const table = nameAt(tokens, skipWords(tokens, start + 2, ['if', 'exists', 'only']));
384
+ if (!table)
385
+ return [];
386
+ const body = tokens.slice(table.next);
387
+ return body.map((_token, index) => tableActionObject(body, index, table, tokens[start].line)).filter(Boolean);
355
388
  }
356
-
357
389
  function truncatedObjects(tokens, start) {
358
- const objects = [];
359
- let index = skipWords(tokens, start + 1, ['table', 'only']);
360
- while (index < tokens.length) {
361
- const table = nameAt(tokens, index);
362
- if (!table) break;
363
- objects.push({ ...table, kind: 'table', line: tokens[start].line });
364
- if (tokens[table.next]?.v !== ',') break;
365
- index = skipWords(tokens, table.next + 1, ['only']);
366
- }
367
- return objects;
368
- }
369
-
390
+ const objects = [];
391
+ let index = skipWords(tokens, start + 1, ['table', 'only']);
392
+ while (index < tokens.length) {
393
+ const table = nameAt(tokens, index);
394
+ if (!table)
395
+ break;
396
+ objects.push({ ...table, kind: 'table', line: tokens[start].line });
397
+ if (tokens[table.next]?.v !== ',')
398
+ break;
399
+ index = skipWords(tokens, table.next + 1, ['only']);
400
+ }
401
+ return objects;
402
+ }
370
403
  function destructiveObjects(statement) {
371
- const objects = [];
372
- for (let index = 0; index < statement.length; index += 1) {
373
- if (sqlWord(statement[index], 'drop')) objects.push(...dropObjects(statement, index));
374
- else if (sqlWord(statement[index], 'truncate')) objects.push(...truncatedObjects(statement, index));
375
- else if (sqlWord(statement[index], 'alter') && sqlWord(statement[index + 1], 'table')) objects.push(...alterObjects(statement, index));
376
- else if (sqlWord(statement[index], 'alter') && ['type', 'schema', 'view', 'sequence', 'function', 'procedure', 'index'].includes(statement[index + 1]?.v)) {
377
- const object = nameAt(statement, index + 2);
378
- if (object && statement.slice(object.next).some((token) => sqlWord(token, 'rename'))) objects.push({ ...object, kind: statement[index + 1].v, line: statement[index].line });
404
+ const objects = [];
405
+ for (let index = 0; index < statement.length; index += 1) {
406
+ if (sqlWord(statement[index], 'drop'))
407
+ objects.push(...dropObjects(statement, index));
408
+ else if (sqlWord(statement[index], 'truncate'))
409
+ objects.push(...truncatedObjects(statement, index));
410
+ else if (sqlWord(statement[index], 'alter') && sqlWord(statement[index + 1], 'table'))
411
+ objects.push(...alterObjects(statement, index));
412
+ else if (sqlWord(statement[index], 'alter') && ['type', 'schema', 'view', 'sequence', 'function', 'procedure', 'index'].includes(statement[index + 1]?.v)) {
413
+ const object = nameAt(statement, index + 2);
414
+ if (object && statement.slice(object.next).some((token) => sqlWord(token, 'rename')))
415
+ objects.push({ ...object, kind: statement[index + 1].v, line: statement[index].line });
416
+ }
379
417
  }
380
- }
381
- return objects;
418
+ return objects;
382
419
  }
383
-
384
420
  /** Keep the static parts of one SQL expression together across interpolation and string concatenation. */
385
421
  function sourceSqlText(ts, expression, checker, visiting = new Set()) {
386
- const node = unwrapExpression(ts, expression);
387
- if (ts.isStringLiteralLike(node)) return node.text;
388
- if (ts.isTaggedTemplateExpression(node)) return sourceSqlText(ts, node.template, checker, visiting);
389
- if (ts.isIdentifier(node)) {
390
- const declaration = checker.getSymbolAtLocation(node)?.valueDeclaration;
391
- if (!declaration || !ts.isVariableDeclaration(declaration) || !isConstVariable(ts, declaration)
392
- || !declaration.initializer || visiting.has(declaration)) return null;
393
- return sourceSqlText(ts, declaration.initializer, checker, new Set([...visiting, declaration]));
394
- }
395
- if (ts.isTemplateExpression(node)) return node.head.text + node.templateSpans.map((span) =>
396
- `${sourceSqlText(ts, span.expression, checker, visiting) ?? ' '}${span.literal.text}`).join('');
397
- if (ts.isBinaryExpression(node) && node.operatorToken.kind === ts.SyntaxKind.PlusToken) {
398
- return `${sourceSqlText(ts, node.left, checker, visiting) ?? ' '}${sourceSqlText(ts, node.right, checker, visiting) ?? ' '}`;
399
- }
400
- return null;
401
- }
402
-
422
+ const node = unwrapExpression(ts, expression);
423
+ if (ts.isStringLiteralLike(node))
424
+ return node.text;
425
+ if (ts.isTaggedTemplateExpression(node))
426
+ return sourceSqlText(ts, node.template, checker, visiting);
427
+ if (ts.isIdentifier(node)) {
428
+ const declaration = checker.getSymbolAtLocation(node)?.valueDeclaration;
429
+ if (!declaration || !ts.isVariableDeclaration(declaration) || !isConstVariable(ts, declaration)
430
+ || !declaration.initializer || visiting.has(declaration))
431
+ return null;
432
+ return sourceSqlText(ts, declaration.initializer, checker, new Set([...visiting, declaration]));
433
+ }
434
+ if (ts.isTemplateExpression(node))
435
+ return node.head.text + node.templateSpans.map((span) => `${sourceSqlText(ts, span.expression, checker, visiting) ?? ' '}${span.literal.text}`).join('');
436
+ if (ts.isBinaryExpression(node) && node.operatorToken.kind === ts.SyntaxKind.PlusToken) {
437
+ return `${sourceSqlText(ts, node.left, checker, visiting) ?? ' '}${sourceSqlText(ts, node.right, checker, visiting) ?? ' '}`;
438
+ }
439
+ return null;
440
+ }
403
441
  /** SET CONSTRAINTS names have no table qualifier; every matching table's constraint is affected. */
404
442
  function globalConstraintNames(statement) {
405
- const names = new Set();
406
- for (let index = 0; index < statement.length; index += 1) {
407
- if (!sqlWord(statement[index], 'set') || !sqlWord(statement[index + 1], 'constraints')) continue;
408
- let at = index + 2;
409
- while (at < statement.length && !sqlWord(statement[at], 'all')) {
410
- const constraint = nameAt(statement, at);
411
- if (!constraint) break;
412
- names.add(constraint.leaf);
413
- if (statement[constraint.next]?.v !== ',') break;
414
- at = constraint.next + 1;
443
+ const names = new Set();
444
+ for (let index = 0; index < statement.length; index += 1) {
445
+ if (!sqlWord(statement[index], 'set') || !sqlWord(statement[index + 1], 'constraints'))
446
+ continue;
447
+ let at = index + 2;
448
+ while (at < statement.length && !sqlWord(statement[at], 'all')) {
449
+ const constraint = nameAt(statement, at);
450
+ if (!constraint)
451
+ break;
452
+ names.add(constraint.leaf);
453
+ if (statement[constraint.next]?.v !== ',')
454
+ break;
455
+ at = constraint.next + 1;
456
+ }
415
457
  }
416
- }
417
- return names;
458
+ return names;
418
459
  }
419
-
420
460
  function sourceNameScopes(ts, text, file) {
421
- const source = ts.createSourceFile(file, text, ts.ScriptTarget.Latest, true);
422
- const checker = lexicalChecker(ts, source);
423
- const scopes = [];
424
- const entityNames = /\.entity\.[cm]?tsx?$/.test(file) ? new Set() : null;
425
- const addSql = (sql) => {
426
- for (const statement of databaseSqlStatements(databaseSqlTokens(sql))) {
427
- const names = new Set(statement.filter((token) => sqlName(token) !== null).map((token) => token.v));
428
- if (entityNames) for (const name of names) entityNames.add(name);
429
- else {
430
- const constraints = new Set(statement.flatMap((token, index) =>
431
- sqlWord(token, 'constraint') && sqlName(statement[index + 1]) !== null ? [statement[index + 1].v] : []));
432
- scopes.push({ names, constraints, globalConstraints: globalConstraintNames(statement) });
433
- }
434
- }
435
- };
436
- const visit = (node) => {
437
- const sql = sourceSqlText(ts, node, checker);
438
- if (sql !== null) addSql(sql);
439
- if (entityNames && ts.isIdentifier(node)) entityNames.add(node.text);
440
- ts.forEachChild(node, visit);
441
- };
442
- visit(source);
443
- return entityNames ? [{ names: entityNames, constraints: entityNames, globalConstraints: new Set() }] : scopes;
444
- }
445
-
461
+ const source = ts.createSourceFile(file, text, ts.ScriptTarget.Latest, true);
462
+ const checker = lexicalChecker(ts, source);
463
+ const scopes = [];
464
+ const entityNames = /\.entity\.[cm]?tsx?$/.test(file) ? new Set() : null;
465
+ const addSql = (sql) => {
466
+ for (const statement of databaseSqlStatements(databaseSqlTokens(sql))) {
467
+ const names = new Set(statement.filter((token) => sqlName(token) !== null).map((token) => token.v));
468
+ if (entityNames)
469
+ for (const name of names)
470
+ entityNames.add(name);
471
+ else {
472
+ const constraints = new Set(statement.flatMap((token, index) => sqlWord(token, 'constraint') && sqlName(statement[index + 1]) !== null ? [statement[index + 1].v] : []));
473
+ scopes.push({ names, constraints, globalConstraints: globalConstraintNames(statement) });
474
+ }
475
+ }
476
+ };
477
+ const visit = (node) => {
478
+ const sql = sourceSqlText(ts, node, checker);
479
+ if (sql !== null)
480
+ addSql(sql);
481
+ if (entityNames && ts.isIdentifier(node))
482
+ entityNames.add(node.text);
483
+ ts.forEachChild(node, visit);
484
+ };
485
+ visit(source);
486
+ return entityNames ? [{ names: entityNames, constraints: entityNames, globalConstraints: new Set() }] : scopes;
487
+ }
446
488
  /**
447
489
  * Whether a be/src source references a destroyed object. A column (`<schema>.<table>.<column>`) is referenced only by a source that
448
490
  * names both its table and the column in one SQL statement or entity, so separate queries cannot supply each other's names.
449
491
  * SQL constraints require explicit constraint names, while entities retain their table/decorator association.
450
492
  * Other object kinds match their leaf name conservatively.
451
493
  */
452
- const referencesObject = (scopes, object) => scopes.some(({ names, constraints, globalConstraints }) =>
453
- (object.kind === 'constraint' && globalConstraints.has(object.leaf))
454
- || ((object.kind === 'constraint' ? constraints : names).has(object.leaf)
455
- && (!['column', 'constraint'].includes(object.kind) || !object.table || names.has(object.table))));
456
-
494
+ const referencesObject = (scopes, object) => scopes.some(({ names, constraints, globalConstraints }) => (object.kind === 'constraint' && globalConstraints.has(object.leaf))
495
+ || ((object.kind === 'constraint' ? constraints : names).has(object.leaf)
496
+ && (!['column', 'constraint'].includes(object.kind) || !object.table || names.has(object.table))));
457
497
  function destructiveObjectFinding(file, object, contract, references) {
458
- const reference = references.find(({ scopes }) => referencesObject(scopes, object));
459
- if (contract && !reference) return null;
460
- const reason = reference && contract ? `${reference.file} still references this object; remove the reference before the contract migration`
461
- : 'use a *_contract_* migration after the application stops using this object';
462
- return found(DB_MIGRATION_DESTRUCTIVE, file, `${file}:${object.line} destructively changes ${object.name}; ${reason}`,
463
- { line: object.line, object: object.name, ...(reference ? { reference: reference.file } : {}) });
464
- }
465
-
498
+ const reference = references.find(({ scopes }) => referencesObject(scopes, object));
499
+ if (contract && !reference)
500
+ return null;
501
+ const reason = reference && contract ? `${reference.file} still references this object; remove the reference before the contract migration`
502
+ : 'use a *_contract_* migration after the application stops using this object';
503
+ return found(DB_MIGRATION_DESTRUCTIVE, file, `${file}:${object.line} destructively changes ${object.name}; ${reason}`, { line: object.line, object: object.name, ...(reference ? { reference: reference.file } : {}) });
504
+ }
466
505
  function destructiveFileFindings(file, text, references) {
467
- const contract = /_contract_[a-z0-9]+(?:[-_][a-z0-9]+)*\.sql$/.test(file);
468
- const seen = new Set();
469
- const objects = databaseSqlStatements(databaseExecutableTokens(text)).flatMap(destructiveObjects);
470
- return objects.flatMap((object) => {
471
- const key = `${object.line}:${object.kind}:${object.name}`;
472
- if (seen.has(key)) return [];
473
- seen.add(key);
474
- const finding = destructiveObjectFinding(file, object, contract, references);
475
- return finding ? [finding] : [];
476
- });
477
- }
478
-
506
+ const contract = /_contract_[a-z0-9]+(?:[-_][a-z0-9]+)*\.sql$/.test(file);
507
+ const seen = new Set();
508
+ const objects = databaseSqlStatements(databaseExecutableTokens(text)).flatMap(destructiveObjects);
509
+ return objects.flatMap((object) => {
510
+ const key = `${object.line}:${object.kind}:${object.name}`;
511
+ if (seen.has(key))
512
+ return [];
513
+ seen.add(key);
514
+ const finding = destructiveObjectFinding(file, object, contract, references);
515
+ return finding ? [finding] : [];
516
+ });
517
+ }
479
518
  /** Destructive changes require a contract migration and no remaining SQL/entity reference in be/src. */
480
519
  export function destructiveMigrationFindings({ repoRoot, migrations, files }) {
481
- const sources = files.filter((file) => /^be\/src\/.+\.(?:sql|entity)\.[cm]?tsx?$/.test(file));
482
- const ts = sources.length ? loadTypescript(repoRoot, HERE) : null;
483
- if (sources.length && !ts) return [found(DB_MIGRATION_DESTRUCTIVE, 'hfs.json', 'destructive migration checks require the TypeScript parser to read be/src references')];
484
- const references = sources.map((file) => ({ file, scopes: sourceNameScopes(ts, readText(repoRoot, file) ?? '', file) }));
485
- return migrations.flatMap((file) => {
486
- const text = readText(repoRoot, file);
487
- return text === null ? [] : destructiveFileFindings(file, text, references);
488
- });
520
+ const sources = files.filter((file) => /^be\/src\/.+\.(?:sql|entity)\.[cm]?tsx?$/.test(file));
521
+ const ts = sources.length ? loadTypescript(repoRoot, HERE) : null;
522
+ if (sources.length && !ts)
523
+ return [found(DB_MIGRATION_DESTRUCTIVE, 'hfs.json', 'destructive migration checks require the TypeScript parser to read be/src references')];
524
+ const references = ts ? sources.map((file) => ({ file, scopes: sourceNameScopes(ts, readText(repoRoot, file) ?? '', file) })) : [];
525
+ return migrations.flatMap((file) => {
526
+ const text = readText(repoRoot, file);
527
+ return text === null ? [] : destructiveFileFindings(file, text, references);
528
+ });
489
529
  }