@starci/eslint-canon-be 1.8.0 → 1.8.1

package/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 1.8.1 - 2026-09-30
+
+- New: `no-entity-manager-wrapper` (R36) closes the renamed-repository loophole: a class that injects or holds a typeorm `EntityManager` outside a `*.service.ts` / `*.handler.ts` (`*Store`, `*Statements`, `*Dao`, `*Gateway` wrappers) and an exported function whose first parameter is an `EntityManager` (a statement module) are findings. Exempt: `platform/database`, `apps/migrate` and the test tree (`src/tests/`, whose builders take an EntityManager by design).
+
 ## 1.8.0 - 2026-09-30
 
 - Breaking (hotfix ahead of 2.0.0, owner rule "no repositories"): `sql-only-in-repository` is removed. `sql-text-only` (R36) takes its place: raw SQL text is written only in a `<name>.sql.ts` (the capability's `persistence/<name>.sql.ts`, or a test builder's `src/tests/fixtures/builders/<area>.sql.ts`); everywhere else `.query(...)` takes an imported text constant, never a string literal or template; `createQueryBuilder` is refused everywhere. Migrations keep their inline SQL.

package/README.md

@@ -54,7 +54,7 @@ A sample, not the list:
 | Area | What the rules hold |
 |---|---|
 | **Errors** | A `catch` rethrows, logs through the logger port or returns an outcome carrying its cause; an error lives in its capability's `errors/`, extends `DomainError`, and no bare `Error` or framework exception escapes (`catch-must-account`, `error-home`) |
-| **Schema authority** | Migrations only: no `synchronize`, no `migrationsRun`, no runtime DDL, no entity glob; raw SQL text only in a `<name>.sql.ts`, no `*.repository.ts` file; no ORM entity in a contract (`no-runtime-schema`, `sql-text-only`, `no-repository-file`, `no-entity-in-contract`) |
+| **Schema authority** | Migrations only: no `synchronize`, no `migrationsRun`, no runtime DDL, no entity glob; raw SQL text only in a `<name>.sql.ts`, no `*.repository.ts` file and no EntityManager wrapper or statement module; no ORM entity in a contract (`no-runtime-schema`, `sql-text-only`, `no-repository-file`, `no-entity-manager-wrapper`, `no-entity-in-contract`) |
 | **Config and secrets** | `process.env` only in `platform/config`; no literal default for a secret, password, token, key or URL; secrets compare with `timingSafeEqual` (`no-direct-env-read`, `no-secret-default`, `secret-compare-timing-safe`) |
 | **Default deny** | Typed bodies and arguments, no `GraphQLJSON` tunnel, no `switch (operation)`, and `@Public` carries a reason (`no-untyped-body`, `public-needs-reason`) |
 | **Module shape** | `@Global()` only on the manifest allowlist; typed `ConfigurableModuleBuilder`; static `register`; one module per file; no `new` of a provider; no module-level `let` |

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@starci/eslint-canon-be",
-  "version": "1.8.0",
+  "version": "1.8.1",
   "description": "The StarCi back-end lint canon: every rule its laws publish, gathered as one flat-config plugin.",
   "type": "module",
   "license": "UNLICENSED",

package/schema-authority.mjs

@@ -10,6 +10,10 @@
  *   - `sql-text-only` (R36) keeps raw SQL text inside a `<name>.sql.ts` (the owning capability's `persistence/`,
  *     or a test builder's `src/tests/fixtures/builders/<area>.sql.ts`): `.query(...)` elsewhere takes an imported
  *     text constant, never a literal or template; `createQueryBuilder` is not used.
+ *   - `no-entity-manager-wrapper` (R36) refuses the repository pattern under any other name: a class that injects or
+ *     holds a typeorm `EntityManager` outside a `*.service.ts` / `*.handler.ts` (a `*Store`, `*Statements`, `*Dao`,
+ *     `*Gateway` wrapper), and an exported function whose first parameter is an `EntityManager` (a statement module).
+ *     Exempt: `platform/database`, `apps/migrate`, the test tree (`src/tests/`, whose builders take an EntityManager by design).
  *   - `no-repository-file` (R36) refuses a `*.repository.ts` file: repositories are banned (owner rule); SQL text lives
  *     in `<name>.sql.ts` and the capability's service runs it on the shared EntityManager.
  *   - `no-entity-in-contract` (R37 `BE_ENTITY_IN_CONTRACT`) keeps ORM entities out of the types that cross a
@@ -111,6 +115,67 @@ export const sqlTextOnly = {
     },
 }
 
+/** Files that may hold or pass an EntityManager freely: the connection owner, the migrate app and the test tree. */
+const EM_OWNER = /\/src\/modules\/platform\/database\/|\/apps\/migrate\/|\/src\/tests\//
+/** The roles whose class holds the shared EntityManager: services and CQRS handlers. */
+const EM_CLASS_ROLE = /\.(?:service|handler)\.[cm]?ts$/
+/** Spec files are judged by the spec rules, not here. */
+const SPEC_FILE = /\.(?:e2e-|integration-|contract-)?spec\.[cm]?ts$/
+
+/** The repository pattern under another name: an EntityManager wrapper class or a statement module. */
+export const noEntityManagerWrapper = {
+    meta: {
+        type: "problem",
+        docs: { description: "Only a service or a handler holds the EntityManager; no wrapper class and no exported function taking an EntityManager first." },
+        schema: [],
+        messages: {
+            wrapper: "`{{name}}` wraps the EntityManager for another class: the repository pattern under another name. Put the SQL text in `<name>.sql.ts` and run it from the capability's `*.service.ts` (or the handler) on the shared EntityManager.",
+            statement: "`{{name}}` takes an EntityManager as its first parameter: a statement module, the repository pattern under another name. Put the SQL text in `<name>.sql.ts` and run it from the capability's `*.service.ts` on the shared EntityManager.",
+        },
+    },
+    create(context) {
+        const filename = normalizePath(context.filename || context.getFilename())
+        if (isDeclarationFile(filename) || isMigrationFile(filename) || EM_OWNER.test(filename) || SPEC_FILE.test(filename)) return {}
+        const managerNames = new Set()
+        const isManager = (annotation) => {
+            const type = annotation?.typeAnnotation ?? annotation
+            return type?.type === "TSTypeReference" && type.typeName.type === "Identifier" && managerNames.has(type.typeName.name)
+        }
+        const paramType = (param) => (param.type === "TSParameterProperty" ? param.parameter : param).typeAnnotation
+        const holdsManager = (klass) => klass.body.body.some((member) => {
+            if (member.type === "PropertyDefinition" && isManager(member.typeAnnotation)) return true
+            if (member.type === "MethodDefinition" && (member.kind === "constructor" || member.kind === "set")) return member.value.params.some((param) => isManager(paramType(param)))
+            return false
+        })
+        const firstIsManager = (fn) => fn?.params?.length > 0 && isManager(paramType(fn.params[0]))
+        return {
+            ImportDeclaration(node) {
+                if (node.source.value !== "typeorm") return
+                for (const spec of node.specifiers) if (spec.type === "ImportSpecifier" && keyName(spec.imported) === "EntityManager") managerNames.add(spec.local.name)
+            },
+            "ClassDeclaration, ClassExpression"(node) {
+                if (managerNames.size === 0 || EM_CLASS_ROLE.test(filename) || !holdsManager(node)) return
+                context.report({ node: node.id ?? node, messageId: "wrapper", data: { name: node.id?.name ?? "this class" } })
+            },
+            ExportNamedDeclaration(node) {
+                if (managerNames.size === 0 || !node.declaration) return
+                const declaration = node.declaration
+                if (declaration.type === "FunctionDeclaration" && firstIsManager(declaration)) {
+                    context.report({ node: declaration.id ?? declaration, messageId: "statement", data: { name: declaration.id?.name ?? "function" } })
+                }
+                if (declaration.type === "VariableDeclaration") {
+                    for (const declarator of declaration.declarations) {
+                        const init = declarator.init
+                        if ((init?.type === "ArrowFunctionExpression" || init?.type === "FunctionExpression") && firstIsManager(init)) {
+                            context.report({ node: declarator.id, messageId: "statement", data: { name: declarator.id.name } })
+                        }
+                    }
+                }
+            },
+        }
+    },
+}
+
 /** Repositories are banned: a `*.repository.ts` file is a finding. */
 export const noRepositoryFile = {
     meta: {
@@ -197,6 +262,7 @@ export const rules = {
     "no-runtime-schema": noRuntimeSchema,
     "sql-text-only": sqlTextOnly,
     "no-repository-file": noRepositoryFile,
+    "no-entity-manager-wrapper": noEntityManagerWrapper,
     "no-entity-in-contract": noEntityInContract,
     "migration-down-reversible": migrationDownReversible,
 }
@@ -206,6 +272,7 @@ export const recommended = {
     "starci-be/no-runtime-schema": "error",
     "starci-be/sql-text-only": "error",
     "starci-be/no-repository-file": "error",
+    "starci-be/no-entity-manager-wrapper": "error",
     "starci-be/no-entity-in-contract": "error",
     "starci-be/migration-down-reversible": "error",
 }