@stamhoofd/backend 2.83.4 → 2.84.0

package/tests/e2e/register.test.ts

@@ -1,6 +1,6 @@
 import { Request } from '@simonbackx/simple-endpoints';
 import { BalanceItemFactory, GroupFactory, MemberFactory, MemberWithRegistrations, Organization, OrganizationFactory, OrganizationRegistrationPeriod, Platform, RegistrationPeriod, RegistrationPeriodFactory, Token, UserFactory } from '@stamhoofd/models';
-import { AdministrationFeeSettings, BalanceItemCartItem, BalanceItemStatus, BalanceItemType, BooleanStatus, DefaultAgeGroup, FreeContributionSettings, GroupOption, GroupOptionMenu, IDRegisterCart, IDRegisterCheckout, IDRegisterItem, PaymentMethod, PermissionLevel, Permissions, PlatformMembershipType, PlatformMembershipTypeConfig, ReceivableBalanceType, ReduceablePrice, RegisterItemOption, Version } from '@stamhoofd/structures';
+import { AdministrationFeeSettings, BalanceItemCartItem, BalanceItemRelation, BalanceItemRelationType, BalanceItemStatus, BalanceItemType, BooleanStatus, DefaultAgeGroup, FreeContributionSettings, GroupOption, GroupOptionMenu, IDRegisterCart, IDRegisterCheckout, IDRegisterItem, PaymentMethod, PermissionLevel, Permissions, PlatformMembershipType, PlatformMembershipTypeConfig, ReceivableBalanceType, ReduceablePrice, RegisterItemOption, TranslatedString, Version } from '@stamhoofd/structures';
 import { v4 as uuidv4 } from 'uuid';
 import { GetMemberFamilyEndpoint } from '../../src/endpoints/global/members/GetMemberFamilyEndpoint';
 import { RegisterMembersEndpoint } from '../../src/endpoints/global/registration/RegisterMembersEndpoint';
@@ -9,30 +9,24 @@ import { GetReceivableBalanceEndpoint } from '../../src/endpoints/organization/d
 import { PlatformMembershipService } from '../../src/services/PlatformMembershipService';
 import { testServer } from '../helpers/TestServer';
 import { TestUtils } from '@stamhoofd/test-utils';
+import { BalanceItemService } from '../../src/services/BalanceItemService';
+import { assertBalances } from '../assertions/assertBalances';
 
 describe('E2E.Register', () => {
-    // #region global
     const registerEndpoint = new RegisterMembersEndpoint();
-    const memberBalanceEndpoint = new GetMemberBalanceEndpoint();
     const receivableBalancesEndpoint = new GetReceivableBalanceEndpoint();
     const getMemberFamilyEndpoint = new GetMemberFamilyEndpoint();
 
     let period: RegistrationPeriod;
 
-    // #region helpers
     const register = async (body: IDRegisterCheckout, organization: Organization, token: Token) => {
         const request = Request.buildJson('POST', `/v${Version}/members/register`, organization.getApiHost(), body);
         request.headers.authorization = 'Bearer ' + token.accessToken;
         return await testServer.test(registerEndpoint, request);
     };
 
-    const getBalance = async (memberId: string, organization: Organization, token: Token) => {
-        const request = Request.buildJson('GET', `/v${Version}/organization/members/${memberId}/balance`, organization.getApiHost());
-        request.headers.authorization = 'Bearer ' + token.accessToken;
-        return await testServer.test(memberBalanceEndpoint, request);
-    };
-
     const getReceivableBalance = async (type: ReceivableBalanceType, id: string, organization: Organization, token: Token) => {
+        await BalanceItemService.flushAll();
         const request = Request.buildJson('GET', `/v${Version}/receivable-balances/${type}/${id}`, organization.getApiHost());
         request.headers.authorization = 'Bearer ' + token.accessToken;
         return await testServer.test(receivableBalancesEndpoint, request);
@@ -43,15 +37,16 @@ describe('E2E.Register', () => {
         request.headers.authorization = 'Bearer ' + token.accessToken;
         return await testServer.test(getMemberFamilyEndpoint, request);
     };
-    // #endregion
-
-    // #endregion
 
     beforeEach(async () => {
         // These tests should run in platform mode
         TestUtils.setEnvironment('userMode', 'platform');
     });
 
+    afterEach(() => {
+        jest.useRealTimers();
+    });
+
     beforeAll(async () => {
         const previousPeriod = await new RegistrationPeriodFactory({
             startDate: new Date(2022, 0, 1),
@@ -60,7 +55,7 @@ describe('E2E.Register', () => {
 
         period = await new RegistrationPeriodFactory({
             startDate: new Date(2023, 0, 1),
-            endDate: new Date(2023, 11, 31),
+            endDate: new Date(2050, 11, 31),
         }).create();
 
         period.previousPeriodId = previousPeriod.id;
@@ -81,14 +76,12 @@ describe('E2E.Register', () => {
 
         const token = await Token.createToken(user);
 
-        const member = await new MemberFactory({ organization, user })
-            .create();
+        const member = await new MemberFactory({ organization, user }).create();
 
         const otherMembers: MemberWithRegistrations[] = [];
 
         for (let i = 0; i < otherMemberAmount; i++) {
-            otherMembers.push(await new MemberFactory({ organization, user })
-                .create());
+            otherMembers.push(await new MemberFactory({ organization, user }).create());
         }
 
         const group = await new GroupFactory({
@@ -96,8 +89,7 @@ describe('E2E.Register', () => {
             price: 25,
             reducedPrice: 21,
             stock: 5,
-        })
-            .create();
+        }).create();
 
         const groupPrice = group.settings.prices[0];
 
@@ -117,7 +109,6 @@ describe('E2E.Register', () => {
 
     describe('Register prices and balances', () => {
         test('Register by member should create balance for member', async () => {
-            // #region arrange
             const { organization, group, groupPrice, token, member } = await initData();
 
             const body = IDRegisterCheckout.create({
@@ -143,26 +134,25 @@ describe('E2E.Register', () => {
                 totalPrice: 25,
                 customer: null,
             });
-            // #endregion
 
-            // #region act and assert
-            const balanceBefore = await getBalance(member.id, organization, token);
-            expect(balanceBefore).toBeDefined();
-            expect(balanceBefore.body.length).toBe(0);
+            await assertBalances({ member }, []);
 
             await register(body, organization, token);
 
-            const balance = await getBalance(member.id, organization, token);
-            expect(balance).toBeDefined();
-            expect(balance.body.length).toBe(1);
-            expect(balance.body[0].price).toBe(25);
-            expect(balance.body[0].pricePaid).toBe(0);
-            expect(balance.body[0].pricePending).toBe(25);
-            // #endregion
+            await assertBalances({ member }, [
+                {
+                    pricePaid: 0,
+                    type: BalanceItemType.Registration,
+                    status: BalanceItemStatus.Due,
+                    unitPrice: 25,
+                    amount: 1,
+                    pricePending: 25,
+                    priceOpen: 0,
+                },
+            ]);
         });
 
         test('Should create balance items for options', async () => {
-            // #region arrange
             const { organization, group, groupPrice, token, member } = await initData();
 
             const option1 = GroupOption.create({
@@ -227,37 +217,94 @@ describe('E2E.Register', () => {
                 totalPrice: 50,
                 customer: null,
             });
-            // #endregion
 
-            // #region act and assert
-            const balanceBefore = await getBalance(member.id, organization, token);
-            expect(balanceBefore).toBeDefined();
-            expect(balanceBefore.body.length).toBe(0);
+            await assertBalances({ member }, []);
 
             await register(body, organization, token);
 
-            const balance = await getBalance(member.id, organization, token);
-            expect(balance).toBeDefined();
-            expect(balance.body.length).toBe(3);
-            expect(balance.body).toEqual(expect.arrayContaining([
-                expect.objectContaining({
-                    price: 25,
+            await assertBalances({ member }, [
+                {
+                    type: BalanceItemType.Registration,
+                    amount: 2,
+                    unitPrice: 5,
+                    price: 10,
                     pricePaid: 0,
-                }),
-                expect.objectContaining({
+                    pricePending: 10,
+                    relations: new Map([
+                        [
+                            BalanceItemRelationType.Group,
+                            BalanceItemRelation.create({
+                                id: group.id,
+                                name: group.settings.name,
+                            }),
+                        ],
+                        [
+                            BalanceItemRelationType.GroupOptionMenu,
+                            BalanceItemRelation.create({
+                                id: optionMenu.id,
+                                name: new TranslatedString(optionMenu.name),
+                            }),
+                        ],
+                        [
+                            BalanceItemRelationType.GroupOption,
+                            BalanceItemRelation.create({
+                                id: option1.id,
+                                name: new TranslatedString(option1.name),
+                            }),
+                        ],
+                    ]),
+                },
+                {
+                    type: BalanceItemType.Registration,
+                    amount: 5,
+                    unitPrice: 3,
                     price: 15,
                     pricePaid: 0,
-                }),
-                expect.objectContaining({
-                    price: 10,
+                    pricePending: 15,
+                    relations: new Map([
+                        [
+                            BalanceItemRelationType.Group,
+                            BalanceItemRelation.create({
+                                id: group.id,
+                                name: group.settings.name,
+                            }),
+                        ],
+                        [
+                            BalanceItemRelationType.GroupOptionMenu,
+                            BalanceItemRelation.create({
+                                id: optionMenu.id,
+                                name: new TranslatedString(optionMenu.name),
+                            }),
+                        ],
+                        [
+                            BalanceItemRelationType.GroupOption,
+                            BalanceItemRelation.create({
+                                id: option2.id,
+                                name: new TranslatedString(option2.name),
+                            }),
+                        ],
+                    ]),
+                },
+                {
+                    type: BalanceItemType.Registration,
+                    amount: 1,
+                    price: 25,
                     pricePaid: 0,
-                }),
-            ]));
-            // #endregion
+                    pricePending: 25,
+                    relations: new Map([
+                        [
+                            BalanceItemRelationType.Group,
+                            BalanceItemRelation.create({
+                                id: group.id,
+                                name: group.settings.name,
+                            }),
+                        ],
+                    ]),
+                },
+            ]);
         });
 
         test('Should reset free contribution if no options on organization', async () => {
-            // #region arrange
             const { organization, group, groupPrice, token, member, user } = await initData();
 
             const body = IDRegisterCheckout.create({
@@ -283,9 +330,7 @@ describe('E2E.Register', () => {
                 totalPrice: 25,
                 customer: null,
             });
-            // #endregion
 
-            // #region act and assert
             const receivableBalanceBefore = await getReceivableBalance(ReceivableBalanceType.user, user.id, organization, token);
             expect(receivableBalanceBefore).toBeDefined();
             expect(receivableBalanceBefore.body.balanceItems.length).toBe(0);
@@ -303,11 +348,9 @@ describe('E2E.Register', () => {
                     pricePaid: 0,
                 }),
             ]));
-            // #endregion
         });
 
         test('Should create balance item for free contribution', async () => {
-            // #region arrange
             const { organization, group, groupPrice, token, member, user } = await initData();
 
             organization.meta.recordsConfiguration.freeContribution = FreeContributionSettings.create({
@@ -340,9 +383,7 @@ describe('E2E.Register', () => {
                 totalPrice: 55,
                 customer: null,
             });
-            // #endregion
 
-            // #region act and assert
             const receivableBalanceBefore = await getReceivableBalance(ReceivableBalanceType.user, user.id, organization, token);
             expect(receivableBalanceBefore).toBeDefined();
             expect(receivableBalanceBefore.body.balanceItems.length).toBe(0);
@@ -366,11 +407,9 @@ describe('E2E.Register', () => {
                     pricePaid: 0,
                 }),
             ]));
-            // #endregion
         });
 
         test('Should create balance item for free administration fee if register by member', async () => {
-            // #region arrange
             const { organization, group, groupPrice, token, member, user } = await initData();
 
             organization.meta.registrationPaymentConfiguration.administrationFee = AdministrationFeeSettings.create({
@@ -401,9 +440,7 @@ describe('E2E.Register', () => {
                 paymentMethod: PaymentMethod.PointOfSale,
                 totalPrice: 58,
             });
-            // #endregion
 
-            // #region act and assert
             const receivableBalanceBefore = await getReceivableBalance(ReceivableBalanceType.user, user.id, organization
                 , token);
             expect(receivableBalanceBefore).toBeDefined();
@@ -429,11 +466,9 @@ describe('E2E.Register', () => {
                     type: BalanceItemType.AdministrationFee,
                 }),
             ]));
-            // #endregion
         });
 
         test('Should create balance item for cart item', async () => {
-            // #region arrange
             const { organization, group, groupPrice, token, member, user } = await initData();
 
             const balanceItem1 = await new BalanceItemFactory({
@@ -475,9 +510,6 @@ describe('E2E.Register', () => {
                 totalPrice: 35,
             });
 
-            // #endregion
-
-            // #region act and assert
             const response = await register(body, organization, token);
             expect(response.body.registrations.length).toBe(1);
 
@@ -495,11 +527,9 @@ describe('E2E.Register', () => {
                     pricePending: 25,
                 }),
             ]));
-            // #endregion
         });
 
         test('Should apply reduced price if member requires financial support', async () => {
-            // #region arrange
             const { organization, group, groupPrice, token, member } = await initData();
             member.details.requiresFinancialSupport = BooleanStatus.create({
                 value: true,
@@ -530,25 +560,25 @@ describe('E2E.Register', () => {
                 totalPrice: 21,
                 customer: null,
             });
-            // #endregion
 
-            // #region act and assert
-            const balanceBefore = await getBalance(member.id, organization, token);
-            expect(balanceBefore).toBeDefined();
-            expect(balanceBefore.body.length).toBe(0);
+            await assertBalances({ member }, []);
 
             await register(body, organization, token);
 
-            const balance = await getBalance(member.id, organization, token);
-            expect(balance).toBeDefined();
-            expect(balance.body.length).toBe(1);
-            expect(balance.body[0].price).toBe(21);
-            expect(balance.body[0].pricePaid).toBe(0);
-            // #endregion
+            await assertBalances({ member }, [
+                {
+                    unitPrice: 21,
+                    amount: 1,
+                    pricePaid: 0,
+                    pricePending: 21,
+                    priceOpen: 0,
+                    type: BalanceItemType.Registration,
+                    status: BalanceItemStatus.Due,
+                },
+            ]);
         });
 
         test('Should apply reduced price for options if member requires financial support', async () => {
-            // #region arrange
             const { organization, group, groupPrice, token, member } = await initData();
             member.details.requiresFinancialSupport = BooleanStatus.create({
                 value: true,
@@ -618,48 +648,39 @@ describe('E2E.Register', () => {
                 totalPrice: 32,
                 customer: null,
             });
-            // #endregion
 
-            // #region act and assert
-            const balanceBefore = await getBalance(member.id, organization, token);
-            expect(balanceBefore).toBeDefined();
-            expect(balanceBefore.body.length).toBe(0);
+            await assertBalances({ member }, []);
 
             await register(body, organization, token);
 
-            const balance = await getBalance(member.id, organization, token);
-            expect(balance).toBeDefined();
-            expect(balance.body.length).toBe(3);
-            expect(balance.body).toEqual(expect.arrayContaining([
-                expect.objectContaining({
+            await assertBalances({ member }, [
+                {
                     unitPrice: 3,
                     amount: 2,
                     pricePending: 6,
                     pricePaid: 0,
                     status: BalanceItemStatus.Due,
-                }),
-                expect.objectContaining({
+                },
+                {
                     unitPrice: 21,
                     pricePaid: 0,
                     pricePending: 21,
                     amount: 1,
                     status: BalanceItemStatus.Due,
-                }),
-                expect.objectContaining({
+                },
+                {
                     unitPrice: 1,
                     pricePaid: 0,
                     pricePending: 5,
                     amount: 5,
                     status: BalanceItemStatus.Due,
-                }),
-            ]));
-            // #endregion
+                },
+            ]);
         });
     });
 
     describe('Delete registrations', () => {
         test('Should cancel balance item for deleted registration', async () => {
-            // #region arrange
             const { member, group: group1, groupPrice: groupPrice1, organization, token } = await initData();
 
             const body1 = IDRegisterCheckout.create({
@@ -675,16 +696,12 @@ describe('E2E.Register', () => {
                             memberId: member.id,
                         }),
                     ],
-                    balanceItems: [
-                    ],
-                    deleteRegistrationIds: [],
                 }),
                 administrationFee: 0,
                 freeContribution: 0,
                 paymentMethod: PaymentMethod.PointOfSale,
                 totalPrice: 25,
                 customer: null,
-                asOrganizationId: organization.id,
             });
 
             const response1 = await register(body1, organization, token);
@@ -693,6 +710,17 @@ describe('E2E.Register', () => {
 
             const registrationToDelete = response1.body.registrations[0];
 
+            await assertBalances({ member }, [
+                {
+                    unitPrice: 25,
+                    pricePaid: 0,
+                    status: BalanceItemStatus.Due,
+                    pricePending: 25,
+                    priceOpen: 0,
+                    registrationId: registrationToDelete.id,
+                },
+            ]);
+
             const group = await new GroupFactory({
                 organization,
                 price: 30,
@@ -706,57 +734,41 @@ describe('E2E.Register', () => {
                     items: [
                         IDRegisterItem.create({
                             id: uuidv4(),
-                            replaceRegistrationIds: [],
-                            options: [],
                             groupPrice,
                             organizationId: organization.id,
                             groupId: group.id,
                             memberId: member.id,
                         }),
                     ],
-                    balanceItems: [
-                    ],
                     deleteRegistrationIds: [registrationToDelete.id],
                 }),
-                administrationFee: 0,
-                freeContribution: 0,
-                paymentMethod: PaymentMethod.PointOfSale,
-                totalPrice: 30,
-                customer: null,
+                totalPrice: 30 - 25,
                 asOrganizationId: organization.id,
             });
-            // #endregion
-
-            // #region act and assert
-            const balanceBefore = await getBalance(member.id, organization, token);
-            expect(balanceBefore).toBeDefined();
-            expect(balanceBefore.body.length).toBe(1);
-            expect(balanceBefore.body[0].price).toBe(25);
-            expect(balanceBefore.body[0].pricePaid).toBe(0);
 
             await register(body2, organization, token);
 
-            const balance = await getBalance(member.id, organization, token);
-            expect(balance).toBeDefined();
-            expect(balance.body.length).toBe(2);
-
-            expect(balance.body).toEqual(expect.arrayContaining([
-                expect.objectContaining({
+            await assertBalances({ member }, [
+                {
                     unitPrice: 25,
+                    amount: 1,
                     pricePaid: 0,
                     status: BalanceItemStatus.Canceled,
-                }),
-                expect.objectContaining({
+                    registrationId: registrationToDelete.id,
+                    pricePending: 25,
+                    priceOpen: -25,
+                },
+                {
                     unitPrice: 30,
                     pricePaid: 0,
                     status: BalanceItemStatus.Due,
-                }),
-            ]));
-            // #endregion
+                    priceOpen: 30,
+                    pricePending: 0,
+                },
+            ]);
         });
 
         test('Should cancel all related balance item for deleted registration', async () => {
-            // #region arrange
             const { member, group: group1, groupPrice: groupPrice1, organization, token } = await initData();
 
             const option1 = GroupOption.create({
@@ -792,7 +804,6 @@ describe('E2E.Register', () => {
                     items: [
                         IDRegisterItem.create({
                             id: uuidv4(),
-                            replaceRegistrationIds: [],
                             options: [
                                 RegisterItemOption.create({
                                     option: option1,
@@ -811,13 +822,7 @@ describe('E2E.Register', () => {
                             memberId: member.id,
                         }),
                     ],
-                    balanceItems: [
-                    ],
-                    deleteRegistrationIds: [],
                 }),
-                administrationFee: 0,
-                freeContribution: 0,
-                paymentMethod: PaymentMethod.PointOfSale,
                 totalPrice: 50,
                 customer: null,
                 asOrganizationId: organization.id,
@@ -829,6 +834,32 @@ describe('E2E.Register', () => {
 
             const registrationToDelete = response1.body.registrations[0];
 
+            await assertBalances({ member }, [
+                {
+                    unitPrice: 5,
+                    amount: 2,
+                    pricePending: 0,
+                    priceOpen: 10,
+                    status: BalanceItemStatus.Due,
+                    registrationId: registrationToDelete.id,
+                },
+                {
+                    unitPrice: 3,
+                    amount: 5,
+                    pricePending: 0,
+                    priceOpen: 15,
+                    status: BalanceItemStatus.Due,
+                    registrationId: registrationToDelete.id,
+                },
+                {
+                    unitPrice: 25,
+                    pricePending: 0,
+                    priceOpen: 25,
+                    status: BalanceItemStatus.Due,
+                    registrationId: registrationToDelete.id,
+                },
+            ]);
+
             const group = await new GroupFactory({
                 organization,
                 price: 30,
@@ -842,69 +873,56 @@ describe('E2E.Register', () => {
                     items: [
                         IDRegisterItem.create({
                             id: uuidv4(),
-                            replaceRegistrationIds: [],
-                            options: [],
                             groupPrice,
                             organizationId: organization.id,
                             groupId: group.id,
                             memberId: member.id,
                         }),
                     ],
-                    balanceItems: [
-                    ],
                     deleteRegistrationIds: [registrationToDelete.id],
                 }),
-                administrationFee: 0,
-                freeContribution: 0,
-                paymentMethod: PaymentMethod.PointOfSale,
-                totalPrice: 30,
-                customer: null,
+                totalPrice: 30 - 50,
                 asOrganizationId: organization.id,
             });
-            // #endregion
-
-            // #region act and assert
-            const balanceBefore = await getBalance(member.id, organization, token);
-            expect(balanceBefore).toBeDefined();
-            expect(balanceBefore.body.length).toBe(3);
 
             await register(body2, organization, token);
 
-            const balance = await getBalance(member.id, organization, token);
-            expect(balance).toBeDefined();
-            expect(balance.body.length).toBe(4);
-
-            expect(balance.body).toEqual(expect.arrayContaining([
-                expect.objectContaining({
+            await assertBalances({ member }, [
+                {
                     unitPrice: 5,
                     amount: 2,
-                    pricePaid: 0,
+                    pricePending: 0,
+                    priceOpen: 0,
                     status: BalanceItemStatus.Canceled,
-                }),
-                expect.objectContaining({
+                    registrationId: registrationToDelete.id,
+                },
+                {
                     unitPrice: 3,
-                    pricePaid: 0,
                     amount: 5,
+                    pricePending: 0,
+                    priceOpen: 0,
                     status: BalanceItemStatus.Canceled,
-                }),
-                expect.objectContaining({
+                    registrationId: registrationToDelete.id,
+                },
+                {
                     unitPrice: 25,
-                    pricePaid: 0,
-                    amount: 1,
+                    pricePending: 0,
+                    priceOpen: 0,
                     status: BalanceItemStatus.Canceled,
-                }),
-                expect.objectContaining({
+                    registrationId: registrationToDelete.id,
+                },
+                {
                     unitPrice: 30,
                     pricePaid: 0,
                     amount: 1,
                     status: BalanceItemStatus.Due,
-                }),
-            ]));
-            // #endregion
+                    pricePending: 0,
+                    priceOpen: 30,
+                },
+            ]);
         });
 
         test('Should apply cancelation fee', async () => {
-            // #region arrange
             const { member, group: group1, groupPrice: groupPrice1, organization, token } = await initData();
 
             const body1 = IDRegisterCheckout.create({
@@ -912,23 +930,14 @@ describe('E2E.Register', () => {
                     items: [
                         IDRegisterItem.create({
                             id: uuidv4(),
-                            replaceRegistrationIds: [],
-                            options: [],
                             groupPrice: groupPrice1,
                             organizationId: organization.id,
                             groupId: group1.id,
                             memberId: member.id,
                         }),
                     ],
-                    balanceItems: [
-                    ],
-                    deleteRegistrationIds: [],
                 }),
-                administrationFee: 0,
-                freeContribution: 0,
-                paymentMethod: PaymentMethod.PointOfSale,
                 totalPrice: 25,
-                customer: null,
                 asOrganizationId: organization.id,
             });
 
@@ -938,6 +947,18 @@ describe('E2E.Register', () => {
 
             const registrationToDelete = response1.body.registrations[0];
 
+            await assertBalances({ member }, [
+                {
+                    unitPrice: 25,
+                    pricePaid: 0,
+                    status: BalanceItemStatus.Due,
+                    type: BalanceItemType.Registration,
+                    pricePending: 0,
+                    priceOpen: 25,
+                    registrationId: registrationToDelete.id,
+                },
+            ]);
+
             const group = await new GroupFactory({
                 organization,
                 price: 30,
@@ -959,167 +980,135 @@ describe('E2E.Register', () => {
                             memberId: member.id,
                         }),
                     ],
-                    balanceItems: [
-                    ],
                     deleteRegistrationIds: [registrationToDelete.id],
                 }),
-                administrationFee: 0,
-                freeContribution: 0,
-                paymentMethod: PaymentMethod.PointOfSale,
-                totalPrice: 30,
-                customer: null,
+                totalPrice: 30 - 25 + 5, // 20% of 25 is 5
                 asOrganizationId: organization.id,
-                cancellationFeePercentage: 2000,
+                cancellationFeePercentage: 20_00,
             });
-            // #endregion
-
-            // #region act and assert
-            const balanceBefore = await getBalance(member.id, organization, token);
-            expect(balanceBefore).toBeDefined();
-            expect(balanceBefore.body.length).toBe(1);
-            expect(balanceBefore.body[0].price).toBe(25);
-            expect(balanceBefore.body[0].pricePaid).toBe(0);
 
             await register(body2, organization, token);
-
-            const balance = await getBalance(member.id, organization, token);
-            expect(balance).toBeDefined();
-            expect(balance.body.length).toBe(3);
-
-            expect(balance.body).toEqual(expect.arrayContaining([
-                expect.objectContaining({
+            await assertBalances({ member }, [
+                {
                     unitPrice: 25,
                     pricePaid: 0,
-                    pricePending: 0,
-                    amount: 1,
                     status: BalanceItemStatus.Canceled,
+                    pricePending: 0,
+                    priceOpen: 0,
                     type: BalanceItemType.Registration,
-                }),
-                expect.objectContaining({
-                    unitPrice: 30,
+                    registrationId: registrationToDelete.id,
+                },
+                {
+                    unitPrice: 5,
                     pricePaid: 0,
                     pricePending: 0,
+                    priceOpen: 5,
                     amount: 1,
+                    type: BalanceItemType.CancellationFee,
                     status: BalanceItemStatus.Due,
-                    type: BalanceItemType.Registration,
-                }),
-                expect.objectContaining({
-                    unitPrice: 5,
+                    registrationId: registrationToDelete.id,
+                },
+                {
+                    unitPrice: 30,
                     pricePaid: 0,
                     pricePending: 0,
+                    priceOpen: 30,
                     amount: 1,
-                    type: BalanceItemType.CancellationFee,
                     status: BalanceItemStatus.Due,
-                }),
-            ]));
-            // #endregion
+                    type: BalanceItemType.Registration,
+                },
+            ]);
         });
     });
 
     describe('Register for group with default age group', () => {
         test('Should create membership', async () => {
-            // #region arrange
             const date = new Date('2023-05-14');
-            jest.useFakeTimers().setSystemTime(date);
+            jest.useFakeTimers({ advanceTimers: true, doNotFake: ['setTimeout', 'clearTimeout', 'hrtime', 'nextTick', 'performance', 'queueMicrotask', 'setImmediate', 'clearImmediate'] }).setSystemTime(date);
 
-            try {
-                const platformMembershipTypeConfig = PlatformMembershipTypeConfig.create({
-                    startDate: period.startDate,
-                    endDate: period.endDate,
-                });
+            const platformMembershipTypeConfig = PlatformMembershipTypeConfig.create({
+                startDate: period.startDate,
+                endDate: period.endDate,
+            });
 
-                const platformMembershipType = PlatformMembershipType.create({
-                    name: 'werkjaar',
-                    periods: new Map([
-                        [period.id, platformMembershipTypeConfig],
-                    ]),
-                });
+            const platformMembershipType = PlatformMembershipType.create({
+                name: 'werkjaar',
+                periods: new Map([
+                    [period.id, platformMembershipTypeConfig],
+                ]),
+            });
 
-                const platform = await Platform.getForEditing();
+            const platform = await Platform.getForEditing();
 
-                platform.config.membershipTypes = [
-                    platformMembershipType,
-                ];
+            platform.config.membershipTypes = [
+                platformMembershipType,
+            ];
 
-                const defaultAgeGroup = DefaultAgeGroup.create({
-                    names: ['test groep'],
-                    defaultMembershipTypeId: platformMembershipType.id,
-                });
+            const defaultAgeGroup = DefaultAgeGroup.create({
+                names: ['test groep'],
+                defaultMembershipTypeId: platformMembershipType.id,
+            });
 
-                platform.config.defaultAgeGroups = [defaultAgeGroup];
+            platform.config.defaultAgeGroups = [defaultAgeGroup];
 
-                await platform.save();
+            await platform.save();
 
-                const { member, group, groupPrice, organization, token } = await initData();
+            const { member, group, groupPrice, organization, token } = await initData();
 
-                // todo: remove from initData
-                member.organizationId = null;
-                await member.save();
+            // todo: remove from initData
+            member.organizationId = null;
+            await member.save();
 
-                group.defaultAgeGroupId = defaultAgeGroup.id;
-                await group.save();
+            group.defaultAgeGroupId = defaultAgeGroup.id;
+            await group.save();
 
-                const organizationPeriod = new OrganizationRegistrationPeriod();
-                organizationPeriod.organizationId = organization.id;
-                organizationPeriod.periodId = period.id;
-                await organizationPeriod.save();
+            const organizationPeriod = new OrganizationRegistrationPeriod();
+            organizationPeriod.organizationId = organization.id;
+            organizationPeriod.periodId = period.id;
+            await organizationPeriod.save();
 
-                const body = IDRegisterCheckout.create({
-                    cart: IDRegisterCart.create({
-                        items: [
-                            IDRegisterItem.create({
-                                id: uuidv4(),
-                                replaceRegistrationIds: [],
-                                options: [],
-                                groupPrice: groupPrice,
-                                organizationId: organization.id,
-                                groupId: group.id,
-                                memberId: member.id,
-                                trial: false,
-                            }),
-                        ],
-                        balanceItems: [],
-                        deleteRegistrationIds: [],
-                    }),
-                    administrationFee: 0,
-                    freeContribution: 0,
-                    paymentMethod: PaymentMethod.PointOfSale,
-                    totalPrice: 25,
-                    asOrganizationId: organization.id,
-                    customer: null,
-                });
-                // #endregion
+            const body = IDRegisterCheckout.create({
+                cart: IDRegisterCart.create({
+                    items: [
+                        IDRegisterItem.create({
+                            id: uuidv4(),
+                            groupPrice: groupPrice,
+                            organizationId: organization.id,
+                            groupId: group.id,
+                            memberId: member.id,
+                            trial: false,
+                        }),
+                    ],
+                }),
+                totalPrice: 25,
+                asOrganizationId: organization.id,
+            });
 
-                // act and assert
-                const familyBefore = await getMemberFamily(member.id, organization, token);
-                expect(familyBefore).toBeDefined();
-                expect(familyBefore.body.members.length).toBe(1);
-                expect(familyBefore.body.members[0]).toBeDefined();
-                expect(familyBefore.body.members[0].platformMemberships.length).toBe(0);
+            // act and assert
+            const familyBefore = await getMemberFamily(member.id, organization, token);
+            expect(familyBefore).toBeDefined();
+            expect(familyBefore.body.members.length).toBe(1);
+            expect(familyBefore.body.members[0]).toBeDefined();
+            expect(familyBefore.body.members[0].platformMemberships.length).toBe(0);
 
-                const response = await register(body, organization, token);
+            const response = await register(body, organization, token);
 
-                expect(response.body).toBeDefined();
-                expect(response.body.registrations.length).toBe(1);
+            expect(response.body).toBeDefined();
+            expect(response.body.registrations.length).toBe(1);
 
-                await PlatformMembershipService.updateMembershipsForId(member.id, false);
+            await PlatformMembershipService.updateMembershipsForId(member.id, false);
 
-                const familyAfter = await getMemberFamily(member.id, organization, token);
-                expect(familyAfter).toBeDefined();
-                expect(familyAfter.body.members.length).toBe(1);
-                expect(familyAfter.body.members[0]).toBeDefined();
-                expect(familyAfter.body.members[0].platformMemberships.length).toBe(1);
-                expect(familyAfter.body.members[0].platformMemberships[0].membershipTypeId).toBe(platformMembershipType.id);
-            }
-            finally {
-                jest.useFakeTimers().resetAllMocks();
-            }
-        });
+            const familyAfter = await getMemberFamily(member.id, organization, token);
+            expect(familyAfter).toBeDefined();
+            expect(familyAfter.body.members.length).toBe(1);
+            expect(familyAfter.body.members[0]).toBeDefined();
+            expect(familyAfter.body.members[0].platformMemberships.length).toBe(1);
+            expect(familyAfter.body.members[0].platformMemberships[0].membershipTypeId).toBe(platformMembershipType.id);
+        }, 20_000);
 
         test('Should set trial until on membership if trial', async () => {
-            // #region arrange
             const date = new Date('2023-05-14');
-            jest.useFakeTimers().setSystemTime(date);
+            jest.useFakeTimers({ advanceTimers: true, doNotFake: ['setTimeout', 'clearTimeout', 'hrtime', 'nextTick', 'performance', 'queueMicrotask', 'setImmediate', 'clearImmediate'] }).setSystemTime(date);
 
             try {
                 const platformMembershipTypeConfig = PlatformMembershipTypeConfig.create({
@@ -1170,8 +1159,6 @@ describe('E2E.Register', () => {
                         items: [
                             IDRegisterItem.create({
                                 id: uuidv4(),
-                                replaceRegistrationIds: [],
-                                options: [],
                                 groupPrice: groupPrice,
                                 organizationId: organization.id,
                                 groupId: group.id,
@@ -1179,17 +1166,10 @@ describe('E2E.Register', () => {
                                 trial: true,
                             }),
                         ],
-                        balanceItems: [],
-                        deleteRegistrationIds: [],
                     }),
-                    administrationFee: 0,
-                    freeContribution: 0,
-                    paymentMethod: PaymentMethod.PointOfSale,
                     totalPrice: 0,
                     asOrganizationId: organization.id,
-                    customer: null,
                 });
-                // #endregion
 
                 // act and assert
                 const familyBefore = await getMemberFamily(member.id, organization, token);
@@ -1218,7 +1198,7 @@ describe('E2E.Register', () => {
                 expect(trialUntil!.getDate()).toBe(24);
             }
             finally {
-                jest.useFakeTimers().resetAllMocks();
+                jest.useRealTimers().resetAllMocks();
             }
         });
     });