@stamhoofd/backend 2.8.0 → 2.13.0

package/src/helpers/ViesHelper.ts

@@ -0,0 +1,151 @@
+import { AutoEncoderPatchType } from '@simonbackx/simple-encoding';
+import { isSimpleError, isSimpleErrors, SimpleError } from '@simonbackx/simple-errors';
+import { Company, Country } from '@stamhoofd/structures';
+import axios from 'axios';
+import * as jsvat from 'jsvat-next'; // has no default export, so we need the wildcard
+
+export class ViesHelperStatic {
+    testMode = false;
+
+    async request(method: "GET" | "POST", url: string, content: any) {
+
+        const json = content ? JSON.stringify(content) : "";
+
+        console.log("[VIES REQUEST]", method, url, content ? "\n [VIES REQUEST] " : undefined, json)
+
+        const response = await axios.request({
+            method,
+            url,
+            headers: {
+                'Content-Type': json.length > 0 ? 'application/json' : "text/plain",
+            },
+            data: json
+            
+        })
+        console.log("[VIES RESPONSE]", method, url, "\n[VIES RESPONSE]", JSON.stringify(response.data))
+        return response.data
+    }
+
+    async checkCompany(company: Company, patch: AutoEncoderPatchType<Company>|Company) {
+        if (!company.address) {
+            // Not allowed to set
+            patch.companyNumber = null;
+            patch.VATNumber = null;
+            return;
+        }
+
+        if (company.VATNumber !== null) {
+            // Changed VAT number
+            patch.VATNumber = await ViesHelper.checkVATNumber(company.address.country, company.VATNumber)
+
+            if (company.address.country === Country.Belgium) {
+                patch.companyNumber = company.VATNumber
+            }
+        }
+
+        if (company.companyNumber) {
+            if (company.VATNumber !== null && company.address.country === Country.Belgium) {
+                // Already validated
+            } else {
+                // Need to validate
+                const result = await ViesHelper.checkCompanyNumber(company.address.country, company.companyNumber)
+                patch.companyNumber = result.companyNumber
+                if (result.VATNumber !== undefined) {
+                    patch.VATNumber = result.VATNumber
+                }
+            }
+        }
+    }
+
+    async checkCompanyNumber(country: Country, companyNumber: string): Promise<{companyNumber: string|null, VATNumber?: string|null}> {
+        if (country !== Country.Belgium) {
+            // Not supported
+            return {
+                companyNumber
+            };
+        }
+
+        // In Belgium, the company number syntax is the same as VAT number
+
+        const result = jsvat.checkVAT(companyNumber, [jsvat.belgium]);
+
+        if (!result.isValid) {
+            throw new SimpleError({
+                "code": "invalid_field",
+                "message": "Ongeldig ondernemingsnummer: " + companyNumber,
+                "field": "companyNumber"
+            })
+        }
+
+        // If this is a valid VAT number, we can assume it's a valid company number
+        try {
+            const corrected = await this.checkVATNumber(Country.Belgium, companyNumber);
+
+            // this is a VAT number, not a company number
+            return {
+                companyNumber: corrected,
+                VATNumber: corrected
+            }
+        } catch (e) {
+            if (isSimpleError(e) || isSimpleErrors(e)) {
+                // Ignore: normal that it is not a valid VAT number
+            } else {
+                // Other errors should be thrown
+                throw e;
+            }
+        }
+
+        return {
+            companyNumber: result.value ?? companyNumber,
+
+            // VATNumber should always be set to null if it is not a valid VAT number
+            VATNumber: null
+        };
+    }
+
+    async checkVATNumber(country: Country, vatNumber: string): Promise<string> {
+        const result = jsvat.checkVAT(vatNumber, country === Country.Belgium ? [jsvat.belgium] : [jsvat.netherlands]);
+
+        if (!result.isValid) {
+            throw new SimpleError({
+                "code": "invalid_field",
+                "message": "Ongeldig BTW-nummer: " + vatNumber,
+                "field": "VATNumber"
+            })
+        } 
+
+        const formatted = result.value ?? vatNumber;
+
+        try {
+            const cleaned = formatted.substring(2).replace(/(\.\-\s)+/g, "")
+            const response = await this.request("POST", "https://ec.europa.eu/taxation_customs/vies/rest-api/check-vat-number", {
+                countryCode: country,
+                vatNumber: cleaned
+            });
+
+            if (typeof response !== 'object' || response === null || typeof response.valid !== 'boolean') {
+                // APi error
+                throw new Error("Invalid response from VIES")
+            }
+            
+            if (!response.valid) {
+                throw new SimpleError({
+                    "code": "invalid_field",
+                    "message": "Het opgegeven BTW-nummer is ongeldig of niet BTW-plichtig: " + formatted,
+                    "field": "VATNumber"
+                })
+            }
+        } catch (e) {
+            if (isSimpleError(e) || isSimpleErrors(e)) {
+                throw e;
+            }
+            // Unavailable: ignore for now
+            console.error('VIES error', e);
+        }
+
+        return formatted;
+    }
+
+}
+
+export const ViesHelper = new ViesHelperStatic();

package/src/seeds/1722344160-update-membership.ts

@@ -22,33 +22,30 @@ export default new Migration(async () => {
                 value: id,
                 sign: '>'
             }
-        }, {limit: 100, sort: ['id']});
-
-        // const members = await Member.getByIDs(...rawMembers.map(m => m.id));
-
-        for (const member of rawMembers) {
-            const memberWithRegistrations = await Member.getWithRegistrations(member.id);
-            if(memberWithRegistrations) {
-                await memberWithRegistrations.updateMemberships();
-                await memberWithRegistrations.save();
-            } else {
-                throw new Error("Member with registrations not found: " + member.id);
-            }
-
-            c++;
-
-            if (c%1000 === 0) {
-                process.stdout.write('.');
-            }
-            if (c%10000 === 0) {
-                process.stdout.write('\n');
-            }
-        }
+        }, {limit: 500, sort: ['id']});
 
         if (rawMembers.length === 0) {
             break;
         }
 
+        const promises: Promise<any>[] = [];
+        
+
+        for (const member of rawMembers) {
+            promises.push((async () => {
+                await Member.updateMembershipsForId(member.id, true);
+                c++;
+    
+                if (c%1000 === 0) {
+                    process.stdout.write('.');
+                }
+                if (c%10000 === 0) {
+                    process.stdout.write('\n');
+                }
+            })())
+        }
+
+        await Promise.all(promises);
         id = rawMembers[rawMembers.length - 1].id;
     }
 

package/src/seeds/1722344161-sync-member-users.ts

@@ -0,0 +1,60 @@
+import { Migration } from '@simonbackx/simple-database';
+import { Member } from '@stamhoofd/models';
+import { MemberUserSyncer } from '../helpers/MemberUserSyncer';
+import { logger } from '@simonbackx/simple-logging';
+
+export default new Migration(async () => {
+    if (STAMHOOFD.environment == "test") {
+        console.log("skipped in tests")
+        return;
+    }
+
+    if(STAMHOOFD.userMode !== "platform") {
+        console.log("skipped seed update-membership because usermode not platform")
+        return;
+    }
+
+    process.stdout.write('\n');
+    let c = 0;
+    let id: string = '';
+
+    await logger.setContext({tags: ['silent-seed', 'seed']}, async () => {
+        while(true) {
+            const rawMembers = await Member.where({
+                id: {
+                    value: id,
+                    sign: '>'
+                }
+            }, {limit: 500, sort: ['id']});
+
+            if (rawMembers.length === 0) {
+                break;
+            }
+
+            const membersWithRegistrations = await Member.getBlobByIds(...rawMembers.map(m => m.id));
+
+            const promises: Promise<any>[] = [];
+
+            for (const memberWithRegistrations of membersWithRegistrations) {
+                promises.push((async () => {
+                    await MemberUserSyncer.onChangeMember(memberWithRegistrations);
+                    c++;
+
+                    if (c%1000 === 0) {
+                        process.stdout.write('.');
+                    }
+                    if (c%10000 === 0) {
+                        process.stdout.write('\n');
+                    }
+                })());
+            }
+
+            await Promise.all(promises);
+            id = rawMembers[rawMembers.length - 1].id;
+        }
+    })
+
+
+    // Do something here
+    return Promise.resolve()
+})

package/.env.json

@@ -1,65 +0,0 @@
-{
-    "environment": "development",
-    "domains": {
-        "dashboard": "dashboard.stamhoofd",
-        "registration": {
-            "": "be.stamhoofd",
-            "BE": "be.stamhoofd",
-            "NL": "nl.stamhoofd"
-        },
-        "marketing": {
-            "": "www.be.stamhoofd",
-            "BE": "www.be.stamhoofd",
-            "NL": "www.nl.stamhoofd"
-        },
-        "webshop": {
-            "": "shop.be.stamhoofd",
-            "BE": "shop.be.stamhoofd",
-            "NL": "shop.nl.stamhoofd"
-        },
-        "webshopPrefix": "shop",
-        "legacyWebshop": "shop.stamhoofd",
-        "api": "api.stamhoofd",
-        "demoApi": "api.stamhoofd",
-        "rendererApi": "renderer.stamhoofd"
-    },
-        "translationNamespace": "digit",
-    "userMode": "platform",
-    
-    "PORT": 9091,
-    "DB_HOST": "127.0.0.1",
-    "DB_USER": "root",
-    "DB_PASS": "root",
-    "DB_DATABASE": "ksa-stamhoofd",
-
-    "SMTP_HOST": "0.0.0.0",
-    "SMTP_USERNAME": "username",
-    "SMTP_PASSWORD": "password",
-    "SMTP_PORT": 1025,
-
-    "TRANSACTIONAL_SMTP_HOST": "0.0.0.0",
-    "TRANSACTIONAL_SMTP_USERNAME": "username",
-    "TRANSACTIONAL_SMTP_PASSWORD": "password",
-    "TRANSACTIONAL_SMTP_PORT": 1025,
-
-    "AWS_ACCESS_KEY_ID": "",
-    "AWS_SECRET_ACCESS_KEY": "",
-    "AWS_REGION": "",
-
-    "SPACES_ENDPOINT": "",
-    "SPACES_BUCKET": "",
-    "SPACES_KEY": "",
-    "SPACES_SECRET": "",
-
-    "MOLLIE_CLIENT_ID": "",
-    "MOLLIE_SECRET": "",
-    "MOLLIE_API_KEY": "",
-    "MOLLIE_ORGANIZATION_TOKEN": "",
-
-    "LATEST_IOS_VERSION": 0,
-    "LATEST_ANDROID_VERSION": 0,
-
-    "NOLT_SSO_SECRET_KEY": "",
-    "INTERNAL_SECRET_KEY": "",
-    "CRONS_DISABLED": false
-}