@stamhoofd/backend 2.79.6 → 2.79.7

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@stamhoofd/backend",
-    "version": "2.79.6",
+    "version": "2.79.7",
     "main": "./dist/index.js",
     "exports": {
         ".": {
@@ -38,14 +38,14 @@
         "@simonbackx/simple-encoding": "2.21.0",
         "@simonbackx/simple-endpoints": "1.19.1",
         "@simonbackx/simple-logging": "^1.0.1",
-        "@stamhoofd/backend-i18n": "2.79.6",
-        "@stamhoofd/backend-middleware": "2.79.6",
-        "@stamhoofd/email": "2.79.6",
-        "@stamhoofd/models": "2.79.6",
-        "@stamhoofd/queues": "2.79.6",
-        "@stamhoofd/sql": "2.79.6",
-        "@stamhoofd/structures": "2.79.6",
-        "@stamhoofd/utility": "2.79.6",
+        "@stamhoofd/backend-i18n": "2.79.7",
+        "@stamhoofd/backend-middleware": "2.79.7",
+        "@stamhoofd/email": "2.79.7",
+        "@stamhoofd/models": "2.79.7",
+        "@stamhoofd/queues": "2.79.7",
+        "@stamhoofd/sql": "2.79.7",
+        "@stamhoofd/structures": "2.79.7",
+        "@stamhoofd/utility": "2.79.7",
         "archiver": "^7.0.1",
         "aws-sdk": "^2.885.0",
         "axios": "1.6.8",
@@ -65,5 +65,5 @@
     "publishConfig": {
         "access": "public"
     },
-    "gitHead": "5ed5677f28e62a73283527518b8e7ac0c8b4818e"
+    "gitHead": "d8675cbc91c2fcdcc6bbd3b3925ccd8063b15522"
 }

package/src/endpoints/global/registration/RegisterMembersEndpoint.ts

@@ -457,41 +457,9 @@ export class RegisterMembersEndpoint extends Endpoint<Params, Query, Body, Respo
             balanceItem.organizationId = organization.id;
 
             // Who is responsible for payment?
-            let balanceItem2: BalanceItem | null = null;
             if (registration.payingOrganizationId) {
-                // Create a separate balance item for this meber to pay back the paying organization
-                // this is not yet associated with a payment but will be added to the outstanding balance of the member
-
+                // We no longer also charge the member. This has been removed, ref STA-288
                 balanceItem.payingOrganizationId = registration.payingOrganizationId;
-
-                balanceItem2 = new BalanceItem();
-
-                // NOTE: we don't connect the registrationId here
-                // because otherwise the total price and pricePaid for the registration would be incorrect
-                // balanceItem2.registrationId = registration.id;
-
-                balanceItem2.unitPrice = unitPrice;
-                balanceItem2.amount = amount ?? 1;
-                balanceItem2.description = description;
-                balanceItem2.relations = relations;
-                balanceItem2.type = type;
-
-                // Who needs to receive this money?
-                balanceItem2.organizationId = registration.payingOrganizationId;
-
-                // Who is responsible for payment?
-                balanceItem2.memberId = registration.memberId;
-
-                if (registration.trialUntil) {
-                    balanceItem2.dueAt = registration.trialUntil;
-                }
-
-                // If the paying organization hasn't paid yet, this should be hidden and move to pending as soon as the paying organization has paid
-                balanceItem2.status = BalanceItemStatus.Hidden;
-                await balanceItem2.save();
-
-                // do not add to createdBalanceItems array because we don't want to add this to the payment if we create a payment
-                unrelatedCreatedBalanceItems.push(balanceItem2);
             }
             else {
                 balanceItem.memberId = registration.memberId;
@@ -501,9 +469,6 @@ export class RegisterMembersEndpoint extends Endpoint<Params, Query, Body, Respo
             balanceItem.status = BalanceItemStatus.Hidden;
             balanceItem.pricePaid = 0;
 
-            // Connect the 'pay back' balance item to this balance item. As soon as this balance item is paid, we'll mark the other one as pending so the outstanding balance for the member increases
-            balanceItem.dependingBalanceItemId = balanceItem2?.id ?? null;
-
             if (registration.trialUntil) {
                 balanceItem.dueAt = registration.trialUntil;
             }

package/src/helpers/AuthenticatedStructures.ts

@@ -391,7 +391,7 @@ export class AuthenticatedStructures {
         const organizations = new Map<string, Organization>();
 
         const registrationIds = Formatter.uniqueArray(members.flatMap(m => m.registrations.map(r => r.id)));
-        const balances = await CachedBalance.getForObjects(registrationIds, Context.organization?.id ?? null);
+        const balances = await CachedBalance.getForObjects(registrationIds, null);
 
         if (includeUser) {
             for (const organizationId of includeUser.permissions?.organizationPermissions.keys() ?? []) {