@stamhoofd/backend 2.62.0 → 2.64.0

package/src/endpoints/organization/dashboard/payments/PatchBalanceItemsEndpoint.ts

@@ -6,6 +6,7 @@ import { QueueHandler } from '@stamhoofd/queues';
 import { BalanceItemStatus, BalanceItemType, BalanceItemWithPayments, PermissionLevel } from '@stamhoofd/structures';
 
 import { Context } from '../../../../helpers/Context';
+import { BalanceItemService } from '../../../../services/BalanceItemService';
 
 type Params = Record<string, never>;
 type Query = undefined;
@@ -36,17 +37,13 @@ export class PatchBalanceItemsEndpoint extends Endpoint<Params, Query, Body, Res
             throw Context.auth.error();
         }
 
-        if (request.body.changes.length == 0) {
+        if (request.body.changes.length === 0) {
             return new Response([]);
         }
 
         const returnedModels: BalanceItem[] = [];
         const updateOutstandingBalance: BalanceItem[] = [];
 
-        // Keep track of updates
-        const memberIds: string[] = [];
-        const registrationIds: string[] = [];
-
         await QueueHandler.schedule('balance-item-update/' + organization.id, async () => {
             for (const { put } of request.body.getPuts()) {
                 // Create a new balance item
@@ -58,7 +55,8 @@ export class PatchBalanceItemsEndpoint extends Endpoint<Params, Query, Body, Res
                 model.amount = put.amount;
                 model.organizationId = organization.id;
                 model.createdAt = put.createdAt;
-                model.status = put.status === BalanceItemStatus.Hidden ? BalanceItemStatus.Hidden : BalanceItemStatus.Pending;
+                model.dueAt = put.dueAt;
+                model.status = put.status === BalanceItemStatus.Hidden ? BalanceItemStatus.Hidden : BalanceItemStatus.Due;
 
                 if (put.userId) {
                     model.userId = (await this.validateUserId(model, put.userId)).id;
@@ -66,10 +64,43 @@ export class PatchBalanceItemsEndpoint extends Endpoint<Params, Query, Body, Res
 
                 if (put.memberId) {
                     model.memberId = (await this.validateMemberId(put.memberId)).id;
-                    memberIds.push(model.memberId);
                 }
 
-                if (!model.userId && !model.memberId) {
+                if (put.payingOrganizationId) {
+                    // Not allowed if not full admin
+                    if (!Context.auth.hasPlatformFullAccess()) {
+                        throw Context.auth.error('Je moet volledige platform beheerder zijn om schulden tussen verenigingen te wijzigen of toe te voegen');
+                    }
+                    if (put.payingOrganizationId === model.organizationId) {
+                        throw new SimpleError({
+                            code: 'invalid_field',
+                            message: 'payingOrganizationId cannot be the same as organizationId',
+                            human: 'Dit is een ongeldige situatie. Een schuld moet tussen verschillende verenigingen zijn.',
+                            field: 'payingOrganizationId',
+                        });
+                    }
+
+                    model.payingOrganizationId = put.payingOrganizationId;
+                }
+
+                if (model.dueAt && model.price < 0) {
+                    throw new SimpleError({
+                        code: 'invalid_price',
+                        message: 'Cannot create negative balance in the future',
+                        human: 'Het is niet mogelijk om een negatief openstaand bedrag toe te voegen in de toekomst',
+                    });
+                }
+
+                if (model.createdAt > new Date()) {
+                    throw new SimpleError({
+                        code: 'invalid_field',
+                        message: 'createdAt cannot be in the future',
+                        human: 'De datum kan niet in de toekomst liggen',
+                        field: 'createdAt',
+                    });
+                }
+
+                if (!model.userId && !model.memberId && !model.payingOrganizationId) {
                     throw new SimpleError({
                         code: 'invalid_field',
                         message: 'No user or member provided',
@@ -93,39 +124,53 @@ export class PatchBalanceItemsEndpoint extends Endpoint<Params, Query, Body, Res
                     });
                 }
 
-                if (patch.unitPrice !== undefined) {
-                    // throw new SimpleError({
-                    //    code: 'invalid_field',
-                    //    message: 'You cannot change the unit price of a balance item',
-                    //    human: 'Het is niet mogelijk om de eenheidsprijs van een openstaande schuld te wijzigen. Je kan de openstaande schuld verwijderen en opnieuw aanmaken indien noodzakelijk.',
-                    // });
-                }
+                if (patch.payingOrganizationId !== undefined) {
+                    // Not allowed if not full admin
+                    if (!Context.auth.hasPlatformFullAccess()) {
+                        throw Context.auth.error('Je moet volledige platform beheerder zijn om schulden tussen verenigingen te wijzigen of toe te voegen');
+                    }
+                    if (patch.payingOrganizationId === model.organizationId) {
+                        throw new SimpleError({
+                            code: 'invalid_field',
+                            message: 'payingOrganizationId cannot be the same as organizationId',
+                            human: 'Dit is een ongeldige situatie. Een schuld moet tussen verschillende verenigingen zijn.',
+                            field: 'payingOrganizationId',
+                        });
+                    }
 
-                // Check permissions
-                if (model.memberId) {
-                    // Update old
-                    memberIds.push(model.memberId);
+                    model.payingOrganizationId = patch.payingOrganizationId;
                 }
 
                 if (patch.memberId) {
                     model.memberId = (await this.validateMemberId(patch.memberId)).id;
-
-                    // Update new
-                    memberIds.push(model.memberId);
-                }
-
-                if (model.registrationId) {
-                    // Update old
-                    registrationIds.push(model.registrationId);
                 }
 
                 if (patch.createdAt) {
                     model.createdAt = patch.createdAt;
+
+                    if (model.createdAt > new Date()) {
+                        throw new SimpleError({
+                            code: 'invalid_field',
+                            message: 'createdAt cannot be in the future',
+                            human: 'De datum kan niet in de toekomst liggen',
+                            field: 'createdAt',
+                        });
+                    }
                 }
 
                 model.description = patch.description ?? model.description;
                 model.unitPrice = patch.unitPrice ?? model.unitPrice;
                 model.amount = patch.amount ?? model.amount;
+                model.dueAt = patch.dueAt === undefined ? model.dueAt : patch.dueAt;
+
+                if ((patch.dueAt !== undefined || patch.unitPrice !== undefined) && model.dueAt && model.price < 0) {
+                    throw new SimpleError({
+                        code: 'invalid_price',
+                        message: 'Cannot create negative balance in the future',
+                        human: 'Het is niet mogelijk om een negatief openstaand bedrag toe te voegen in de toekomst',
+                        field: 'dueAt',
+                    });
+                }
 
                 if (model.orderId) {
                     // Not allowed to change this
@@ -142,13 +187,21 @@ export class PatchBalanceItemsEndpoint extends Endpoint<Params, Query, Body, Res
                     }
                 }
                 else if (patch.status) {
-                    model.status = model.pricePaid >= model.price ? BalanceItemStatus.Paid : BalanceItemStatus.Pending;
+                    model.status = patch.status;
+                }
+
+                if (!model.userId && !model.memberId && !model.payingOrganizationId) {
+                    throw new SimpleError({
+                        code: 'invalid_field',
+                        message: 'No user or member provided',
+                        field: 'userId',
+                    });
                 }
 
                 await model.save();
                 returnedModels.push(model);
 
-                if (patch.unitPrice || patch.amount || patch.status) {
+                if (patch.unitPrice || patch.amount || patch.status || patch.dueAt !== undefined) {
                     updateOutstandingBalance.push(model);
                 }
             }
@@ -156,8 +209,14 @@ export class PatchBalanceItemsEndpoint extends Endpoint<Params, Query, Body, Res
 
         await BalanceItem.updateOutstanding(updateOutstandingBalance);
 
+        // Reallocate
+        await BalanceItemService.reallocate(updateOutstandingBalance, organization.id);
+
+        // Reload returnedModels
+        const returnedModelsReloaded = await BalanceItem.getByIDs(...returnedModels.map(m => m.id));
+
         return new Response(
-            await BalanceItem.getStructureWithPayments(returnedModels),
+            await BalanceItem.getStructureWithPayments(returnedModelsReloaded),
         );
     }
 

package/src/endpoints/organization/dashboard/payments/PatchPaymentsEndpoint.ts

@@ -1,15 +1,14 @@
 import { AutoEncoderPatchType, Decoder, PatchableArrayAutoEncoder, PatchableArrayDecoder, StringDecoder } from '@simonbackx/simple-encoding';
 import { DecodedRequest, Endpoint, Request, Response } from '@simonbackx/simple-endpoints';
 import { SimpleError } from '@simonbackx/simple-errors';
-import { BalanceItem, BalanceItemPayment, Payment, Token } from '@stamhoofd/models';
+import { BalanceItem, BalanceItemPayment, Payment } from '@stamhoofd/models';
 import { QueueHandler } from '@stamhoofd/queues';
-import { Payment as PaymentStruct, PaymentGeneral, PaymentMethod, PaymentStatus, PermissionLevel } from '@stamhoofd/structures';
+import { PaymentGeneral, PaymentMethod, PaymentStatus, Payment as PaymentStruct, PaymentType, PermissionLevel } from '@stamhoofd/structures';
 
 import { AuthenticatedStructures } from '../../../../helpers/AuthenticatedStructures';
 import { Context } from '../../../../helpers/Context';
-import { ExchangePaymentEndpoint } from '../../shared/ExchangePaymentEndpoint';
-import { PaymentService } from '../../../../services/PaymentService';
 import { BalanceItemService } from '../../../../services/BalanceItemService';
+import { PaymentService } from '../../../../services/PaymentService';
 
 type Params = Record<string, never>;
 type Query = undefined;
@@ -49,11 +48,11 @@ export class PatchPaymentsEndpoint extends Endpoint<Params, Query, Body, Respons
         // Modify payments
         for (const { put } of request.body.getPuts()) {
             // Create a new payment
-            if (put.balanceItemPayments.length == 0) {
+            if (put.balanceItemPayments.length === 0) {
                 throw new SimpleError({
                     code: 'invalid_field',
                     message: 'You need to add at least one balance item payment',
-                    human: 'Een betaling moet ten minste één afrekening bevatten voor een openstaande rekening.',
+                    human: 'Een betaling moet ten minste één item bestaan',
                     field: 'balanceItemPayments',
                 });
             }
@@ -72,8 +71,9 @@ export class PatchPaymentsEndpoint extends Endpoint<Params, Query, Body, Respons
             payment.status = PaymentStatus.Created;
             payment.method = put.method;
             payment.customer = put.customer;
+            payment.type = put.type;
 
-            if (payment.method == PaymentMethod.Transfer) {
+            if (payment.method === PaymentMethod.Transfer) {
                 if (!put.transferSettings) {
                     throw new SimpleError({
                         code: 'invalid_field',
@@ -112,7 +112,11 @@ export class PatchPaymentsEndpoint extends Endpoint<Params, Query, Body, Respons
                 balanceItemPayment.organizationId = organization.id;
                 balanceItemPayment.balanceItemId = balanceItem.id;
                 balanceItemPayment.price = item.price;
-                balanceItemPayments.push(balanceItemPayment);
+
+                if (item.price !== 0) {
+                    // Otherwise skip
+                    balanceItemPayments.push(balanceItemPayment);
+                }
             }
 
             // Check permissions
@@ -122,17 +126,55 @@ export class PatchPaymentsEndpoint extends Endpoint<Params, Query, Body, Respons
 
             // Check total price
             const totalPrice = balanceItemPayments.reduce((total, item) => total + item.price, 0);
+            payment.price = totalPrice;
 
-            if (totalPrice !== put.price) {
-                throw new SimpleError({
-                    code: 'invalid_field',
-                    message: "Total price doesn't match",
-                    human: 'De totale prijs komt niet overeen met de som van de afrekeningen',
-                    field: 'price',
-                });
-            }
+            switch (payment.type) {
+                case PaymentType.Payment: {
+                    if (totalPrice <= 0) {
+                        throw new SimpleError({
+                            code: 'invalid_field',
+                            message: 'The price should be greater than zero',
+                            human: 'Het totaalbedrag moet groter zijn dan 0 euro',
+                            field: 'price',
+                        });
+                    }
+                    break;
+                }
 
-            payment.price = totalPrice;
+                case PaymentType.Chargeback:
+                case PaymentType.Refund: {
+                    if (totalPrice >= 0) {
+                        throw new SimpleError({
+                            code: 'invalid_field',
+                            message: 'The price should be smaller than zero',
+                            human: 'Het totaalbedrag moet kleiner zijn dan 0 euro',
+                            field: 'price',
+                        });
+                    }
+                    break;
+                }
+
+                case PaymentType.Reallocation:
+                {
+                    if (totalPrice !== 0) {
+                        throw new SimpleError({
+                            code: 'invalid_field',
+                            message: 'Total price should be zero',
+                            human: 'Het totaalbedrag moet 0 euro zijn',
+                            field: 'price',
+                        });
+                    }
+
+                    if (balanceItemPayments.length < 2) {
+                        throw new SimpleError({
+                            code: 'missing_items',
+                            message: 'At least two items are required for a reallocation',
+                            human: 'Er moeten minstens twee items in een verrekening zitten',
+                        });
+                    }
+                    break;
+                }
+            }
 
             // Save payment
             await payment.save();
@@ -158,6 +200,9 @@ export class PatchPaymentsEndpoint extends Endpoint<Params, Query, Body, Respons
                 }
 
                 await BalanceItem.updateOutstanding(balanceItems);
+
+                // Reallocate
+                await BalanceItemService.reallocate(balanceItems, organization.id);
             }
 
             changedPayments.push(payment);

package/src/endpoints/organization/dashboard/receivable-balances/GetReceivableBalanceEndpoint.ts

@@ -44,10 +44,19 @@ export class GetReceivableBalanceEndpoint extends Endpoint<Params, Query, Body,
             case ReceivableBalanceType.organization: {
                 paymentModels = await Payment.select()
                     .where('organizationId', organization.id)
-                    .where('payingOrganizationId', request.params.id)
                     .andWhere(
                         SQL.whereNot('status', PaymentStatus.Failed),
                     )
+                    .join(
+                        SQL.join(BalanceItemPayment.table)
+                            .where(SQL.column(BalanceItemPayment.table, 'paymentId'), SQL.column(Payment.table, 'id')),
+                    )
+                    .join(
+                        SQL.join(BalanceItem.table)
+                            .where(SQL.column(BalanceItemPayment.table, 'balanceItemId'), SQL.column(BalanceItem.table, 'id')),
+                    )
+                    .where(SQL.column(BalanceItem.table, 'payingOrganizationId'), request.params.id)
+                    .groupBy(SQL.column(Payment.table, 'id'))
                     .fetch();
                 break;
             }
@@ -71,6 +80,46 @@ export class GetReceivableBalanceEndpoint extends Endpoint<Params, Query, Body,
                     .fetch();
                 break;
             }
+
+            case ReceivableBalanceType.user: {
+                paymentModels = await Payment.select()
+                    .where('organizationId', organization.id)
+                    .join(
+                        SQL.join(BalanceItemPayment.table)
+                            .where(SQL.column(BalanceItemPayment.table, 'paymentId'), SQL.column(Payment.table, 'id')),
+                    )
+                    .join(
+                        SQL.join(BalanceItem.table)
+                            .where(SQL.column(BalanceItemPayment.table, 'balanceItemId'), SQL.column(BalanceItem.table, 'id')),
+                    )
+                    .where(SQL.column(BalanceItem.table, 'userId'), request.params.id)
+                    .andWhere(
+                        SQL.whereNot('status', PaymentStatus.Failed),
+                    )
+                    .groupBy(SQL.column(Payment.table, 'id'))
+                    .fetch();
+                break;
+            }
+
+            case ReceivableBalanceType.registration: {
+                paymentModels = await Payment.select()
+                    .where('organizationId', organization.id)
+                    .join(
+                        SQL.join(BalanceItemPayment.table)
+                            .where(SQL.column(BalanceItemPayment.table, 'paymentId'), SQL.column(Payment.table, 'id')),
+                    )
+                    .join(
+                        SQL.join(BalanceItem.table)
+                            .where(SQL.column(BalanceItemPayment.table, 'balanceItemId'), SQL.column(BalanceItem.table, 'id')),
+                    )
+                    .where(SQL.column(BalanceItem.table, 'registrationId'), request.params.id)
+                    .andWhere(
+                        SQL.whereNot('status', PaymentStatus.Failed),
+                    )
+                    .groupBy(SQL.column(Payment.table, 'id'))
+                    .fetch();
+                break;
+            }
         }
 
         const balanceItems = await BalanceItem.getStructureWithPayments(balanceItemModels);
@@ -79,8 +128,9 @@ export class GetReceivableBalanceEndpoint extends Endpoint<Params, Query, Body,
         const balances = await CachedBalance.getForObjects([request.params.id], organization.id);
 
         const created = new CachedBalance();
-        created.amount = 0;
+        created.amountOpen = 0;
         created.amountPending = 0;
+        created.amountPaid = 0;
         created.organizationId = organization.id;
         created.objectId = request.params.id;
         created.objectType = request.params.type;

package/src/endpoints/organization/dashboard/receivable-balances/GetReceivableBalancesEndpoint.ts

@@ -3,7 +3,7 @@ import { DecodedRequest, Endpoint, Request, Response } from '@simonbackx/simple-
 import { SimpleError } from '@simonbackx/simple-errors';
 import { CachedBalance } from '@stamhoofd/models';
 import { compileToSQLFilter, compileToSQLSorter } from '@stamhoofd/sql';
-import { ReceivableBalance as ReceivableBalanceStruct, CountFilteredRequest, LimitedFilteredRequest, PaginatedResponse, StamhoofdFilter, assertSort, getSortFilter } from '@stamhoofd/structures';
+import { ReceivableBalance as ReceivableBalanceStruct, CountFilteredRequest, LimitedFilteredRequest, PaginatedResponse, StamhoofdFilter, assertSort, getSortFilter, ReceivableBalanceType } from '@stamhoofd/structures';
 
 import { AuthenticatedStructures } from '../../../../helpers/AuthenticatedStructures';
 import { Context } from '../../../../helpers/Context';
@@ -49,8 +49,14 @@ export class GetReceivableBalancesEndpoint extends Endpoint<Params, Query, Body,
         scopeFilter = {
             organizationId: organization.id,
             $or: {
-                amount: { $neq: 0 },
+                amountOpen: { $neq: 0 },
                 amountPending: { $neq: 0 },
+                nextDueAt: { $neq: null },
+            },
+            $not: {
+                objectType: {
+                    $in: Context.auth.hasSomePlatformAccess() ? [ReceivableBalanceType.registration] : [ReceivableBalanceType.organization, ReceivableBalanceType.registration],
+                },
             },
         };
 

package/src/endpoints/organization/dashboard/registration-periods/PatchOrganizationRegistrationPeriodsEndpoint.ts

@@ -346,7 +346,11 @@ export class PatchOrganizationRegistrationPeriodsEndpoint extends Endpoint<Param
             model.settings.period = period.getBaseStructure();
 
             if (model.type !== GroupType.EventRegistration) {
-                model.settings.startDate = period.startDate;
+                // Note: start date is curomizable, as long as it stays between period start and end
+                if (model.settings.startDate < period.startDate || model.settings.startDate > period.endDate) {
+                    model.settings.startDate = period.startDate;
+                }
+
                 model.settings.endDate = period.endDate;
             }
         }
@@ -446,9 +450,13 @@ export class PatchOrganizationRegistrationPeriodsEndpoint extends Endpoint<Param
         model.status = struct.status;
         model.type = struct.type;
         model.settings.period = period.getBaseStructure();
-        model.settings.startDate = period.startDate;
         model.settings.endDate = period.endDate;
 
+        // Note: start date is curomizable, as long as it stays between period start and end
+        if (model.settings.startDate < period.startDate || model.settings.startDate > period.endDate) {
+            model.settings.startDate = period.startDate;
+        }
+
         if (!await Context.auth.canAccessGroup(model, PermissionLevel.Full)) {
             // Create a temporary permission role for this user
             const organizationPermissions = user.permissions?.organizationPermissions?.get(organizationId);

package/src/endpoints/organization/dashboard/webshops/PatchWebshopOrdersEndpoint.ts

@@ -169,7 +169,7 @@ export class PatchWebshopOrdersEndpoint extends Endpoint<Params, Query, Body, Re
                         balanceItem.description = webshop.meta.name;
                         balanceItem.pricePaid = 0;
                         balanceItem.organizationId = organization.id;
-                        balanceItem.status = BalanceItemStatus.Pending;
+                        balanceItem.status = BalanceItemStatus.Due;
                         balanceItem.relations = new Map([
                             [
                                 BalanceItemRelationType.Webshop,
@@ -271,13 +271,23 @@ export class PatchWebshopOrdersEndpoint extends Endpoint<Params, Query, Body, Re
                     const items = await BalanceItem.where({ orderId: model.id });
                     if (items.length >= 1) {
                         model.markUpdated();
-                        items[0].unitPrice = model.totalToPay;
-                        items[0].description = model.generateBalanceDescription(webshop);
-                        items[0].updateStatus();
-                        await items[0].save();
+
+                        const paidItem = items.find(i => i.status === BalanceItemStatus.Due && i.pricePaid !== 0) ?? items[0];
+
+                        paidItem.unitPrice = model.data.totalPrice;
+                        paidItem.amount = 1;
+
+                        if (model.isDue) {
+                            paidItem.status = BalanceItemStatus.Due;
+                        }
+                        else {
+                            paidItem.status = BalanceItemStatus.Canceled;
+                        }
+                        paidItem.description = model.generateBalanceDescription(webshop);
+                        await paidItem.save();
 
                         // Zero out the other items
-                        const otherItems = items.slice(1);
+                        const otherItems = items.filter(i => i.id !== paidItem.id);
                         await BalanceItem.deleteItems(otherItems);
                     }
                     else if (items.length === 0
@@ -285,11 +295,12 @@ export class PatchWebshopOrdersEndpoint extends Endpoint<Params, Query, Body, Re
                         model.markUpdated();
                         const balanceItem = new BalanceItem();
                         balanceItem.orderId = model.id;
-                        balanceItem.unitPrice = model.totalToPay;
+                        balanceItem.unitPrice = model.data.totalPrice;
+                        balanceItem.amount = 1;
+                        balanceItem.status = BalanceItemStatus.Due;
                         balanceItem.description = model.generateBalanceDescription(webshop);
                         balanceItem.pricePaid = 0;
                         balanceItem.organizationId = organization.id;
-                        balanceItem.status = BalanceItemStatus.Pending;
                         await balanceItem.save();
                     }
                 }

package/src/endpoints/organization/webshops/PlaceOrderEndpoint.ts

@@ -6,7 +6,7 @@ import { I18n } from '@stamhoofd/backend-i18n';
 import { Email } from '@stamhoofd/email';
 import { BalanceItem, BalanceItemPayment, MolliePayment, MollieToken, Order, PayconiqPayment, Payment, RateLimiter, Webshop, WebshopDiscountCode } from '@stamhoofd/models';
 import { QueueHandler } from '@stamhoofd/queues';
-import { BalanceItemStatus, Order as OrderStruct, OrderData, OrderResponse, Payment as PaymentStruct, PaymentMethod, PaymentMethodHelper, PaymentProvider, PaymentStatus, Version, Webshop as WebshopStruct, WebshopAuthType, BalanceItemType, BalanceItemRelationType, BalanceItemRelation, AuditLogSource } from '@stamhoofd/structures';
+import { BalanceItemStatus, Order as OrderStruct, OrderData, OrderResponse, Payment as PaymentStruct, PaymentMethod, PaymentMethodHelper, PaymentProvider, PaymentStatus, Version, Webshop as WebshopStruct, WebshopAuthType, BalanceItemType, BalanceItemRelationType, BalanceItemRelation, AuditLogSource, PaymentCustomer } from '@stamhoofd/structures';
 import { Formatter } from '@stamhoofd/utility';
 
 import { BuckarooHelper } from '../../../helpers/BuckarooHelper';
@@ -169,6 +169,11 @@ export class PlaceOrderEndpoint extends Endpoint<Params, Query, Body, ResponseBo
                 payment.status = PaymentStatus.Created;
                 payment.price = totalPrice;
                 payment.paidAt = null;
+                payment.customer = PaymentCustomer.create({
+                    firstName: request.body.customer.firstName,
+                    lastName: request.body.customer.lastName,
+                    email: request.body.customer.email,
+                });
 
                 // Determine the payment provider
                 // Throws if invalid
@@ -219,18 +224,18 @@ export class PlaceOrderEndpoint extends Endpoint<Params, Query, Body, ResponseBo
                 let paymentUrl: string | null = null;
                 const description = webshop.meta.name + ' - ' + payment.id;
 
-                if (payment.method == PaymentMethod.Transfer) {
+                if (payment.method === PaymentMethod.Transfer) {
                     await order.markValid(payment, []);
 
                     if (order.number) {
                         balanceItem.description = order.generateBalanceDescription(webshop);
                     }
 
-                    balanceItem.status = BalanceItemStatus.Pending;
+                    balanceItem.status = BalanceItemStatus.Due;
                     await balanceItem.save();
                     await payment.save();
                 }
-                else if (payment.method == PaymentMethod.PointOfSale) {
+                else if (payment.method === PaymentMethod.PointOfSale) {
                     // Not really paid, but needed to create the tickets if needed
                     await order.markPaid(payment, organization, webshop);
 
@@ -238,7 +243,7 @@ export class PlaceOrderEndpoint extends Endpoint<Params, Query, Body, ResponseBo
                         balanceItem.description = order.generateBalanceDescription(webshop);
                     }
 
-                    balanceItem.status = BalanceItemStatus.Pending;
+                    balanceItem.status = BalanceItemStatus.Due;
                     await balanceItem.save();
                     await payment.save();
                 }

package/src/helpers/AdminPermissionChecker.ts

@@ -263,7 +263,7 @@ export class AdminPermissionChecker {
             }
 
             const cachedBalance = await CachedBalance.getForObjects([member.id]);
-            if (cachedBalance.length === 0 || (cachedBalance[0].amount === 0 && cachedBalance[0].amountPending === 0)) {
+            if (cachedBalance.length === 0 || (cachedBalance[0].amountOpen === 0 && cachedBalance[0].amountPending === 0)) {
                 return true;
             }
         }
@@ -1063,6 +1063,7 @@ export class AdminPermissionChecker {
             for (const registration of cloned.registrations) {
                 registration.price = 0;
                 registration.pricePaid = 0;
+                registration.balances = [];
             }
         }
 
@@ -1310,7 +1311,7 @@ export class AdminPermissionChecker {
     }
 
     hasSomePlatformAccess(): boolean {
-        return !!this.platformPermissions;
+        return !!this.platformPermissions && !this.platformPermissions.isEmpty;
     }
 
     canManagePlatformAdmins() {