@stamhoofd/backend 2.56.0 → 2.57.0

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@stamhoofd/backend",
-    "version": "2.56.0",
+    "version": "2.57.0",
     "main": "./dist/index.js",
     "exports": {
         ".": {
@@ -34,17 +34,17 @@
         "@bwip-js/node": "^4.5.1",
         "@mollie/api-client": "3.7.0",
         "@simonbackx/simple-database": "1.25.0",
-        "@simonbackx/simple-encoding": "2.16.6",
+        "@simonbackx/simple-encoding": "2.17.0",
         "@simonbackx/simple-endpoints": "1.14.0",
         "@simonbackx/simple-logging": "^1.0.1",
-        "@stamhoofd/backend-i18n": "2.56.0",
-        "@stamhoofd/backend-middleware": "2.56.0",
-        "@stamhoofd/email": "2.56.0",
-        "@stamhoofd/models": "2.56.0",
-        "@stamhoofd/queues": "2.56.0",
-        "@stamhoofd/sql": "2.56.0",
-        "@stamhoofd/structures": "2.56.0",
-        "@stamhoofd/utility": "2.56.0",
+        "@stamhoofd/backend-i18n": "2.57.0",
+        "@stamhoofd/backend-middleware": "2.57.0",
+        "@stamhoofd/email": "2.57.0",
+        "@stamhoofd/models": "2.57.0",
+        "@stamhoofd/queues": "2.57.0",
+        "@stamhoofd/sql": "2.57.0",
+        "@stamhoofd/structures": "2.57.0",
+        "@stamhoofd/utility": "2.57.0",
         "archiver": "^7.0.1",
         "aws-sdk": "^2.885.0",
         "axios": "1.6.8",
@@ -64,5 +64,5 @@
     "publishConfig": {
         "access": "public"
     },
-    "gitHead": "39e791f29d992c918b83871d9dc6cf72c418b2c4"
+    "gitHead": "9e6e3c22154937a4977cc0d1b669d9577067b832"
 }

package/src/endpoints/global/events/PatchEventsEndpoint.ts

@@ -1,7 +1,7 @@
 import { AutoEncoderPatchType, Decoder, PatchableArrayAutoEncoder, PatchableArrayDecoder, patchObject, StringDecoder } from '@simonbackx/simple-encoding';
 import { DecodedRequest, Endpoint, Request, Response } from '@simonbackx/simple-endpoints';
 import { Event, Group, Platform, RegistrationPeriod } from '@stamhoofd/models';
-import { Event as EventStruct, GroupType, NamedObject, Group as GroupStruct } from '@stamhoofd/structures';
+import { Event as EventStruct, GroupType, NamedObject, Group as GroupStruct, AuditLogType } from '@stamhoofd/structures';
 
 import { SimpleError } from '@simonbackx/simple-errors';
 import { SQL, SQLWhereSign } from '@stamhoofd/sql';
@@ -9,6 +9,7 @@ import { Formatter } from '@stamhoofd/utility';
 import { AuthenticatedStructures } from '../../../helpers/AuthenticatedStructures';
 import { Context } from '../../../helpers/Context';
 import { PatchOrganizationRegistrationPeriodsEndpoint } from '../../organization/dashboard/registration-periods/PatchOrganizationRegistrationPeriodsEndpoint';
+import { AuditLogService } from '../../../services/AuditLogService';
 
 type Params = { id: string };
 type Query = undefined;
@@ -106,10 +107,18 @@ export class PatchEventsEndpoint extends Endpoint<Params, Query, Body, ResponseB
             await event.save();
 
             events.push(event);
+
+            await AuditLogService.log({
+                type: AuditLogType.EventAdded,
+                event,
+            });
         }
 
+        const patchingEvents = await Event.getByIDs(...request.body.getPatches().map(p => p.id));
+        const initialStructs = (await AuthenticatedStructures.events(patchingEvents)).map(e => e.clone()); // Clone is required for audit log (otherwise references might change)
+
         for (const patch of request.body.getPatches()) {
-            const event = await Event.getByID(patch.id);
+            const event = patchingEvents.find(e => e.id === patch.id);
 
             if (!event) {
                 throw new SimpleError({
@@ -242,6 +251,15 @@ export class PatchEventsEndpoint extends Endpoint<Params, Query, Body, ResponseB
             }
 
             events.push(event);
+
+            const struct = initialStructs.find(e => e.id === patch.id);
+
+            await AuditLogService.log({
+                type: AuditLogType.EventEdited,
+                event,
+                oldData: struct,
+                patch,
+            });
         }
 
         for (const id of request.body.getDeletes()) {
@@ -258,10 +276,16 @@ export class PatchEventsEndpoint extends Endpoint<Params, Query, Body, ResponseB
             }
 
             await event.delete();
+
+            await AuditLogService.log({
+                type: AuditLogType.EventDeleted,
+                event,
+            });
         }
 
+        const structures = await AuthenticatedStructures.events(events);
         return new Response(
-            await AuthenticatedStructures.events(events),
+            structures,
         );
     }
 

package/src/endpoints/global/platform/PatchPlatformEnpoint.ts

@@ -51,6 +51,8 @@ export class PatchPlatformEndpoint extends Endpoint<
         const platform = await Platform.getShared();
 
         if (request.body.privateConfig) {
+            const oldConfig = platform.privateConfig.clone();
+
             // Did we patch roles?
             if (request.body.privateConfig.roles) {
                 if (!Context.auth.canManagePlatformAdmins()) {
@@ -75,6 +77,12 @@ export class PatchPlatformEndpoint extends Endpoint<
                     request.body.privateConfig.emails,
                 );
             }
+
+            await AuditLogService.log({
+                type: AuditLogType.PlatformSettingsChanged,
+                oldConfig,
+                patch: request.body.privateConfig,
+            });
         }
 
         let shouldUpdateSetupSteps = false;
@@ -110,7 +118,7 @@ export class PatchPlatformEndpoint extends Endpoint<
                 }
 
                 await AuditLogService.log({
-                    type: AuditLogType.PlatformSettingChanged,
+                    type: AuditLogType.PlatformSettingsChanged,
                     oldConfig,
                     patch: newConfig,
                 });

package/src/endpoints/organization/dashboard/organization/PatchOrganizationEndpoint.ts

@@ -2,7 +2,7 @@ import { AutoEncoderPatchType, Decoder, isPatchableArray, ObjectData, PatchableA
 import { DecodedRequest, Endpoint, Request, Response } from '@simonbackx/simple-endpoints';
 import { SimpleError, SimpleErrors } from '@simonbackx/simple-errors';
 import { Organization, OrganizationRegistrationPeriod, PayconiqPayment, Platform, RegistrationPeriod, SetupStepUpdater, StripeAccount, Webshop } from '@stamhoofd/models';
-import { BuckarooSettings, Company, OrganizationMetaData, OrganizationPatch, Organization as OrganizationStruct, PayconiqAccount, PaymentMethod, PaymentMethodHelper, PermissionLevel, PlatformConfig } from '@stamhoofd/structures';
+import { AuditLogType, BuckarooSettings, Company, OrganizationMetaData, OrganizationPatch, Organization as OrganizationStruct, PayconiqAccount, PaymentMethod, PaymentMethodHelper, PermissionLevel, PlatformConfig } from '@stamhoofd/structures';
 import { Formatter } from '@stamhoofd/utility';
 
 import { AuthenticatedStructures } from '../../../../helpers/AuthenticatedStructures';
@@ -10,6 +10,7 @@ import { BuckarooHelper } from '../../../../helpers/BuckarooHelper';
 import { Context } from '../../../../helpers/Context';
 import { TagHelper } from '../../../../helpers/TagHelper';
 import { ViesHelper } from '../../../../helpers/ViesHelper';
+import { AuditLogService } from '../../../../services/AuditLogService';
 
 type Params = Record<string, never>;
 type Query = undefined;
@@ -213,6 +214,7 @@ export class PatchOrganizationEndpoint extends Endpoint<Params, Query, Body, Res
                     await this.validateCompanies(organization, request.body.meta.companies);
                     shouldUpdateSetupSteps = true;
                 }
+                const oldMeta = organization.meta.clone();
 
                 const savedPackages = organization.meta.packages;
                 organization.meta.patchOrPut(request.body.meta);
@@ -281,6 +283,13 @@ export class PatchOrganizationEndpoint extends Endpoint<Params, Query, Body, Res
 
                     updateTags = true;
                 }
+
+                await AuditLogService.log({
+                    type: AuditLogType.OrganizationSettingsChanged,
+                    organization,
+                    oldMeta,
+                    patch: request.body.meta,
+                });
             }
 
             if (request.body.active !== undefined) {

package/src/endpoints/organization/dashboard/registration-periods/PatchOrganizationRegistrationPeriodsEndpoint.ts

@@ -1,11 +1,12 @@
 import { DecodedRequest, Endpoint, Request, Response } from '@simonbackx/simple-endpoints';
-import { GroupPrivateSettings, Group as GroupStruct, GroupType, OrganizationRegistrationPeriod as OrganizationRegistrationPeriodStruct, PermissionLevel, PermissionsResourceType, ResourcePermissions, Version } from '@stamhoofd/structures';
+import { AuditLogType, GroupPrivateSettings, Group as GroupStruct, GroupType, OrganizationRegistrationPeriod as OrganizationRegistrationPeriodStruct, PermissionLevel, PermissionsResourceType, ResourcePermissions, Version } from '@stamhoofd/structures';
 
 import { AutoEncoderPatchType, Decoder, PatchableArrayAutoEncoder, PatchableArrayDecoder, StringDecoder } from '@simonbackx/simple-encoding';
 import { SimpleError } from '@simonbackx/simple-errors';
 import { Group, Member, Organization, OrganizationRegistrationPeriod, Platform, RegistrationPeriod, SetupStepUpdater } from '@stamhoofd/models';
 import { AuthenticatedStructures } from '../../../../helpers/AuthenticatedStructures';
 import { Context } from '../../../../helpers/Context';
+import { AuditLogService } from '../../../../services/AuditLogService';
 
 type Params = Record<string, never>;
 type Query = undefined;
@@ -281,6 +282,11 @@ export class PatchOrganizationRegistrationPeriodsEndpoint extends Endpoint<Param
         model.deletedAt = new Date();
         await model.save();
         Member.updateMembershipsForGroupId(id);
+
+        await AuditLogService.log({
+            type: AuditLogType.GroupDeleted,
+            group: model,
+        });
     }
 
     static async patchGroup(struct: AutoEncoderPatchType<GroupStruct>, period?: RegistrationPeriod | null) {
@@ -289,6 +295,7 @@ export class PatchOrganizationRegistrationPeriodsEndpoint extends Endpoint<Param
         if (!model || !await Context.auth.canAccessGroup(model, PermissionLevel.Full)) {
             throw Context.auth.error('Je hebt geen toegangsrechten om deze groep te wijzigen');
         }
+        const originalStruct = (await AuthenticatedStructures.group(model)).clone(); // Clone is required for deep changes
 
         const previousProperties = {
             deletedAt: model.deletedAt,
@@ -417,6 +424,13 @@ export class PatchOrganizationRegistrationPeriodsEndpoint extends Endpoint<Param
         if (struct.deletedAt !== undefined || struct.defaultAgeGroupId !== undefined) {
             Member.updateMembershipsForGroupId(model.id);
         }
+
+        await AuditLogService.log({
+            type: AuditLogType.GroupEdited,
+            group: model,
+            oldData: originalStruct,
+            patch,
+        });
     }
 
     static async createGroup(struct: GroupStruct, organizationId: string, period: RegistrationPeriod, options?: { allowedIds?: string[] }): Promise<Group> {
@@ -497,6 +511,12 @@ export class PatchOrganizationRegistrationPeriodsEndpoint extends Endpoint<Param
 
         await model.save();
         await model.updateOccupancy({ isNew: true }); // Force update steps
+
+        await AuditLogService.log({
+            type: AuditLogType.GroupAdded,
+            group: model,
+        });
+
         return model;
     }
 }