@stamhoofd/backend 2.42.1 → 2.42.3

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@stamhoofd/backend",
-    "version": "2.42.1",
+    "version": "2.42.3",
     "main": "./dist/index.js",
     "exports": {
         ".": {
@@ -36,14 +36,14 @@
         "@simonbackx/simple-encoding": "2.15.1",
         "@simonbackx/simple-endpoints": "1.14.0",
         "@simonbackx/simple-logging": "^1.0.1",
-        "@stamhoofd/backend-i18n": "2.42.1",
-        "@stamhoofd/backend-middleware": "2.42.1",
-        "@stamhoofd/email": "2.42.1",
-        "@stamhoofd/models": "2.42.1",
-        "@stamhoofd/queues": "2.42.1",
-        "@stamhoofd/sql": "2.42.1",
-        "@stamhoofd/structures": "2.42.1",
-        "@stamhoofd/utility": "2.42.1",
+        "@stamhoofd/backend-i18n": "2.42.3",
+        "@stamhoofd/backend-middleware": "2.42.3",
+        "@stamhoofd/email": "2.42.3",
+        "@stamhoofd/models": "2.42.3",
+        "@stamhoofd/queues": "2.42.3",
+        "@stamhoofd/sql": "2.42.3",
+        "@stamhoofd/structures": "2.42.3",
+        "@stamhoofd/utility": "2.42.3",
         "archiver": "^7.0.1",
         "aws-sdk": "^2.885.0",
         "axios": "1.6.8",
@@ -60,5 +60,5 @@
         "postmark": "^4.0.5",
         "stripe": "^16.6.0"
     },
-    "gitHead": "0ae30257fe64d7fd724536a28db36f6c23711e59"
+    "gitHead": "ee0812960b3c22f3c13c15b0b5a84639aeba5ad8"
 }

package/src/endpoints/global/files/ExportToExcelEndpoint.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-unsafe-argument */
 import { Decoder } from '@simonbackx/simple-encoding';
 import { DecodedRequest, Endpoint, Request, Response } from '@simonbackx/simple-endpoints';
 import { SimpleError } from '@simonbackx/simple-errors';

package/src/excel-loaders/payments.ts

@@ -332,21 +332,6 @@ function getSettlementColumns(): XlsxTransformerColumn<PaymentGeneral>[] {
                 };
             },
         },
-        {
-            id: 'settlement.fee',
-            name: 'Uitbetalingstransactiekosten',
-            width: 25,
-            getValue: (object: PaymentGeneralWithStripeAccount) => {
-                return {
-                    value: object.settlement?.fee !== undefined ? (object.settlement?.fee / 100) : null,
-                    style: {
-                        numberFormat: {
-                            id: XlsxBuiltInNumberFormat.Currency2DecimalWithRed,
-                        },
-                    },
-                };
-            },
-        },
     ];
 }
 

package/src/helpers/AdminPermissionChecker.ts

@@ -482,6 +482,10 @@ export class AdminPermissionChecker {
         }
 
         const { balanceItems } = await Payment.loadBalanceItems(payments);
+
+        if (balanceItems.length === 0) {
+            return false;
+        }
         return await this.canAccessBalanceItems(balanceItems, permissionLevel);
     }
 
@@ -501,7 +505,7 @@ export class AdminPermissionChecker {
         }
 
         if (balanceItems.length === 0) {
-            return false;
+            return true;
         }
 
         const organizationId = balanceItems[0].organizationId;

package/src/helpers/AuthenticatedStructures.ts

@@ -31,8 +31,8 @@ export class AuthenticatedStructures {
             // Note: permission checking is moved here for performacne to avoid loading the data multiple times
             if (!(await Context.auth.canAccessBalanceItems(balanceItems, PermissionLevel.Read, { registrations, orders }))) {
                 throw new SimpleError({
-                    code: 'not_found',
-                    message: 'Payment not found',
+                    code: 'permission_denied',
+                    message: 'Permission denied',
                     human: 'Je hebt geen toegang tot deze betaling',
                 });
             }

package/src/helpers/FileCache.ts

@@ -24,7 +24,7 @@ async function randomBytes(size: number): Promise<Buffer> {
 export class FileCache {
     static async getWriteStream(extension: '.xlsx'): Promise<{
         file: string;
-        stream: WritableStream;
+        stream: Writable;
     }> {
         if (!STAMHOOFD.CACHE_PATH) {
             throw new SimpleError({
@@ -51,7 +51,7 @@ export class FileCache {
 
         return {
             file: path + '/' + fileName,
-            stream: Writable.toWeb(s),
+            stream: s,
         };
     }