@stamhoofd/backend 2.111.0 → 2.112.0

package/src/endpoints/organization/shared/GetUitpasNumberDetailsEndpoint.ts

@@ -0,0 +1,72 @@
+import { DecodedRequest, Endpoint, Request, Response } from '@simonbackx/simple-endpoints';
+import { UitpasNumberDetails, UitpasNumbersGetDetailsRequest } from '@stamhoofd/structures';
+
+import { Decoder } from '@simonbackx/simple-encoding';
+import { isSimpleError, isSimpleErrors, SimpleError, SimpleErrors } from '@simonbackx/simple-errors';
+import { uitpasApiResponseToSocialTariff } from '../../../helpers/updateMemberDetailsUitpasNumber.js';
+import { UitpasService } from '../../../services/uitpas/UitpasService.js';
+
+type Params = Record<string, never>;
+type Query = UitpasNumbersGetDetailsRequest;
+type Body = undefined;
+type ResponseBody = UitpasNumberDetails[];
+
+/**
+ * Get the details such as the social tariff for a list of uitpas numbers.
+ */
+export class GetUitpasNumberDetailsEndpoint extends Endpoint<Params, Query, Body, ResponseBody> {
+    queryDecoder = UitpasNumbersGetDetailsRequest as Decoder<UitpasNumbersGetDetailsRequest>;
+
+    protected doesMatch(request: Request): [true, Params] | [false] {
+        if (request.method !== 'GET') {
+            return [false];
+        }
+
+        const params = Endpoint.parseParameters(request.url, '/uitpas/details', {});
+
+        if (params) {
+            return [true, params as Params];
+        }
+        return [false];
+    }
+
+    async handle(request: DecodedRequest<Params, Query, Body>) {
+        const uitpasNumbers: string[] = request.query.uitpasNumbers;
+        if (uitpasNumbers.length > 5) {
+            throw new SimpleError({
+                code: 'maximum_limit',
+                message: 'Please only request up to 5 numbers at the same time',
+            });
+        }
+
+        const results: UitpasNumberDetails[] = [];
+        const simpleErrors = new SimpleErrors();
+
+        for (let i = 0; i < uitpasNumbers.length; i++) {
+            const uitpasNumber = uitpasNumbers[i];
+
+            try {
+                const result = await UitpasService.getPassByUitpasNumber(uitpasNumber);
+                const socialTariff = uitpasApiResponseToSocialTariff(result);
+                results.push(UitpasNumberDetails.create({
+                    uitpasNumber,
+                    socialTariff,
+                }));
+            }
+            catch (error) {
+                if (isSimpleError(error) || isSimpleErrors(error)) {
+                    error.addNamespace(i.toString());
+                    error.addNamespace('uitpasNumbers');
+                    simpleErrors.addError(error);
+                }
+                else {
+                    throw error;
+                }
+            }
+        }
+
+        simpleErrors.throwIfNotEmpty();
+
+        return new Response(results);
+    }
+}

package/src/endpoints/organization/webshops/RetrieveUitpasSocialTariffPriceEndpoint.ts

@@ -3,8 +3,9 @@ import { SimpleError } from '@simonbackx/simple-errors';
 import { UitpasPriceCheckRequest, UitpasPriceCheckResponse } from '@stamhoofd/structures';
 
 import { Decoder } from '@simonbackx/simple-encoding';
-import { UitpasService } from '../../../services/uitpas/UitpasService';
-import { Context } from '../../../helpers/Context';
+import { Context } from '../../../helpers/Context.js';
+import { UitpasService } from '../../../services/uitpas/UitpasService.js';
+
 type Params = Record<string, never>;
 type Query = undefined;
 type Body = UitpasPriceCheckRequest;

package/src/excel-loaders/members.ts

@@ -122,7 +122,7 @@ export const baseMemberColumns: XlsxTransformerColumn<PlatformMember>[] = [
         name: $t(`87c1a48c-fef5-44c3-ae56-c83463fcfb84`),
         width: 20,
         getValue: ({ patchedMember: object }: PlatformMember) => ({
-            value: object.details.uitpasNumber,
+            value: object.details.uitpasNumberDetails?.uitpasNumber ?? null,
         }),
     },
     {
@@ -160,6 +160,32 @@ export const baseMemberColumns: XlsxTransformerColumn<PlatformMember>[] = [
             };
         },
     },
+    {
+        id: 'organization',
+        name: $t(`afd7843d-f355-445b-a158-ddacf469a5b1`),
+        width: 40,
+        getValue: (member: PlatformMember) => {
+            const organizations = member.filterOrganizations({ currentPeriod: true, types: [GroupType.Membership] });
+            const str = Formatter.joinLast(organizations.map(o => o.name).sort(), ', ', ' ' + $t(`c1843768-2bf4-42f2-baa4-42f49028463d`) + ' ') || Context.i18n.$t('1a16a32a-7ee4-455d-af3d-6073821efa8f');
+
+            return {
+                value: str,
+            };
+        },
+    },
+    {
+        id: 'uri',
+        name: $t(`27cfaf26-6b88-4ebc-a50a-627a9f0f9e64`),
+        width: 30,
+        getValue: (member: PlatformMember) => {
+            const organizations = member.filterOrganizations({ currentPeriod: true, types: [GroupType.Membership] });
+            const str = Formatter.joinLast(organizations.map(o => o.uri).sort(), ', ', ' ' + $t(`c1843768-2bf4-42f2-baa4-42f49028463d`) + ' ') || Context.i18n.$t('1a16a32a-7ee4-455d-af3d-6073821efa8f');
+
+            return {
+                value: str,
+            };
+        },
+    },
 
     ...XlsxTransformerColumnHelper.creatColumnsForParents(),
 
@@ -216,32 +242,6 @@ const sheet: XlsxTransformerSheet<PlatformMember, PlatformMember> = {
     name: $t(`fb35c140-e936-4e91-aa92-ef4dfc59fb51`),
     columns: [
         ...baseMemberColumns,
-        {
-            id: 'organization',
-            name: $t(`afd7843d-f355-445b-a158-ddacf469a5b1`),
-            width: 40,
-            getValue: (member: PlatformMember) => {
-                const organizations = member.filterOrganizations({ currentPeriod: true, types: [GroupType.Membership] });
-                const str = Formatter.joinLast(organizations.map(o => o.name).sort(), ', ', ' ' + $t(`c1843768-2bf4-42f2-baa4-42f49028463d`) + ' ') || Context.i18n.$t('1a16a32a-7ee4-455d-af3d-6073821efa8f');
-
-                return {
-                    value: str,
-                };
-            },
-        },
-        {
-            id: 'uri',
-            name: $t(`27cfaf26-6b88-4ebc-a50a-627a9f0f9e64`),
-            width: 30,
-            getValue: (member: PlatformMember) => {
-                const organizations = member.filterOrganizations({ currentPeriod: true, types: [GroupType.Membership] });
-                const str = Formatter.joinLast(organizations.map(o => o.uri).sort(), ', ', ' ' + $t(`c1843768-2bf4-42f2-baa4-42f49028463d`) + ' ') || Context.i18n.$t('1a16a32a-7ee4-455d-af3d-6073821efa8f');
-
-                return {
-                    value: str,
-                };
-            },
-        },
         {
             id: 'group',
             name: $t(`0c230001-c3be-4a8e-8eab-23dc3fd96e52`),

package/src/helpers/AdminPermissionChecker.ts

@@ -1,10 +1,10 @@
 import { AutoEncoderPatchType, PatchMap } from '@simonbackx/simple-encoding';
 import { isSimpleError, isSimpleErrors, SimpleError } from '@simonbackx/simple-errors';
 import { BalanceItem, CachedBalance, Document, Email, EmailTemplate, Event, EventNotification, Group, Member, MemberPlatformMembership, MemberWithRegistrations, Order, Organization, OrganizationRegistrationPeriod, Payment, Registration, User, Webshop } from '@stamhoofd/models';
-import { AccessRight, EmailTemplate as EmailTemplateStruct, EventPermissionChecker, FinancialSupportSettings, GroupCategory, GroupStatus, GroupType, MemberWithRegistrationsBlob, PermissionLevel, PermissionsResourceType, Platform as PlatformStruct, ReceivableBalanceType, RecordSettings, ResourcePermissions } from '@stamhoofd/structures';
+import { AccessRight, EmailTemplate as EmailTemplateStruct, EventPermissionChecker, FinancialSupportSettings, GroupCategory, GroupStatus, GroupType, MemberWithRegistrationsBlob, PermissionLevel, PermissionsResourceType, Platform as PlatformStruct, ReceivableBalanceType, RecordSettings, ResourcePermissions, UitpasNumberDetails, UitpasSocialTariff, UitpasSocialTariffStatus } from '@stamhoofd/structures';
 import { Formatter } from '@stamhoofd/utility';
-import { MemberRecordStore } from '../services/MemberRecordStore';
-import { addTemporaryMemberAccess, hasTemporaryMemberAccess } from './TemporaryMemberAccess';
+import { MemberRecordStore } from '../services/MemberRecordStore.js';
+import { addTemporaryMemberAccess, hasTemporaryMemberAccess } from './TemporaryMemberAccess.js';
 
 /**
  * One class with all the responsabilities of checking permissions to each resource in the system by a given user, possibly in an organization context.
@@ -1478,7 +1478,7 @@ export class AdminPermissionChecker {
         // Has financial read access?
         if (!options?.forAdminCartCalculation && !await this.hasFinancialMemberAccess(member, PermissionLevel.Read)) {
             cloned.details.requiresFinancialSupport = null;
-            cloned.details.uitpasNumber = null;
+            cloned.details.uitpasNumberDetails = null;
             cloned.outstandingBalance = 0;
 
             for (const registration of cloned.registrations) {
@@ -1507,7 +1507,7 @@ export class AdminPermissionChecker {
     /**
      * Only for creating new members
      */
-    filterMemberPut(member: MemberWithRegistrations, data: MemberWithRegistrationsBlob, options: {asUserManager: boolean}) {
+    filterMemberPut(member: MemberWithRegistrations, data: MemberWithRegistrationsBlob, options: { asUserManager: boolean }) {
         if (options.asUserManager || STAMHOOFD.userMode === 'platform') {
             // A user manager cannot choose the member number + in platform mode, nobody can choose the member number
             data.details.memberNumber = null;
@@ -1515,7 +1515,12 @@ export class AdminPermissionChecker {
 
         // Do not allow setting the security code
         data.details.securityCode = null;
-     }
+        if (data.details.uitpasNumberDetails) {
+            data.details.uitpasNumberDetails.socialTariff = UitpasSocialTariff.create({
+                status: UitpasSocialTariffStatus.Unknown,
+            });
+        }
+    }
 
     async filterMemberPatch(member: MemberWithRegistrations, data: AutoEncoderPatchType<MemberWithRegistrationsBlob>): Promise<AutoEncoderPatchType<MemberWithRegistrationsBlob>> {
         if (!data.details) {
@@ -1537,10 +1542,9 @@ export class AdminPermissionChecker {
             });
         }
 
-
         const hasRecordAnswers = !!data.details.recordAnswers;
         const hasNotes = data.details.notes !== undefined;
-        const isSetFinancialSupportTrue = data.details.shouldApplyReducedPrice;
+        const isSetFinancialSupportTrue = data.details.didSetManualFinancialSupport;
 
         if (data.details.securityCode !== undefined || data.details.trackingYear !== undefined) {
             const hasFullAccess = await this.canAccessMember(member, PermissionLevel.Full);
@@ -1561,6 +1565,22 @@ export class AdminPermissionChecker {
             }
         }
 
+        if (data.details.uitpasNumberDetails && data.details.uitpasNumberDetails.socialTariff !== undefined) {
+            if (data.details.uitpasNumberDetails.uitpasNumber === undefined) {
+                data.details.uitpasNumberDetails = undefined;
+            }
+            else if (data.details.uitpasNumberDetails.uitpasNumber !== member.details.uitpasNumberDetails?.uitpasNumber) {
+                // if uitpas number did change -> status should be reset
+                data.details.uitpasNumberDetails = UitpasNumberDetails.create({
+                    uitpasNumber: data.details.uitpasNumberDetails.uitpasNumber,
+                });
+            }
+            else {
+                // if uitpas number did not change
+                data.details.uitpasNumberDetails.socialTariff = member.details.uitpasNumberDetails?.socialTariff;
+            }
+        }
+
         if (hasRecordAnswers) {
             if (!(data.details.recordAnswers instanceof PatchMap)) {
                 throw new SimpleError({
@@ -1594,7 +1614,7 @@ export class AdminPermissionChecker {
             // A user manager cannot choose the member number + in platform mode, nobody can choose the member number
             delete data.details.memberNumber;
         }
-        
+
         if (hasNotes && isUserManager && !(await this.canAccessMember(member, PermissionLevel.Full))) {
             throw new SimpleError({
                 code: 'permission_denied',
@@ -1633,7 +1653,7 @@ export class AdminPermissionChecker {
             }
 
             if (!isUserManager) {
-                if (data.details.uitpasNumber) {
+                if (data.details.uitpasNumberDetails) {
                     throw new SimpleError({
                         code: 'permission_denied',
                         message: 'Je hebt geen toegangsrechten om het UiTPAS-nummer van dit lid aan te passen',

package/src/helpers/AuthenticatedStructures.ts

@@ -1,12 +1,12 @@
 import { SimpleError } from '@simonbackx/simple-errors';
-import { AuditLog, BalanceItem, CachedBalance, Document, Event, EventNotification, Group, Member, MemberPlatformMembership, MemberResponsibilityRecord, MemberWithRegistrations, Order, Organization, OrganizationRegistrationPeriod, Payment, Registration, RegistrationPeriod, Ticket, User, Webshop } from '@stamhoofd/models';
-import { AuditLogReplacement, AuditLogReplacementType, AuditLog as AuditLogStruct, DetailedReceivableBalance, Document as DocumentStruct, EventNotification as EventNotificationStruct, Event as EventStruct, GenericBalance, Group as GroupStruct, GroupType, MemberPlatformMembership as MemberPlatformMembershipStruct, MembersBlob, MemberWithRegistrationsBlob, NamedObject, OrganizationRegistrationPeriod as OrganizationRegistrationPeriodStruct, Organization as OrganizationStruct, PaymentGeneral, PermissionLevel, Platform, PrivateOrder, PrivateWebshop, ReceivableBalanceObject, ReceivableBalanceObjectContact, ReceivableBalance as ReceivableBalanceStruct, ReceivableBalanceType, RegistrationsBlob, RegistrationWithMemberBlob, TicketPrivate, UserWithMembers, WebshopPreview, Webshop as WebshopStruct } from '@stamhoofd/structures';
+import { AuditLog, BalanceItem, CachedBalance, Document, Event, EventNotification, Group, Invoice, Member, MemberPlatformMembership, MemberResponsibilityRecord, MemberWithRegistrations, Order, Organization, OrganizationRegistrationPeriod, Payment, Registration, RegistrationPeriod, Ticket, User, Webshop } from '@stamhoofd/models';
+import { AuditLogReplacement, AuditLogReplacementType, AuditLog as AuditLogStruct, DetailedReceivableBalance, Document as DocumentStruct, EventNotification as EventNotificationStruct, Event as EventStruct, GenericBalance, Group as GroupStruct, GroupType, InvoicedBalanceItem, InvoiceStruct, MemberPlatformMembership as MemberPlatformMembershipStruct, MembersBlob, MemberWithRegistrationsBlob, NamedObject, OrganizationRegistrationPeriod as OrganizationRegistrationPeriodStruct, Organization as OrganizationStruct, PaymentGeneral, PermissionLevel, Platform, PrivateOrder, PrivateWebshop, ReceivableBalanceObject, ReceivableBalanceObjectContact, ReceivableBalance as ReceivableBalanceStruct, ReceivableBalanceType, RegistrationsBlob, RegistrationWithMemberBlob, TicketPrivate, UserWithMembers, WebshopPreview, Webshop as WebshopStruct } from '@stamhoofd/structures';
 import { Sorter } from '@stamhoofd/utility';
 
 import { SQL } from '@stamhoofd/sql';
 import { Formatter } from '@stamhoofd/utility';
-import { BalanceItemService } from '../services/BalanceItemService';
-import { Context } from './Context';
+import { BalanceItemService } from '../services/BalanceItemService.js';
+import { Context } from './Context.js';
 
 /**
  * Builds authenticated structures for the current user
@@ -28,9 +28,10 @@ export class AuthenticatedStructures {
         }
 
         const { balanceItemPayments, balanceItems } = await Payment.loadBalanceItems(payments);
-        const { registrations, orders } = await Payment.loadBalanceItemRelations(balanceItems);
 
         if (checkPermissions) {
+            const { registrations, orders } = await Payment.loadBalanceItemRelations(balanceItems);
+
             // Note: permission checking is moved here for performacne to avoid loading the data multiple times
             if (!(await Context.auth.canAccessBalanceItems(balanceItems, PermissionLevel.Read, { registrations, orders }))) {
                 throw new SimpleError({
@@ -53,6 +54,24 @@ export class AuthenticatedStructures {
         }, includeSettlements);
     }
 
+    static async invoices(invoices: Invoice[]): Promise<InvoiceStruct[]> {
+        if (invoices.length === 0) {
+            return [];
+        }
+
+        const { invoicedBalanceItems } = await Invoice.loadBalanceItems(invoices);
+
+        return invoices.map((invoice) => {
+            const items = invoicedBalanceItems.filter(i => i.invoiceId === invoice.id);
+            return InvoiceStruct.create({
+                ...invoice,
+                items: items.map((item) => {
+                    return InvoicedBalanceItem.create(item);
+                }),
+            });
+        });
+    }
+
     static async group(group: Group) {
         return (await this.groups([group]))[0];
     }

package/src/helpers/StripeHelper.ts

@@ -4,6 +4,7 @@ import { BalanceItem, BalanceItemPayment, Organization, Payment, StripeAccount,
 import { calculateVATPercentage, PaymentMethod, PaymentMethodHelper, PaymentStatus } from '@stamhoofd/structures';
 import { Formatter } from '@stamhoofd/utility';
 import Stripe from 'stripe';
+import { passthroughFetch } from './passthroughFetch.js';
 
 export class StripeHelper {
     static get notConfiguredError() {
@@ -18,7 +19,16 @@ export class StripeHelper {
         if (!STAMHOOFD.STRIPE_SECRET_KEY) {
             throw this.notConfiguredError;
         }
-        return new Stripe(STAMHOOFD.STRIPE_SECRET_KEY, { apiVersion: '2024-06-20', typescript: true, maxNetworkRetries: 0, timeout: 10000, stripeAccount: accountId ?? undefined });
+        return new Stripe(STAMHOOFD.STRIPE_SECRET_KEY, {
+            apiVersion: '2024-06-20',
+            typescript: true,
+            maxNetworkRetries: 0,
+            timeout: 10000,
+            stripeAccount: accountId ?? undefined,
+            httpClient: STAMHOOFD.environment === 'test'
+                ? Stripe.createFetchHttpClient(passthroughFetch)
+                : undefined,
+        });
     }
 
     static async saveChargeInfo(model: StripePaymentIntent | StripeCheckoutSession, charge: Stripe.Charge, payment: Payment) {

package/src/helpers/StripePayoutChecker.ts

@@ -1,6 +1,7 @@
 import { Order, Payment, StripeCheckoutSession, StripePaymentIntent } from '@stamhoofd/models';
 import { Settlement } from '@stamhoofd/structures';
 import Stripe from 'stripe';
+import { passthroughFetch } from './passthroughFetch.js';
 
 export class StripePayoutChecker {
     private stripe: Stripe;
@@ -14,6 +15,9 @@ export class StripePayoutChecker {
                 maxNetworkRetries: 1,
                 timeout: 10000,
                 stripeAccount,
+                httpClient: STAMHOOFD.environment === 'test'
+                    ? Stripe.createFetchHttpClient(passthroughFetch)
+                    : undefined,
             });
 
         this.stripePlatform = new Stripe(
@@ -22,6 +26,9 @@ export class StripePayoutChecker {
                 typescript: true,
                 maxNetworkRetries: 1,
                 timeout: 10000,
+                httpClient: STAMHOOFD.environment === 'test'
+                    ? Stripe.createFetchHttpClient(passthroughFetch)
+                    : undefined,
             });
     }
 

package/src/helpers/UitpasTokenRepository.ts

@@ -73,10 +73,6 @@ export class UitpasTokenRepository {
     }
 
     private static async getModelFromDb(organizationId: string | null) {
-        let model = await UitpasClientCredential.select().where('organizationId', organizationId).first(false);
-        if (model) {
-            return model; // found in database
-        }
         if (organizationId === null) {
             // platform client id and secret are not yet in the database, but should be configured in the environment variables
             if (!STAMHOOFD.UITPAS_API_CLIENT_ID || !STAMHOOFD.UITPAS_API_CLIENT_SECRET) {
@@ -86,12 +82,18 @@ export class UitpasTokenRepository {
                     human: $t('71a8218b-c58e-4e95-9626-551b80eb8367'),
                 });
             }
-            model = new UitpasClientCredential();
+            const model = new UitpasClientCredential();
             model.clientId = STAMHOOFD.UITPAS_API_CLIENT_ID;
             model.clientSecret = STAMHOOFD.UITPAS_API_CLIENT_SECRET;
             model.organizationId = null; // null means platform
             return model;
         }
+
+        const model = await UitpasClientCredential.select().where('organizationId', organizationId).first(false);
+        if (model) {
+            return model; // found in database
+        }
+
         return null; // not found in database
     }
 

package/src/helpers/passthroughFetch.ts

@@ -0,0 +1,24 @@
+/**
+ * A passthrough wrapper around the global `fetch` function.
+ *
+ * This is necessary because passing `fetch` directly to
+ * `Stripe.createFetchHttpClient` does not guarantee correct `this` binding
+ * in all environments (such as Node.js or test runners).
+ *
+ * In particular, in certain test environments (e.g., using MSW, Nock, or when
+ * mocks are applied), passing `fetch` point-free (i.e., just `fetch`) may
+ * result in `this` being undefined, leading to unexpected errors like
+ * `TypeError: Illegal invocation`.
+ *
+ * Wrapping `fetch` inside a new function (`passthroughFetch`) ensures:
+ * - Correct argument forwarding
+ * - Proper binding of `this` context (implicitly bound to `globalThis`)
+ * - More predictable async behavior across environments
+ *
+ * See also: https://github.com/nock/nock/issues/2785#issuecomment-2427076034
+ *
+ * @param args - The arguments to pass to `fetch`, matching
+ * `Parameters<typeof fetch>`.
+ * @returns A `Promise<Response>` from calling the global `fetch`.
+ */
+export const passthroughFetch = (...args: Parameters<typeof fetch>) => fetch(...args);

package/src/helpers/updateMemberDetailsUitpasNumber.ts

@@ -0,0 +1,149 @@
+import { AutoEncoderPatchType } from '@simonbackx/simple-encoding';
+import { isSimpleError, SimpleError } from '@simonbackx/simple-errors';
+import { Member } from '@stamhoofd/models';
+import { MemberDetails, ReviewTimes, UitpasSocialTariff, UitpasSocialTariffStatus } from '@stamhoofd/structures';
+import { GetPassResponse } from '../services/uitpas/PassholderEndpoints.js';
+import { UitpasService } from '../services/uitpas/UitpasService.js';
+import { throwIfInvalidUitpasNumber } from '../services/uitpas/checkUitpasNumbers.js';
+
+/**
+ * Updates the social tariff if an uitpas number is set.
+ * @param details
+ * @returns whether the social tariff was updated
+ */
+export async function updateMemberDetailsUitpasNumber(details: MemberDetails): Promise<boolean> {
+    if (!details.uitpasNumberDetails) {
+        return false;
+    }
+
+    const uitpasNumber = details.uitpasNumberDetails.uitpasNumber;
+    throwIfInvalidUitpasNumber(uitpasNumber);
+    const result = await UitpasService.getPassByUitpasNumber(uitpasNumber);
+    const socialTariff = uitpasApiResponseToSocialTariff(result);
+    details.uitpasNumberDetails.socialTariff = socialTariff;
+    return true;
+}
+
+/**
+ * Updates the social tariff if an uitpas number is set.
+ * Removes uitpas number reviewed on error.
+ * @param details
+ * @returns whether the social tariff was updated
+ */
+export async function updateMemberDetailsUitpasNumberForPatch(memberId: string, details: MemberDetails, previousUitpasNumber: string | null): Promise<boolean> {
+    if (!details.uitpasNumberDetails) {
+        return false;
+    }
+
+    const wasActive = details.uitpasNumberDetails.isActive;
+
+    let isUpdated = false;
+
+    try {
+        isUpdated = await updateMemberDetailsUitpasNumber(details);
+    }
+    catch (error: any) {
+        const isUitpasEqual = previousUitpasNumber !== null && previousUitpasNumber === details.uitpasNumberDetails.uitpasNumber;
+
+        if (isSimpleError(error)) {
+            if (error.hasCode('https://api.publiq.be/probs/uitpas/pass-not-found') || error.hasCode('https://api.publiq.be/probs/uitpas/invalid-uitpas-number')) {
+                if (isUitpasEqual) {
+                    // set the status of the social tariff to unknown if the uitpas number did not change and the number is unknown
+                    const member = await Member.getByID(memberId);
+                    if (member && member.details.uitpasNumberDetails) {
+                        member.details.uitpasNumberDetails.socialTariff = UitpasSocialTariff.create({
+                            status: UitpasSocialTariffStatus.Unknown,
+                        });
+                        member.details.reviewTimes.removeReview('uitpasNumber');
+
+                        await member.save();
+                    }
+                }
+
+                // always throw an error if the number is unknown by the uitpas api
+                throw error;
+            }
+        }
+
+        // do not throw if the number did not change
+        if (isUitpasEqual) {
+            console.error(`Catched error while updating social tariff for member (uitpas number did not change) ${memberId}:`, error.message);
+            return false;
+        }
+
+        throw error;
+    }
+
+    // force a review if the social tariff changed from active to not active (and the number did not change)
+    if (isUpdated
+        // is uitpas equal
+        && previousUitpasNumber !== null && previousUitpasNumber === details.uitpasNumberDetails.uitpasNumber
+        // did change from active to not active
+        && wasActive && !details.uitpasNumberDetails.isActive) {
+        // force a review
+        details.reviewTimes.removeReview('uitpasNumber');
+    }
+
+    return isUpdated;
+}
+
+export function uitpasApiResponseToSocialTariff(response: GetPassResponse): UitpasSocialTariff {
+    let endDate: Date | null = null;
+
+    if (response.socialTariff.endDate) {
+        try {
+            endDate = new Date(response.socialTariff.endDate);
+        }
+        catch (e) {
+            console.error(e);
+            console.error('endDate: ', response.socialTariff.endDate);
+
+            // prevent unreadable error message if invalid end date
+            throw new SimpleError({
+                code: 'invalid_data',
+                message: 'Invalid social tariff end date',
+                human: $t('abc1a491-8038-4435-9007-c77cc00c0886'),
+            });
+        }
+    }
+
+    const status = uitpasSocialTariffStatusToEnum(response.socialTariff.status);
+
+    return UitpasSocialTariff.create({
+        status,
+        endDate,
+        updatedAt: new Date(),
+    });
+}
+
+export function didUitpasReviewChange(reviewTimesPatch: ReviewTimes | AutoEncoderPatchType<ReviewTimes> | undefined, originalReviewTimes: ReviewTimes): boolean {
+    const newReview = reviewTimesPatch?.times.find(t => t.name === 'uitpasNumber');
+    if (!newReview) {
+        return false;
+    }
+
+    const lastReviewTime = originalReviewTimes.getLastReview('uitpasNumber');
+    if (!lastReviewTime) {
+        return true;
+    }
+
+    return newReview.reviewedAt.getTime() !== lastReviewTime.getTime();
+}
+
+/**
+ * Prevent bad input from uitpas api
+ * @param status
+ * @returns
+ */
+function uitpasSocialTariffStatusToEnum(status: 'ACTIVE' | 'EXPIRED' | 'NONE' | 'UNKNOWN'): UitpasSocialTariffStatus {
+    switch (status) {
+        case 'ACTIVE':
+            return UitpasSocialTariffStatus.Active;
+        case 'EXPIRED':
+            return UitpasSocialTariffStatus.Expired;
+        case 'NONE':
+            return UitpasSocialTariffStatus.None;
+        default:
+            return UitpasSocialTariffStatus.Unknown;
+    }
+}