@staix/agent-hub 0.20.0 → 0.21.0

package/src/hub/recovery-policy.ts

@@ -0,0 +1,220 @@
+/** Fresh, read-only privacy and policy proof for a host-sealed conductor recovery.
+ * This does not reconstruct the daemon's memory-only private-turn flag: the live
+ * admission path must also refuse contextPii before minting a recovery authority.
+ */
+import { Database } from "bun:sqlite";
+import { createHash } from "node:crypto";
+import { closeSync, constants, fstatSync, lstatSync, openSync, readSync } from "node:fs";
+import { isAbsolute, join, resolve } from "node:path";
+import { types } from "node:util";
+import { definitionOf } from "../adapters/registry.ts";
+import type { HubConfig } from "./daemon.ts";
+import type { ConfigSourceTexts } from "./config-reload.ts";
+import { conductorPeer } from "./conductor.ts";
+import { DEFAULT_ROLES } from "./hub-tools.ts";
+import { HUB_DB_BUSY_TIMEOUT_MS } from "./db-timeout.ts";
+import { readInstanceConfig, type InstanceConfigLayer } from "./instance-config.ts";
+import { effectiveInstanceRoles } from "./instances.ts";
+import { realPath } from "./project.ts";
+import { RecoveryAuthorityError } from "./recovery-authority.ts";
+import { peerRosterConfig, rosterAllows } from "./roster.ts";
+import { parseOverlay, parseRouting, type Routing } from "./routing.ts";
+
+export interface RecoveryPolicyProject { root: string; id: string; stateDir: string }
+export interface RecoveryPolicyCapture { policyDigest: string; boardDigest: string }
+/** Host-captured inputs, shared with loadConfig before any module evaluation. */
+export interface RecoveryPolicyInputs { layers: InstanceConfigLayer[]; routing: Routing; texts?: ConfigSourceTexts; routingFallback?: string }
+const MAX_POLICY_BYTES = 1024 * 1024;
+const MAX_ACTOR_TASKS = 4096;
+const MAX_SIGNALS_BYTES = 65536;
+function refuse(): never { throw new RecoveryAuthorityError(); }
+const hash = (text: string): string => createHash("sha256").update(text).digest("hex");
+const stamp = (s: NonNullable<ReturnType<typeof lstatSync>>): string => JSON.stringify([s.dev, s.ino, s.size, s.mode, s.nlink, s.mtimeMs, s.ctimeMs]);
+
+/** Only bounded, regular, stable files; an absent optional policy is different from an unreadable one. */
+function boundedText(file: string, optional = false): string | undefined {
+  let fd: number;
+  try { fd = openSync(file, constants.O_RDONLY | constants.O_NOFOLLOW | constants.O_NONBLOCK); }
+  catch (error) { if (optional && (error as NodeJS.ErrnoException).code === "ENOENT") return undefined; throw error; }
+  try {
+    const before = fstatSync(fd);
+    if (!before.isFile() || before.nlink !== 1 || before.size > MAX_POLICY_BYTES || realPath(file) !== file) refuse();
+    const bytes = Buffer.alloc(before.size + 1);
+    let length = 0;
+    while (length < bytes.length) { const n = readSync(fd, bytes, length, bytes.length - length, null); if (!n) break; length += n; }
+    if (length !== before.size || stamp(before) !== stamp(fstatSync(fd)) || stamp(before) !== stamp(lstatSync(file))) refuse();
+    return new TextDecoder("utf-8", { fatal: true }).decode(bytes.subarray(0, length));
+  } finally { closeSync(fd); }
+}
+
+/** Derive compatibility from the verified target bytes, never the caller's mutable feature claim. */
+export function readRecoveryTargetFeatures(targetRoot: string): readonly string[] {
+  try {
+    const source = boundedText(join(targetRoot, "src/hub/control-client.ts"))!;
+    // ponytail: one literal array, at most 128 fixed labels. A computed export needs a versioned target manifest.
+    const declarations = [...source.matchAll(/export const DAEMON_FEATURES\s*=\s*(\[[^\]]*\])(?:\s+as const)?\s*;/g)];
+    if (declarations.length !== 1) refuse();
+    const values: unknown = JSON.parse(declarations[0]![1]!);
+    if (!Array.isArray(values) || !values.length || values.length > 128 || values.some(value => typeof value !== "string" || !/^[a-z][a-z0-9_]{0,63}$/.test(value))
+      || new Set(values).size !== values.length || !values.includes("conductor_recovery")) refuse();
+    return Object.freeze([...values]);
+  } catch { return refuse(); }
+}
+
+/** Stable semantic encoding; never evaluate config accessors or serialize runtime objects. */
+function canonical(value: unknown, depth = 0): string {
+  if (depth > 32) refuse();
+  if (value === null || typeof value === "boolean" || typeof value === "string") return JSON.stringify(value);
+  if (typeof value === "number" && Number.isFinite(value)) return JSON.stringify(value);
+  if (types.isProxy(value)) refuse();
+  if (Array.isArray(value)) {
+    if (Object.getPrototypeOf(value) !== Array.prototype || value.length > MAX_POLICY_BYTES) refuse();
+    const fields = Object.getOwnPropertyDescriptors(value);
+    if (Reflect.ownKeys(value).length !== value.length + 1 || Object.values(fields).some(field => !Object.hasOwn(field, "value"))) refuse();
+    const parts: string[] = [];
+    for (let index = 0; index < value.length; index++) {
+      const field = fields[String(index)]; if (!field) refuse();
+      parts.push(canonical(field.value, depth + 1));
+    }
+    return `[${parts.join(",")}]`;
+  }
+  if (!value || typeof value !== "object" || ![Object.prototype, null].includes(Object.getPrototypeOf(value))) refuse();
+  const fields = Object.getOwnPropertyDescriptors(value);
+  if (Reflect.ownKeys(value).some(key => typeof key !== "string") || Object.values(fields).some(field => !Object.hasOwn(field, "value"))) refuse();
+  return `{${Object.keys(fields).sort().filter(key => fields[key]!.value !== undefined).map(key => `${JSON.stringify(key)}:${canonical(fields[key]!.value, depth + 1)}`).join(",")}}`;
+}
+
+function freshRoles(layers: readonly InstanceConfigLayer[], scope: ReturnType<typeof readInstanceConfig>): Record<string, string[]> {
+  const roles = structuredClone(DEFAULT_ROLES);
+  for (const { raw } of layers) if (raw.roles !== undefined) {
+    conductorPeer(raw.roles);
+    for (const [id, list] of Object.entries(raw.roles as Record<string, string[]>)) {
+      const definition = definitionOf(id), ceiling = definition?.routing?.allowedRoles;
+      roles[id] = (ceiling ? list.filter(role => ceiling.includes(role)) : list).filter(role => role !== "planner" || !definition || definition.projection?.plannerEligible === true);
+    }
+  }
+  const configured = Object.fromEntries(scope.catalog.definitions.filter(d => !definitionOf(d.kind)).map(d => [d.kind, [...d.roles]]));
+  const extras = Object.fromEntries(Object.keys(scope.instances ?? {}).map(id => [id, effectiveInstanceRoles(id, scope.instances, roles, scope.catalog)]));
+  return { ...configured, ...roles, ...extras };
+}
+
+function publicActorBoard(stateDir: string, peer: string, routing: Routing): string {
+  const file = join(stateDir, "hub.db"), before = lstatSync(file);
+  if (!before.isFile() || before.isSymbolicLink() || before.nlink !== 1 || realPath(file) !== file) refuse();
+  const db = new Database(file, { readonly: true });
+  db.run(`PRAGMA busy_timeout = ${HUB_DB_BUSY_TIMEOUT_MS}`);
+  try {
+    db.run("BEGIN");
+    // Metadata only. In particular no unrelated task titles, bodies, history or refs are read.
+    const rows = db.query(`SELECT id, state, owner, reviewer,
+      CASE WHEN typeof(signals) = 'text' AND length(CAST(signals AS BLOB)) <= ${MAX_SIGNALS_BYTES} THEN signals ELSE NULL END AS signals
+      FROM tasks WHERE (owner = ? OR reviewer = ?) AND (state NOT IN ('approved', 'cancelled') OR state IS NULL)
+      ORDER BY id LIMIT ${MAX_ACTOR_TASKS + 1}`).all(peer, peer) as { id: number; state: string; owner: string | null; reviewer: string | null; signals: string | null }[];
+    if (rows.length > MAX_ACTOR_TASKS) refuse();
+    let total = 0;
+    for (const row of rows) {
+      if (!Number.isSafeInteger(row.id) || row.id <= 0 || !["proposed", "in_progress", "in_review", "changes_requested"].includes(row.state)
+        || row.signals === null || (total += Buffer.byteLength(row.signals)) > MAX_POLICY_BYTES) refuse();
+      const signals: unknown = JSON.parse(row.signals);
+      if (!Array.isArray(signals) || signals.length > 1024 || signals.some(signal => typeof signal !== "string" || signal.length > 1024)) refuse();
+      if (signals.includes("pii_path") || signals.includes("pii") && routing.constraints.pii === "local_only") refuse();
+    }
+    db.run("COMMIT");
+    const after = lstatSync(file);
+    if (after.dev !== before.dev || after.ino !== before.ino || realPath(file) !== file) refuse();
+    // Unrelated public board activity must not revoke a public conductor's offline continuity.
+    return hash(canonical({ schema: 1, peer, private: false }));
+  } finally { db.close(); }
+}
+
+/** A protected pending edit is not authorization to apply it through a restart. */
+export function assertRecoveryConfiguration(accepted: HubConfig, candidate: HubConfig): void {
+  try {
+    const previous = canonical(accepted), next = canonical(candidate);
+    if (Buffer.byteLength(previous) > 8 * MAX_POLICY_BYTES || Buffer.byteLength(next) > 8 * MAX_POLICY_BYTES || previous !== next) refuse();
+  } catch { return refuse(); }
+}
+
+export function assertRecoveryRouting(accepted: Routing, candidate: Routing): void {
+  try { if (canonical(accepted) !== canonical(candidate)) refuse(); }
+  catch { refuse(); }
+}
+
+/** Unknown future keys are still protected inputs; an older source may not silently authorize a pending edit. */
+export function assertRecoverySourceInputs(accepted: readonly { name: string; raw: Record<string, unknown> }[], candidate: RecoveryPolicyInputs): void {
+  try {
+    const actual: { name: string; raw: Record<string, unknown> }[] = [...candidate.layers];
+    for (const name of ["routing.toml", "routing.local.toml"] as const) {
+      const text = candidate.texts?.[name];
+      if (text != null) {
+        const raw = Bun.TOML.parse(text);
+        if (!raw || typeof raw !== "object" || Array.isArray(raw)) refuse();
+        actual.push({ name, raw: raw as Record<string, unknown> });
+      }
+    }
+    const projection = (rows: readonly { name: string; raw: Record<string, unknown> }[]) => Object.fromEntries(rows.filter(row => Object.keys(row.raw).length > 0).map(row => [row.name, row.raw]));
+    if (canonical(projection(accepted)) !== canonical(projection(actual))) refuse();
+  } catch { refuse(); }
+}
+
+/** One bounded source capture feeds both loadConfig and the recovery proof. No module is evaluated. */
+export function recoveryRoutingFallback(): string {
+  try { return boundedText(resolve(import.meta.dir, "..", "..", "templates", "routing.toml"))!; } catch { return refuse(); }
+}
+
+export function readRecoveryPolicyInputs(root: string, fallback?: string): RecoveryPolicyInputs {
+  try {
+    if (!isAbsolute(root) || realPath(root) !== root) refuse();
+    const layers: InstanceConfigLayer[] = [];
+    const texts: ConfigSourceTexts = { "config.json": null, "config.local.json": null, "routing.toml": null, "routing.local.toml": null };
+    for (const name of ["config.json", "config.local.json"] as const) {
+      const text = boundedText(join(root, ".agenthub", name), true);
+      texts[name] = text ?? null;
+      if (text === undefined) continue;
+      const raw: unknown = JSON.parse(text);
+      if (!raw || typeof raw !== "object" || Array.isArray(raw)) refuse();
+      layers.push({ name, raw: raw as Record<string, unknown> });
+    }
+    const ownMain = boundedText(join(root, ".agenthub", "routing.toml"), true);
+    const main = ownMain ?? fallback ?? recoveryRoutingFallback();
+    if (Buffer.byteLength(main) > MAX_POLICY_BYTES) refuse();
+    const overlay = boundedText(join(root, ".agenthub", "routing.local.toml"), true);
+    texts["routing.toml"] = ownMain ?? null; texts["routing.local.toml"] = overlay ?? null;
+    return { layers, routing: parseRouting(main, overlay === undefined ? undefined : parseOverlay(overlay)), texts, ...(ownMain === undefined ? { routingFallback: main } : {}) };
+  } catch { return refuse(); }
+}
+
+/** currentConfig must be host-loaded from these exact inputs and compared with the running accepted config.
+ * Supplied inputs are never reread from raw config/routing files. Board privacy is always fresh.
+ */
+export function captureRecoveryPolicy(project: RecoveryPolicyProject, peer: string, currentConfig: HubConfig, inputs?: RecoveryPolicyInputs): RecoveryPolicyCapture {
+  try {
+    if (!project.id || !isAbsolute(project.root) || !isAbsolute(project.stateDir) || realPath(project.root) !== project.root || realPath(project.stateDir) !== project.stateDir) refuse();
+    const snapshot = canonical(inputs ?? readRecoveryPolicyInputs(project.root));
+    if (Buffer.byteLength(snapshot) > 8 * MAX_POLICY_BYTES) refuse();
+    // Copy host own-data fields once, so proof evaluation cannot run callbacks or observe mutation mid-capture.
+    const captured = JSON.parse(snapshot) as RecoveryPolicyInputs;
+    const { layers, routing } = captured;
+    if (!Array.isArray(layers) || layers.length > 2 || new Set(layers.map(layer => layer.name)).size !== layers.length
+      || layers.some(layer => !["config.json", "config.local.json"].includes(layer.name) || !layer.raw || typeof layer.raw !== "object" || Array.isArray(layer.raw))) refuse();
+    // Explicit empty runtime definitions: never import a module or trust a retained display catalog.
+    const scope = readInstanceConfig(project.root, layers, []);
+    if (scope.adapter_modules?.length || scope.declaredExternalInstances?.length || currentConfig.adapter_modules?.length) refuse();
+    const roles = freshRoles(layers, scope);
+    if (conductorPeer(roles) !== peer || conductorPeer(currentConfig.roles) !== peer || canonical(roles) !== canonical(currentConfig.roles)
+      || canonical(scope.instances ?? {}) !== canonical(currentConfig.instances ?? {}) || scope.instances?.[peer]?.readOnly === true
+      || !scope.catalog.definitionOf(peer, scope.instances)) refuse();
+    // roster is merged key by key by loadConfig; independently refresh the exact fields that admit the actor.
+    const rawRoster = Object.assign({}, ...layers.map(layer => layer.raw.roster ?? {}));
+    const roster = peerRosterConfig(rawRoster, scope.instances, scope.catalog);
+    if (canonical(roster) !== canonical(currentConfig.roster) || !rosterAllows(roster, peer, currentConfig.pi.enabled, scope.instances, scope.catalog)) refuse();
+    // ponytail: at most 2 MiB config, 2 MiB routing and 4096 actor-bound open rows (1 MiB signals).
+    // A larger board fails closed; the upgrade path is an indexed durable per-actor privacy generation.
+    // Seal version-neutral inputs and the fresh actor decision. Defaults and registry projections may evolve in the verified target.
+    const policy = canonical({ schema: 1, project: { root: project.root, id: project.id, stateDir: project.stateDir }, peer,
+      actor: { conductor: true, rostered: true, writable: true }, sources: layers, texts: captured.texts ?? null,
+      routingFallback: captured.routingFallback ?? null });
+    if (Buffer.byteLength(policy) > 8 * MAX_POLICY_BYTES) refuse();
+    return { policyDigest: hash(policy), boardDigest: publicActorBoard(project.stateDir, peer, routing) };
+  } catch { return refuse(); }
+}

package/src/hub/research.ts

@@ -58,8 +58,8 @@ export interface TaskRecord {
   /** #258 AC11: task briefs handed over for it, and how many of them carried a hub-memory fail note; absent without briefs. */
   briefs?: { delivered: number; withFail: number };
 }
-/** A person's later verdict on one task record: `createdAt` binds it to that task, not a later one with the same id. */
-export interface LabelRecord { schema: typeof RESEARCH_SCHEMA; kind: "label"; project: string; task: number; createdAt: string; label: Label; at: string }
+/** A person's later verdict on one task record: `createdAt` binds it to that task, not a later one with the same id. `by`: the agent that labelled its own task (#933); absent for the person. */
+export interface LabelRecord { schema: typeof RESEARCH_SCHEMA; kind: "label"; project: string; task: number; createdAt: string; label: Label; at: string; by?: string }
 export type ResearchRecord = TaskRecord | LabelRecord;
 
 /** The store name for a project: a hash of its id, never its path. */
@@ -293,15 +293,26 @@ export function formatResearch(r: ResearchReport): string[] {
   return [head, row("all approved tasks", r.overall), ...section("by class", r.byClass), ...section("by owner", r.byOwner), ...section("by model", r.byModel), ...section("by project", r.byProject), ...(Object.keys(r.byMemoryBrief).some((k) => k !== "no brief recorded") ? section("by memory brief", r.byMemoryBrief) : [])];
 }
 
-/** Each approved task once, its last record, and every task's latest label: what both reports count. */
-function latestRecords(records: ResearchRecord[], since: number): { all: TaskRecord[]; labels: Map<string, Label> } {
-  const latest = new Map<string, TaskRecord>(), labels = new Map<string, Label>();
+/**
+ * The label each record counts with: the person's latest label, whatever came after it; an agent's (#933, `by` set) only when the person
+ * never labelled that record, the latest of them then. An agent's verdict on its own task never replaces the person's.
+ */
+function effectiveLabels(records: readonly ResearchRecord[]): Map<string, LabelRecord> {
+  const labels = new Map<string, LabelRecord>();
   for (const r of records) {
-    const key = recordKey(r);
-    if (r.kind === "label") { labels.set(key, r.label); continue; }
-    if (Date.parse(r.approvedAt) >= since) latest.set(key, r);
+    if (r.kind !== "label") continue;
+    const key = recordKey(r), held = labels.get(key);
+    if (r.by === undefined || held === undefined || held.by !== undefined) labels.set(key, r);
   }
-  return { all: [...latest.values()], labels };
+  return labels;
+}
+const labelValues = (labels: Map<string, LabelRecord>): Map<string, Label> => new Map([...labels].map(([key, r]) => [key, r.label]));
+
+/** Each approved task once, its last record, and every task's effective label: what both reports count. */
+function latestRecords(records: ResearchRecord[], since: number): { all: TaskRecord[]; labels: Map<string, Label> } {
+  const latest = new Map<string, TaskRecord>();
+  for (const r of records) if (r.kind === "task" && Date.parse(r.approvedAt) >= since) latest.set(recordKey(r), r);
+  return { all: [...latest.values()], labels: labelValues(effectiveLabels(records)) };
 }
 
 /** The peers that worked on a task: every peer with an attributed event, else (older records) owners, reviewer and token peers. */
@@ -364,15 +375,14 @@ export function formatAddons(rows: AddonComparison[]): string[] {
 
 export const CSV_COLUMNS = ["project", "task", "class", "pii", "outcome", "createdAt", "startedAt", "approvedAt", "wallMs", "activeMs", "owners",
   "reviewer", "reviewRounds", "changesRequested", "checkPassed", "checkFailed", "dones", "reassignments", "firstPass", "stuck", "overlaps", "conflicts",
-  "testsPass", "testsFail", "tokens", "turns", "filesChanged", "models", "label", "writerVersion", "writerSource"] as const;
-/** Task records as CSV with a header row, one row per record, each with the task's latest label; JSONL has every field. */
+  "testsPass", "testsFail", "tokens", "turns", "filesChanged", "models", "label", "labelBy", "writerVersion", "writerSource"] as const;
+/** Task records as CSV with a header row, one row per record, each with its effective label and who gave it (empty: the person); JSONL has every field. */
 export function toCsv(records: ResearchRecord[]): string {
-  const labels = new Map<string, Label>();
-  for (const r of records) if (r.kind === "label") labels.set(recordKey(r), r.label);
+  const labels = effectiveLabels(records);
   const cell = (v: unknown) => { const s = v === null || v === undefined ? "" : String(v); return /[",\n]/.test(s) ? `"${s.replace(/"/g, '""')}"` : s; };
   const rows = records.filter((r): r is TaskRecord => r.kind === "task").map((r) => [r.project, r.task, r.class, r.pii, r.outcome, r.createdAt, r.startedAt,
     r.approvedAt, r.wallMs, r.activeMs, r.owners.join(" "), r.reviewer, r.reviewRounds, r.changesRequested, r.checkPassed, r.checkFailed, r.dones,
     r.reassignments, r.firstPass, r.stuck, r.overlaps, r.conflicts, r.tests.pass, r.tests.fail, r.tokens.total, r.turns, r.filesChanged, r.models.join(" "),
-    labels.get(recordKey(r)) ?? "", r.writer.version, r.writer.source].map(cell).join(","));
+    labels.get(recordKey(r))?.label ?? "", labels.get(recordKey(r))?.by ?? "", r.writer.version, r.writer.source].map(cell).join(","));
   return [CSV_COLUMNS.join(","), ...rows].join("\n") + "\n";
 }

package/src/hub/restart.ts

@@ -7,6 +7,7 @@ import { MAX_HOP } from "./envelope.ts";
 import { validateJournalSnapshot } from "./delivery-journal.ts";
 import { atomicPrivateJSON } from "./recovery-store.ts";
 import { RecoveryDeferredHubError, validateDeferredHub } from "./deferred-hub.ts";
+import { validExternalInstanceBinding, type ExternalInstanceBinding } from "./external-instance.ts";
 
 export const RESTART_SCHEMA_VERSION = 1;
 
@@ -24,6 +25,8 @@ export interface RestartPeerSnapshot {
    * cannot be resumed and a fresh session is accepted instead. Absent in snapshots written
    * before this flag; those are re-derived from disk (#64). */
   sessionPersisted?: boolean;
+  /** Retained stable identity for an explicitly stopped module instance; never authorizes automatic resume. */
+  externalInstance?: ExternalInstanceBinding;
 }
 
 export interface RestartSnapshot {
@@ -41,6 +44,8 @@ export interface RestartSnapshot {
     manualPaused: PeerId[];
     boardDigest: string;
     budgetDigest: string;
+    /** Whole captured binding set; portable identities are covered alongside queue/board integrity. */
+    externalBindingsDigest?: string;
   };
 }
 
@@ -87,7 +92,9 @@ export function readRestartSnapshot(stateDir: string, expected: RestartReadExpec
     }, occupied);
   } catch (error) { if (error instanceof RecoveryDeferredHubError) throw error; return undefined; }
   if (!Array.isArray(s.manualPaused) || !s.manualPaused.every((id) => typeof id === "string") || !Array.isArray(s.peers) || !s.peers.every((peer) => peer && typeof peer === "object" && typeof peer.id === "string" && ["idle", "busy", "paused", "offline"].includes(peer.state as string) && Array.isArray(peer.queueIds) && peer.queueIds.every((id) => typeof id === "string"))) return undefined;
+  if (s.peers.some(peer => Object.hasOwn(peer, "externalInstance") && (peer.state !== "offline" || !validExternalInstanceBinding(peer.externalInstance, expected.projectRoot, peer.id)))) return undefined;
   if (s.integrity !== undefined && (!s.integrity || typeof s.integrity !== "object" || typeof s.integrity.boardDigest !== "string" || typeof s.integrity.budgetDigest !== "string" || !Array.isArray(s.integrity.manualPaused) || !s.integrity.manualPaused.every((id) => typeof id === "string") || !s.integrity.queues || typeof s.integrity.queues !== "object" || !Object.values(s.integrity.queues).every((ids) => Array.isArray(ids) && ids.every((id) => typeof id === "string")))) return undefined;
+  if (s.integrity && Object.hasOwn(s.integrity, "externalBindingsDigest") && (typeof s.integrity.externalBindingsDigest !== "string" || !/^[a-f0-9]{64}$/.test(s.integrity.externalBindingsDigest))) return undefined;
   if (bus.journal !== undefined) { try { validateJournalSnapshot(bus.journal); } catch { return undefined; } }
   return s as RestartSnapshot;
 }

package/src/hub/routing.ts

@@ -1,3 +1,5 @@
+import { contextHeadroom, type ContextAdmission } from "./context-window.ts";
+import { queueBackpressure, type QueueBackpressureCode, type QueueBackpressurePolicy, type QueuePressure } from "./queue-backpressure.ts";
 import { selectReviewerPool, type ReviewerPoolSelection } from "./reviewer-pool.ts";
 import { ADAPTERS, definitionOf, kindOf, familyOf, type ProjectAdapterCatalog } from "../adapters/registry.ts";
 import { readFileSync, statSync } from "node:fs";
@@ -119,6 +121,17 @@ export interface InstanceRoutingOptions {
   instances?: Readonly<Record<string, { kind: string }>>;
   wip?: Record<string, number>;
   load?: Record<string, number>;
+  /** Separate from WIP and sibling load: bounded pending delivery metadata for new automatic offers. */
+  queues?: Readonly<Record<string, QueuePressure>>;
+  queueBackpressure?: QueueBackpressurePolicy;
+  /** Host-only explicit person/conductor nomination; a name or reservation alone grants no bypass. */
+  queueOverride?: "owner" | "reviewer" | "both";
+  /** Fresh native session evidence supplied by the host; never read telemetry inside assign(). */
+  contextAdmission?: ContextAdmission;
+  /** Host-authorized explicit nomination or self-claim, never inferred from namedOwner or a reservation. */
+  contextOverride?: boolean;
+  /** Host-proven person reservation: queue pressure holds this exact target instead of rerouting it. No bypass is granted. */
+  queueReservedHold?: PeerId;
   /** Positive host verification of the live extra runtime's noncanonical execution root. */
   ownerIsolation?: Readonly<Record<string, boolean>>;
 }
@@ -297,7 +310,7 @@ export function detectSignals(task: Pick<Task, "title" | "detail" | "refs">, rou
 /** A peer's entry in a peer-indexed map: own keys only, so a peer named `constructor` is never an inherited Object member. */
 export const peerEntry = <T>(map: Readonly<Record<string, T>> | undefined, peer: string): T | undefined => (map && Object.hasOwn(map, peer) ? map[peer] : undefined);
 
-export type RoutingRefusalCode = "instance" | "family" | "tests" | "spec" | "roster" | "pull-only" | "not-attached" | "excluded" | "owner-admission" | "offline" | "paused" | "failing" | "pii" | "policy";
+export type RoutingRefusalCode = QueueBackpressureCode | "context-headroom" | "instance" | "family" | "tests" | "spec" | "roster" | "pull-only" | "not-attached" | "excluded" | "owner-admission" | "offline" | "paused" | "failing" | "pii" | "policy";
 export interface RoutingRefusal { peer: PeerId; role: "owner" | "reviewer"; code: RoutingRefusalCode; reason: string }
 export interface Assignment {
   reviewSelection?: ReviewerPoolSelection;
@@ -333,6 +346,9 @@ export function ownerRoleOfClass(cls: TaskClass): "planner" | "implementer" | "r
 /** Why a planner was chosen: the person named it, rotation reached it, the task's recorded planner is kept, or there is none (PII, no holder). */
 export type PlannerReason = "rotation" | "named" | "kept" | "none";
 
+/** The remote namespace has no local task, reviewer or planner authority, even for malformed remote ids. */
+export function isRemotePeerId(peer: unknown): boolean { return typeof peer === "string" && peer.includes("@"); }
+
 /**
  * I-2 (#525-3): the peers that implemented a task, read from its own history: any peer with an `accepted` or `done` entry. A reviewer is
  * never one of them, so a multi-role holder (implementer and reviewer) never reviews a change it made, even after the task changed hands.
@@ -367,10 +383,11 @@ export interface PlannerWalk { planner?: PeerId; reason: PlannerReason; walk: {
  *   holder, availability never renumbers it (the #519 seed rule). When all are skipped, the seed holder is taken, "rotation (none available)".
  */
 export function plannerWalk(input: PlannerWalkInput): PlannerWalk {
-  const holders = [...new Set(input.planners)].sort((a, b) => (a < b ? -1 : a > b ? 1 : 0));
+  const holders = [...new Set(input.planners)].filter(peer => !isRemotePeerId(peer)).sort((a, b) => (a < b ? -1 : a > b ? 1 : 0));
   const walk: { peer: PeerId; note: string }[] = [];
   const finish = (reason: PlannerReason, planner: PeerId | undefined, detail: string): PlannerWalk => ({ ...(planner ? { planner } : {}), reason, walk, line: planner ? `planner: ${planner} (${detail})` : `planner: none (${detail})` });
   if (input.pii) return finish("none", undefined, "pii: planning stays with the person");
+  if (isRemotePeerId(input.named)) return finish("none", undefined, "remote peers cannot hold local roles");
   if (!holders.length) return finish("none", undefined, "no planner holder");
   if (input.named !== undefined) {
     if (!holders.includes(input.named)) { walk.push({ peer: input.named, note: "skipped, not a planner holder" }); return finish("none", undefined, `named ${input.named} is not a planner holder`); }
@@ -463,6 +480,7 @@ export function assign(
   const former = implementers(task.history);
   const blocked = (peer: PeerId, role: "owner" | "reviewer"): string | undefined => {
     const deny = (code: RoutingRefusalCode, reason: string): string => { refusals.set(`${role}:${peer}`, { peer, role, code, reason }); return reason; };
+    if (isRemotePeerId(peer)) return deny("policy", "remote peers cannot hold local roles");
     const ceiling = (opts.adapterCatalog?.definitionOf ?? definitionOf)(peer, opts.instances)?.routing?.allowedRoles;
     const requiredRole = role === "reviewer" ? "reviewer" : ownerRoleOfClass(task.class);
     if (ceiling && !ceiling.includes(requiredRole)) return deny("policy", "adapter role ceiling excludes this assignment");
@@ -498,10 +516,20 @@ export function assign(
       if (routing.signals.long_context_tokens > limit) return deny("policy", `${nativeRouting.backendLabel} ${backend} capability limit ${limit} tokens`);
     }
     if (nativeRouting?.longContext === "skip-owner" && role === "owner" && task.signals.includes("long_context") && routing.constraints.long_context === "skip_local") return deny("policy", "long_context: skip local");
-    // I-2 (#525-3): a peer that implemented this task never reviews it, whoever holds it now, a named reviewer included. It is the LAST check,
-    // so it only ever removes a candidate that was otherwise eligible: a former implementer that is offline, paused, failing or off roster is
-    // refused for that real reason and leaves the outcome exactly as it was before I-2 (a task with no other reviewer still approves directly).
+    // I-2 (#525-3) is the last capability/independence gate, before queue-capacity admission. A former implementer never reviews its task,
+    // including a named reviewer. Earlier offline, paused, failing and roster refusals retain their existing reason and outcome.
     if (role === "reviewer" && former.has(peer)) return deny("policy", "implemented this task");
+    if (role === "owner" && requiredRole !== "reviewer" && opts.contextAdmission) {
+      const decision = contextHeadroom(opts.contextAdmission.policy, adapter?.budget?.context ? peerEntry(opts.contextAdmission.peers, peer) : undefined, opts.now ?? NaN);
+      if (decision) {
+        trace.push(`  owner context ${peer}: ${decision.note}${opts.contextOverride ? "; explicit override" : ""}`);
+        if (decision.blocked && !opts.contextOverride) return deny("context-headroom", decision.note);
+      }
+    }
+    if (opts.queueOverride !== role && opts.queueOverride !== "both") {
+      const pressure = queueBackpressure(peer, opts.queueBackpressure, peerEntry(opts.queues, peer), opts.now ?? NaN);
+      if (pressure) return deny(pressure.code, pressure.reason);
+    }
     return undefined;
   };
   /** Quota that resets soonest gets used first: headroom per hour left in the window, at least 15 min (a task assigned that close to a reset mostly runs after it). */
@@ -556,12 +584,15 @@ export function assign(
     return ranked.find((p) => states[p] === "idle") ?? ranked[0];
   };
 
-  // The PII constraint, capability limits, exclusions and peer states still apply: when they pass it over, routing proceeds.
+  // Safety/state refusals still permit the existing reservation fallback. Queue pressure holds a host-proven person reservation instead.
   const unreserved = reserved ? blocked(reserved, "owner") : undefined;
-  if (reserved) trace.push(`reserved owner ${reserved}: ${unreserved ? `not honored, ${unreserved}; routing proceeds` : "honored"}`);
+  const reservedRefusal = reserved ? refusals.get(`owner:${reserved}`) : undefined;
+  const queueReservedHeld = reserved === opts.queueReservedHold && reservedRefusal !== undefined
+    && ["queue-count", "queue-age", "queue-age-unknown"].includes(reservedRefusal.code);
+  if (reserved) trace.push(`reserved owner ${reserved}: ${queueReservedHeld ? `held, ${unreserved}; reservation retained` : unreserved ? `not honored, ${unreserved}; routing proceeds` : "honored"}`);
   // Never the task's current owner by default: a decline or an escalation has to reach the next peer in the list.
   const automaticOwner = !(reserved && !unreserved) && opts.candidates === undefined && !(instanceMode && opts.namedOwner !== undefined);
-  const wanted = reserved && !unreserved ? [reserved] : opts.candidates ?? (instanceMode && opts.namedOwner !== undefined ? [opts.namedOwner] : expandClassPeers(policy?.peers ?? [], states, opts));
+  const wanted = queueReservedHeld ? [] : reserved && !unreserved ? [reserved] : opts.candidates ?? (instanceMode && opts.namedOwner !== undefined ? [opts.namedOwner] : expandClassPeers(policy?.peers ?? [], states, opts));
   const owner = pick(wanted, "owner", undefined, automaticOwner);
   trace.push(owner ? `owner: ${owner}` : "owner: none available, task stays proposed (ahub task assign <id> <peer>)");
   const ownerHold = owner ? peerEntry(opts.held, owner) : undefined;
@@ -680,6 +711,12 @@ export function assign(
         reviewBlocked = true;
         trace.push("  every eligible reviewer implemented this task: the person reviews");
       }
+      // Queue pressure holds a new review offer; it must never turn review exhaustion into direct approval.
+      if (!reviewer && [...refusals.values()].some(row => row.role === "reviewer" && (row.code === "queue-count" || row.code === "queue-age" || row.code === "queue-age-unknown"))) {
+        reviewer = "user";
+        reviewBlocked = true;
+        trace.push("  reviewer queue backpressure: automatic review held; the person may override");
+      }
       trace.push(reviewer ? `reviewer: ${reviewer}` : "reviewer: none, done will approve directly");
       const reviewerHold = reviewer ? peerEntry(opts.held, reviewer) : undefined;
       if (reviewerHold) trace.push(`  hold: ${reviewer}'s queue is held: ${reviewerHold} (it receives the review once the hold is resolved)`);
@@ -719,6 +756,10 @@ export interface SplitInput {
   /** Other open work each peer has: a busy owner does not start from orientation plus two whole units. */
   backlog: Record<PeerId, number>;
   available: Record<PeerId, boolean>;
+  /** #489 H2: `tasks.split_min_observations`; absent is `SPLIT_MIN`. */
+  minObservations?: number;
+  /** #489 H2: `tasks.split_max_failure_share`; absent is `SPLIT_FAILURE_SHARE`. */
+  maxFailureShare?: number;
 }
 
 export interface SplitPrediction {
@@ -733,7 +774,7 @@ export interface SplitPrediction {
 
 /** Observations a peer needs, and the share of failures a history may hold, before a prediction is made. */
 export const SPLIT_MIN = 5;
-const SPLIT_FAILURE_SHARE = 0.3;
+export const SPLIT_FAILURE_SHARE = 0.3;
 
 /**
  * Shadow split prediction (issue #109): never changes assignment. For two similar units of overlapping work, a split
@@ -744,6 +785,8 @@ const SPLIT_FAILURE_SHARE = 0.3;
  * comparable. A difference under a tenth of the single time is inconclusive.
  */
 export function predictSplit(input: SplitInput): SplitPrediction {
+  // #489 H2: `tasks.split_min_observations` and `tasks.split_max_failure_share`; absent, the constants above.
+  const minObservations = input.minObservations ?? SPLIT_MIN, maxFailureShare = input.maxFailureShare ?? SPLIT_FAILURE_SHARE;
   const trace: string[] = ["shadow split prediction (it never changes assignment):"];
   const unknown = (why: string): SplitPrediction => ({ verdict: "unknown", trace: [...trace, `  unknown: ${why}`] });
   const [a, b] = input.peers;
@@ -767,8 +810,8 @@ export function predictSplit(input: SplitInput): SplitPrediction {
     const all = input.observations[p] ?? [];
     const failed = all.filter((o) => o.outcome !== "approved").length;
     const ok = all.filter((o): o is Required<SplitObservation> => o.outcome === "approved" && o.orient !== undefined && o.work !== undefined);
-    if (ok.length < SPLIT_MIN) return unknown(`${p} has ${ok.length} measured task(s) with this profile; ${SPLIT_MIN} are needed`);
-    if (failed / all.length > SPLIT_FAILURE_SHARE) return unknown(`${failed} of ${all.length} of ${p}'s recorded tasks failed: its successes alone would understate its time`);
+    if (ok.length < minObservations) return unknown(`${p} has ${ok.length} measured task(s) with this profile; ${minObservations} are needed`);
+    if (failed / all.length > maxFailureShare) return unknown(`${failed} of ${all.length} of ${p}'s recorded tasks failed: its successes alone would understate its time`);
     const works = ok.map((o) => o.work).sort((x, y) => x - y);
     const u = median(works);
     const iqr = works[Math.floor((works.length * 3) / 4)]! - works[Math.floor(works.length / 4)]!;