@staix/agent-hub 0.12.19 → 0.12.21

package/src/cli/launch.ts

@@ -1,6 +1,9 @@
 // Launchers inject only the flags the hub owns and refuse user-supplied duplicates.
-import { readFileSync } from "node:fs";
-import { resolve } from "node:path";
+import { mkdirSync, writeFileSync, renameSync, unlinkSync, lstatSync, readFileSync } from "node:fs";
+import { randomUUID } from "node:crypto";
+import { resolve, join, basename, dirname, isAbsolute } from "node:path";
+import { processLiveness, processSignature } from "../pi/process-signature.ts";
+import { realPath } from "../hub/project.ts";
 import { peerChildEnv } from "../hub/child-process.ts";
 export const CLAUDE_CHANNEL = "plugin:agent-hub@agent-hub";
 
@@ -8,6 +11,8 @@ export const CLAUDE_CHANNEL = "plugin:agent-hub@agent-hub";
 export function nativeLaunchEnv(tool: "claude" | "codex" | "pi", source: NodeJS.ProcessEnv): NodeJS.ProcessEnv {
   const env = peerChildEnv(tool, source);
   delete env.AGENTHUB_UNATTENDED;
+  // Channel evidence for the plugin (issue #205): set beside the development-channel flag `buildLaunch` always passes.
+  if (tool === "claude") env.AGENTHUB_CHANNEL = "1";
   return env;
 }
 
@@ -38,6 +43,36 @@ export interface Launch {
   cmd: string;
   args: string[];
   warning?: string;
+  permissionHook?: boolean;
+  hookPurpose?: FactsHook["purpose"];
+  settingsFile?: string;
+  unattended?: boolean;
+}
+
+/** Retire only our prior private Claude settings file, after the replacement launch record is committed. */
+export function cleanupClaudeSettings(stateDir: string, previous: unknown): void {
+  if (typeof previous !== "string" || !isAbsolute(previous) || !/^claude-settings-[0-9a-f]{8}-[0-9a-f]{4}-4[0-9a-f]{3}-[89ab][0-9a-f]{3}-[0-9a-f]{12}\.json$/.test(basename(previous))) return;
+  try {
+    const root = realPath(stateDir);
+    if (realPath(dirname(previous)) !== root) return;
+    const stat = lstatSync(previous);
+    if (!stat.isFile() || stat.isSymbolicLink() || stat.nlink !== 1 || (stat.mode & 0o777) !== 0o600 || !process.getuid || stat.uid !== process.getuid()) return;
+    if (realPath(previous) !== join(root, basename(previous))) return;
+    unlinkSync(previous);
+  } catch { /* Missing or unverifiable files remain untouched. */ }
+}
+
+/** Crash fallback only: an absent/unreadable owner identity never certifies that its native launch ended. */
+export function cleanupStaleClaudeSettings(stateDir: string, previous: unknown, identity = processSignature): void {
+  if (!previous || typeof previous !== "object" || Array.isArray(previous)) return;
+  const record = previous as Record<string, unknown>;
+  if (typeof record.launcherSignature !== "string" || !record.launcherSignature) return;
+  if (processLiveness(record.launcherPid, record.launcherSignature, identity) !== "gone") return;
+  // ponytail: spawnSync launch records have no independent native identity, so crash-left settings are retained.
+  // Upgrade path: record the native child's PID and processSignature before admitting crash fallback cleanup.
+  if (typeof record.nativePid !== "number" || !Number.isSafeInteger(record.nativePid) || record.nativePid <= 0 || record.nativePid === record.launcherPid || typeof record.nativeSignature !== "string" || !record.nativeSignature) return;
+  if (processLiveness(record.nativePid, record.nativeSignature, identity) !== "gone") return;
+  cleanupClaudeSettings(stateDir, record.settingsFile);
 }
 
 export interface StatusLineTee {
@@ -59,22 +94,22 @@ export function statusLineSettings(tee: StatusLineTee): string {
   return JSON.stringify({ statusLine: { type: "command", command, refreshInterval: tee.original?.refreshInterval ?? 10, ...(tee.original?.padding !== undefined ? { padding: tee.original.padding } : {}) } });
 }
 
-/** The turn-free facts hook (issue #108): absolute path of src/cli/facts-hook.ts and the hub's state dir. */
+/** Shared facts, native observation and permission hook transport. */
 export interface FactsHook {
   script: string;
   stateDir: string;
   /** The same hook transport can observe native turns without injecting facts. */
-  purpose?: "facts" | "idle" | "facts-and-idle";
+  purpose?: "facts" | "idle" | "facts-and-idle" | "permission";
   /** Observe native sessions/turns for every enabled facts, idle or conductor hook configuration. */
   observeNative?: boolean;
 }
 
-/** Shared by actual launch and read-only preview; advisory facts remain disabled. */
-export function claudeObservationHooks(config: { coordination?: string; task_sweep?: { enabled: boolean }; roles?: Record<string, string[]> }, paths: Pick<FactsHook, "script" | "stateDir">): FactsHook | undefined {
+/** Shared by actual launch and preview; permissions are always enabled, advisory facts remain disabled. */
+export function claudeObservationHooks(config: { coordination?: string; task_sweep?: { enabled: boolean }; roles?: Record<string, string[]> }, paths: Pick<FactsHook, "script" | "stateDir">): FactsHook {
   const facts = config.coordination === "turn-free";
   const idle = config.task_sweep?.enabled === true;
   const observeNative = facts || idle || config.roles?.claude?.includes("conductor") === true;
-  return facts || idle || observeNative ? { ...paths, purpose: facts ? (idle ? "facts-and-idle" : "facts") : "idle", ...(observeNative ? { observeNative: true } : {}) } : undefined;
+  return { ...paths, purpose: facts ? (idle ? "facts-and-idle" : "facts") : idle || observeNative ? "idle" : "permission", ...(observeNative ? { observeNative: true } : {}) };
 }
 
 /**
@@ -82,11 +117,11 @@ export function claudeObservationHooks(config: { coordination?: string; task_swe
  * facts hook before and after every tool call and at the end of each turn (issue #108; the turn end is the quiescence
  * evidence of issue #107).
  */
-export function sessionSettings(tee: StatusLineTee, facts?: FactsHook): string {
-  const settings = JSON.parse(statusLineSettings(tee)) as Record<string, unknown>;
+export function sessionSettings(tee?: StatusLineTee, facts?: FactsHook): string {
+  const settings = (tee ? JSON.parse(statusLineSettings(tee)) : {}) as Record<string, unknown>;
   if (facts) {
-    const hooks = [{ type: "command", command: `AGENTHUB_STATE_DIR=${sh(facts.stateDir)} bun ${sh(facts.script)}`, timeout: 5 }];
-    settings.hooks = { PreToolUse: [{ matcher: "*", hooks }], PostToolUse: [{ matcher: "*", hooks }], Stop: [{ hooks }] };
+    const hooks = [{ type: "command", command: `AGENTHUB_STATE_DIR=${sh(facts.stateDir)} AGENTHUB_HOOK_PURPOSE=${sh(facts.purpose ?? "facts")} bun ${sh(facts.script)}`, timeout: 5 }];
+    settings.hooks = { PreToolUse: [{ matcher: "*", hooks }], ...(facts.purpose !== "permission" ? { PostToolUse: [{ matcher: "*", hooks }], Stop: [{ hooks }] } : {}) };
     if (facts.observeNative) Object.assign(settings.hooks as object, { SessionStart: [{ matcher: "*", hooks }], UserPromptSubmit: [{ hooks }] });
   }
   return JSON.stringify(settings);
@@ -95,7 +130,7 @@ export function sessionSettings(tee: StatusLineTee, facts?: FactsHook): string {
 export function buildLaunch(
   tool: "claude" | "codex",
   userArgs: string[],
-  ctx: { unattended: boolean; proxyUrl?: string; codexBin?: string; statusLine?: StatusLineTee; facts?: FactsHook },
+  ctx: { unattended: boolean; proxyUrl?: string; codexBin?: string; statusLine?: StatusLineTee; facts?: FactsHook; preview?: boolean },
 ): Launch {
   // Hub-level switches are consumed here; everything else passes through to the tool.
   const passthrough = userArgs.filter((a) => !["--unattended", "--safe", "--new"].includes(a));
@@ -107,17 +142,62 @@ export function buildLaunch(
   if (tool === "claude") {
     // `--settings` takes one value, so a user-supplied one wins and Claude has no quota source for that session.
     const own = passthrough.some((a) => a === "--settings" || a.startsWith("--settings="));
-    const tee = ctx.statusLine && !own ? ["--settings", sessionSettings(ctx.statusLine, ctx.facts)] : [];
+    let settingsArgs = ctx.statusLine && !own ? ["--settings", sessionSettings(ctx.statusLine, ctx.facts)] : [];
+    let nativeArgs = passthrough;
+    let settingsFile: string | undefined;
+    if (own) {
+      if (passthrough.filter(a => a === "--settings" || a.startsWith("--settings=")).length > 1) throw new Error("pass --settings only once so the hub permission hook stays installed");
+      const index = passthrough.findIndex(a => a === "--settings" || a.startsWith("--settings="));
+      const arg = passthrough[index]!;
+      const value = arg === "--settings" ? passthrough[index + 1] : arg.slice("--settings=".length);
+      if (!value) throw new Error("--settings requires a JSON object or readable file so the hub permission hook can be installed");
+      let caller: Record<string, unknown>;
+      try {
+        caller = JSON.parse(value.trim().startsWith("{") ? value : readFileSync(resolve(value), "utf8"));
+        if (!caller || typeof caller !== "object" || Array.isArray(caller)) throw new Error("not an object");
+      } catch { throw new Error("cannot read --settings as a JSON object; the hub permission hook must be installed"); }
+      if (ctx.facts && caller.disableAllHooks === true) throw new Error("--settings disableAllHooks prevents the required hub permission hook; enable hooks to launch");
+      const injected = JSON.parse(sessionSettings(undefined, ctx.facts));
+      const callerHooks = caller.hooks;
+      if (callerHooks !== undefined && (!callerHooks || typeof callerHooks !== "object" || Array.isArray(callerHooks))) throw new Error("--settings hooks must be an object");
+      const hooks = { ...(callerHooks as Record<string, unknown> | undefined) };
+      for (const [event, entries] of Object.entries(injected.hooks ?? {})) {
+        const existing = hooks[event];
+        if (existing !== undefined && !Array.isArray(existing)) throw new Error(`--settings ${event} hooks must be an array`);
+        hooks[event] = [...(existing as unknown[] | undefined ?? []), ...(entries as unknown[])];
+      }
+      settingsArgs = ["--settings", JSON.stringify({ ...caller, ...(ctx.facts ? { hooks } : {}) })];
+      nativeArgs = passthrough.filter((_, i) => i !== index && (arg !== "--settings" || i !== index + 1));
+    } else if (ctx.facts && !ctx.statusLine) {
+      const injected = JSON.parse(sessionSettings(undefined, ctx.facts));
+      settingsArgs = ["--settings", JSON.stringify({ hooks: injected.hooks })];
+    }
+    if (settingsArgs.length && !ctx.preview) {
+      const stateDir = ctx.facts?.stateDir ?? ctx.statusLine?.stateDir;
+      if (!stateDir) throw new Error("Claude session settings require the hub state directory");
+      const file = join(stateDir, `claude-settings-${randomUUID()}.json`);
+      try {
+        mkdirSync(stateDir, { recursive: true, mode: 0o700 });
+        writeFileSync(`${file}.tmp`, settingsArgs[1]!, { mode: 0o600, flag: "wx" });
+        renameSync(`${file}.tmp`, file);
+      } catch {
+        try { unlinkSync(`${file}.tmp`); } catch { /* no temp file was written */ }
+        throw new Error("cannot write private Claude session settings in the hub state directory");
+      }
+      settingsArgs[1] = file;
+      settingsFile = file;
+    }
     const notes = [
       unattended ? UNATTENDED_WARNING : "",
       ctx.statusLine && own ? "note: you passed --settings, so the hub's status line tee is off and the budget coordinator cannot see Claude's quota (ahub budget set claude <0..1> still works)." : "",
-      ctx.facts && own && ctx.facts.purpose !== "idle" ? "note: you passed --settings, so the hub's turn-free facts hooks are off for this session: Claude will not see the other agents' changes at its tool calls." : "",
-      ctx.facts && own && (ctx.facts.purpose === "idle" || ctx.facts.purpose === "facts-and-idle") ? "note: you passed --settings, so native idle observation hooks are off for this session: task idle sweeps cannot verify Claude between turns." : "",
-      ctx.facts?.observeNative && own ? "note: you passed --settings, so native session/turn observation hooks are off: completed turns and supervision tokens may be unavailable." : "",
     ].filter(Boolean);
     return {
       cmd: "claude",
-      args: ["--dangerously-load-development-channels", claudeChannel(passthrough), ...(unattended ? ["--dangerously-skip-permissions"] : []), ...tee, ...passthrough],
+      args: ["--dangerously-load-development-channels", claudeChannel(passthrough), ...(unattended ? ["--dangerously-skip-permissions"] : []), ...settingsArgs, ...nativeArgs],
+      ...(settingsFile ? { settingsFile } : {}),
+      permissionHook: !!ctx.facts,
+      ...(ctx.facts ? { hookPurpose: ctx.facts.purpose ?? "facts" } : {}),
+      unattended,
       ...(notes.length ? { warning: notes.join("\n") } : {}),
     };
   }
@@ -125,6 +205,7 @@ export function buildLaunch(
   return {
     cmd: ctx.codexBin ?? "codex",
     args: ["--enable", "tui_app_server", "--remote", ctx.proxyUrl, ...(unattended ? ["--dangerously-bypass-approvals-and-sandbox"] : []), ...passthrough],
+    unattended,
     ...warning,
   };
 }