@stage5/lumine 0.3.52 → 0.3.53

package/lib/build-review.js

@@ -761,8 +761,21 @@ async function runChromeReview({
   });
   const closed = new Promise((resolve, reject) => {
     child.once("error", reject);
-    child.once("close", (code, signal) => {
-      resolve({ code: Number(code ?? -1), signal: signal || null });
+    child.once("exit", (code, signal) => {
+      // Chrome's crash reporter can inherit stderr and outlive Chrome. Node's
+      // `close` then never fires even though the browser already exited.
+      // Drain the last output briefly, then close only our pipe endpoints;
+      // do not kill another process or turn an early browser exit into success.
+      let done = false;
+      const finish = (stdioDrainTimedOut) => {
+        if (done) return;
+        done = true;
+        clearTimeout(drainTimer);
+        for (const stream of child.stdio) stream?.destroy?.();
+        resolve({ code: Number(code ?? -1), signal: signal || null, stdioDrainTimedOut });
+      };
+      const drainTimer = setTimeout(() => finish(true), 250);
+      child.once("close", () => finish(false));
     });
   });
   // The hard kill covers the observation window plus, when a script runs,
@@ -1140,6 +1153,7 @@ export async function runManagedBuildReview({ options, authToken, buildId }) {
       closeRequested: browser.closeRequested === true,
       forcedTermination: browser.forcedTermination === true,
       exitedCleanly: browser.code === 0 && !browser.signal,
+      stdioDrainTimedOut: browser.stdioDrainTimedOut === true,
       evidenceCompleteBeforeClose: browser.evidenceCompleteBeforeClose === true,
       exitedBeforeClose: browser.exitedBeforeClose === true,
       closeDurationMs: Number.isFinite(browser.closeDurationMs)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@stage5/lumine",
-  "version": "0.3.52",
+  "version": "0.3.53",
   "description": "Command line tools for launching Lumine builds on Twinkle.",
   "type": "module",
   "bin": {

package/sdk/LUMINE_ADMIN.md

@@ -1184,7 +1184,7 @@ lumine admin report serve --file <dir>/daily-management-report.md [--port <n>] [
 ```
 
 These compose the documented commands in this contract, running them as child processes, so every scope check, audit and pagination rule applies unchanged.
-- **`gather`** saves each read-only report into `<dir>`, including the canonical published Math Lab queue in `math-lab-queue.json`. It follows `bot-output` to exhaustion and renders `bot-chats.txt`, then lists any failed step in `gather.json`. Total/per-step `durationMs`, attempts and recovered reads make recurring slow or failing collection steps visible during the daily review. It also creates `review-state.json`: every source is fetched, not read. Children bypass update checks, require matching fresh stdout/file receipts, and retry an unconfirmed opted-in read at most once. Mutations never auto-retry. It needs the active run for run-scoped reads.
+- **`gather`** saves its fixed set of read-only reports into `<dir>`, including the canonical published Math Lab queue in `math-lab-queue.json`. It is not the complete daily checklist: app refills/usage, all-type Build reviews, sponsor integrity and other duties need their own steps. Repository agents follow the current full-run coverage index in `agent-guides/lumine-admin.md`. It follows `bot-output` to exhaustion and renders `bot-chats.txt`, then lists any failed step in `gather.json`. Total/per-step `durationMs`, attempts and recovered reads make recurring slow or failing collection steps visible during the daily review. It also creates `review-state.json`: every source is fetched, not read. Children bypass update checks, require matching fresh stdout/file receipts, and retry an unconfirmed opted-in read at most once. Mutations never auto-retry. It needs the active run for run-scoped reads.
 - **`progress`** reads local review state and explicit operator acknowledgments, writes private `progress.json`, and keeps reading, canonical effort mutations, the run lease, and browser checks separate. Add all required duties for the actual run scope and its carryovers; collection alone is not a full review. A completed run lease cannot complete a pending duty. Reading acknowledgments bind to the current file bytes and are operator attestations, not proof of comprehension.
 - **`featured candidates`** returns Subjects posted after the Bangkok-midnight cutoff that are off the board and provably never Featured. Each one comes with its human/bot comment counts, explicit comment truncation/completeness, and whether Mikey has viewed it. Counts from truncated context are partial. An unavailable Subject context fails the collection. Eligibility only: ranking stays editorial.
 - **`report serve`** detaches a loopback server that answers only `/`, `marked.min.js` and the report Markdown. `--open` opens Chrome and reports whether the OS accepted the request. Render, navigation and original-source verification remain pending until actually checked. Startup failures stop only the child this command started.