@stage5/lumine 0.3.42 → 0.3.43

package/lib/admin-featured.js

@@ -253,6 +253,7 @@ export async function runFeaturedWorkflow({
   operation,
   authToken,
   runId,
+  sourceRunId = 0,
   request = requestJson,
 }) {
   const apiUrl = String(options.apiUrl).replace(/\/$/, "");
@@ -273,9 +274,9 @@ export async function runFeaturedWorkflow({
       options.adminFile,
       options.adminApprove,
     );
-    if (plan.runId !== runId)
+    if (plan.runId !== runId && !(sourceRunId > 0 && plan.runId === sourceRunId))
       throw invalid(
-        "This plan belongs to a different run; prepare and approve a fresh plan.",
+        "This plan belongs to a different run; prepare and approve a fresh plan, or apply it from an approvals run started on its full run (--scope approvals --source-run).",
       );
     const result = await call(
       "/plan/apply",

package/lib/admin.js

@@ -1312,6 +1312,8 @@ export async function adminCommand(options) {
   });
   let runId = 0;
   let runScope = null;
+  // The full run an approvals run applies (0 for every other run).
+  let sourceRunId = 0;
   let correctionSessionId = 0;
   let correctionSession = null;
   let commentSessionId = 0;
@@ -1406,6 +1408,8 @@ export async function adminCommand(options) {
     if (selectedRun) {
       runScope = canonicalAdminRunScope(selectedRun);
       assertAdminOperationAllowedForRunScope({ operation, runScope });
+      sourceRunId =
+        runScope === "approvals" ? Number(selectedRun.sourceRunId || 0) : 0;
     }
     if (options.adminIdentity && commentSession) {
       const requestedIdentity = parseIdentity(options.adminIdentity);
@@ -1519,6 +1523,8 @@ export async function adminCommand(options) {
         operation,
         authToken: auth.token,
         runId,
+        // An approvals run applies its source full run's Featured plan.
+        sourceRunId,
       });
     } else if (operation.name === "build.review") {
       result = await runManagedBuildReview({
@@ -2302,7 +2308,8 @@ export function canonicalAdminRunScope(run) {
   const raw = run?.runScope;
   if (raw === undefined || raw === null || raw === "") return "full";
   const scope = String(raw);
-  if (["full", "featured", "newspaper"].includes(scope)) return scope;
+  if (["full", "featured", "newspaper", "approvals"].includes(scope))
+    return scope;
   throw cliValidationError(
     "The API returned an invalid administrator run scope.",
   );
@@ -2334,6 +2341,17 @@ const FEATURED_RUN_OPERATIONS = new Set([
   "daily-run.fail",
 ]);
 
+// An approvals run acts on Mikey's decisions whenever he gets to them: a full
+// run's write work without the newspaper, sponsor scan or bank seeding (the
+// API holds the same line through the run's scopes).
+const APPROVALS_RUN_EXCLUDED_OPERATIONS = new Set([
+  "news.claim",
+  "news.print",
+  "news.submit",
+  "sponsor.integrity.scan",
+  "reward-bank.seed",
+]);
+
 export function assertAdminOperationAllowedForRunScope({
   operation,
   runScope,
@@ -2354,6 +2372,12 @@ export function assertAdminOperationAllowedForRunScope({
       `A newspaper-only run does not authorize ${operation.name}.`,
     );
   }
+  if (runScope === "approvals") {
+    if (!APPROVALS_RUN_EXCLUDED_OPERATIONS.has(operation.name)) return;
+    throw cliValidationError(
+      `An approvals run does not do ${operation.name}; that belongs to a full daily run.`,
+    );
+  }
   if (runScope !== "featured") return;
   const subjectCommentAlias =
     operation.name === "post.comments" &&
@@ -3788,8 +3812,23 @@ export function parseAdminOperation(options) {
   if (namespace === "daily-run") {
     if (action === "start") {
       const runScope = parseDailyRunScope(options.adminScope || "full");
-      const commentMode = parseCommentMode(options.commentMode || "off");
-      if (runScope !== "full" && commentMode !== "off") {
+      // An approvals run acts on decisions, so it posts unless told otherwise.
+      const commentMode = parseCommentMode(
+        options.commentMode || (runScope === "approvals" ? "post" : "off"),
+      );
+      // Optional: lets an approvals run reuse that run's plans and drafts.
+      const sourceRunId =
+        runScope === "approvals" && options.adminSourceRun
+          ? parseRequiredInteger(options.adminSourceRun, "--source-run", 1)
+          : undefined;
+      if (runScope !== "approvals" && options.adminSourceRun) {
+        throw cliValidationError("--source-run is only for --scope approvals.");
+      }
+      if (
+        runScope !== "full" &&
+        runScope !== "approvals" &&
+        commentMode !== "off"
+      ) {
         throw cliValidationError("A scoped run requires --comment-mode off.");
       }
       return writeOperation(
@@ -3805,6 +3844,7 @@ export function parseAdminOperation(options) {
           commentMode,
           scope: runScope,
           runKey: options.runKey || defaultDailyRunKey(runScope),
+          ...(sourceRunId ? { sourceRunId } : {}),
         },
       );
     }
@@ -5455,8 +5495,10 @@ function parseDailyRunScope(value) {
   const scope = String(value || "full")
     .trim()
     .toLowerCase();
-  if (!["full", "featured", "newspaper"].includes(scope)) {
-    throw cliValidationError("--scope must be full, featured, or newspaper.");
+  if (!["full", "featured", "newspaper", "approvals"].includes(scope)) {
+    throw cliValidationError(
+      "--scope must be full, featured, newspaper, or approvals.",
+    );
   }
   return scope;
 }
@@ -5788,17 +5830,24 @@ function printAdminEnergyBudget(energyBudget) {
     );
   }
   console.log(
-    "day        | charged | overflow | users | rechg | runs | calls/run avg/p90 | $/run avg/p90 | stops chg/unchg | busy | queue rst/stop/resume | telemetry rows",
+    "day        | charged | overflow | users | rechg | runs | calls/run avg/p90 | $/run avg/p90 | stops chg/unchg | busy | queue rst/stop/resume/wait-cancel | telemetry rows",
   );
   for (const day of energyBudget.byDay || []) {
     const m = day.telemetry.metrics;
     const runs = day.runs.total;
     // Queue metrics are absent from APIs older than the queued-request telemetry.
-    const queue = ["queued_restored", "queued_stopped", "busy_resume_requested"]
+    // worker_wait_cancelled: a request cancelled because the Build worker
+    // stayed unreachable through the API handoff wait.
+    const queue = [
+      "queued_restored",
+      "queued_stopped",
+      "busy_resume_requested",
+      "worker_wait_cancelled",
+    ]
       .map((metric) => String(m[metric]?.count ?? "-"))
       .join("/");
     console.log(
-      `${day.dayKey}${day.inProgress ? "*" : " "}| ${formatAdminUsd(day.chargedUsd).padStart(7)} | ${formatAdminUsd(day.overflowUsd).padStart(8)} | ${String(day.users).padStart(5)} | ${String(day.recharges).padStart(5)} | ${String(runs.runs).padStart(4)} | ${String(runs.callsPerRun.avg).padStart(7)}/${String(runs.callsPerRun.p90).padEnd(9)} | ${formatAdminUsd(runs.usdPerRun.avg).padStart(6)}/${formatAdminUsd(runs.usdPerRun.p90).padEnd(6)} | ${String(m.budget_stop_changed.count).padStart(7)}/${String(m.budget_stop_unchanged.count).padEnd(7)} | ${String(m.busy_refusal.count).padStart(4)} | ${queue.padEnd(21)} | ${day.telemetry.rowCount}`,
+      `${day.dayKey}${day.inProgress ? "*" : " "}| ${formatAdminUsd(day.chargedUsd).padStart(7)} | ${formatAdminUsd(day.overflowUsd).padStart(8)} | ${String(day.users).padStart(5)} | ${String(day.recharges).padStart(5)} | ${String(runs.runs).padStart(4)} | ${String(runs.callsPerRun.avg).padStart(7)}/${String(runs.callsPerRun.p90).padEnd(9)} | ${formatAdminUsd(runs.usdPerRun.avg).padStart(6)}/${formatAdminUsd(runs.usdPerRun.p90).padEnd(6)} | ${String(m.budget_stop_changed.count).padStart(7)}/${String(m.budget_stop_unchanged.count).padEnd(7)} | ${String(m.busy_refusal.count).padStart(4)} | ${queue.padEnd(33)} | ${day.telemetry.rowCount}`,
     );
   }
   console.log("* = in-progress UTC day; never headline it.");

package/lib/build-review.js

@@ -909,15 +909,19 @@ async function runChromeReview({
       }
     }
     await cdp.send("Browser.close").catch(() => {});
+    let forcedTermination = false;
     const closeResult = await Promise.race([
       closed,
       delay(5_000).then(() => {
+        forcedTermination = true;
         child.kill("SIGTERM");
         return closed;
       }),
     ]);
     return {
       ...closeResult,
+      closeRequested: true,
+      forcedTermination,
       stdout,
       stderr,
       consoleLines: consoleLines.slice(-MAX_CAPTURED_LOG_LINES),
@@ -934,6 +938,31 @@ async function runChromeReview({
   }
 }
 
+const CHROME_KILLED_AFTER_CLOSE_CODE = 2;
+
+// Chrome sometimes exits 2 (RESULT_CODE_KILLED) while tearing down a
+// GPU-heavy page after our own Browser.close. Every piece of evidence was
+// captured before that close, so that one shutdown result is cleanup, not a
+// failed review. Any other code, a signal, or our forced kill still fails.
+export function reviewBrowserExitedCleanly(browser) {
+  return (
+    browser?.code === 0 ||
+    (browser?.code === CHROME_KILLED_AFTER_CLOSE_CODE &&
+      !browser.signal &&
+      browser.closeRequested === true &&
+      browser.forcedTermination === false)
+  );
+}
+
+// The last few Chrome stderr lines, for diagnosing a nonzero exit.
+function chromeStderrTail(stderr) {
+  return String(stderr || "")
+    .split(/\r?\n/)
+    .filter(Boolean)
+    .slice(-20)
+    .map((line) => line.slice(0, 400));
+}
+
 function captureConsoleEvidence(stderr, cdpLines = []) {
   const chromeLines = String(stderr || "")
     .split(/\r?\n/)
@@ -1003,8 +1032,9 @@ export async function runManagedBuildReview({ options, authToken, buildId }) {
   const interactionOutcome = browser.interaction || null;
   const interactionCompleted =
     !interaction || interactionOutcome?.status === "completed";
+  const browserExitedCleanly = reviewBrowserExitedCleanly(browser);
   const confirmed =
-    browser.code === 0 &&
+    browserExitedCleanly &&
     screenshotBytes > 0 &&
     browser.runtimeReadiness?.ready === true &&
     beforeVersion === afterVersion &&
@@ -1025,6 +1055,10 @@ export async function runManagedBuildReview({ options, authToken, buildId }) {
       executable,
       exitCode: browser.code,
       signal: browser.signal,
+      closeRequested: browser.closeRequested === true,
+      forcedTermination: browser.forcedTermination === true,
+      exitedCleanly: browserExitedCleanly,
+      stderrTail: browser.code === 0 ? null : chromeStderrTail(browser.stderr),
       runtimeReadiness: browser.runtimeReadiness,
     },
     screenshot: {
@@ -1059,7 +1093,12 @@ export async function runManagedBuildReview({ options, authToken, buildId }) {
         ? "The Build was republished during review; review the new artifact before commenting."
         : browser.runtimeReadiness?.runtimeErrorVisible
           ? "The isolated Build runtime exposed a runtime error instead of a reviewable app."
-          : interactionFailure
+          : !browserExitedCleanly &&
+              screenshotBytes > 0 &&
+              browser.runtimeReadiness?.ready === true &&
+              interactionCompleted
+            ? `Chrome exited with ${browser.signal ? `signal ${browser.signal}` : `code ${browser.code}`}${browser.forcedTermination ? " after the CLI had to stop it" : ""} once the review evidence was captured. The app loaded and the screenshots are in the receipt, but the receipt is not confirmed; see browser.stderrTail and review again.`
+            : interactionFailure
             ? `Interaction step ${interactionOutcome?.failedStep?.index ?? "?"} (${interactionOutcome?.failedStep?.kind ?? "?"}) failed: ${interactionOutcome?.failedStep?.error ?? "unknown"} The receipt lists the ${interactionOutcome?.stepsCompleted ?? 0} completed step(s) and their screenshots; fix the script and review again.`
             : "The isolated Build runtime did not become visibly reviewable before the observation window ended.",
       interactionFailure

package/lib/commands.js

@@ -2798,6 +2798,7 @@ export function parseArgs(args) {
     adminAs: raw.as ? String(raw.as) : "",
     adminContextLimit: raw.limit === undefined ? 20 : Number(raw.limit),
     adminRun: raw.run ? String(raw.run) : "",
+    adminSourceRun: raw.sourceRun ? String(raw.sourceRun) : "",
     adminTarget: raw.target ? String(raw.target) : "",
     adminActions: raw.actions ? String(raw.actions) : "",
     adminDate: raw.date ? String(raw.date) : "",
@@ -3235,6 +3236,7 @@ export function printHelp() {
   lumine admin ai-email-policy get --email <address> [--json]
   lumine admin ai-email-policy set --email <address> --mode <automatic|separate_accounts> --note <text> [--json]
   lumine admin daily-run start [--scope full|featured|newspaper] [--identity zero|ciel|auto] [--comment-mode off|draft|post] [--run-key <key>] [--json]
+  lumine admin daily-run start --scope approvals [--source-run <run-id>] [--identity zero|ciel] [--comment-mode off|draft|post] [--json]   # act on Mikey's decisions; --source-run reuses that run's plans and drafts
   lumine admin daily-run status|report|complete|fail [--run <completed-run-id>] [--reason <text>] [--json]
   lumine admin daily-run escalation add --target <target> --note <summary> [--severity attention|urgent] [--json]
   lumine admin escalation list [--status open|acknowledged|resolved|all] [--limit <number>] [--json]

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@stage5/lumine",
-  "version": "0.3.42",
+  "version": "0.3.43",
   "description": "Command line tools for launching Lumine builds on Twinkle.",
   "type": "module",
   "bin": {

package/sdk/LUMINE_ADMIN.md

@@ -28,6 +28,30 @@ canonical structured data.
   `off`. It cannot inspect queues, conduct, logs, Builds, or Featured.
   Completion does not advance full-review windows or carry-over telemetry.
   Its distinct `/daily-runs/start/newspaper` endpoint fails closed on older APIs.
+- `--scope approvals [--source-run <id>]` acts on Mikey's decisions whenever
+  he gets to them (Mikey, 10-17: don't be trapped by the morning run). It has
+  a full run's write work: Featured plans and changes, Featured-comment and
+  generic recommendations, rewards, comments (draft, post, edit) and chat. It
+  has none of the newspaper, sponsor scan, bank seeding or reading duties, and
+  never counts as a full review, so review windows don't move.
+  - `--source-run` is optional. It lets the run use that run's prepared
+    Featured plan (same hash) and review receipts for up to 7 days, abandoned
+    runs included. A stale board is still refused at apply, so prepare a new
+    plan then.
+  - Source drafts expire after 30 minutes: re-draft an approved comment with
+    its approved text (with a fresh `builds review` receipt for an app). The
+    API refuses a second published comment by the same identity in the same
+    place for the same source run.
+  - Identity defaults to the source run's (else today's scheduled one) and
+    `--identity` overrides it. Either way it is named explicitly, so Bangkok
+    midnight doesn't end the run. `--comment-mode` defaults to `post`.
+    Its distinct `/daily-runs/start/approvals` endpoint fails closed on older
+    APIs.
+- **Complete a full run when its report is delivered** (`daily-run complete`),
+  even with Mikey's decisions still pending. Do not hold it open for them: an
+  expired run can never be completed, so the review would not count, its
+  report would be unavailable, and the next run would re-read the whole
+  window. When Mikey answers, start an approvals run on it.
 - The public content actor is Zero or Ciel. Mikey's operator ID is retained in
   private audit rows and is not embedded in public comment metadata.
 - Delegated HTTP work never authenticates as the bot, opens a bot socket, changes
@@ -1017,6 +1041,8 @@ identity, or advances rotation.
 lumine admin daily-run start --identity auto --comment-mode off --json
 lumine admin daily-run start --scope featured --identity auto --json
 lumine admin daily-run start --scope newspaper --identity auto --json
+lumine admin daily-run start --scope approvals --source-run 125 --json
+lumine admin daily-run start --scope approvals --identity zero --json
 lumine admin daily-run start --identity ciel --comment-mode draft \
   --run-key daily:2026-08-06:review --json
 lumine admin daily-run status --json
@@ -2769,7 +2795,9 @@ inferred. The CLI then reads the live board and verifies exact membership/order.
 Retry the identical apply command after uncertain transport failure; it reuses
 the same idempotency key. If the final read fails or finds an intervening change,
 the error retains the canonical apply receipt and never restores old state.
-Expired/different runs require a fresh plan and renewed approval.
+A different run requires a fresh plan and renewed approval, except an
+approvals run started with `--source-run <the plan's run>`, which can apply
+that exact plan with the same hash (or prepare a new one).
 
 Use the following workflow for full daily comment review, or only when Mikey's
 Featured slice includes comment encouragement: