@staff0rd/assist 0.661.0 → 0.663.0

package/dist/index.js

@@ -6,7 +6,7 @@ import { Command } from "commander";
 // package.json
 var package_default = {
   name: "@staff0rd/assist",
-  version: "0.661.0",
+  version: "0.663.0",
   type: "module",
   main: "dist/index.js",
   bin: {
@@ -651,8 +651,7 @@ var DEFAULT_BACKUP_DIR = "~/.assist/backups";
 var DEFAULT_CLONE_DIR = "~/git";
 var assistConfigShape = {
   advice: z3.strictObject({
-    include: z3.array(z3.enum(adviceFragmentNames)).default([]),
-    exclude: z3.array(z3.enum(adviceFragmentNames)).default([]),
+    fragments: z3.partialRecord(z3.enum(adviceFragmentNames), z3.boolean()).default({}),
     extra: z3.string().optional(),
     verify: z3.string().optional()
   }).optional(),
@@ -2870,8 +2869,7 @@ function configHelp(command, entries, preamble) {
 
 // src/shared/configEnumDescriptions.ts
 var byKey = {
-  "advice.include": adviceFragmentTitles,
-  "advice.exclude": adviceFragmentTitles
+  "advice.fragments": adviceFragmentTitles
 };
 function configEnumDescriptions(key) {
   return byKey[key];
@@ -3002,11 +3000,24 @@ function unionOfObjectsConfigNode(inner, base, build2) {
 }
 
 // src/shared/recordConfigNode.ts
+function enumKeyValues(keyType, base, build2) {
+  if (!keyType) return void 0;
+  const key = build2(keyType, base.path);
+  return key.kind === "scalar" ? key.enumValues : void 0;
+}
 function recordConfigNode(inner, base, build2) {
   const valueType = inner.def?.valueType;
   if (inner.def?.type !== "record" || !valueType) return void 0;
   const value = build2(valueType, [...base.path, { kind: "entry" }]);
-  return { ...base, kind: "record", value };
+  const keyValues = enumKeyValues(inner.def?.keyType, base, build2);
+  const keyDescriptions = keyValues ? configEnumDescriptions(formatConfigPath(base.path)) : void 0;
+  return {
+    ...base,
+    kind: "record",
+    value,
+    ...keyValues ? { keyValues } : {},
+    ...keyDescriptions ? { keyDescriptions } : {}
+  };
 }
 
 // src/shared/scalarConfigNode.ts
@@ -3101,14 +3112,9 @@ function enumerateConfigLeafKeys(schema2) {
 // src/commands/advise/adviceConfigHelp.ts
 var adviceConfigHelp = [
   {
-    key: "advice.include",
-    setter: 'assist config set advice.include "refactor"',
-    note: "fragment names included whatever their condition says; 'assist advise --explain' lists every name"
-  },
-  {
-    key: "advice.exclude",
-    setter: 'assist config set advice.exclude "jira-context"',
-    note: "fragment names dropped even when their condition matches; 'assist advise --explain' lists every name"
+    key: "advice.fragments",
+    setter: "assist config set advice.fragments.verify false",
+    note: "force a fragment on (true) or off (false) whatever its condition says; 'assist advise --explain' lists every name"
   },
   {
     key: "advice.extra",
@@ -5369,13 +5375,14 @@ var adviceConditions = {
 
 // src/commands/advise/selectAdvice.ts
 function decide(fragment, context) {
-  const advice = context.config.advice;
-  const exclude = advice?.exclude ?? [];
-  const include = advice?.include ?? [];
-  if (exclude.includes(fragment.name))
-    return { fragment, included: false, reason: "excluded by advice.exclude" };
-  if (include.includes(fragment.name))
-    return { fragment, included: true, reason: "included by advice.include" };
+  const fragments = context.config.advice?.fragments ?? {};
+  const override = fragments[fragment.name];
+  if (override !== void 0)
+    return {
+      fragment,
+      included: override,
+      reason: `advice.fragments.${fragment.name} is ${override}`
+    };
   const condition = adviceConditions[fragment.when];
   if (!condition)
     return {
@@ -27491,6 +27498,32 @@ async function reply(commentId, body) {
   }
 }
 
+// src/commands/prs/status/fetchReviewThreads.ts
+import { execSync as execSync51 } from "child_process";
+var THREAD_QUERY2 = `query($owner: String!, $repo: String!, $prNumber: Int!) { repository(owner: $owner, name: $repo) { pullRequest(number: $prNumber) { reviewThreads(first: 100) { nodes { isResolved } } } } }`;
+function fetchReviewThreads(org, repo, prNumber) {
+  const output = execSync51(
+    `gh api graphql -f query='${THREAD_QUERY2}' -F owner=${org} -F repo=${repo} -F prNumber=${prNumber}`,
+    { encoding: "utf8", stdio: ["ignore", "pipe", "pipe"] }
+  );
+  const nodes = JSON.parse(output)?.data?.repository?.pullRequest?.reviewThreads?.nodes;
+  if (!Array.isArray(nodes)) {
+    throw new Error("unexpected response from gh api graphql");
+  }
+  return nodes;
+}
+
+// src/commands/prs/status/countUnresolvedThreads.ts
+function countUnresolvedThreads(org, repo, prNumber) {
+  try {
+    return fetchReviewThreads(org, repo, prNumber).filter(
+      (thread) => !thread.isResolved
+    ).length;
+  } catch {
+    return null;
+  }
+}
+
 // src/commands/prs/status/describeFetchError.ts
 function firstLine2(text18) {
   const line = text18.split("\n").map((candidate) => candidate.trim()).find((candidate) => candidate.length > 0);
@@ -27515,10 +27548,10 @@ function describeFetchError(error) {
 }
 
 // src/commands/prs/status/fetchRepoPullRequests.ts
-import { execSync as execSync51 } from "child_process";
+import { execSync as execSync52 } from "child_process";
 var FIELDS = "number,title,url,author,isDraft,createdAt,updatedAt,reviewDecision,latestReviews,statusCheckRollup,mergeable";
 function fetchRepoPullRequests(org, repo) {
-  const output = execSync51(
+  const output = execSync52(
     `gh pr list --state open --json ${FIELDS} --limit 100 -R ${org}/${repo}`,
     { encoding: "utf8", stdio: ["ignore", "pipe", "pipe"] }
   );
@@ -27577,7 +27610,7 @@ function toReviews(pr) {
     state: review2.state ?? "UNKNOWN"
   }));
 }
-function toPrStatus(pr, now = Date.now()) {
+function toPrStatus(pr, unresolvedThreads, now = Date.now()) {
   const age = describeAge(pr.updatedAt, now);
   return {
     number: pr.number,
@@ -27593,7 +27626,8 @@ function toPrStatus(pr, now = Date.now()) {
     reviewDecision: pr.reviewDecision || null,
     reviews: toReviews(pr),
     checks: summariseChecks(pr.statusCheckRollup),
-    mergeable: pr.mergeable || "UNKNOWN"
+    mergeable: pr.mergeable || "UNKNOWN",
+    unresolvedThreads
   };
 }
 
@@ -27612,7 +27646,11 @@ function buildPrsStatusReport(repoArguments, now = Date.now()) {
     const repo = `${parsed.org}/${parsed.repo}`;
     try {
       const pullRequests = fetchRepoPullRequests(parsed.org, parsed.repo).map(
-        (pr) => toPrStatus(pr, now)
+        (pr) => toPrStatus(
+          pr,
+          countUnresolvedThreads(parsed.org, parsed.repo, pr.number),
+          now
+        )
       );
       report2.repos.push({ repo, pullRequests });
     } catch (error) {
@@ -27652,6 +27690,13 @@ function checkLines(pr) {
   }
   return lines2;
 }
+function threadsLine(pr) {
+  if (pr.unresolvedThreads === null) {
+    return chalk186.dim("unresolved comments: unknown");
+  }
+  if (pr.unresolvedThreads === 0) return null;
+  return chalk186.yellow(`unresolved comments: ${pr.unresolvedThreads}`);
+}
 function mergeableLine(pr) {
   if (pr.mergeable === "CONFLICTING") return chalk186.red("conflicting");
   if (pr.mergeable === "MERGEABLE") return null;
@@ -27664,6 +27709,7 @@ function printPrStatus(pr) {
   const details = [
     reviewLine(pr),
     ...checkLines(pr),
+    threadsLine(pr),
     mergeableLine(pr),
     chalk186.dim(pr.url)
   ];
@@ -27702,7 +27748,7 @@ function prsStatus(repos2, options2) {
 }
 
 // src/commands/prs/wontfix.ts
-import { execSync as execSync52 } from "child_process";
+import { execSync as execSync53 } from "child_process";
 function validateReason(reason4) {
   const lowerReason = reason4.toLowerCase();
   if (lowerReason.includes("claude") || lowerReason.includes("opus")) {
@@ -27719,7 +27765,7 @@ function validateShaReferences(reason4) {
   const invalidShas = [];
   for (const sha of shas) {
     try {
-      execSync52(`git cat-file -t ${sha}`, { stdio: "pipe" });
+      execSync53(`git cat-file -t ${sha}`, { stdio: "pipe" });
     } catch {
       invalidShas.push(sha);
     }
@@ -28108,7 +28154,7 @@ function resolveReadTimeTarget(target) {
 }
 
 // src/commands/prs/fetchPrBody.ts
-import { execSync as execSync53 } from "child_process";
+import { execSync as execSync54 } from "child_process";
 function exitGhNotInstalled() {
   console.error("Error: GitHub CLI (gh) is not installed.");
   console.error("Install it from https://cli.github.com/");
@@ -28129,7 +28175,7 @@ function currentRepo() {
 function fetchPrBody(number, repo) {
   const { org, repo: name } = repo ?? currentRepo();
   try {
-    const raw = execSync53(`gh pr view ${number} --json body -R ${org}/${name}`, {
+    const raw = execSync54(`gh pr view ${number} --json body -R ${org}/${name}`, {
       encoding: "utf8",
       stdio: ["pipe", "pipe", "pipe"]
     });
@@ -28285,10 +28331,10 @@ import chalk190 from "chalk";
 import Enquirer2 from "enquirer";
 
 // src/commands/ravendb/searchItems.ts
-import { execSync as execSync54 } from "child_process";
+import { execSync as execSync55 } from "child_process";
 import chalk189 from "chalk";
 function opExec(args) {
-  return execSync54(`op ${args}`, {
+  return execSync55(`op ${args}`, {
     encoding: "utf8",
     stdio: ["pipe", "pipe", "pipe"]
   }).trim();
@@ -28440,7 +28486,7 @@ ${errorText}`
 }
 
 // src/commands/ravendb/resolveOpSecret.ts
-import { execSync as execSync55 } from "child_process";
+import { execSync as execSync56 } from "child_process";
 import chalk194 from "chalk";
 function resolveOpSecret(reference) {
   if (!reference.startsWith("op://")) {
@@ -28448,7 +28494,7 @@ function resolveOpSecret(reference) {
     process.exit(1);
   }
   try {
-    return execSync55(`op read "${reference}"`, {
+    return execSync56(`op read "${reference}"`, {
       encoding: "utf8",
       stdio: ["pipe", "pipe", "pipe"]
     }).trim();
@@ -28698,7 +28744,7 @@ Refactor check failed:
 }
 
 // src/commands/refactor/check/getViolations/index.ts
-import { execSync as execSync56 } from "child_process";
+import { execSync as execSync57 } from "child_process";
 import fs31 from "fs";
 import { minimatch as minimatch6 } from "minimatch";
 
@@ -28748,7 +28794,7 @@ function getGitFiles(options2) {
   }
   const files = /* @__PURE__ */ new Set();
   if (options2.staged || options2.modified) {
-    const staged = execSync56("git diff --cached --name-only", {
+    const staged = execSync57("git diff --cached --name-only", {
       encoding: "utf8"
     });
     for (const file of staged.trim().split("\n").filter(Boolean)) {
@@ -28756,7 +28802,7 @@ function getGitFiles(options2) {
     }
   }
   if (options2.unstaged || options2.modified) {
-    const unstaged = execSync56("git diff --name-only", { encoding: "utf8" });
+    const unstaged = execSync57("git diff --name-only", { encoding: "utf8" });
     for (const file of unstaged.trim().split("\n").filter(Boolean)) {
       files.add(file);
     }
@@ -30338,9 +30384,9 @@ async function checkoutOnlySession(number) {
 import chalk213 from "chalk";
 
 // src/commands/review/fetchPrDiffInfo.ts
-import { execSync as execSync57 } from "child_process";
+import { execSync as execSync58 } from "child_process";
 function getCurrentBranch3() {
-  return execSync57("git rev-parse --abbrev-ref HEAD", {
+  return execSync58("git rev-parse --abbrev-ref HEAD", {
     encoding: "utf8"
   }).trim();
 }
@@ -30348,7 +30394,7 @@ function fetchPrDiffInfo() {
   const { org, repo } = getRepoInfo();
   const branch2 = getCurrentBranch3();
   const fields = "number,baseRefName,baseRefOid,headRefName,headRefOid";
-  const raw = execSync57(
+  const raw = execSync58(
     `gh pr list --state open --head ${branch2} --json ${fields} -R ${org}/${repo}`,
     {
       encoding: "utf8",
@@ -30373,7 +30419,7 @@ function fetchPrDiffInfo() {
 }
 function fetchPrChangedFiles(prNumber) {
   const { org, repo } = getRepoInfo();
-  const out = execSync57(
+  const out = execSync58(
     `gh api repos/${org}/${repo}/pulls/${prNumber}/files --paginate --jq ".[].filename"`,
     {
       encoding: "utf8",
@@ -30754,9 +30800,9 @@ function buildReviewPaths(repoRoot2, key) {
 }
 
 // src/commands/review/fetchExistingComments.ts
-import { execSync as execSync58 } from "child_process";
+import { execSync as execSync59 } from "child_process";
 function fetchRawComments(org, repo, prNumber) {
-  const out = execSync58(
+  const out = execSync59(
     `gh api --paginate repos/${org}/${repo}/pulls/${prNumber}/comments`,
     { encoding: "utf8", maxBuffer: 64 * 1024 * 1024 }
   );
@@ -30787,14 +30833,14 @@ function fetchExistingComments() {
 }
 
 // src/commands/review/gatherContext.ts
-import { execSync as execSync60 } from "child_process";
+import { execSync as execSync61 } from "child_process";
 
 // src/commands/review/fetchPrDiff.ts
-import { execSync as execSync59 } from "child_process";
+import { execSync as execSync60 } from "child_process";
 function fetchPrDiff(prNumber, baseSha, headSha) {
   const { org, repo } = getRepoInfo();
   try {
-    return execSync59(`gh pr diff ${prNumber} -R ${org}/${repo}`, {
+    return execSync60(`gh pr diff ${prNumber} -R ${org}/${repo}`, {
       encoding: "utf8",
       maxBuffer: 256 * 1024 * 1024,
       stdio: ["ignore", "pipe", "pipe"]
@@ -30809,10 +30855,10 @@ function isDiffTooLarge(error) {
 }
 function fetchDiffViaGit(baseSha, headSha) {
   try {
-    execSync59(`git fetch origin ${baseSha} ${headSha}`, { stdio: "ignore" });
+    execSync60(`git fetch origin ${baseSha} ${headSha}`, { stdio: "ignore" });
   } catch {
   }
-  return execSync59(`git diff ${baseSha}...${headSha}`, {
+  return execSync60(`git diff ${baseSha}...${headSha}`, {
     encoding: "utf8",
     maxBuffer: 256 * 1024 * 1024
   });
@@ -30820,11 +30866,11 @@ function fetchDiffViaGit(baseSha, headSha) {
 
 // src/commands/review/gatherContext.ts
 function gatherContext() {
-  const branch2 = execSync60("git rev-parse --abbrev-ref HEAD", {
+  const branch2 = execSync61("git rev-parse --abbrev-ref HEAD", {
     encoding: "utf8"
   }).trim();
-  const sha = execSync60("git rev-parse HEAD", { encoding: "utf8" }).trim();
-  const shortSha = execSync60("git rev-parse --short=7 HEAD", {
+  const sha = execSync61("git rev-parse HEAD", { encoding: "utf8" }).trim();
+  const shortSha = execSync61("git rev-parse --short=7 HEAD", {
     encoding: "utf8"
   }).trim();
   const prInfo = fetchPrDiffInfo();
@@ -34791,7 +34837,7 @@ import { mkdirSync as mkdirSync31 } from "fs";
 import { join as join93 } from "path";
 
 // src/commands/voice/checkLockFile.ts
-import { execSync as execSync61 } from "child_process";
+import { execSync as execSync62 } from "child_process";
 import { existsSync as existsSync78, mkdirSync as mkdirSync30, readFileSync as readFileSync58, writeFileSync as writeFileSync48 } from "fs";
 import { join as join92 } from "path";
 function isProcessAlive2(pid) {
@@ -34820,7 +34866,7 @@ function bootstrapVenv() {
   if (existsSync78(getVenvPython())) return;
   console.log("Setting up Python environment...");
   const pythonDir = getPythonDir();
-  execSync61(
+  execSync62(
     `uv sync --project "${pythonDir}" --extra runtime --no-install-project`,
     {
       stdio: "inherit",
@@ -35441,11 +35487,11 @@ function runCommandToCompletion(command, args, env, cwd, quiet) {
 }
 
 // src/commands/run/runPreCommands.ts
-import { execSync as execSync62 } from "child_process";
+import { execSync as execSync63 } from "child_process";
 function runPreCommands(pre, cwd) {
   for (const cmd of pre) {
     try {
-      execSync62(cmd, { stdio: "inherit", cwd });
+      execSync63(cmd, { stdio: "inherit", cwd });
     } catch (error) {
       const code = error && typeof error === "object" && "status" in error ? error.status : 1;
       process.exit(code);
@@ -36172,7 +36218,7 @@ function registerRun(program2) {
 }
 
 // src/commands/screenshot/index.ts
-import { execSync as execSync63 } from "child_process";
+import { execSync as execSync64 } from "child_process";
 import { existsSync as existsSync85, mkdirSync as mkdirSync34, unlinkSync as unlinkSync22, writeFileSync as writeFileSync51 } from "fs";
 import { tmpdir as tmpdir9 } from "os";
 import { join as join100, resolve as resolve21 } from "path";
@@ -36315,7 +36361,7 @@ function runPowerShellScript(processName, outputPath) {
   const scriptPath = join100(tmpdir9(), `assist-screenshot-${Date.now()}.ps1`);
   writeFileSync51(scriptPath, captureWindowPs1, "utf8");
   try {
-    execSync63(
+    execSync64(
       `powershell -NoProfile -ExecutionPolicy Bypass -File "${scriptPath}" -ProcessName "${processName}" -OutputPath "${outputPath}"`,
       { stdio: ["ignore", "pipe", "pipe"], encoding: "utf8" }
     );
@@ -42607,7 +42653,7 @@ async function statusLine() {
 }
 
 // src/commands/update.ts
-import { execSync as execSync64 } from "child_process";
+import { execSync as execSync65 } from "child_process";
 import * as path90 from "path";
 
 // src/commands/restartDaemonAfterUpdate.ts
@@ -42631,7 +42677,7 @@ function isGlobalNpmInstall(dir) {
     if (resolved.split(path90.sep).includes("node_modules")) {
       return true;
     }
-    const globalPrefix = execSync64("npm prefix -g", { stdio: "pipe" }).toString().trim();
+    const globalPrefix = execSync65("npm prefix -g", { stdio: "pipe" }).toString().trim();
     return resolved.toLowerCase().startsWith(path90.resolve(globalPrefix).toLowerCase());
   } catch {
     return false;
@@ -42642,18 +42688,18 @@ async function update2() {
   console.log(`Assist is installed at: ${installDir}`);
   if (isGitRepo(installDir)) {
     console.log("Detected git repo installation, pulling latest...");
-    execSync64("git pull", { cwd: installDir, stdio: "inherit" });
+    execSync65("git pull", { cwd: installDir, stdio: "inherit" });
     console.log("Installing dependencies...");
-    execSync64("npm i", { cwd: installDir, stdio: "inherit" });
+    execSync65("npm i", { cwd: installDir, stdio: "inherit" });
     console.log("Building...");
-    execSync64("npm run build", { cwd: installDir, stdio: "inherit" });
+    execSync65("npm run build", { cwd: installDir, stdio: "inherit" });
     console.log("Syncing commands...");
-    execSync64("assist sync", { stdio: "inherit" });
+    execSync65("assist sync", { stdio: "inherit" });
   } else if (isGlobalNpmInstall(installDir)) {
     console.log("Detected global npm installation, updating...");
-    execSync64("npm i -g @staff0rd/assist@latest", { stdio: "inherit" });
+    execSync65("npm i -g @staff0rd/assist@latest", { stdio: "inherit" });
     console.log("Syncing commands...");
-    execSync64("assist sync", { stdio: "inherit" });
+    execSync65("assist sync", { stdio: "inherit" });
   } else {
     console.error(
       "Could not determine installation method. Expected a git repo or global npm install."

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@staff0rd/assist",
-	"version": "0.661.0",
+	"version": "0.663.0",
 	"type": "module",
 	"main": "dist/index.js",
 	"bin": {