@staff0rd/assist 0.643.2 → 0.643.4

package/dist/index.js

@@ -6,7 +6,7 @@ import { Command } from "commander";
 // package.json
 var package_default = {
   name: "@staff0rd/assist",
-  version: "0.643.2",
+  version: "0.643.4",
   type: "module",
   main: "dist/index.js",
   bin: {
@@ -8853,16 +8853,21 @@ function buildReviewPhase() {
   };
 }
 
+// src/commands/backlog/appendReviewPhase.ts
+function appendReviewPhase(plan2) {
+  if (plan2.at(-1)?.name === REVIEW_PHASE_NAME) return plan2;
+  return [...plan2, buildReviewPhase()];
+}
+
 // src/commands/backlog/runReview.ts
 async function runReview(item, fallbackPlan, spawnOptions) {
   const plan2 = await reloadPlan(item.id) ?? fallbackPlan;
-  const reviewPhase = buildReviewPhase();
-  const allPhases = [...plan2, reviewPhase];
+  const allPhases = appendReviewPhase(plan2);
   let reviewOptions = spawnOptions;
   while (true) {
     const outcome = await executePhase(
       item,
-      plan2.length,
+      allPhases.length - 1,
       allPhases,
       reviewOptions
     );
@@ -9297,6 +9302,9 @@ function printPhase(phase, index3, isCurrent, sessions) {
   printPhaseTasks(phase);
   printPhaseSessions(sessions);
 }
+function reviewPhaseIndex(plan2) {
+  return plan2.at(-1)?.name === REVIEW_PHASE_NAME ? plan2.length - 1 : plan2.length;
+}
 function printReviewSessions(item, planLength) {
   const sessions = (item.phaseSessions ?? []).filter(
     (s) => s.phaseIdx >= planLength
@@ -9308,13 +9316,17 @@ function printReviewSessions(item, planLength) {
 }
 function printPlan(item) {
   if (!item.plan || item.plan.length === 0) return;
+  const plan2 = item.plan;
+  const reviewIdx = reviewPhaseIndex(plan2);
   console.log(chalk55.bold("Plan"));
-  for (const [i, phase] of item.plan.entries()) {
+  for (const [i, phase] of plan2.entries()) {
     const isCurrent = item.currentPhase === i + 1;
-    const sessions = (item.phaseSessions ?? []).filter((s) => s.phaseIdx === i);
+    const sessions = (item.phaseSessions ?? []).filter(
+      (s) => i === reviewIdx ? s.phaseIdx >= i : s.phaseIdx === i
+    );
     printPhase(phase, i, isCurrent, sessions);
   }
-  printReviewSessions(item, item.plan.length);
+  if (reviewIdx === plan2.length) printReviewSessions(item, plan2.length);
   console.log();
 }
 
@@ -10198,7 +10210,7 @@ async function parseStarBody(req) {
 
 // src/commands/backlog/resolveRewindPlan.ts
 function resolveRewindPlan(item) {
-  return [...resolvePlan(item), buildReviewPhase()];
+  return appendReviewPhase(resolvePlan(item));
 }
 
 // src/commands/backlog/web/withReviewPhase.ts
@@ -14831,7 +14843,10 @@ ${issues}`);
 // src/commands/backlog/propose/proposedItemSchema.ts
 import { z as z6 } from "zod";
 var proposedPhaseSchema = z6.strictObject({
-  name: z6.string().trim().min(1, "phase name is required"),
+  name: z6.string().trim().min(1, "phase name is required").refine(
+    (name) => name.toLowerCase() !== REVIEW_PHASE_NAME.toLowerCase(),
+    `"${REVIEW_PHASE_NAME}" is owned by the runner and appended to every plan automatically \u2014 remove this phase`
+  ),
   tasks: z6.array(z6.string().trim().min(1)).min(1, "a phase needs at least one task"),
   manualChecks: z6.array(z6.string().trim().min(1)).default([])
 });
@@ -14913,6 +14928,15 @@ async function propose(options2) {
   console.log(chalk82.green(`Added item ${formatItemId(id)}: ${item.name}`));
 }
 
+// src/commands/backlog/propose/proposeHelpText.ts
+var proposeHelpText = `The payload is strict JSON: { name, type, description?, acceptanceCriteria?, phases? }.
+Each phase is { name, tasks, manualChecks? } and needs at least one task.
+
+The Review phase is owned by the runner and appended to every plan automatically,
+so it must not be authored: a phase named "Review" is rejected. Do not add a final
+phase for verifying acceptance criteria, confirming manual checks, committing or
+marking the item done \u2014 that is what the appended Review phase does.`;
+
 // src/commands/backlog/registerItemCommands.ts
 function registerItemCommands(cmd) {
   cmd.command("list").alias("ls").description("List all backlog items").option(
@@ -14931,7 +14955,8 @@ function registerItemCommands(cmd) {
   ).option(
     "--confirmed",
     "Create the item after its draft has been reviewed in chat (agent use outside a web session)"
-  ).action(propose);
+  ).addHelpText("after", `
+${proposeHelpText}`).action(propose);
   cmd.command("add-phase <id> <name>").description("Add a phase to an existing backlog item").option("--task <task...>", "Task description (repeatable)").option(
     "--manual-check <check...>",
     "Manual check description (repeatable)"

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@staff0rd/assist",
-	"version": "0.643.2",
+	"version": "0.643.4",
 	"type": "module",
 	"main": "dist/index.js",
 	"bin": {