@staff0rd/assist 0.565.1 → 0.566.0

package/dist/index.js

@@ -6,7 +6,7 @@ import { Command } from "commander";
 // package.json
 var package_default = {
   name: "@staff0rd/assist",
-  version: "0.565.1",
+  version: "0.566.0",
   type: "module",
   main: "dist/index.js",
   bin: {
@@ -468,6 +468,9 @@ var DEFAULT_MODELS_DIR = "~/.assist/voice/models";
 var DEFAULT_BACKUP_DIR = "~/.assist/backups";
 var DEFAULT_CLONE_DIR = "~/git";
 var assistConfigShape = {
+  backlog: z3.strictObject({
+    previewComments: z3.boolean().default(false)
+  }).optional(),
   backup: z3.strictObject({
     dir: z3.string().default(DEFAULT_BACKUP_DIR)
   }).default({ dir: DEFAULT_BACKUP_DIR }),
@@ -4329,6 +4332,11 @@ var backlogConfigHelp = [
     setter: 'assist config set subtasks.0.title "Review"',
     note: "default sub-tasks seeded onto every new backlog item"
   },
+  {
+    key: "backlog.previewComments",
+    setter: "assist config set backlog.previewComments true",
+    note: "review 'backlog comment' in the web preview pane before it is written (default: off)"
+  },
   {
     key: "clone.baseDir",
     setter: "assist config set clone.baseDir ~/git",
@@ -12568,6 +12576,11 @@ function applyScopedConfigSet(key, value, cwd, scope, globalConfigPath) {
   return result.ok ? { ok: true, payload: { target: result.target } } : result;
 }
 
+// src/commands/config/writesGlobalConfigFile.ts
+function writesGlobalConfigFile(scope) {
+  return scope !== "project";
+}
+
 // src/commands/config/ConfigWriteScope.ts
 function isConfigWriteScope(value) {
   return value === "project" || value === "global" || value === "repo";
@@ -12599,7 +12612,7 @@ async function handleConfigWrite(req, res, apply) {
     return;
   }
   const target = globalConfigTargetFor(parsed.cwd);
-  if (!target.ok) {
+  if (!target.ok && writesGlobalConfigFile(parsed.scope)) {
     respondJson(res, 400, { error: target.error, errors: [target.error] });
     return;
   }
@@ -12607,7 +12620,7 @@ async function handleConfigWrite(req, res, apply) {
     const result = apply({
       ...parsed,
       cwd: toGitCwd(parsed.cwd),
-      globalConfigPath: target.path
+      globalConfigPath: target.ok ? target.path : void 0
     });
     if (!result.ok) {
       respondJson(res, 400, {
@@ -13986,6 +13999,7 @@ async function awaitPreviewApproval(subject, request) {
 
 // src/commands/backlog/comment/reviewProposedComment.ts
 async function reviewProposedComment(item, text18) {
+  if (loadConfig().backlog?.previewComments !== true) return;
   const sessionId = process.env.ASSIST_SESSION_ID;
   if (process.env.ASSIST_SESSION !== "1" || !sessionId) return;
   await awaitPreviewApproval("Backlog comment preview", {
@@ -22694,6 +22708,44 @@ function registerPrompts(program2) {
   program2.command("prompts").description("Show top denied tool calls by frequency").action(prompts2);
 }
 
+// src/commands/prs/postReviewComment.ts
+var MUTATION_SINGLE = `mutation($prId: ID!, $body: String!, $path: String!, $line: Int!) { addPullRequestReviewThread(input: { pullRequestId: $prId, body: $body, path: $path, line: $line, side: RIGHT }) { thread { id } } }`;
+var MUTATION_MULTI = `mutation($prId: ID!, $body: String!, $path: String!, $line: Int!, $startLine: Int!) { addPullRequestReviewThread(input: { pullRequestId: $prId, body: $body, path: $path, line: $line, startLine: $startLine, side: RIGHT, startSide: RIGHT }) { thread { id } } }`;
+function assertThreadCreated(stdout) {
+  let parsed;
+  try {
+    parsed = JSON.parse(stdout);
+  } catch {
+    throw new Error(`GitHub returned an unparseable response: ${stdout}`);
+  }
+  const id = parsed.data?.addPullRequestReviewThread?.thread?.id;
+  if (typeof id !== "string" || id.length === 0) {
+    throw new Error(
+      "GitHub did not create a review thread (no thread id returned); the line is likely outside the PR diff."
+    );
+  }
+}
+function postReviewComment(vars) {
+  const { startLine, ...base } = vars;
+  const stdout = startLine === void 0 ? runGhGraphql(MUTATION_SINGLE, base) : runGhGraphql(MUTATION_MULTI, { ...base, startLine });
+  assertThreadCreated(stdout);
+}
+
+// src/commands/prs/reviewProposedPrComment.ts
+import { randomUUID as randomUUID9 } from "crypto";
+async function reviewProposedPrComment(title, body, prNumber) {
+  const sessionId = process.env.ASSIST_SESSION_ID;
+  if (process.env.ASSIST_SESSION !== "1" || !sessionId) return;
+  await awaitPreviewApproval("PR comment preview", {
+    sessionId,
+    requestId: randomUUID9(),
+    title,
+    body,
+    prNumber,
+    kind: "pr-comment"
+  });
+}
+
 // src/commands/prs/shared.ts
 import { execSync as execSync43 } from "child_process";
 function isGhNotInstalled(error) {
@@ -22778,8 +22830,6 @@ function findCurrentPrNumber() {
 }
 
 // src/commands/prs/comment.ts
-var MUTATION_SINGLE = `mutation($prId: ID!, $body: String!, $path: String!, $line: Int!) { addPullRequestReviewThread(input: { pullRequestId: $prId, body: $body, path: $path, line: $line, side: RIGHT }) { thread { id } } }`;
-var MUTATION_MULTI = `mutation($prId: ID!, $body: String!, $path: String!, $line: Int!, $startLine: Int!) { addPullRequestReviewThread(input: { pullRequestId: $prId, body: $body, path: $path, line: $line, startLine: $startLine, side: RIGHT, startSide: RIGHT }) { thread { id } } }`;
 function validateBody(body) {
   const lower = body.toLowerCase();
   if (lower.includes("claude") || lower.includes("opus")) {
@@ -22793,33 +22843,15 @@ function validateLine(line) {
     process.exit(1);
   }
 }
-function assertThreadCreated(stdout) {
-  let parsed;
-  try {
-    parsed = JSON.parse(stdout);
-  } catch {
-    throw new Error(`GitHub returned an unparseable response: ${stdout}`);
-  }
-  const id = parsed.data?.addPullRequestReviewThread?.thread?.id;
-  if (typeof id !== "string" || id.length === 0) {
-    throw new Error(
-      "GitHub did not create a review thread (no thread id returned); the line is likely outside the PR diff."
-    );
-  }
-}
-function postComment(vars) {
-  const { startLine, ...base } = vars;
-  const stdout = startLine === void 0 ? runGhGraphql(MUTATION_SINGLE, base) : runGhGraphql(MUTATION_MULTI, { ...base, startLine });
-  assertThreadCreated(stdout);
-}
-function comment2(path80, line, body, startLine) {
+async function comment2(path80, line, body, startLine) {
   validateBody(body);
   validateLine(line);
   if (startLine !== void 0) validateLine(startLine);
+  const range = startLine !== void 0 ? `${startLine}-${line}` : `${line}`;
+  await reviewProposedPrComment(`Comment on ${path80}:${range}`, body, null);
   try {
     const prId = getCurrentPrNodeId();
-    postComment({ prId, body, path: path80, line, startLine });
-    const range = startLine !== void 0 ? `${startLine}-${line}` : `${line}`;
+    postReviewComment({ prId, body, path: path80, line, startLine });
     console.log(`Added review comment on ${path80}:${range}`);
   } catch (error) {
     if (isGhNotInstalled(error)) {
@@ -22832,7 +22864,7 @@ function comment2(path80, line, body, startLine) {
 }
 
 // src/commands/prs/edit.ts
-import { randomUUID as randomUUID9 } from "crypto";
+import { randomUUID as randomUUID10 } from "crypto";
 
 // src/commands/prs/appendScreenshots.ts
 function appendScreenshots(body, screenshots) {
@@ -23046,7 +23078,7 @@ async function edit(options2) {
   if (process.env.ASSIST_SESSION === "1" && sessionId) {
     const decision = await awaitPreviewApproval("PR preview", {
       sessionId,
-      requestId: randomUUID9(),
+      requestId: randomUUID10(),
       title: options2.title ?? title,
       body: newBody,
       prNumber: number
@@ -23757,7 +23789,7 @@ async function placePr(prNumber, title, body, options2) {
 }
 
 // src/commands/prs/previewAndPlace.ts
-import { randomUUID as randomUUID10 } from "crypto";
+import { randomUUID as randomUUID11 } from "crypto";
 
 // src/commands/sessions/shared/requestSession.ts
 function parseIncoming(line, type) {
@@ -23892,7 +23924,7 @@ function warn(reason4) {
 async function previewAndPlace(args) {
   const decision = await awaitPreviewApproval("PR preview", {
     sessionId: args.sessionId,
-    requestId: randomUUID10(),
+    requestId: randomUUID11(),
     title: args.title,
     body: args.body,
     prNumber: args.prNumber,
@@ -23945,8 +23977,9 @@ function validateBody2(body) {
     process.exit(1);
   }
 }
-function reply(commentId, body) {
+async function reply(commentId, body) {
   validateBody2(body);
+  await reviewProposedPrComment(`Reply to comment #${commentId}`, body, null);
   try {
     const prNumber = getCurrentPrNumber();
     const { org, repo } = getRepoInfo();
@@ -23992,9 +24025,14 @@ function validateShaReferences(reason4) {
     process.exit(1);
   }
 }
-function wontfix(commentId, reason4) {
+async function wontfix(commentId, reason4) {
   validateReason(reason4);
   validateShaReferences(reason4);
+  await reviewProposedPrComment(
+    `Won't fix comment #${commentId}`,
+    reason4,
+    null
+  );
   try {
     resolveCommentWithReply(commentId, reason4);
   } catch (error) {
@@ -24029,7 +24067,7 @@ function registerPrsComments(prsCommand) {
   prsCommand.command("wontfix <comment-id> <reason>").description(
     "Reply with reason and resolve thread (reason of - reads it from stdin)"
   ).action(async (commentId, reason4) => {
-    wontfix(
+    await wontfix(
       Number.parseInt(commentId, 10),
       await readBodyArgument(reason4)
     );
@@ -24037,12 +24075,19 @@ function registerPrsComments(prsCommand) {
   prsCommand.command("reply <comment-id> <body>").description(
     "Reply to a comment thread without resolving it (body of - reads it from stdin)"
   ).action(async (commentId, body) => {
-    reply(Number.parseInt(commentId, 10), await readBodyArgument(body));
+    await reply(
+      Number.parseInt(commentId, 10),
+      await readBodyArgument(body)
+    );
   });
   prsCommand.command("comment <path> <line> <body>").description(
     "Add a line comment to the pending review (body of - reads it from stdin)"
   ).action(async (path80, line, body) => {
-    comment2(path80, Number.parseInt(line, 10), await readBodyArgument(body));
+    await comment2(
+      path80,
+      Number.parseInt(line, 10),
+      await readBodyArgument(body)
+    );
   });
 }
 
@@ -26362,10 +26407,10 @@ function registerRefactor(program2) {
 }
 
 // src/commands/review/checkoutOnlySession.ts
-import { randomUUID as randomUUID11 } from "crypto";
+import { randomUUID as randomUUID12 } from "crypto";
 async function checkoutOnlySession(number) {
   await checkoutPr(number);
-  const claudeSessionId = randomUUID11();
+  const claudeSessionId = randomUUID12();
   emitActivity({ kind: "command", name: "review", claudeSessionId });
   const { done: done2 } = spawnClaude("", {
     permissionMode: "acceptEdits",
@@ -31727,7 +31772,7 @@ var ClientHub = class extends Set {
 };
 
 // src/commands/sessions/daemon/createSession.ts
-import { randomUUID as randomUUID12 } from "crypto";
+import { randomUUID as randomUUID13 } from "crypto";
 
 // src/commands/sessions/daemon/sessionBase.ts
 function sessionBase(id, status3) {
@@ -31923,7 +31968,7 @@ function spawnRun(opts) {
 function createSession(id, prompt, cwd, design, harness, holdPty) {
   if (harness && harness !== "claude")
     return createHarnessSession(id, harness, prompt, cwd, holdPty);
-  const claudeSessionId = randomUUID12();
+  const claudeSessionId = randomUUID13();
   return {
     ...sessionBase(id, prompt ? "running" : "waiting"),
     name: `Session ${id}`,
@@ -32502,9 +32547,21 @@ function decidePrPreview(sessions, waiters, notify2, d) {
   notify2();
 }
 
+// src/commands/sessions/daemon/isPreviewKind.ts
+var PREVIEW_KINDS = [
+  "pr",
+  "backlog-item",
+  "backlog-comment",
+  "pr-comment"
+];
+function isPreviewKind(value) {
+  return PREVIEW_KINDS.includes(value);
+}
+
 // src/commands/sessions/daemon/previewTargetLabel.ts
 function previewTargetLabel(kind, itemType, prNumber, draft) {
   if (kind === "backlog-comment") return "backlog comment";
+  if (kind === "pr-comment") return "pr comment";
   if (kind === "backlog-item") return `backlog ${itemType}`;
   if (prNumber !== null) return `edit #${prNumber}`;
   return draft ? "create draft" : "create";
@@ -32523,7 +32580,7 @@ function setPrPreview(sessions, waiters, notify2, client, d) {
     return;
   }
   const prNumber = typeof d.prNumber === "number" ? d.prNumber : null;
-  const kind = d.kind === "backlog-item" || d.kind === "backlog-comment" ? d.kind : "pr";
+  const kind = isPreviewKind(d.kind) ? d.kind : "pr";
   const itemType = d.itemType === "bug" ? "bug" : "story";
   const draft = d.draft === true;
   session.pendingPrPreview = {
@@ -33964,7 +34021,7 @@ function codexRespawnPlan(session) {
 }
 
 // src/commands/sessions/daemon/interactiveRespawnPlan.ts
-import { randomUUID as randomUUID13 } from "crypto";
+import { randomUUID as randomUUID14 } from "crypto";
 function interactiveRespawnPlan(session, resumes) {
   const { claudeSessionId, cwd, initialPrompt } = session;
   if (!resumes) return null;
@@ -33982,7 +34039,7 @@ function interactiveRespawnPlan(session, resumes) {
   return null;
 }
 function freshClaudePlan(session, prompt, cwd) {
-  const claudeSessionId = randomUUID13();
+  const claudeSessionId = randomUUID14();
   return {
     spawn: () => {
       session.claudeSessionId = claudeSessionId;
@@ -34860,10 +34917,10 @@ function startReusedRunPty(session, assistArgs, itemId2, hold, clients, onStatus
 }
 
 // src/commands/sessions/daemon/createWatcherSession.ts
-import { randomUUID as randomUUID14 } from "crypto";
+import { randomUUID as randomUUID15 } from "crypto";
 var WATCH_PROMPT = "/watch";
 function createWatcherSession(id, cwd) {
-  const claudeSessionId = randomUUID14();
+  const claudeSessionId = randomUUID15();
   return {
     ...sessionBase(id, "running"),
     name: `Session ${id}`,

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@staff0rd/assist",
-	"version": "0.565.1",
+	"version": "0.566.0",
 	"type": "module",
 	"main": "dist/index.js",
 	"bin": {