npm - @staff0rd/assist - Versions diffs - 0.239.0 → 0.240.0 - Mend

@staff0rd/assist 0.239.0 → 0.240.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (3) hide show

package/README.md CHANGED Viewed

@@ -91,13 +91,14 @@ After installation, the `assist` command will be available globally. You can als
 - `assist prs fixed <comment-id> <sha>` - Reply with commit link and resolve thread
 - `assist prs wontfix <comment-id> <reason>` - Reply with reason and resolve thread
 - `assist prs comment <path> <line> <body>` - Add a line comment to the pending review
-- `assist review [sha] [options]` - Run Claude and Codex in parallel to review the open PR for the current branch. The diff is fetched from GitHub (base SHA → head SHA via `gh pr diff`), so stale local base branches don't pollute the review; fails fast if no PR is open. By default, prompts before posting line-bound comments and then prompts again to submit the pending review (defaulting to no). Cached `claude.md` / `codex.md` / `synthesis.md` are reused when present; if any reviewer is re-run, the synthesis is invalidated.
-  - `[sha]` - Review that commit's diff (`sha^..sha`) instead of the open PR. Files land under `.assist/reviews/<shortSha>/`, no GitHub lookup or posting happens, and `--refine` / `--apply` / `--submit` are rejected
+- `assist review [number] [options]` - Run Claude and Codex in parallel to review the open PR for the current branch. The diff is fetched from GitHub (base SHA → head SHA via `gh pr diff`), so stale local base branches don't pollute the review; fails fast if no PR is open. By default, prompts before posting line-bound comments and then prompts again to submit the pending review (defaulting to no). Cached `claude.md` / `codex.md` / `synthesis.md` are reused when present; if any reviewer is re-run, the synthesis is invalidated.
+  - `[number]` - Run `gh pr checkout <number>` first, then review that PR's branch. If the checkout fails (dirty working tree, unknown PR number), the review aborts
   - `--no-prompt` - Skip all confirmations
   - `--submit` - Default the submit prompt to yes (or auto-submit when combined with `--no-prompt`)
   - `--force` - Clear all cached files and re-run every phase
   - `--refine` - Skip posting; launch an interactive Claude session that walks through `synthesis.md` and edits it in place. A subsequent `assist review` reuses the refined file and posts only the surviving findings
   - `--apply` - Skip posting; launch an interactive Claude session that walks through each finding asking apply/skip. Applied findings are fixed in the working tree (unstaged) and removed from `synthesis.md`; skipped findings stay so a subsequent `assist review` posts them. Cannot be combined with `--refine`
+  - `--backlog` - Skip posting; launch an interactive Claude session running `/bug` that files all findings (including `already-raised`) as a single bug backlog item with one phase per finding. `synthesis.md` is left untouched; `--submit` is ignored. Cannot be combined with `--refine` or `--apply`
   - `--verbose` - Disable the stacked-spinner UI and fall back to per-line log output. Non-TTY environments (CI) automatically use this mode
 - `assist news` - Start the news web UI showing latest RSS feed items (same as `news web`)
 - `assist news add [url]` - Add an RSS feed URL to the config

package/dist/index.js CHANGED Viewed

@@ -6,7 +6,7 @@ import { Command } from "commander";
 // package.json
 var package_default = {
   name: "@staff0rd/assist",
-  version: "0.239.0",
+  version: "0.240.0",
   type: "module",
   main: "dist/index.js",
   bin: {
@@ -12863,6 +12863,9 @@ function registerRefactor(program2) {
   registerRestructure(refactorCommand);
 }
+// src/commands/review/review.ts
+import { execFileSync as execFileSync6 } from "child_process";
 // src/commands/review/formatPriorComments.ts
 function threadKey(c, byId) {
   if (c.threadId) return c.threadId;
@@ -12936,23 +12939,6 @@ ${formatFiles(context.changedFiles)}
 ${priorBlock}
 ## Diff (PR #${context.prNumber}: ${context.baseSha}..${context.headSha})
-\`\`\`diff
-${context.diff.trimEnd()}
-\`\`\`
-`;
-}
-function buildShaRequest(context) {
-  return `# Code review request
-- Commit: \`${context.sha}\`
-- Parent: \`${context.parentSha}\`
-## Changed files
-${formatFiles(context.changedFiles)}
-## Diff (commit ${context.sha}: ${context.parentSha}..${context.sha})
 \`\`\`diff
 ${context.diff.trimEnd()}
 \`\`\`
@@ -13006,12 +12992,41 @@ function fetchExistingComments() {
 }
 // src/commands/review/gatherContext.ts
-import { execSync as execSync42 } from "child_process";
+import { execSync as execSync43 } from "child_process";
-// src/commands/review/fetchPrDiffInfo.ts
+// src/commands/review/fetchPrDiff.ts
 import { execSync as execSync41 } from "child_process";
+function fetchPrDiff(prNumber, baseSha, headSha) {
+  const { org, repo } = getRepoInfo();
+  try {
+    return execSync41(`gh pr diff ${prNumber} -R ${org}/${repo}`, {
+      encoding: "utf-8",
+      maxBuffer: 256 * 1024 * 1024,
+      stdio: ["ignore", "pipe", "pipe"]
+    });
+  } catch (error) {
+    if (!isDiffTooLarge(error)) throw error;
+    return fetchDiffViaGit(baseSha, headSha);
+  }
+}
+function isDiffTooLarge(error) {
+  return error instanceof Error && (error.message.includes("too_large") || error.message.includes("maximum number of files"));
+}
+function fetchDiffViaGit(baseSha, headSha) {
+  try {
+    execSync41(`git fetch origin ${baseSha} ${headSha}`, { stdio: "ignore" });
+  } catch {
+  }
+  return execSync41(`git diff ${baseSha}...${headSha}`, {
+    encoding: "utf-8",
+    maxBuffer: 256 * 1024 * 1024
+  });
+}
+// src/commands/review/fetchPrDiffInfo.ts
+import { execSync as execSync42 } from "child_process";
 function getCurrentBranch2() {
-  return execSync41("git rev-parse --abbrev-ref HEAD", {
+  return execSync42("git rev-parse --abbrev-ref HEAD", {
     encoding: "utf-8"
   }).trim();
 }
@@ -13021,7 +13036,7 @@ function fetchPrDiffInfo() {
   const fields = "number,baseRefName,baseRefOid,headRefName,headRefOid";
   let raw;
   try {
-    raw = execSync41(`gh pr view ${branch} --json ${fields} -R ${org}/${repo}`, {
+    raw = execSync42(`gh pr view ${branch} --json ${fields} -R ${org}/${repo}`, {
       encoding: "utf-8",
       stdio: ["ignore", "pipe", "pipe"]
     });
@@ -13045,32 +13060,28 @@ function fetchPrDiffInfo() {
 }
 function fetchPrChangedFiles(prNumber) {
   const { org, repo } = getRepoInfo();
-  const out = execSync41(`gh pr diff ${prNumber} --name-only -R ${org}/${repo}`, {
-    encoding: "utf-8",
-    maxBuffer: 64 * 1024 * 1024
-  });
+  const out = execSync42(
+    `gh api repos/${org}/${repo}/pulls/${prNumber}/files --paginate --jq ".[].filename"`,
+    {
+      encoding: "utf-8",
+      maxBuffer: 64 * 1024 * 1024
+    }
+  );
   return out.trim().split("\n").filter(Boolean);
 }
-function fetchPrDiff(prNumber) {
-  const { org, repo } = getRepoInfo();
-  return execSync41(`gh pr diff ${prNumber} -R ${org}/${repo}`, {
-    encoding: "utf-8",
-    maxBuffer: 256 * 1024 * 1024
-  });
-}
 // src/commands/review/gatherContext.ts
 function gatherContext() {
-  const branch = execSync42("git rev-parse --abbrev-ref HEAD", {
+  const branch = execSync43("git rev-parse --abbrev-ref HEAD", {
     encoding: "utf-8"
   }).trim();
-  const sha = execSync42("git rev-parse HEAD", { encoding: "utf-8" }).trim();
-  const shortSha = execSync42("git rev-parse --short=7 HEAD", {
+  const sha = execSync43("git rev-parse HEAD", { encoding: "utf-8" }).trim();
+  const shortSha = execSync43("git rev-parse --short=7 HEAD", {
     encoding: "utf-8"
   }).trim();
   const prInfo = fetchPrDiffInfo();
   const changedFiles = fetchPrChangedFiles(prInfo.prNumber);
-  const diff2 = fetchPrDiff(prInfo.prNumber);
+  const diff2 = fetchPrDiff(prInfo.prNumber, prInfo.baseSha, prInfo.headSha);
   return {
     branch,
     sha,
@@ -13440,6 +13451,29 @@ async function runApplySession(synthesisPath) {
   await done2;
 }
+// src/commands/review/runBacklogSession.ts
+function buildBacklogPrompt(synthesisPath) {
+  return `/bug add each finding in ${synthesisPath} as a phase
+Read ${synthesisPath}. It contains a list of findings under the \`## Findings\` heading, each in a \`### Finding:\` block with Severity, Source, Location, Impact, and Recommendation fields.
+File ONE bug backlog item covering the review findings:
+- Include EVERY finding in the file as a phase on that single item \u2014 including findings whose Source is \`already-raised\`.
+- Each phase should be named after its finding's title and its tasks should capture the finding's Location, Impact, and Recommendation.
+- Use \`assist backlog add\` to create the item, then \`assist backlog add-phase\` for each finding.
+Important constraints:
+- Do not edit ${synthesisPath} \u2014 leave it untouched.
+- Do not post anything to a PR.
+- Do not stage, commit, or push any changes.`;
+}
+async function runBacklogSession(synthesisPath) {
+  const { done: done2 } = spawnClaude(buildBacklogPrompt(synthesisPath), {
+    allowEdits: true
+  });
+  await done2;
+}
 // src/commands/review/cachedReviewerResult.ts
 import { statSync as statSync2 } from "fs";
 function cachedReviewerResult(name, outputPath) {
@@ -14356,6 +14390,10 @@ function setupReviewDir(repoRoot, context, force) {
   return paths;
 }
 async function runPostSynthesis(synthesisPath, options2) {
+  if (options2.backlog) {
+    await runBacklogSession(synthesisPath);
+    return;
+  }
   if (options2.apply) {
     await runApplySession(synthesisPath);
     return;
@@ -14376,58 +14414,6 @@ async function reviewPr(repoRoot, options2) {
   console.log(`Done. Review folder: ${paths.reviewDir}`);
 }
-// src/commands/review/gatherShaContext.ts
-import { execSync as execSync43 } from "child_process";
-function resolveSha(ref, format2) {
-  const flag = format2 === "short" ? "--short=7 " : "";
-  try {
-    return execSync43(`git rev-parse --verify ${flag}${ref}^{commit}`, {
-      encoding: "utf-8",
-      stdio: ["ignore", "pipe", "pipe"]
-    }).trim();
-  } catch {
-    console.error(`Error: could not resolve commit \`${ref}\`.`);
-    process.exit(1);
-  }
-}
-function gatherShaContext(ref) {
-  const sha = resolveSha(ref, "long");
-  const shortSha = resolveSha(sha, "short");
-  const parentSha = resolveSha(`${sha}^`, "long");
-  const range = `${parentSha}..${sha}`;
-  const changedFiles = execSync43(`git diff --name-only ${range}`, {
-    encoding: "utf-8",
-    maxBuffer: 64 * 1024 * 1024
-  }).trim().split("\n").filter(Boolean);
-  const diff2 = execSync43(`git diff ${range}`, {
-    encoding: "utf-8",
-    maxBuffer: 256 * 1024 * 1024
-  });
-  return { sha, shortSha, parentSha, changedFiles, diff: diff2 };
-}
-// src/commands/review/reviewSha.ts
-function gatherShaChangedContext(ref) {
-  const context = gatherShaContext(ref);
-  if (context.changedFiles.length > 0) return context;
-  console.error(
-    `Error: commit ${context.sha} has no changed files \u2014 nothing to review.`
-  );
-  process.exit(1);
-}
-function setupShaReviewDir(repoRoot, context, force) {
-  const paths = buildReviewPaths(repoRoot, context.shortSha);
-  prepareReviewDir(paths, buildShaRequest(context), force);
-  console.log(`Review folder: ${paths.reviewDir}`);
-  return paths;
-}
-async function reviewSha(repoRoot, options2) {
-  const context = gatherShaChangedContext(options2.sha);
-  const paths = setupShaReviewDir(repoRoot, context, options2.force ?? false);
-  await runReviewPipeline(paths, { verbose: options2.verbose ?? false });
-  console.log(`Done. Review folder: ${paths.reviewDir}`);
-}
 // src/commands/review/review.ts
 function resolveRepoRoot() {
   const repoRoot = findRepoRoot(process.cwd());
@@ -14435,41 +14421,40 @@ function resolveRepoRoot() {
   console.error("Error: not inside a git repository.");
   process.exit(1);
 }
-function rejectShaFlag(flag) {
-  console.error(`Error: ${flag} cannot be combined with a SHA argument.`);
-  process.exit(1);
-}
 function validateOptions(options2) {
   if (options2.apply && options2.refine) {
     console.error("Error: --apply cannot be combined with --refine.");
     process.exit(1);
   }
-  if (!options2.sha) return;
-  if (options2.refine) rejectShaFlag("--refine");
-  if (options2.apply) rejectShaFlag("--apply");
-  if (options2.submit) rejectShaFlag("--submit");
+  if (options2.backlog && (options2.refine || options2.apply)) {
+    console.error(
+      "Error: --backlog cannot be combined with --refine or --apply."
+    );
+    process.exit(1);
+  }
+}
+function checkoutPr(number) {
+  try {
+    execFileSync6("gh", ["pr", "checkout", number], { stdio: "inherit" });
+  } catch {
+    console.error(`gh pr checkout ${number} failed; aborting.`);
+    process.exit(1);
+  }
 }
 async function review(options2 = {}) {
   validateOptions(options2);
   const repoRoot = resolveRepoRoot();
-  if (options2.sha) {
-    await reviewSha(repoRoot, {
-      sha: options2.sha,
-      force: options2.force,
-      verbose: options2.verbose
-    });
-    return;
-  }
+  if (options2.number) checkoutPr(options2.number);
   await reviewPr(repoRoot, options2);
 }
 // src/commands/registerReview.ts
 function registerReview(program2) {
   program2.command("review").description(
-    "Run Claude and Codex in parallel to review the current branch, or a single commit when a SHA is given"
+    "Run Claude and Codex in parallel to review the current branch's PR, or check out a PR by number first when given"
   ).argument(
-    "[sha]",
-    "Optional commit SHA to review (sha^..sha); when provided, no PR lookup or GitHub posting happens"
+    "[number]",
+    "Optional PR number; when provided, runs `gh pr checkout <number>` before reviewing"
   ).option(
     "--no-prompt",
     "Skip confirmation prompts; use flag defaults non-interactively"
@@ -14485,11 +14470,14 @@ function registerReview(program2) {
   ).option(
     "--apply",
     "After synthesis, launch an interactive Claude session to apply fixes for each finding; applied findings are removed from synthesis, skipped ones remain for a later post"
+  ).option(
+    "--backlog",
+    "After synthesis, launch an interactive Claude session running /bug to file all findings as a single backlog item with one phase per finding, instead of posting to the PR"
   ).option(
     "--verbose",
     "Disable spinner UI and use per-line log output (per-tool lines, starting/done lines)"
   ).action(
-    (sha, options2) => review({ ...options2, sha })
+    (number, options2) => review({ ...options2, number })
   );
 }
@@ -16229,7 +16217,7 @@ async function auth() {
 }
 // src/commands/roam/postRoamActivity.ts
-import { execFileSync as execFileSync6 } from "child_process";
+import { execFileSync as execFileSync7 } from "child_process";
 import { readdirSync as readdirSync7, readFileSync as readFileSync37, statSync as statSync4 } from "fs";
 import { join as join47 } from "path";
 function findPortFile(roamDir) {
@@ -16262,7 +16250,7 @@ function postRoamActivity(app, event) {
   }
   const url = `http://127.0.0.1:${port}/api/v1/activity/${app}/${event}?pid=${app === "codex" ? 99998 : 99999}`;
   try {
-    execFileSync6("curl", ["-sf", "--max-time", "0.2", "-X", "POST", url], {
+    execFileSync7("curl", ["-sf", "--max-time", "0.2", "-X", "POST", url], {
       stdio: "ignore"
     });
   } catch {
@@ -16389,13 +16377,13 @@ function runPreCommands(pre, cwd) {
 }
 // src/commands/run/spawnRunCommand.ts
-import { execFileSync as execFileSync7, spawn as spawn8 } from "child_process";
+import { execFileSync as execFileSync8, spawn as spawn8 } from "child_process";
 import { existsSync as existsSync47 } from "fs";
 import { dirname as dirname25, join as join48, resolve as resolve11 } from "path";
 function resolveCommand2(command) {
   if (process.platform !== "win32" || command !== "bash") return command;
   try {
-    const gitPath = execFileSync7("where", ["git"], { encoding: "utf8" }).trim().split("\r\n")[0];
+    const gitPath = execFileSync8("where", ["git"], { encoding: "utf8" }).trim().split("\r\n")[0];
     const gitRoot = resolve11(dirname25(gitPath), "..");
     const gitBash = join48(gitRoot, "bin", "bash.exe");
     if (existsSync47(gitBash)) return gitBash;
@@ -16827,7 +16815,7 @@ function summaryPathFor(jsonlPath2) {
 }
 // src/commands/sessions/summarise/summariseSession.ts
-import { execFileSync as execFileSync8 } from "child_process";
+import { execFileSync as execFileSync9 } from "child_process";
 // src/commands/sessions/summarise/iterateUserMessages.ts
 import * as fs27 from "fs";
@@ -16904,7 +16892,7 @@ function summariseSession(jsonlPath2) {
   }
   const prompt = buildPrompt2(firstMessage, backlogIds);
   try {
-    const output = execFileSync8("claude", ["-p", "--model", "haiku", prompt], {
+    const output = execFileSync9("claude", ["-p", "--model", "haiku", prompt], {
       encoding: "utf8",
       timeout: 3e4,
       stdio: ["ignore", "pipe", "ignore"]

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
 	"name": "@staff0rd/assist",
-	"version": "0.239.0",
+	"version": "0.240.0",
 	"type": "module",
 	"main": "dist/index.js",
 	"bin": {