@staff0rd/assist 0.220.1 → 0.220.2

package/dist/index.js

@@ -6,7 +6,7 @@ import { Command } from "commander";
 // package.json
 var package_default = {
   name: "@staff0rd/assist",
-  version: "0.220.1",
+  version: "0.220.2",
   type: "module",
   main: "dist/index.js",
   bin: {
@@ -4070,10 +4070,10 @@ function printTaskStatuses(tasks) {
 }
 
 // src/commands/verify/run/createTimerCallback/index.ts
-function logFailedScripts(failed) {
+function logFailedScripts(failed2) {
   console.error(`
-${failed.length} script(s) failed:`);
-  for (const f of failed) {
+${failed2.length} script(s) failed:`);
+  for (const f of failed2) {
     console.error(`  - ${f.script} (exit code ${f.code})`);
   }
 }
@@ -4150,9 +4150,9 @@ function runEntry(entry, onComplete) {
     });
   });
 }
-function exitIfFailed(failed) {
-  if (failed.length === 0) return;
-  logFailedScripts(failed);
+function exitIfFailed(failed2) {
+  if (failed2.length === 0) return;
+  logFailedScripts(failed2);
   process.exit(1);
 }
 function runAllEntries(entries, timer) {
@@ -8401,52 +8401,52 @@ function renderInline(node) {
   if (node.marks?.some((m) => m.type === "code")) return `\`${text}\``;
   return text;
 }
-function renderChildren(node, indent) {
-  return renderNodes(node.content ?? [], indent);
+function renderChildren(node, indent2) {
+  return renderNodes(node.content ?? [], indent2);
 }
-function renderOrderedList(node, indent) {
+function renderOrderedList(node, indent2) {
   let counter = 0;
   return (node.content ?? []).map((item) => {
     counter++;
-    return renderListItem(item, indent, `${counter}.`);
+    return renderListItem(item, indent2, `${counter}.`);
   }).join("\n");
 }
-function renderBulletList(node, indent) {
-  return (node.content ?? []).map((item) => renderListItem(item, indent, "-")).join("\n");
+function renderBulletList(node, indent2) {
+  return (node.content ?? []).map((item) => renderListItem(item, indent2, "-")).join("\n");
 }
-function renderHeading(node, indent) {
+function renderHeading(node, indent2) {
   const level = node.attrs?.level ?? 1;
-  return `${"#".repeat(level)} ${renderChildren(node, indent)}`;
+  return `${"#".repeat(level)} ${renderChildren(node, indent2)}`;
 }
 var renderers = {
   text: (node) => renderInline(node),
   paragraph: renderChildren,
   orderedList: renderOrderedList,
   bulletList: renderBulletList,
-  listItem: (node, indent) => renderListItem(node, indent, "-"),
+  listItem: (node, indent2) => renderListItem(node, indent2, "-"),
   heading: renderHeading,
   doc: renderChildren
 };
-function renderNode(node, indent) {
+function renderNode(node, indent2) {
   const renderer = renderers[node.type];
-  if (renderer) return renderer(node, indent);
-  return node.content ? renderChildren(node, indent) : "";
+  if (renderer) return renderer(node, indent2);
+  return node.content ? renderChildren(node, indent2) : "";
 }
-function renderNodes(nodes, indent) {
-  return nodes.map((node) => renderNode(node, indent)).join("");
+function renderNodes(nodes, indent2) {
+  return nodes.map((node) => renderNode(node, indent2)).join("");
 }
 function isListNode(node) {
   return node.type === "orderedList" || node.type === "bulletList";
 }
-function renderListChild(child, indent, pad, marker, isFirst) {
-  if (isListNode(child)) return renderNodes([child], indent + 1);
-  if (child.type !== "paragraph") return renderNode(child, indent);
-  const text = renderChildren(child, indent);
+function renderListChild(child, indent2, pad, marker, isFirst) {
+  if (isListNode(child)) return renderNodes([child], indent2 + 1);
+  if (child.type !== "paragraph") return renderNode(child, indent2);
+  const text = renderChildren(child, indent2);
   return isFirst ? `${pad}${marker} ${text}` : `${pad}  ${text}`;
 }
-function renderListItem(node, indent, marker) {
-  const pad = "  ".repeat(indent);
-  return (node.content ?? []).map((child, i) => renderListChild(child, indent, pad, marker, i === 0)).join("\n");
+function renderListItem(node, indent2, marker) {
+  const pad = "  ".repeat(indent2);
+  return (node.content ?? []).map((child, i) => renderListChild(child, indent2, pad, marker, i === 0)).join("\n");
 }
 function adfToText(doc) {
   return renderNodes([doc], 0);
@@ -10283,13 +10283,13 @@ function runScript(script, cwd) {
     });
   });
 }
-function logFailures(failed) {
-  for (const f of failed) {
+function logFailures(failed2) {
+  for (const f of failed2) {
     console.error(f.output);
   }
   console.error(`
-${failed.length} verify script(s) failed:`);
-  for (const f of failed) {
+${failed2.length} verify script(s) failed:`);
+  for (const f of failed2) {
     console.error(`  - ${f.script} (exit code ${f.code})`);
   }
 }
@@ -10300,9 +10300,9 @@ async function runVerifyQuietly() {
   const results = await Promise.all(
     result.verifyScripts.map((script) => runScript(script, packageDir))
   );
-  const failed = results.filter((r) => r.code !== 0);
-  if (failed.length > 0) {
-    logFailures(failed);
+  const failed2 = results.filter((r) => r.code !== 0);
+  if (failed2.length > 0) {
+    logFailures(failed2);
     return false;
   }
   return true;
@@ -12017,21 +12017,21 @@ function buildCommentBody(finding) {
 }
 function postFindings(findings) {
   let posted = 0;
-  let failed = 0;
+  let failed2 = 0;
   for (const finding of findings) {
     const body = buildCommentBody(finding);
     try {
       comment2(finding.file, finding.line, body, finding.startLine);
       posted++;
     } catch (error) {
-      failed++;
+      failed2++;
       const message = error instanceof Error ? error.message : String(error);
       console.error(
         `Failed to post comment on ${finding.file}:${finding.line}: ${message}`
       );
     }
   }
-  return { posted, failed };
+  return { posted, failed: failed2 };
 }
 
 // src/commands/review/submitPendingReview.ts
@@ -12386,6 +12386,61 @@ function skippedCodexResult(outputPath) {
   return { name: "codex", outputPath, exitCode: 0, stderr: "" };
 }
 
+// src/commands/review/formatReviewerFailure.ts
+var FAST_FAIL_MS = 1e3;
+var STDOUT_TAIL_LINES = 20;
+function indent(text) {
+  return text.split(/\r?\n/).map((line) => `  ${line}`);
+}
+function tailLines(text, maxLines) {
+  const lines = text.split(/\r?\n/);
+  return lines.length <= maxLines ? text : lines.slice(-maxLines).join("\n");
+}
+function isFastFail(input) {
+  return input.exitCode !== 0 && input.elapsedMs !== void 0 && input.elapsedMs < FAST_FAIL_MS;
+}
+function fastFailHint(command) {
+  return [
+    `${command} exited almost immediately \u2014 it likely failed to start.`,
+    `Common causes: not installed on PATH, not authenticated, or misconfigured.`,
+    `Try \`${command} --version\` to confirm install, then \`${command} login\` if authentication may be missing.`
+  ];
+}
+function outputDetail(input) {
+  const stderr = input.stderr.trim();
+  if (stderr) return ["stderr:", ...indent(stderr)];
+  const stdout = (input.stdout ?? "").trim();
+  if (stdout) {
+    return [
+      `stdout (no stderr was captured \u2014 showing last ${STDOUT_TAIL_LINES} lines):`,
+      ...indent(tailLines(stdout, STDOUT_TAIL_LINES))
+    ];
+  }
+  return [
+    "No stderr or stdout was captured. Check the review folder for partial output, or rerun with --verbose for full streaming output."
+  ];
+}
+function formatReviewerFailure(input) {
+  const command = input.command ?? input.name;
+  const seconds = Math.round((input.elapsedMs ?? 0) / 1e3);
+  const headerLine = `${command} CLI exited with code ${input.exitCode} after ${seconds}s`;
+  const detailLines = [];
+  if (isFastFail(input)) detailLines.push(...fastFailHint(command));
+  detailLines.push(...outputDetail(input));
+  return { headerLine, detailLines };
+}
+function printReviewerFailure(input) {
+  if (input.exitCode === 0) return;
+  const diagnostic = formatReviewerFailure(input);
+  console.error(`[${input.name}] ${diagnostic.headerLine}`);
+  for (const line of diagnostic.detailLines) console.error(line);
+}
+
+// src/commands/review/printReviewerFailures.ts
+function printReviewerFailures(results) {
+  for (const r of results) printReviewerFailure(r);
+}
+
 // src/commands/review/runAndSynthesise.ts
 import { existsSync as existsSync35, unlinkSync as unlinkSync12 } from "fs";
 
@@ -12450,26 +12505,26 @@ The review request is at: ${requestPath}
 `;
 }
 
-// src/commands/review/printReviewerFailures.ts
-function printReviewerFailures(results) {
-  for (const r of results) {
-    if (r.exitCode === 0) continue;
-    console.error(`[${r.name}] exited with code ${r.exitCode}`);
-    if (r.stderr) console.error(r.stderr.trim());
-  }
-}
-
 // src/commands/review/runClaudeReviewer.ts
 import { writeFileSync as writeFileSync27 } from "fs";
 
 // src/commands/review/finaliseReviewerSpinner.ts
-function finaliseReviewerSpinner(spinner, name, exitCode, elapsedMs) {
+var SUMMARY_MAX_LEN = 80;
+function summariseStderr(stderr) {
+  const firstLine = stderr.split(/\r?\n/).find((l) => l.trim().length > 0);
+  if (!firstLine) return "";
+  const trimmed = firstLine.trim();
+  return trimmed.length > SUMMARY_MAX_LEN ? `${trimmed.slice(0, SUMMARY_MAX_LEN - 1)}\u2026` : trimmed;
+}
+function finaliseReviewerSpinner(spinner, name, exitCode, elapsedMs, stderr = "") {
   const elapsed = Math.round(elapsedMs / 1e3);
   if (exitCode === 0) {
     spinner.succeed(`${name} \u2014 done in ${elapsed}s`);
     return;
   }
-  spinner.fail(`${name} \u2014 failed in ${elapsed}s`);
+  const summary = summariseStderr(stderr);
+  const suffix = summary ? `: ${summary}` : "";
+  spinner.fail(`${name} \u2014 failed in ${elapsed}s (exit ${exitCode})${suffix}`);
 }
 
 // src/commands/review/finaliseReviewerRun.ts
@@ -12479,13 +12534,17 @@ function finaliseReviewerRun(spec, spinner, result) {
       spinner,
       spec.name,
       result.exitCode,
-      result.elapsedMs
+      result.elapsedMs,
+      result.stderr
     );
   return {
     name: spec.name,
+    command: spec.command,
     outputPath: spec.outputPath,
     exitCode: result.exitCode,
-    stderr: result.stderr
+    stderr: result.stderr,
+    stdout: result.stdout,
+    elapsedMs: result.elapsedMs
   };
 }
 
@@ -12610,14 +12669,35 @@ function attachStderrCollector(child) {
   return state;
 }
 
+// src/commands/review/attachStdoutTail.ts
+function attachStdoutTail(child, maxBytes = 8192) {
+  const state = { value: "" };
+  child.stdout?.on("data", (chunk) => {
+    state.value += chunk.toString("utf-8");
+    if (state.value.length > maxBytes) {
+      state.value = state.value.slice(state.value.length - maxBytes);
+    }
+  });
+  return state;
+}
+
 // src/commands/review/logChildClose.ts
-function logChildClose(name, code, elapsedSeconds, stderr) {
-  if (code === 0) {
-    console.log(`[${name}] done in ${elapsedSeconds}s`);
+function logChildClose(args) {
+  const elapsedSeconds = Math.round(args.elapsedMs / 1e3);
+  if (args.exitCode === 0) {
+    console.log(`[${args.name}] done in ${elapsedSeconds}s`);
     return;
   }
-  console.error(`[${name}] exited with code ${code} in ${elapsedSeconds}s`);
-  if (stderr) console.error(stderr.trim());
+  const diagnostic = formatReviewerFailure({
+    name: args.name,
+    command: args.command,
+    exitCode: args.exitCode,
+    stderr: args.stderr,
+    stdout: args.stdout,
+    elapsedMs: args.elapsedMs
+  });
+  console.error(`[${args.name}] ${diagnostic.headerLine}`);
+  for (const line of diagnostic.detailLines) console.error(line);
 }
 
 // src/commands/review/handleChildClose.ts
@@ -12625,8 +12705,14 @@ function handleChildClose(args) {
   const elapsedMs = Date.now() - args.startedAt;
   const exitCode = args.code ?? 0;
   if (!args.quiet) {
-    const elapsed = Math.round(elapsedMs / 1e3);
-    logChildClose(args.name, exitCode, elapsed, args.stderr);
+    logChildClose({
+      name: args.name,
+      command: args.command,
+      exitCode,
+      elapsedMs,
+      stderr: args.stderr,
+      stdout: args.stdout
+    });
   }
   return { exitCode, elapsedMs };
 }
@@ -12644,6 +12730,7 @@ ${message}` : message;
   return {
     exitCode: 127,
     stderr,
+    stdout: ctx.stdout,
     elapsedMs: Date.now() - ctx.startedAt
   };
 }
@@ -12656,6 +12743,7 @@ function onErrorResult(ctx, err) {
       command: ctx.command,
       name: ctx.name,
       stderr: ctx.stderr.value,
+      stdout: ctx.stdout.value,
       startedAt: ctx.startedAt,
       quiet: ctx.quiet
     },
@@ -12668,10 +12756,12 @@ function onCloseResult(ctx, code) {
     code,
     startedAt: ctx.startedAt,
     name: ctx.name,
+    command: ctx.command,
     stderr: ctx.stderr.value,
+    stdout: ctx.stdout.value,
     quiet: ctx.quiet
   });
-  return { ...closed, stderr: ctx.stderr.value };
+  return { ...closed, stderr: ctx.stderr.value, stdout: ctx.stdout.value };
 }
 function waitForChildExit(ctx) {
   return new Promise((resolve15) => {
@@ -12698,21 +12788,24 @@ function writeStdinSafely(child, payload) {
 }
 function startChild(spec) {
   const child = spawn6(spec.command, spec.args, {
-    stdio: ["pipe", "pipe", "pipe"]
+    stdio: ["pipe", "pipe", "pipe"],
+    shell: process.platform === "win32"
   });
   const flushPending = attachLineParser(child, spec.onLine);
   const stderr = attachStderrCollector(child);
+  const stdout = attachStdoutTail(child);
   writeStdinSafely(child, spec.stdin);
-  return { child, flushPending, stderr };
+  return { child, flushPending, stderr, stdout };
 }
 function runStreamingChild(spec) {
   const startedAt = Date.now();
   if (!spec.quiet) console.log(`[${spec.name}] starting`);
-  const { child, flushPending, stderr } = startChild(spec);
+  const { child, flushPending, stderr, stdout } = startChild(spec);
   return waitForChildExit({
     child,
     flushPending,
     stderr,
+    stdout,
     name: spec.name,
     command: spec.command,
     startedAt,
@@ -12724,9 +12817,10 @@ function runStreamingChild(spec) {
 async function runClaudeReviewer(spec) {
   let finalText = "";
   const { spinner } = spec;
+  const command = "claude";
   const result = await runStreamingChild({
     name: spec.name,
-    command: "claude",
+    command,
     args: [
       "-p",
       "--add-dir",
@@ -12749,7 +12843,7 @@ async function runClaudeReviewer(spec) {
   });
   if (result.exitCode === 0 && finalText)
     writeFileSync27(spec.outputPath, finalText);
-  return finaliseReviewerRun(spec, spinner, result);
+  return finaliseReviewerRun({ ...spec, command }, spinner, result);
 }
 
 // src/commands/review/resolveClaude.ts
@@ -12807,9 +12901,10 @@ function codexArgs(reviewDir, outputPath) {
 }
 async function runCodexReviewer(spec) {
   const { spinner } = spec;
+  const command = "codex";
   const result = await runStreamingChild({
     name: spec.name,
-    command: "codex",
+    command,
     args: codexArgs(spec.reviewDir, spec.outputPath),
     stdin: spec.stdin,
     quiet: Boolean(spinner),
@@ -12822,7 +12917,7 @@ async function runCodexReviewer(spec) {
   if (result.exitCode !== 0 && existsSync34(spec.outputPath)) {
     unlinkSync11(spec.outputPath);
   }
-  return finaliseReviewerRun(spec, spinner, result);
+  return finaliseReviewerRun({ ...spec, command }, spinner, result);
 }
 
 // src/commands/review/resolveCodex.ts
@@ -12858,7 +12953,6 @@ async function runReviewers(reviewDir, claudePath, codexPath, stdinPrompt, optio
     multi: options2.multi
   });
   const results = await Promise.all([claudePromise, codexPromise]);
-  if (options2.multi) printReviewerFailures(results);
   const anyFresh = options2.cachedClaude === null || options2.codexPlan.kind !== "cached";
   return { results, anyFresh };
 }
@@ -12946,12 +13040,14 @@ async function synthesise(paths, options2) {
     outputPath: paths.synthesisPath,
     spinner
   });
-  if (multi) printReviewerFailures([result]);
   if (result.exitCode === 0) printSummary(paths.synthesisPath);
   return result;
 }
 
 // src/commands/review/runAndSynthesise.ts
+function failed(results) {
+  return results.filter((r) => r.exitCode !== 0);
+}
 async function runAndSynthesise(args) {
   const { paths, multi } = args;
   const { results, anyFresh } = await runReviewers(
@@ -12961,17 +13057,17 @@ async function runAndSynthesise(args) {
     buildReviewerStdin(paths.requestPath),
     { multi, codexPlan: args.codexPlan, cachedClaude: args.cachedClaude }
   );
+  const failures = failed(results);
   if (results.every((r) => r.exitCode !== 0)) {
-    console.error(
-      "Both reviewers failed; skipping synthesis. See review folder for stderr details."
-    );
-    return false;
+    console.error("Both reviewers failed; skipping synthesis.");
+    return { ok: false, failures };
   }
   if (anyFresh && existsSync35(paths.synthesisPath)) {
     unlinkSync12(paths.synthesisPath);
   }
   const synthesisResult = await synthesise(paths, { multi });
-  return synthesisResult.exitCode === 0;
+  if (synthesisResult.exitCode !== 0) failures.push(synthesisResult);
+  return { ok: synthesisResult.exitCode === 0, failures };
 }
 
 // src/commands/review/useSpinnerUi.ts
@@ -12994,19 +13090,25 @@ function finishUi(ui, ok) {
   if (ok) ui.elapsed.succeed(label2);
   else ui.elapsed.fail(label2);
 }
+function reportFailures(failures, usingSpinner) {
+  if (failures.length === 0) return;
+  if (!usingSpinner) return;
+  printReviewerFailures(failures);
+}
 async function runReviewPipeline(paths, options2) {
   const cachedClaude = cachedReviewerResult("claude", paths.claudePath);
   const codexPlan = await planCodexReviewer(paths.codexPath);
   const ui = createUi(useSpinnerUi(options2.verbose));
   try {
-    const ok = await runAndSynthesise({
+    const outcome = await runAndSynthesise({
       paths,
       cachedClaude,
       codexPlan,
       multi: ui.multi
     });
-    finishUi(ui, ok);
-    return ok;
+    finishUi(ui, outcome.ok);
+    reportFailures(outcome.failures, ui.multi !== void 0);
+    return outcome.ok;
   } catch (err) {
     ui.multi?.failRemaining();
     throw err;
@@ -15646,9 +15748,9 @@ async function summarise3(options2) {
       `Summarising ${toProcess.length} session(s) (${files.length} total)\u2026`
     )
   );
-  const { succeeded, failed } = processSessions(toProcess);
+  const { succeeded, failed: failed2 } = processSessions(toProcess);
   console.log(
-    chalk145.green(`Done: ${succeeded} summarised`) + (failed > 0 ? chalk145.yellow(`, ${failed} skipped`) : "")
+    chalk145.green(`Done: ${succeeded} summarised`) + (failed2 > 0 ? chalk145.yellow(`, ${failed2} skipped`) : "")
   );
 }
 function selectCandidates(files, options2) {
@@ -15665,7 +15767,7 @@ function selectCandidates(files, options2) {
 }
 function processSessions(files) {
   let succeeded = 0;
-  let failed = 0;
+  let failed2 = 0;
   for (let i = 0; i < files.length; i++) {
     const file = files[i];
     process.stdout.write(chalk145.dim(`  [${i + 1}/${files.length}] `));
@@ -15676,12 +15778,12 @@ function processSessions(files) {
       process.stdout.write(`${chalk145.green("\u2713")} ${summary}
 `);
     } else {
-      failed++;
+      failed2++;
       process.stdout.write(` ${chalk145.yellow("skip")}
 `);
     }
   }
-  return { succeeded, failed };
+  return { succeeded, failed: failed2 };
 }
 
 // src/commands/sessions/registerSessions.ts

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@staff0rd/assist",
-	"version": "0.220.1",
+	"version": "0.220.2",
 	"type": "module",
 	"main": "dist/index.js",
 	"bin": {