@staff0rd/assist 0.218.0 → 0.219.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist/index.js +38 -4
- package/package.json +1 -1
package/dist/index.js
CHANGED
|
@@ -6,7 +6,7 @@ import { Command } from "commander";
|
|
|
6
6
|
// package.json
|
|
7
7
|
var package_default = {
|
|
8
8
|
name: "@staff0rd/assist",
|
|
9
|
-
version: "0.
|
|
9
|
+
version: "0.219.0",
|
|
10
10
|
type: "module",
|
|
11
11
|
main: "dist/index.js",
|
|
12
12
|
bin: {
|
|
@@ -12206,12 +12206,46 @@ async function runApplySession(synthesisPath) {
|
|
|
12206
12206
|
import { existsSync as existsSync35, unlinkSync as unlinkSync12 } from "fs";
|
|
12207
12207
|
|
|
12208
12208
|
// src/commands/review/buildReviewerStdin.ts
|
|
12209
|
-
var REVIEW_PROMPT = `You are
|
|
12209
|
+
var REVIEW_PROMPT = `You are acting as a reviewer for a proposed code change made by another engineer. The full review request \u2014 branch, base, changed files, and unified diff \u2014 is in request.md in the current working directory.
|
|
12210
12210
|
|
|
12211
|
-
Read request.md, then produce a thorough code review in Markdown.
|
|
12211
|
+
Read request.md, then produce a thorough code review in Markdown.
|
|
12212
|
+
|
|
12213
|
+
## When to flag a finding
|
|
12214
|
+
|
|
12215
|
+
A finding is worth raising only if all of the following hold:
|
|
12216
|
+
|
|
12217
|
+
1. It meaningfully impacts the accuracy, performance, security, or maintainability of the code.
|
|
12218
|
+
2. The issue is discrete and actionable \u2014 not a vague observation about the codebase or a tangle of several things.
|
|
12219
|
+
3. Fixing it does not demand more rigour than the rest of the codebase already shows (e.g. don't ask for exhaustive input validation in a repo of one-off scripts).
|
|
12220
|
+
4. The issue was introduced by this change. Do not flag pre-existing bugs.
|
|
12221
|
+
5. The original author would likely fix it if made aware.
|
|
12222
|
+
6. It does not rely on unstated assumptions about the codebase or author's intent.
|
|
12223
|
+
7. You can name the concretely affected code path. Speculation that a change *might* disrupt something elsewhere is not enough \u2014 identify the other code that is provably affected.
|
|
12224
|
+
8. It is clearly not an intentional change by the author.
|
|
12225
|
+
|
|
12226
|
+
## How to write the comment (Impact + Recommendation)
|
|
12227
|
+
|
|
12228
|
+
1. Make clear *why* the issue is a bug.
|
|
12229
|
+
2. Communicate severity accurately \u2014 do not inflate.
|
|
12230
|
+
3. Keep it brief: at most one paragraph of prose. Avoid line breaks inside the natural-language flow unless needed for a code fragment.
|
|
12231
|
+
4. Do not paste code chunks longer than 3 lines. Wrap short snippets in inline code or a fenced block.
|
|
12232
|
+
5. State explicitly the scenarios, environments, or inputs needed for the bug to manifest \u2014 and signal up front that severity depends on those factors.
|
|
12233
|
+
6. Tone is matter-of-fact: not accusatory, not gushing. Read as a helpful assistant, not a performative human reviewer.
|
|
12234
|
+
7. Write so the author grasps the point on first read.
|
|
12235
|
+
8. Avoid flattery and filler ("Great job\u2026", "Thanks for\u2026"). They are not useful to the author.
|
|
12236
|
+
|
|
12237
|
+
Ignore trivial style unless it obscures meaning or violates a documented standard. One finding per distinct issue.
|
|
12238
|
+
|
|
12239
|
+
## How many findings to return
|
|
12240
|
+
|
|
12241
|
+
List every finding that the original author would want to know about and fix. Do not stop at the first qualifying one. If nothing clears the bar above, return no findings \u2014 empty is better than padded.
|
|
12242
|
+
|
|
12243
|
+
## Output format
|
|
12244
|
+
|
|
12245
|
+
For each finding include:
|
|
12212
12246
|
- Severity (blocker, major, minor, nit) \u2014 see rubric below
|
|
12213
12247
|
- File and line (e.g. \`src/foo.ts:42\`) when the finding is tied to a specific location
|
|
12214
|
-
- Impact: what could go wrong
|
|
12248
|
+
- Impact: what could go wrong, including the conditions under which it manifests
|
|
12215
12249
|
- Recommendation: a concrete change
|
|
12216
12250
|
|
|
12217
12251
|
Severity rubric:
|