npm - @staff0rd/assist - Versions diffs - 0.214.1 → 0.215.1 - Mend

@staff0rd/assist 0.214.1 → 0.215.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (3) hide show

package/README.md CHANGED Viewed

@@ -88,7 +88,7 @@ After installation, the `assist` command will be available globally. You can als
 - `assist prs fixed <comment-id> <sha>` - Reply with commit link and resolve thread
 - `assist prs wontfix <comment-id> <reason>` - Reply with reason and resolve thread
 - `assist prs comment <path> <line> <body>` - Add a line comment to the pending review
-- `assist review [--no-prompt] [--submit] [--force] [--refine] [--verbose]` - Run Claude and Codex in parallel to review the open PR for the current branch. The diff is fetched from GitHub (base SHA → head SHA via `gh pr diff`), so stale local base branches don't pollute the review; fails fast if no PR is open. By default, prompts before posting line-bound comments and then prompts again to submit the pending review (defaulting to no). Cached `claude.md` / `codex.md` / `synthesis.md` are reused when present; if any reviewer is re-run, the synthesis is invalidated. `--no-prompt` skips all confirmations. `--submit` defaults the submit prompt to yes (or auto-submits when combined with `--no-prompt`). `--force` clears all cached files and re-runs every phase. `--refine` skips posting and instead launches an interactive Claude session that walks through `synthesis.md` and edits it in place; a subsequent `assist review` (no flag) reuses the refined file and posts only the surviving findings. `--verbose` disables the stacked-spinner UI and falls back to per-line log output (per-tool lines, starting/done lines); non-TTY environments (CI) automatically fall back to verbose-style output
+- `assist review [--no-prompt] [--submit] [--force] [--refine] [--apply] [--verbose]` - Run Claude and Codex in parallel to review the open PR for the current branch. The diff is fetched from GitHub (base SHA → head SHA via `gh pr diff`), so stale local base branches don't pollute the review; fails fast if no PR is open. By default, prompts before posting line-bound comments and then prompts again to submit the pending review (defaulting to no). Cached `claude.md` / `codex.md` / `synthesis.md` are reused when present; if any reviewer is re-run, the synthesis is invalidated. `--no-prompt` skips all confirmations. `--submit` defaults the submit prompt to yes (or auto-submits when combined with `--no-prompt`). `--force` clears all cached files and re-runs every phase. `--refine` skips posting and instead launches an interactive Claude session that walks through `synthesis.md` and edits it in place; a subsequent `assist review` (no flag) reuses the refined file and posts only the surviving findings. `--apply` skips posting and instead launches an interactive Claude session that walks through each remaining finding asking apply/skip; applied findings have their code fix made in the working tree (unstaged) and are removed from `synthesis.md`, while skipped findings stay so a subsequent `assist review` posts them. `--apply` cannot be combined with `--refine`. `--verbose` disables the stacked-spinner UI and falls back to per-line log output (per-tool lines, starting/done lines); non-TTY environments (CI) automatically fall back to verbose-style output
 - `assist news` - Start the news web UI showing latest RSS feed items (same as `news web`)
 - `assist news add [url]` - Add an RSS feed URL to the config
 - `assist news web [-p, --port <number>]` - Start a web view of the news feeds (default port 3001)

package/dist/index.js CHANGED Viewed

@@ -6,7 +6,7 @@ import { Command } from "commander";
 // package.json
 var package_default = {
   name: "@staff0rd/assist",
-  version: "0.214.1",
+  version: "0.215.1",
   type: "module",
   main: "dist/index.js",
   bin: {
@@ -10247,7 +10247,7 @@ async function check(pattern2, options2) {
 }
 // src/commands/refactor/extract/index.ts
-import path36 from "path";
+import path37 from "path";
 import chalk120 from "chalk";
 // src/commands/refactor/extract/applyExtraction.ts
@@ -10844,35 +10844,63 @@ function displayPlan(functionName, relDest, plan2, cwd) {
 }
 // src/commands/refactor/extract/loadProjectFile.ts
+import path36 from "path";
+import chalk119 from "chalk";
+import { Project as Project3 } from "ts-morph";
+// src/commands/refactor/extract/findTsConfig.ts
 import fs19 from "fs";
 import path35 from "path";
-import chalk119 from "chalk";
 import { Project as Project2 } from "ts-morph";
 function findTsConfig(sourcePath) {
   const rootConfig = path35.resolve("tsconfig.json");
   if (!fs19.existsSync(rootConfig)) return rootConfig;
-  const raw = fs19.readFileSync(rootConfig, "utf-8");
+  const tried = /* @__PURE__ */ new Set();
+  const candidates = [rootConfig, ...readReferences(rootConfig)];
+  for (const candidate of candidates) {
+    if (tried.has(candidate)) continue;
+    tried.add(candidate);
+    if (projectIncludes(candidate, sourcePath)) return candidate;
+  }
+  const siblings = fs19.readdirSync(path35.dirname(rootConfig)).filter((f) => /^tsconfig.*\.json$/.test(f)).map((f) => path35.resolve(path35.dirname(rootConfig), f));
+  for (const sibling of siblings) {
+    if (tried.has(sibling)) continue;
+    tried.add(sibling);
+    if (projectIncludes(sibling, sourcePath)) return sibling;
+  }
+  return rootConfig;
+}
+function readReferences(configPath) {
+  if (!fs19.existsSync(configPath)) return [];
+  const raw = fs19.readFileSync(configPath, "utf-8");
   const stripped = raw.replace(/\/\/.*$/gm, "").replace(/\/\*[\s\S]*?\*\//g, "");
   let parsed;
   try {
     parsed = JSON.parse(stripped);
   } catch {
-    return rootConfig;
+    return [];
   }
-  if (!parsed.references?.length) return rootConfig;
-  for (const ref of parsed.references) {
-    const refPath = path35.resolve(ref.path);
-    const configPath = fs19.statSync(refPath, { throwIfNoEntry: false })?.isDirectory() ? path35.join(refPath, "tsconfig.json") : refPath;
-    if (!fs19.existsSync(configPath)) continue;
+  if (!parsed.references?.length) return [];
+  const cwd = path35.dirname(configPath);
+  return parsed.references.map((ref) => {
+    const refPath = path35.resolve(cwd, ref.path);
+    return fs19.statSync(refPath, { throwIfNoEntry: false })?.isDirectory() ? path35.join(refPath, "tsconfig.json") : refPath;
+  }).filter((p) => fs19.existsSync(p));
+}
+function projectIncludes(configPath, sourcePath) {
+  try {
     const project = new Project2({ tsConfigFilePath: configPath });
-    if (project.getSourceFile(sourcePath)) return configPath;
+    return !!project.getSourceFile(sourcePath);
+  } catch {
+    return false;
   }
-  return rootConfig;
 }
+// src/commands/refactor/extract/loadProjectFile.ts
 function loadProjectFile(file) {
-  const sourcePath = path35.resolve(file);
+  const sourcePath = path36.resolve(file);
   const tsConfigPath = findTsConfig(sourcePath);
-  const project = new Project2({
+  const project = new Project3({
     tsConfigFilePath: tsConfigPath
   });
   const sourceFile = project.getSourceFile(sourcePath);
@@ -10885,10 +10913,10 @@ function loadProjectFile(file) {
 // src/commands/refactor/extract/index.ts
 async function extract(file, functionName, destination, options2 = {}) {
-  const sourcePath = path36.resolve(file);
-  const destPath = path36.resolve(destination);
+  const sourcePath = path37.resolve(file);
+  const destPath = path37.resolve(destination);
   const cwd = process.cwd();
-  const relDest = path36.relative(cwd, destPath);
+  const relDest = path37.relative(cwd, destPath);
   const { project, sourceFile } = loadProjectFile(file);
   const plan2 = buildPlan(
     functionName,
@@ -10935,13 +10963,13 @@ function ignore(file) {
 }
 // src/commands/refactor/rename/index.ts
-import path37 from "path";
+import path38 from "path";
 import chalk122 from "chalk";
 async function rename(source, destination, options2 = {}) {
-  const destPath = path37.resolve(destination);
+  const destPath = path38.resolve(destination);
   const cwd = process.cwd();
-  const relSource = path37.relative(cwd, path37.resolve(source));
-  const relDest = path37.relative(cwd, destPath);
+  const relSource = path38.relative(cwd, path38.resolve(source));
+  const relDest = path38.relative(cwd, destPath);
   const { project, sourceFile } = loadProjectFile(source);
   console.log(chalk122.bold(`Rename: ${relSource} \u2192 ${relDest}`));
   if (options2.apply) {
@@ -10954,9 +10982,7 @@ async function rename(source, destination, options2 = {}) {
 }
 // src/commands/refactor/renameSymbol/index.ts
-import path39 from "path";
 import chalk123 from "chalk";
-import { Project as Project3 } from "ts-morph";
 // src/commands/refactor/renameSymbol/findSymbol.ts
 import { SyntaxKind as SyntaxKind13 } from "ts-morph";
@@ -10983,12 +11009,12 @@ function findSymbol(sourceFile, symbolName) {
 }
 // src/commands/refactor/renameSymbol/groupReferences.ts
-import path38 from "path";
+import path39 from "path";
 function groupReferences(symbol, cwd) {
   const refs = symbol.findReferencesAsNodes();
   const grouped = /* @__PURE__ */ new Map();
   for (const ref of refs) {
-    const refFile = path38.relative(cwd, ref.getSourceFile().getFilePath());
+    const refFile = path39.relative(cwd, ref.getSourceFile().getFilePath());
     const lines = grouped.get(refFile) ?? [];
     if (!grouped.has(refFile)) grouped.set(refFile, lines);
     lines.push(ref.getStartLineNumber());
@@ -10998,15 +11024,8 @@ function groupReferences(symbol, cwd) {
 // src/commands/refactor/renameSymbol/index.ts
 async function renameSymbol(file, oldName, newName, options2 = {}) {
-  const filePath = path39.resolve(file);
-  const tsConfigPath = path39.resolve("tsconfig.json");
   const cwd = process.cwd();
-  const project = new Project3({ tsConfigFilePath: tsConfigPath });
-  const sourceFile = project.getSourceFile(filePath);
-  if (!sourceFile) {
-    console.log(chalk123.red(`File not found in project: ${file}`));
-    process.exit(1);
-  }
+  const { project, sourceFile } = loadProjectFile(file);
   const symbol = findSymbol(sourceFile, oldName);
   if (!symbol) {
     console.log(chalk123.red(`Symbol "${oldName}" not found in ${file}`));
@@ -12081,6 +12100,41 @@ function prepareReviewDir(paths, requestBody, force) {
   writeFileSync26(paths.requestPath, requestBody);
 }
+// src/commands/review/runApplySession.ts
+function buildApplyPrompt(synthesisPath) {
+  return `You are helping the user apply fixes for a code review with each finding decided one at a time.
+Read ${synthesisPath}. It contains a list of findings under the \`## Findings\` heading. Each finding is a block in this exact format:
+### Finding: <short title>
+- Severity: blocker | major | minor | nit
+- Source: confirmed | disputed | claude-only | codex-only | already-raised
+- Location: \`path/to/file.ext:LINE\` or \`n/a\` when not tied to a specific line
+- Impact: one sentence on what could go wrong
+- Recommendation: one or two sentences with a concrete change
+For every finding whose Source is NOT \`already-raised\`, walk through it with the user one at a time:
+1. Read the referenced file/lines (use the Location field) and any nearby code needed to understand the impact.
+2. Present a short assessment (one or two sentences) of whether the finding is real and what the right fix is.
+3. Ask the user: apply or skip?
+   - On 'apply': edit the relevant file(s) in place to fix the issue, then remove that finding's entire \`### Finding:\` block from ${synthesisPath} (including any blank line that separated it from the next block).
+   - On 'skip': leave the finding block in ${synthesisPath} unchanged and move on.
+Skip findings whose Source is \`already-raised\` entirely \u2014 do not present them and do not remove them from ${synthesisPath}.
+Important constraints:
+- Do not stage, commit, or push any changes. Leave all code edits unstaged in the working tree.
+- Do not post anything to a PR.
+- Only modify ${synthesisPath} by removing the blocks for findings the user chose to apply. Do not edit the wording of any remaining finding block.
+- When every non-already-raised finding has been decided, briefly summarise what was applied vs skipped and exit.`;
+}
+async function runApplySession(synthesisPath) {
+  const { done: done2 } = spawnClaude(buildApplyPrompt(synthesisPath), {
+    allowEdits: true
+  });
+  await done2;
+}
 // src/commands/review/runReviewPipeline.ts
 import { existsSync as existsSync35, unlinkSync as unlinkSync12 } from "fs";
@@ -12718,38 +12772,52 @@ function resolveRepoRoot() {
   console.error("Error: not inside a git repository.");
   process.exit(1);
 }
+function validateOptions(options2) {
+  if (options2.apply && options2.refine) {
+    console.error("Error: --apply cannot be combined with --refine.");
+    process.exit(1);
+  }
+}
 function logPriorComments(count) {
   if (count === 0) return;
   console.log(`Including ${count} prior review comment(s) in request.md.`);
 }
-async function review(options2 = {}) {
-  const repoRoot = resolveRepoRoot();
+function gatherChangedContext() {
   const context = gatherContext();
-  if (context.changedFiles.length === 0) {
-    console.error(
-      `Error: PR #${context.prNumber} has no changed files \u2014 nothing to review.`
-    );
-    process.exit(1);
-  }
+  if (context.changedFiles.length > 0) return context;
+  console.error(
+    `Error: PR #${context.prNumber} has no changed files \u2014 nothing to review.`
+  );
+  process.exit(1);
+}
+function setupReviewDir(repoRoot, context, force) {
   const paths = buildReviewPaths(repoRoot, context.branch, context.shortSha);
   const priorComments = fetchExistingComments();
   logPriorComments(priorComments?.length ?? 0);
-  prepareReviewDir(
-    paths,
-    buildRequest(context, priorComments),
-    options2.force ?? false
-  );
+  prepareReviewDir(paths, buildRequest(context, priorComments), force);
   console.log(`Review folder: ${paths.reviewDir}`);
+  return paths;
+}
+async function runPostSynthesis(synthesisPath, options2) {
+  if (options2.apply) {
+    await runApplySession(synthesisPath);
+    return;
+  }
+  await handlePostSynthesis(synthesisPath, {
+    refine: options2.refine ?? false,
+    prompt: options2.prompt ?? true,
+    submit: options2.submit ?? false
+  });
+}
+async function review(options2 = {}) {
+  validateOptions(options2);
+  const repoRoot = resolveRepoRoot();
+  const context = gatherChangedContext();
+  const paths = setupReviewDir(repoRoot, context, options2.force ?? false);
   const synthesisOk = await runReviewPipeline(paths, {
     verbose: options2.verbose ?? false
   });
-  if (synthesisOk) {
-    await handlePostSynthesis(paths.synthesisPath, {
-      refine: options2.refine ?? false,
-      prompt: options2.prompt ?? true,
-      submit: options2.submit ?? false
-    });
-  }
+  if (synthesisOk) await runPostSynthesis(paths.synthesisPath, options2);
   console.log(`Done. Review folder: ${paths.reviewDir}`);
 }
@@ -12769,6 +12837,9 @@ function registerReview(program2) {
   ).option(
     "--refine",
     "After synthesis, launch an interactive Claude session to walk through findings instead of posting"
+  ).option(
+    "--apply",
+    "After synthesis, launch an interactive Claude session to apply fixes for each finding; applied findings are removed from synthesis, skipped ones remain for a later post"
   ).option(
     "--verbose",
     "Disable spinner UI and use per-line log output (per-tool lines, starting/done lines)"

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
 	"name": "@staff0rd/assist",
-	"version": "0.214.1",
+	"version": "0.215.1",
 	"type": "module",
 	"main": "dist/index.js",
 	"bin": {