@staff0rd/assist 0.214.0 → 0.214.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist/index.js +18 -2
- package/package.json +1 -1
package/dist/index.js
CHANGED
|
@@ -6,7 +6,7 @@ import { Command } from "commander";
|
|
|
6
6
|
// package.json
|
|
7
7
|
var package_default = {
|
|
8
8
|
name: "@staff0rd/assist",
|
|
9
|
-
version: "0.214.
|
|
9
|
+
version: "0.214.1",
|
|
10
10
|
type: "module",
|
|
11
11
|
main: "dist/index.js",
|
|
12
12
|
bin: {
|
|
@@ -12088,11 +12088,19 @@ import { existsSync as existsSync35, unlinkSync as unlinkSync12 } from "fs";
|
|
|
12088
12088
|
var REVIEW_PROMPT = `You are reviewing a code change. The full review request \u2014 branch, base, changed files, and unified diff \u2014 is in request.md in the current working directory.
|
|
12089
12089
|
|
|
12090
12090
|
Read request.md, then produce a thorough code review in Markdown. For each finding include:
|
|
12091
|
-
- Severity (blocker, major, minor, nit)
|
|
12091
|
+
- Severity (blocker, major, minor, nit) \u2014 see rubric below
|
|
12092
12092
|
- File and line (e.g. \`src/foo.ts:42\`) when the finding is tied to a specific location
|
|
12093
12093
|
- Impact: what could go wrong
|
|
12094
12094
|
- Recommendation: a concrete change
|
|
12095
12095
|
|
|
12096
|
+
Severity rubric:
|
|
12097
|
+
- **blocker** \u2014 ships broken behaviour: crash, data loss, security hole, breaks the build or existing tests, or violates a stated requirement.
|
|
12098
|
+
- **major** \u2014 likely bug, missing error handling on a real failure mode, or a regression in existing behaviour. Not "this could be cleaner" or "this might be slow."
|
|
12099
|
+
- **minor** \u2014 narrow correctness or clarity issue with limited blast radius; worth fixing but not urgent.
|
|
12100
|
+
- **nit** \u2014 style, naming, micro-refactors, comment wording; reviewer would not block on it.
|
|
12101
|
+
|
|
12102
|
+
Default to the lower tier when uncertain. Code-style preferences, refactor suggestions, and "I would have written it differently" belong in nit \u2014 not major. A finding is only major if you can name a concrete failure mode or regression.
|
|
12103
|
+
|
|
12096
12104
|
Group findings by severity. If you have no findings in a category, omit it. End with a short overall summary.
|
|
12097
12105
|
|
|
12098
12106
|
Output only the review Markdown. Do not include any preamble or commentary about the process.`;
|
|
@@ -12592,6 +12600,14 @@ For each finding, emit one block in this exact format:
|
|
|
12592
12600
|
- Impact: one sentence on what could go wrong
|
|
12593
12601
|
- Recommendation: one or two sentences with a concrete change
|
|
12594
12602
|
|
|
12603
|
+
Severity rubric (recalibrate each finding against this \u2014 reviewers tend to inflate):
|
|
12604
|
+
- **blocker** \u2014 ships broken behaviour: crash, data loss, security hole, breaks the build or existing tests, or violates a stated requirement.
|
|
12605
|
+
- **major** \u2014 likely bug, missing error handling on a real failure mode, or a regression in existing behaviour. Not "this could be cleaner" or "this might be slow."
|
|
12606
|
+
- **minor** \u2014 narrow correctness or clarity issue with limited blast radius; worth fixing but not urgent.
|
|
12607
|
+
- **nit** \u2014 style, naming, micro-refactors, comment wording; reviewer would not block on it.
|
|
12608
|
+
|
|
12609
|
+
Default to the lower tier when uncertain. Code-style preferences, refactor suggestions, and "I would have written it differently" belong in nit \u2014 not major. A finding is only major if you can name a concrete failure mode or regression. If a reviewer marked something major but the impact reads as taste or hypothetical, downgrade it.
|
|
12610
|
+
|
|
12595
12611
|
Rules:
|
|
12596
12612
|
- \`confirmed\` = both reviewers raised it.
|
|
12597
12613
|
- \`disputed\` = the reviewers disagreed on the diagnosis or fix.
|