@staff0rd/assist 0.147.1 → 0.147.3

package/claude/commands/test-cover.md

@@ -51,7 +51,7 @@ Use a behavioural, BDD-style structure:
 
 - **Outer `describe`** — the function or module under test
 - **Inner `describe("when ...")`** — groups tests that share the same setup/scenario
-- **`it("should ...")`** — asserts a single rule or behaviour
+- **`it("should ...")`** — asserts a single rule or behaviour. State specifiers (flags, syntax variants, conditions) belong in `when` blocks, never in `it` descriptions — keep assertions as bare outcomes (e.g. "should allow", "should reject")
 
 Each test follows an **Arrange, Act, Assert** pattern. Do NOT add `// arrange`, `// act`, `// assert` comments — just structure the code in that order with whitespace separating the three sections.
 

package/claude/commands/test-review.md

@@ -35,7 +35,7 @@ Assess each test file against these criteria:
 ### BDD structure and Arrange-Act-Assert
 - Does the outer `describe` name the function or module under test?
 - Do inner `describe("when ...")` blocks group tests by shared setup/scenario?
-- Do `it` blocks use `should` phrasing (e.g., `it("should return empty array when no matches")`)?
+- Do `it` blocks use `should` phrasing with bare outcomes (e.g., `it("should allow")`, `it("should reject")`)? State specifiers (flags, syntax variants, conditions) belong in `when` blocks, never in `it` descriptions.
 - Does each test follow Arrange, Act, Assert ordering (without comments labelling the sections)?
 - Are assertions minimal per test — ideally one, at most two closely related? If multiple things are asserted about the same action, are they split into separate `it` blocks under the same `describe("when ...")`?
 

package/dist/index.js

@@ -6,7 +6,7 @@ import { Command } from "commander";
 // package.json
 var package_default = {
   name: "@staff0rd/assist",
-  version: "0.147.1",
+  version: "0.147.3",
   type: "module",
   main: "dist/index.js",
   bin: {
@@ -2608,7 +2608,7 @@ async function list2(options2) {
 
 // src/commands/backlog/next.ts
 import chalk36 from "chalk";
-import enquirer7 from "enquirer";
+import enquirer6 from "enquirer";
 
 // src/commands/backlog/run.ts
 import chalk35 from "chalk";
@@ -2714,10 +2714,8 @@ function buildReviewPhase() {
 import chalk34 from "chalk";
 
 // src/commands/backlog/resolvePhaseResult.ts
-import { spawnSync as spawnSync2 } from "child_process";
 import { existsSync as existsSync16, unlinkSync as unlinkSync3 } from "fs";
 import chalk33 from "chalk";
-import enquirer6 from "enquirer";
 
 // src/commands/backlog/handleIncompletePhase.ts
 import enquirer5 from "enquirer";
@@ -2756,19 +2754,6 @@ function phaseDone(id, phase) {
   console.log(chalk32.green(`Phase ${phase} of item #${id} marked as complete.`));
 }
 
-// src/commands/backlog/spawnClaude.ts
-import { spawn as spawn3 } from "child_process";
-function spawnClaude(prompt) {
-  const child = spawn3("claude", [prompt], {
-    stdio: "inherit"
-  });
-  const done2 = new Promise((resolve7, reject) => {
-    child.on("close", (code) => resolve7(code ?? 0));
-    child.on("error", reject);
-  });
-  return { child, done: done2 };
-}
-
 // src/commands/backlog/resolvePhaseResult.ts
 function cleanupMarker() {
   const statusPath = getPhaseStatusPath();
@@ -2776,56 +2761,29 @@ function cleanupMarker() {
     unlinkSync3(statusPath);
   }
 }
-function runVerify() {
-  const result = spawnSync2("assist", ["verify"], {
-    stdio: "inherit",
-    shell: true
-  });
-  return result.status === 0;
-}
-async function handleCompletedPhase(phaseIndex) {
-  cleanupMarker();
-  console.log(
-    chalk33.green(`
-Phase ${phaseIndex + 1} completed. Running verify...`)
-  );
-  if (runVerify()) {
-    console.log(chalk33.green("Verification passed."));
-    return true;
-  }
-  while (true) {
-    const { action } = await enquirer6.prompt({
-      type: "select",
-      name: "action",
-      message: "Verification failed. What would you like to do?",
-      choices: ["Fix", "Continue to next phase", "Abort"]
-    });
-    if (action === "Fix") {
-      const { done: done2 } = spawnClaude(
-        "Run /verify and fix all failures. Do not move on until every check passes."
-      );
-      await done2;
-      if (runVerify()) {
-        console.log(chalk33.green("Verification passed."));
-        return true;
-      }
-      continue;
-    }
-    return action === "Continue to next phase";
-  }
-}
-async function resolvePhaseResult(phaseIndex, options2) {
+async function resolvePhaseResult(phaseIndex) {
   if (!existsSync16(getPhaseStatusPath())) {
     const action = await handleIncompletePhase();
     if (action === "abort") return -1;
     return action === "skip" ? 1 : 0;
   }
-  if (options2?.skipVerify) {
-    cleanupMarker();
-    return 1;
-  }
-  const shouldContinue = await handleCompletedPhase(phaseIndex);
-  return shouldContinue ? 1 : -1;
+  cleanupMarker();
+  console.log(chalk33.green(`
+Phase ${phaseIndex + 1} completed.`));
+  return 1;
+}
+
+// src/commands/backlog/spawnClaude.ts
+import { spawn as spawn3 } from "child_process";
+function spawnClaude(prompt) {
+  const child = spawn3("claude", [prompt], {
+    stdio: "inherit"
+  });
+  const done2 = new Promise((resolve7, reject) => {
+    child.on("close", (code) => resolve7(code ?? 0));
+    child.on("error", reject);
+  });
+  return { child, done: done2 };
 }
 
 // src/commands/backlog/watchForMarker.ts
@@ -2844,7 +2802,7 @@ function stopWatching() {
 }
 
 // src/commands/backlog/executePhase.ts
-async function executePhase(item, phaseIndex, phases, options2) {
+async function executePhase(item, phaseIndex, phases) {
   const phase = phases[phaseIndex];
   console.log(
     chalk34.bold(
@@ -2859,9 +2817,7 @@ async function executePhase(item, phaseIndex, phases, options2) {
   watchForMarker(child);
   await done2;
   stopWatching();
-  const delta = await resolvePhaseResult(phaseIndex, {
-    skipVerify: options2?.skipVerify
-  });
+  const delta = await resolvePhaseResult(phaseIndex);
   return delta < 0 ? -1 : phaseIndex + delta;
 }
 
@@ -2911,9 +2867,7 @@ async function run2(id) {
   const reviewPhase = buildReviewPhase();
   const allPhases = [...plan2, reviewPhase];
   const reviewIndex = plan2.length;
-  const reviewResult = await executePhase(item, reviewIndex, allPhases, {
-    skipVerify: true
-  });
+  const reviewResult = await executePhase(item, reviewIndex, allPhases);
   if (reviewResult < 0) return;
   if (item.status !== "done") setStatus(id, "done");
   console.log(chalk35.green(`
@@ -2943,7 +2897,7 @@ async function next() {
     name: `${typeLabel(i.type)} #${i.id}: ${i.name}`,
     value: String(i.id)
   }));
-  const { selected } = await enquirer7.prompt({
+  const { selected } = await enquirer6.prompt({
     type: "select",
     name: "selected",
     message: "Choose a backlog item to start:",
@@ -5755,10 +5709,10 @@ function registerJira(program2) {
 
 // src/commands/news/add/index.ts
 import chalk68 from "chalk";
-import enquirer8 from "enquirer";
+import enquirer7 from "enquirer";
 async function add2(url) {
   if (!url) {
-    const response = await enquirer8.prompt({
+    const response = await enquirer7.prompt({
       type: "input",
       name: "url",
       message: "RSS feed URL:",
@@ -5978,7 +5932,7 @@ function registerNews(program2) {
 }
 
 // src/commands/prs/comment.ts
-import { spawnSync as spawnSync3 } from "child_process";
+import { spawnSync as spawnSync2 } from "child_process";
 import { unlinkSync as unlinkSync5, writeFileSync as writeFileSync19 } from "fs";
 import { tmpdir as tmpdir3 } from "os";
 import { join as join20 } from "path";
@@ -6056,7 +6010,7 @@ function comment(path49, line, body) {
     const queryFile = join20(tmpdir3(), `gh-query-${Date.now()}.graphql`);
     writeFileSync19(queryFile, MUTATION);
     try {
-      const result = spawnSync3(
+      const result = spawnSync2(
         "gh",
         [
           "api",
@@ -6394,7 +6348,7 @@ async function listComments() {
 import { execSync as execSync30 } from "child_process";
 
 // src/commands/prs/prs/displayPaginated/index.ts
-import enquirer9 from "enquirer";
+import enquirer8 from "enquirer";
 
 // src/commands/prs/prs/displayPaginated/printPr.ts
 import chalk71 from "chalk";
@@ -6464,7 +6418,7 @@ function parseAction(action) {
 }
 async function promptNavigation(currentPage, totalPages) {
   const choices = buildNavChoices(currentPage, totalPages);
-  const { action } = await enquirer9.prompt({
+  const { action } = await enquirer8.prompt({
     type: "select",
     name: "action",
     message: "Navigate",
@@ -9346,7 +9300,7 @@ function registerVerify(program2) {
 }
 
 // src/commands/voice/devices.ts
-import { spawnSync as spawnSync4 } from "child_process";
+import { spawnSync as spawnSync3 } from "child_process";
 import { join as join32 } from "path";
 
 // src/commands/voice/shared.ts
@@ -9379,7 +9333,7 @@ function getLockFile() {
 // src/commands/voice/devices.ts
 function devices() {
   const script = join32(getPythonDir(), "list_devices.py");
-  spawnSync4(getVenvPython(), [script], { stdio: "inherit" });
+  spawnSync3(getVenvPython(), [script], { stdio: "inherit" });
 }
 
 // src/commands/voice/logs.ts
@@ -9411,7 +9365,7 @@ function logs(options2) {
 }
 
 // src/commands/voice/setup.ts
-import { spawnSync as spawnSync5 } from "child_process";
+import { spawnSync as spawnSync4 } from "child_process";
 import { mkdirSync as mkdirSync10 } from "fs";
 import { join as join34 } from "path";
 
@@ -9472,7 +9426,7 @@ function setup() {
   bootstrapVenv();
   console.log("\nDownloading models...\n");
   const script = join34(getPythonDir(), "setup_models.py");
-  const result = spawnSync5(getVenvPython(), [script], {
+  const result = spawnSync4(getVenvPython(), [script], {
     stdio: "inherit",
     env: { ...process.env, VOICE_LOG_FILE: voicePaths.log }
   });
@@ -9744,7 +9698,7 @@ async function exchangeToken(params) {
 }
 
 // src/commands/roam/promptCredentials.ts
-import enquirer10 from "enquirer";
+import enquirer9 from "enquirer";
 function censor(value) {
   const visible = value.slice(-4);
   return `${"*".repeat(value.length - 4)}${visible}`;
@@ -9753,7 +9707,7 @@ function label(name, existing) {
   return existing ? `${name} (${censor(existing)})` : name;
 }
 async function promptField(name, existing) {
-  const { value } = await enquirer10.prompt({
+  const { value } = await enquirer9.prompt({
     type: "input",
     name: "value",
     message: `${label(name, existing)}:`,
@@ -10276,7 +10230,7 @@ import { fileURLToPath as fileURLToPath7 } from "url";
 import * as fs23 from "fs";
 import * as path45 from "path";
 import chalk105 from "chalk";
-async function syncClaudeMd(claudeDir, targetBase) {
+async function syncClaudeMd(claudeDir, targetBase, options2) {
   const source = path45.join(claudeDir, "CLAUDE.md");
   const target = path45.join(targetBase, "CLAUDE.md");
   const sourceContent = fs23.readFileSync(source, "utf-8");
@@ -10288,7 +10242,7 @@ async function syncClaudeMd(claudeDir, targetBase) {
       );
       console.log();
       printDiff(targetContent, sourceContent);
-      const confirm = await promptConfirm(
+      const confirm = options2?.yes || await promptConfirm(
         chalk105.red("Overwrite existing CLAUDE.md?"),
         false
       );
@@ -10350,7 +10304,7 @@ async function sync(options2) {
   const targetBase = path47.join(os.homedir(), ".claude");
   syncCommands(claudeDir, targetBase);
   await syncSettings(claudeDir, targetBase, { yes: options2?.yes });
-  await syncClaudeMd(claudeDir, targetBase);
+  await syncClaudeMd(claudeDir, targetBase, { yes: options2?.yes });
 }
 function syncCommands(claudeDir, targetBase) {
   const sourceDir = path47.join(claudeDir, "commands");

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@staff0rd/assist",
-	"version": "0.147.1",
+	"version": "0.147.3",
 	"type": "module",
 	"main": "dist/index.js",
 	"bin": {