@staff0rd/assist 0.142.0 → 0.143.0

package/claude/commands/draft.md

@@ -38,7 +38,7 @@ Once you have enough context, propose a complete backlog item. Show it to the us
 
 Keep phases small (2-4 tasks each). A typical item should have 2-3 phases.
 
-Most phases should NOT have manual checks — prefer automated verification via the `verify` field on tasks. Only add `manualChecks` to a phase when the checks are genuinely difficult to automate (e.g. visual appearance, UX flow, hardware interaction). The last phase should always have at least one manual check to confirm the feature works end-to-end.
+Most phases should NOT have manual checks — prefer automated verification via the `verify` field on tasks. Only add `manualChecks` to a phase when the checks are genuinely difficult to automate (e.g. visual appearance, UX flow, hardware interaction). Do not add a final phase just for end-to-end verification — a review phase is auto-appended at runtime.
 
 ## Step 4: Iterate
 

package/dist/index.js

@@ -6,7 +6,7 @@ import { Command } from "commander";
 // package.json
 var package_default = {
   name: "@staff0rd/assist",
-  version: "0.142.0",
+  version: "0.143.0",
   type: "module",
   main: "dist/index.js",
   bin: {
@@ -2609,36 +2609,20 @@ import enquirer6 from "enquirer";
 // src/commands/backlog/run.ts
 import chalk35 from "chalk";
 
-// src/commands/backlog/executePhase.ts
-import chalk34 from "chalk";
-
-// src/commands/backlog/buildPhasePrompt.ts
-function formatTasks(phase) {
-  return phase.tasks.map((t) => {
-    let line = `- ${t.task}`;
-    if (t.verify) line += ` (verify: ${t.verify})`;
-    return line;
-  }).join("\n");
-}
-function buildManualCheckLines(manualChecks, isLastPhase) {
-  if (manualChecks.length > 0) {
-    return [
-      "",
-      "Before marking this phase as done, ask the user to perform these manual checks:",
-      ...manualChecks.map((c) => `- ${c}`),
-      "",
-      "Wait for the user to confirm all manual checks pass before proceeding."
-    ];
-  }
-  if (isLastPhase) {
-    return [
-      "",
-      "This is the final phase. Before marking it as done, ask the user to manually verify",
-      "that the feature works end-to-end and all acceptance criteria are met.",
-      "Wait for the user to confirm before proceeding."
-    ];
-  }
-  return [];
+// src/commands/backlog/buildAuthoredPhasePrompt.ts
+function buildAuthoredPhasePrompt(item, phaseIndex, phase) {
+  const manualChecks = phase.manualChecks ?? [];
+  const needsConfirmation = manualChecks.length > 0;
+  const confirmSuffix = needsConfirmation ? " and the user confirms" : "";
+  return [
+    ...buildContextLines(item, phaseIndex, phase),
+    "",
+    "Focus ONLY on this phase. Do not work on other phases.",
+    "When you have completed all tasks for this phase, run /verify to check your work.",
+    ...buildManualCheckLines(manualChecks),
+    "",
+    `Once verify passes${confirmSuffix}, run: assist backlog phase-done ${item.id} ${phaseIndex}`
+  ].filter((line) => line !== void 0).join("\n");
 }
 function buildContextLines(item, phaseIndex, phase) {
   const ac = item.acceptanceCriteria.map((c) => `- ${c}`).join("\n");
@@ -2655,22 +2639,76 @@ function buildContextLines(item, phaseIndex, phase) {
     formatTasks(phase)
   ];
 }
-function buildPhasePrompt(item, phaseIndex, phase, totalPhases) {
-  const isLastPhase = phaseIndex === totalPhases - 1;
-  const manualChecks = phase.manualChecks ?? [];
-  const needsConfirmation = manualChecks.length > 0 || isLastPhase;
-  const confirmSuffix = needsConfirmation ? " and the user confirms" : "";
+function buildManualCheckLines(manualChecks) {
+  if (manualChecks.length > 0) {
+    return [
+      "",
+      "Before marking this phase as done, ask the user to perform these manual checks:",
+      ...manualChecks.map((c) => `- ${c}`),
+      "",
+      "Wait for the user to confirm all manual checks pass before proceeding."
+    ];
+  }
+  return [];
+}
+function formatTasks(phase) {
+  return phase.tasks.map((t) => {
+    let line = `- ${t.task}`;
+    if (t.verify) line += ` (verify: ${t.verify})`;
+    return line;
+  }).join("\n");
+}
+
+// src/commands/backlog/buildReviewPrompt.ts
+function buildReviewPrompt(item, phaseIndex) {
+  const acLines = item.acceptanceCriteria.map((ac, i) => `${i + 1}. ${ac}`).join("\n");
   return [
-    ...buildContextLines(item, phaseIndex, phase),
+    `You are reviewing backlog item #${item.id}: ${item.name}`,
     "",
-    "Focus ONLY on this phase. Do not work on other phases.",
-    "When you have completed all tasks for this phase, run /verify to check your work.",
-    ...buildManualCheckLines(manualChecks, isLastPhase),
+    item.description ? `Description: ${item.description}` : "",
     "",
-    `Once verify passes${confirmSuffix}, run: assist backlog phase-done ${item.id} ${phaseIndex}`
+    "This is the auto-generated review phase. Verify each acceptance criterion against the current implementation.",
+    "For each criterion, inspect the code and report PASS or FAIL with a brief explanation:",
+    "",
+    acLines,
+    "",
+    "If any criterion fails, fix the issue and re-verify before proceeding.",
+    "",
+    "After all criteria pass, ask the user to confirm any manual checks",
+    "(e.g. end-to-end behaviour they need to verify themselves).",
+    "Wait for the user to confirm before proceeding.",
+    "",
+    "Once the user confirms:",
+    `1. Run: assist backlog done ${item.id}`,
+    "2. Run: /commit",
+    `3. Run: assist backlog phase-done ${item.id} ${phaseIndex}`
   ].filter((line) => line !== void 0).join("\n");
 }
 
+// src/commands/backlog/buildPhasePrompt.ts
+var REVIEW_PHASE_NAME = "Review";
+function buildPhasePrompt(item, phaseIndex, phase) {
+  if (phase.name === REVIEW_PHASE_NAME) {
+    return buildReviewPrompt(item, phaseIndex);
+  }
+  return buildAuthoredPhasePrompt(item, phaseIndex, phase);
+}
+
+// src/commands/backlog/buildReviewPhase.ts
+function buildReviewPhase() {
+  return {
+    name: REVIEW_PHASE_NAME,
+    tasks: [
+      {
+        task: "Verify acceptance criteria, confirm manual checks, mark done, commit, and signal phase-done."
+      }
+    ]
+  };
+}
+
+// src/commands/backlog/executePhase.ts
+import chalk34 from "chalk";
+
 // src/commands/backlog/resolvePhaseResult.ts
 import { spawnSync as spawnSync2 } from "child_process";
 import { existsSync as existsSync16, unlinkSync as unlinkSync3 } from "fs";
@@ -2792,7 +2830,7 @@ async function executePhase(item, phaseIndex, phases) {
     )
   );
   const { child, done: done2 } = spawnClaude(
-    buildPhasePrompt(item, phaseIndex, phase, phases.length)
+    buildPhasePrompt(item, phaseIndex, phase)
   );
   watchForMarker(child);
   await done2;
@@ -2802,28 +2840,28 @@ async function executePhase(item, phaseIndex, phases) {
 }
 
 // src/commands/backlog/run.ts
-function validatePlan(item) {
-  if (!item.plan || item.plan.length === 0) {
-    console.log(
-      chalk35.red("Item has no plan. Use /draft to create one with phases.")
-    );
-    return void 0;
+function resolvePlan(item) {
+  if (item.plan && item.plan.length > 0) {
+    return item.plan;
   }
-  return item.plan;
+  return [
+    {
+      name: "Implement",
+      tasks: item.acceptanceCriteria.map((ac) => ({ task: ac }))
+    }
+  ];
 }
 async function run2(id) {
   const result = loadAndFindItem(id);
   if (!result) return;
   const { item } = result;
-  const plan2 = validatePlan(item);
-  if (!plan2) return;
+  const plan2 = resolvePlan(item);
   const startPhase = item.currentPhase ?? 0;
-  if (startPhase >= plan2.length) {
+  if (startPhase > plan2.length) {
     if (item.status !== "done") setStatus(id, "done");
     console.log(
       chalk35.green(`All phases already complete for #${id}: ${item.name}`)
     );
-    console.log(chalk35.dim("Review the changes, then use /commit when ready."));
     return;
   }
   setStatus(id, "in-progress");
@@ -2842,10 +2880,14 @@ async function run2(id) {
     phaseIndex = await executePhase(item, phaseIndex, plan2);
     if (phaseIndex < 0) return;
   }
+  const reviewPhase = buildReviewPhase();
+  const allPhases = [...plan2, reviewPhase];
+  const reviewIndex = plan2.length;
+  const reviewResult = await executePhase(item, reviewIndex, allPhases);
+  if (reviewResult < 0) return;
   setStatus(id, "done");
   console.log(chalk35.green(`
 All phases complete for #${id}: ${item.name}`));
-  console.log(chalk35.dim("Review the changes, then use /commit when ready."));
 }
 
 // src/commands/backlog/next.ts

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@staff0rd/assist",
-	"version": "0.142.0",
+	"version": "0.143.0",
 	"type": "module",
 	"main": "dist/index.js",
 	"bin": {