@stacksjs/storage 0.74.37 → 0.74.38

package/dist/zip.d.ts

@@ -1,12 +1,27 @@
 import type { ZlibCompressionOptions } from 'bun';
 import type { CommandError, Subprocess } from '@stacksjs/types';
 import type { Result } from '@stacksjs/error-handling';
+/*
+ * Arguments go as an ARRAY, never as a joined string.
+ *
+ * These used to build a shell command and single-quote each path with a
+ * `shellEscape` helper. `runCommand` spawns without a shell, so those quotes
+ * arrived as literal characters in the filename: `zip` looked for a file
+ * called `'uploads'`, quotes included, and answered `zip error: Nothing to
+ * do!` on a directory that was plainly not empty. Every one of these
+ * functions was therefore broken for every input it escaped - which is to say
+ * all of them - and nothing noticed, because they had no caller until
+ * `storage:backup` (stacksjs/stacks#269).
+ *
+ * The array form is what `exec` uses as argv directly, so a path with a space
+ * in it also works now, which the string form could never have managed.
+ */
 export declare function zip(from: string | string[], to?: string, options?: ZipOptions): Promise<Result<Subprocess, CommandError>>;
-export declare function unzip(paths: string | string[]): Promise<Result<Subprocess, CommandError>>;
-export declare function archive(paths: string | string[]): Promise<Result<Subprocess, CommandError>>;
-export declare function unarchive(paths: string | string[]): Promise<Result<Subprocess, CommandError>>;
-export declare function compress(paths: string[]): Promise<Result<Subprocess, CommandError>>;
-export declare function decompress(paths: string | string[]): Promise<Result<Subprocess, CommandError>>;
+export declare function unzip(paths: string | string[], options?: ZipOptions): Promise<Result<Subprocess, CommandError>>;
+export declare function archive(paths: string | string[], to?: string, options?: ZipOptions): Promise<Result<Subprocess, CommandError>>;
+export declare function unarchive(paths: string | string[], options?: ZipOptions): Promise<Result<Subprocess, CommandError>>;
+export declare function compress(paths: string[], to?: string, options?: ZipOptions): Promise<Result<Subprocess, CommandError>>;
+export declare function decompress(paths: string | string[], options?: ZipOptions): Promise<Result<Subprocess, CommandError>>;
 /*
  * Bun's zlib bindings take `Uint8Array<ArrayBuffer>` - a view over a real
  * ArrayBuffer - while `Uint8Array` alone defaults to `ArrayBufferLike`, which

package/dist/zip.js

@@ -1 +1 @@
-import{runCommand}from"@stacksjs/cli";function shellEscape(_arg){return`'${_arg.replace(/'/g,"'\\''")}'`}export async function zip(from,to,options){const toPath=to||"archive.zip";if(Array.isArray(from)){const fromPath=from.map((f)=>shellEscape(f)).join(" ");return runCommand(`zip -r ${shellEscape(toPath)} ${fromPath}`,options)}return runCommand(`zip -r ${shellEscape(toPath)} ${shellEscape(from)}`,options)}export async function unzip(paths){if(Array.isArray(paths))return runCommand(`unzip ${paths.map((p)=>shellEscape(p)).join(" ")}`);return runCommand(`unzip ${shellEscape(paths)}`)}export function archive(paths){return zip(paths)}export function unarchive(paths){return unzip(paths)}export function compress(paths){return zip(paths)}export function decompress(paths){return unzip(paths)}export function gzipSync(data,options){return Bun.gzipSync(data,options)}export function gunzipSync(data){return Bun.gunzipSync(data)}export function deflateSync(data,options){return Bun.deflateSync(data,options)}export function inflateSync(data){return Bun.inflateSync(data)}
+import{runCommand}from"@stacksjs/cli";export async function zip(from,to,options){const toPath=to||"archive.zip",sources=Array.isArray(from)?from:[from];return runCommand(["zip","-r",toPath,...sources],options)}export async function unzip(paths,options){const sources=Array.isArray(paths)?paths:[paths];return runCommand(["unzip","-o",...sources],options)}export function archive(paths,to,options){return zip(paths,to,options)}export function unarchive(paths,options){return unzip(paths,options)}export function compress(paths,to,options){return zip(paths,to,options)}export function decompress(paths,options){return unzip(paths,options)}export function gzipSync(data,options){return Bun.gzipSync(data,options)}export function gunzipSync(data){return Bun.gunzipSync(data)}export function deflateSync(data,options){return Bun.deflateSync(data,options)}export function inflateSync(data){return Bun.inflateSync(data)}

package/package.json

@@ -2,7 +2,7 @@
   "name": "@stacksjs/storage",
   "type": "module",
   "sideEffects": false,
-  "version": "0.74.37",
+  "version": "0.74.38",
   "description": "The Stacks file system.",
   "author": "Chris Breuer",
   "contributors": [
@@ -61,20 +61,20 @@
     "prepublishOnly": "bun run build"
   },
   "dependencies": {
-    "@stacksjs/arrays": "0.74.37",
-    "@stacksjs/cli": "0.74.37",
-    "@stacksjs/config": "0.74.37",
-    "@stacksjs/env": "0.74.37",
-    "@stacksjs/error-handling": "0.74.37",
-    "@stacksjs/logging": "0.74.37",
-    "@stacksjs/path": "0.74.37",
-    "@stacksjs/strings": "0.74.37",
+    "@stacksjs/arrays": "0.74.38",
+    "@stacksjs/cli": "0.74.38",
+    "@stacksjs/config": "0.74.38",
+    "@stacksjs/env": "0.74.38",
+    "@stacksjs/error-handling": "0.74.38",
+    "@stacksjs/logging": "0.74.38",
+    "@stacksjs/path": "0.74.38",
+    "@stacksjs/strings": "0.74.38",
     "@stacksjs/ts-cloud": "^0.15.1",
     "@stacksjs/ts-xml": "^0.1.0",
     "ts-images": "^0.2.11"
   },
   "devDependencies": {
-    "@stacksjs/types": "0.74.37",
+    "@stacksjs/types": "0.74.38",
     "better-dx": "^0.2.24"
   }
 }