@stacksjs/defaults 0.75.467 → 0.75.468

package/ai/skills/stacks-actions/SKILL.md

@@ -1,6 +1,6 @@
 ---
 name: stacks-actions
-description: Use when working with Stacks server actions - creating actions in app/Actions/, auto-generated API actions from the useApi model trait, the 675 default framework actions (auth, dashboard, commerce, content, deployment, jobs), action request/response handling, or action registration. Covers @stacksjs/actions and storage/framework/defaults/app/Actions/.
+description: Use when working with Stacks server actions - creating actions in app/Actions/, auto-generated API actions from the useApi model trait, the 676 default framework actions (auth, dashboard, commerce, content, deployment, jobs), action request/response handling, or action registration. Covers @stacksjs/actions and storage/framework/defaults/app/Actions/.
 license: MIT
 compatibility: Bun >= 1.3.0, TypeScript
 allowed-tools: Read Edit Write Bash Grep Glob

package/ai/skills/stacks-mobile/SKILL.md

@@ -177,8 +177,10 @@ browser with an explicit return path.
 
 A named route parameter may need to exclude website paths. Configure
 `nativeScreenConstraints` on both platforms using the exact route key, for
-example `{ '/:username': { username: { pattern: '[a-z]+', exclude: ['terms'], ignoreCase: true } } }`.
-Patterns match the complete decoded parameter; use syntax shared by JavaScript,
+example `{ '/:username': { username: { pattern: '[a-z]+', exclude: ['terms'], normalize: 'lowercase' } } }`.
+Normalization lowercases decoded parameters and excluded values independently
+of device locale; the match returns the normalized parameter. Patterns then
+match the complete value case-sensitively; use syntax shared by JavaScript,
 Foundation and Kotlin. Constraints apply before query items and preserve static
 route priority. The build requires Craft's `nativeRouteConstraints` capability
 and stops if an installed host would ignore the configuration. For application

package/app/Actions/Dashboard/Content/FileDestroyAction.ts

@@ -1,7 +1,8 @@
 import type { RequestInstance } from '@stacksjs/types'
 import { Action } from '@stacksjs/actions/runtime'
 import { response } from '@stacksjs/router'
-import { DashboardFileError, deleteDashboardFile } from './file-manager'
+import { deleteDashboardFile } from './file-manager'
+import { dashboardFileFailure } from './file-response'
 
 export default new Action({
   name: 'FileDestroyAction',
@@ -16,9 +17,7 @@ export default new Action({
       return response.json(deleted)
     }
     catch (error) {
-      if (error instanceof DashboardFileError)
-        return response.json({ message: error.message, fields: error.fields }, error.status)
-      throw error
+      return dashboardFileFailure(error, 'The file could not be deleted.', 'FileDestroyAction')
     }
   },
 })

package/app/Actions/Dashboard/Content/FileDirectoryStoreAction.ts

@@ -1,7 +1,8 @@
 import type { RequestInstance } from '@stacksjs/types'
 import { Action } from '@stacksjs/actions/runtime'
 import { response } from '@stacksjs/router'
-import { createDashboardDirectory, DashboardFileError } from './file-manager'
+import { createDashboardDirectory } from './file-manager'
+import { dashboardFileFailure } from './file-response'
 
 export default new Action({
   name: 'FileDirectoryStoreAction',
@@ -17,9 +18,7 @@ export default new Action({
       return response.json(directory, 201)
     }
     catch (error) {
-      if (error instanceof DashboardFileError)
-        return response.json({ message: error.message, fields: error.fields }, error.status)
-      throw error
+      return dashboardFileFailure(error, 'The folder could not be created.', 'FileDirectoryStoreAction')
     }
   },
 })

package/app/Actions/Dashboard/Content/FileDuplicateAction.ts

@@ -1,7 +1,8 @@
 import type { RequestInstance } from '@stacksjs/types'
 import { Action } from '@stacksjs/actions/runtime'
 import { response } from '@stacksjs/router'
-import { DashboardFileError, duplicateDashboardFile } from './file-manager'
+import { duplicateDashboardFile } from './file-manager'
+import { dashboardFileFailure } from './file-response'
 
 export default new Action({
   name: 'FileDuplicateAction',
@@ -17,9 +18,7 @@ export default new Action({
       return response.json(duplicated)
     }
     catch (error) {
-      if (error instanceof DashboardFileError)
-        return response.json({ message: error.message, fields: error.fields }, error.status)
-      throw error
+      return dashboardFileFailure(error, 'The file could not be duplicated.', 'FileDuplicateAction')
     }
   },
 })

package/app/Actions/Dashboard/Content/FileFavoriteAction.ts

@@ -1,7 +1,8 @@
 import type { RequestInstance } from '@stacksjs/types'
 import { Action } from '@stacksjs/actions/runtime'
 import { response } from '@stacksjs/router'
-import { DashboardFileError, setDashboardFileFavorite } from './file-manager'
+import { setDashboardFileFavorite } from './file-manager'
+import { dashboardFileFailure } from './file-response'
 
 export default new Action({
   name: 'FileFavoriteAction',
@@ -17,9 +18,7 @@ export default new Action({
       return response.json(result)
     }
     catch (error) {
-      if (error instanceof DashboardFileError)
-        return response.json({ message: error.message, fields: error.fields }, error.status)
-      throw error
+      return dashboardFileFailure(error, 'The favorite could not be saved.', 'FileFavoriteAction')
     }
   },
 })

package/app/Actions/Dashboard/Content/FileIndexAction.ts

@@ -1,7 +1,7 @@
 import type { RequestInstance } from '@stacksjs/types'
 import { Action } from '@stacksjs/actions/runtime'
-import { response } from '@stacksjs/router'
-import { DashboardFileError, getDashboardFileSnapshot, normalizeDashboardFileLimit } from './file-manager'
+import { getDashboardFileSnapshot, normalizeDashboardFileLimit } from './file-manager'
+import { dashboardFileFailure } from './file-response'
 
 export default new Action({
   name: 'FileIndexAction',
@@ -16,9 +16,7 @@ export default new Action({
       })
     }
     catch (error) {
-      if (error instanceof DashboardFileError)
-        return response.json({ message: error.message, fields: error.fields }, error.status)
-      throw error
+      return dashboardFileFailure(error, 'Files could not be loaded.', 'FileIndexAction')
     }
   },
 })

package/app/Actions/Dashboard/Content/FileRenameAction.ts

@@ -1,7 +1,8 @@
 import type { RequestInstance } from '@stacksjs/types'
 import { Action } from '@stacksjs/actions/runtime'
 import { response } from '@stacksjs/router'
-import { DashboardFileError, renameDashboardFile } from './file-manager'
+import { renameDashboardFile } from './file-manager'
+import { dashboardFileFailure } from './file-response'
 
 export default new Action({
   name: 'FileRenameAction',
@@ -17,9 +18,7 @@ export default new Action({
       return response.json(renamed)
     }
     catch (error) {
-      if (error instanceof DashboardFileError)
-        return response.json({ message: error.message, fields: error.fields }, error.status)
-      throw error
+      return dashboardFileFailure(error, 'The file could not be renamed.', 'FileRenameAction')
     }
   },
 })

package/app/Actions/Dashboard/Content/FileReprocessAction.ts

@@ -1,7 +1,8 @@
 import type { RequestInstance } from '@stacksjs/types'
 import { Action } from '@stacksjs/actions/runtime'
 import { response } from '@stacksjs/router'
-import { DashboardFileError, reprocessDashboardFile } from './file-manager'
+import { reprocessDashboardFile } from './file-manager'
+import { dashboardFileFailure } from './file-response'
 
 export default new Action({
   name: 'FileReprocessAction',
@@ -23,9 +24,7 @@ export default new Action({
       return response.json(result)
     }
     catch (error) {
-      if (error instanceof DashboardFileError)
-        return response.json({ message: error.message, fields: error.fields }, error.status)
-      throw error
+      return dashboardFileFailure(error, 'The file could not be reprocessed.', 'FileReprocessAction')
     }
   },
 })

package/app/Actions/Dashboard/Content/FileTagsAction.ts

@@ -1,7 +1,8 @@
 import type { RequestInstance } from '@stacksjs/types'
 import { Action } from '@stacksjs/actions/runtime'
 import { response } from '@stacksjs/router'
-import { DashboardFileError, setDashboardFileTags } from './file-manager'
+import { setDashboardFileTags } from './file-manager'
+import { dashboardFileFailure } from './file-response'
 
 export default new Action({
   name: 'FileTagsAction',
@@ -19,9 +20,7 @@ export default new Action({
       return response.json(result)
     }
     catch (error) {
-      if (error instanceof DashboardFileError)
-        return response.json({ message: error.message, fields: error.fields }, error.status)
-      throw error
+      return dashboardFileFailure(error, 'The tags could not be saved.', 'FileTagsAction')
     }
   },
 })

package/app/Actions/Dashboard/Content/FileUploadAction.ts

@@ -2,7 +2,8 @@ import type { RequestInstance } from '@stacksjs/types'
 import type { UploadedFileLike } from '@stacksjs/storage'
 import { Action } from '@stacksjs/actions/runtime'
 import { response } from '@stacksjs/router'
-import { DashboardFileError, uploadDashboardFiles } from './file-manager'
+import { uploadDashboardFiles } from './file-manager'
+import { dashboardFileFailure } from './file-response'
 
 const MAX_FILES = 20
 const MAX_FILE_BYTES = 10 * 1024 * 1024
@@ -34,9 +35,7 @@ export default new Action({
       return response.json({ uploaded }, 201)
     }
     catch (error) {
-      if (error instanceof DashboardFileError)
-        return response.json({ message: error.message, fields: error.fields }, error.status)
-      throw error
+      return dashboardFileFailure(error, 'The upload could not be completed.', 'FileUploadAction')
     }
   },
 })

package/app/Actions/Dashboard/Content/FileVisibilityAction.ts

@@ -1,7 +1,8 @@
 import type { RequestInstance } from '@stacksjs/types'
 import { Action } from '@stacksjs/actions/runtime'
 import { response } from '@stacksjs/router'
-import { DashboardFileError, setDashboardFileVisibility } from './file-manager'
+import { setDashboardFileVisibility } from './file-manager'
+import { dashboardFileFailure } from './file-response'
 
 export default new Action({
   name: 'FileVisibilityAction',
@@ -17,9 +18,7 @@ export default new Action({
       return response.json(updated)
     }
     catch (error) {
-      if (error instanceof DashboardFileError)
-        return response.json({ message: error.message, fields: error.fields }, error.status)
-      throw error
+      return dashboardFileFailure(error, 'The visibility could not be changed.', 'FileVisibilityAction')
     }
   },
 })

package/app/Actions/Dashboard/Content/file-response.test.ts

@@ -0,0 +1,61 @@
+import type { RequestInstance } from '@stacksjs/types'
+import { afterEach, describe, expect, spyOn, test } from 'bun:test'
+import FileIndexAction from './FileIndexAction'
+import { DashboardFileError } from './file-manager'
+import { dashboardFileFailure } from './file-response'
+
+/**
+ * File actions answer a failure they did not write with a safe 503
+ * (stacksjs/stacks#3174). They rethrew it, and the router put the driver's own
+ * message - `relation "storage_items" does not exist` - in the response body
+ * in every environment, which the file manager then showed in its banner.
+ */
+const driverMessage = 'relation "storage_items" does not exist'
+
+let quiet: ReturnType<typeof spyOn> | null = null
+afterEach(() => {
+  quiet?.mockRestore()
+  quiet = null
+})
+
+describe('dashboardFileFailure', () => {
+  test('keeps the status, message and fields of an error written to be shown', async () => {
+    const reply = dashboardFileFailure(
+      new DashboardFileError('Choose a limit between 1 and 5000.', 422, { limit: 'Too high.' }),
+      'Files could not be loaded.',
+      'FileIndexAction',
+    )
+
+    expect(reply.status).toBe(422)
+    expect(await reply.json()).toEqual({ message: 'Choose a limit between 1 and 5000.', fields: { limit: 'Too high.' } })
+  })
+
+  test('answers any other failure 503 with the safe message and logs the real one', async () => {
+    quiet = spyOn(console, 'error').mockImplementation(() => {})
+    const failure = new Error(driverMessage)
+
+    const reply = dashboardFileFailure(failure, 'Files could not be loaded.', 'FileIndexAction')
+
+    expect(reply.status).toBe(503)
+    expect(await reply.json()).toEqual({ message: 'Files could not be loaded.' })
+    expect(quiet).toHaveBeenCalledWith('[dashboard/api] FileIndexAction failed:', failure)
+  })
+})
+
+describe('FileIndexAction', () => {
+  test('does not send a driver error to the browser', async () => {
+    quiet = spyOn(console, 'error').mockImplementation(() => {})
+    const request = {
+      get: () => {
+        throw new Error(driverMessage)
+      },
+    } as unknown as RequestInstance
+
+    const reply = await FileIndexAction.handle(request) as Response
+
+    expect(reply.status).toBe(503)
+    const body = await reply.text()
+    expect(body).not.toContain('storage_items')
+    expect(JSON.parse(body)).toEqual({ message: 'Files could not be loaded.' })
+  })
+})

package/app/Actions/Dashboard/Content/file-response.ts

@@ -0,0 +1,18 @@
+import { response } from '@stacksjs/router'
+import { dashboardOperationalError } from '../dashboard-response'
+import { DashboardFileError } from './file-manager'
+
+/**
+ * The response for a file action that threw.
+ *
+ * A `DashboardFileError` is written to be shown, so it keeps its status,
+ * message and fields. Anything else - the database behind `storage_items`
+ * being down or not migrated, a driver failing - is logged and answered 503
+ * with `message`, because rethrowing it let the router send the raw driver
+ * message to the browser in every environment (stacksjs/stacks#3174).
+ */
+export function dashboardFileFailure(error: unknown, message: string, action: string): Response {
+  if (error instanceof DashboardFileError)
+    return response.json({ message: error.message, fields: error.fields }, error.status)
+  return dashboardOperationalError(error, message, action)
+}

package/ide/vscode/package.json

@@ -2,7 +2,7 @@
   "publisher": "Stacks",
   "name": "vscode-stacks",
   "displayName": "Stacks",
-  "version": "0.75.467",
+  "version": "0.75.468",
   "description": "Stacks, built into VS Code: stx templates, pickier linting and formatting, encrypted env files, the dev server preview and every buddy command. No other extensions required.",
   "license": "MIT",
   "funding": "https://github.com/sponsors/chrisbbreuer",

package/package.json

@@ -2,7 +2,7 @@
   "name": "@stacksjs/defaults",
   "type": "module",
   "sideEffects": false,
-  "version": "0.75.467",
+  "version": "0.75.468",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/stacksjs/stacks.git",
@@ -45,7 +45,7 @@
   "dependencies": {
     "@iconify-json/f7": "^1.2.2",
     "@iconify-json/hugeicons": "^1.2.35",
-    "@stacksjs/mobile": "0.75.467",
+    "@stacksjs/mobile": "0.75.468",
     "@stacksjs/sanitizer": "0.2.798",
     "@stacksjs/stx": "0.2.798",
     "@xterm/addon-fit": "^0.11.0",