@stacksjs/defaults 0.75.308 → 0.75.310

package/ai/skills/stacks-browse/SKILL.md

@@ -15,6 +15,10 @@ Protocol (CDP) using only Bun's native `Bun.spawn`, `fetch`, and `WebSocket`.
 
 The driver lives at `storage/framework/defaults/ai/skills/stacks-browse/scripts/browse.ts`. Run it with `bun`:
 
+Keep `chrome.ts` beside the driver when copying the standalone skill. It is the
+Chrome executable preparation shared with `@stacksjs/testing/browser` and uses
+only Bun and Node APIs.
+
 ```bash
 bun storage/framework/defaults/ai/skills/stacks-browse/scripts/browse.ts <command> <url> [flags]
 ```

package/ai/skills/stacks-browse/scripts/browse.ts

@@ -23,6 +23,7 @@ import { spawn } from 'bun'
 import { existsSync, mkdirSync, readFileSync, rmSync } from 'node:fs'
 import { tmpdir } from 'node:os'
 import { join } from 'node:path'
+import { chromeHasUpdater, findChrome, prepareMacChrome } from './chrome'
 
 // ── Browser discovery ──────────────────────────────────────────────────────
 
@@ -49,6 +50,7 @@ function collectCandidates(): string[] {
   // DevTools target. Prefer an installed Chrome before spending their bounds.
   for (const bin of ['google-chrome-stable', 'google-chrome', 'chromium', 'chromium-browser', 'brave-browser', 'microsoft-edge', 'chrome'])
     add(which(bin))
+  add(findChrome())
 
   for (const p of [
     '/Applications/Google Chrome.app/Contents/MacOS/Google Chrome',
@@ -199,17 +201,19 @@ export async function waitForBrowserPort(proc: { exitCode: number | null }, port
 }
 
 async function tryLaunch(browser: string): Promise<Session | null> {
+  const executable = chromeHasUpdater(browser) ? prepareMacChrome({ source: browser }).executable : browser
   const userDataDir = join(tmpdir(), `stacks-browse-${process.pid}-${Math.floor(Number(process.hrtime.bigint() % 1000000n))}`)
   mkdirSync(userDataDir, { recursive: true })
 
-  const isHeadlessShell = /chrome-headless-shell|headless_shell/.test(browser)
+  const isHeadlessShell = /chrome-headless-shell|headless_shell/.test(executable)
   const proc = spawn([
-    browser,
+    executable,
     ...(isHeadlessShell ? [] : ['--headless=new']),
     '--remote-debugging-port=0',
     `--user-data-dir=${userDataDir}`,
     '--no-first-run',
     '--no-default-browser-check',
+    ...(process.platform === 'darwin' ? ['--use-mock-keychain'] : []),
     '--disable-gpu',
     '--disable-dev-shm-usage',
     '--hide-scrollbars',
@@ -223,7 +227,7 @@ async function tryLaunch(browser: string): Promise<Session | null> {
   let port: number | null = null
   try {
     port = await waitForBrowserPort(proc, portFile, 15_000)
-    if (port !== null) return { proc, port, userDataDir, browser }
+    if (port !== null) return { proc, port, userDataDir, browser: executable }
   }
   finally {
     if (port === null) {

package/ai/skills/stacks-browse/scripts/chrome.ts

@@ -0,0 +1,106 @@
+// Shared Chrome executable preparation for the standalone skill and testing package.
+import { existsSync, mkdirSync, mkdtempSync, renameSync, rmSync } from 'node:fs'
+import { tmpdir } from 'node:os'
+import { join } from 'node:path'
+import process from 'node:process'
+
+const MAC_CHROMES = [
+  '/Applications/Google Chrome.app/Contents/MacOS/Google Chrome',
+  '/Applications/Google Chrome for Testing.app/Contents/MacOS/Google Chrome for Testing',
+  '/Applications/Chromium.app/Contents/MacOS/Chromium',
+  '/Applications/Google Chrome Canary.app/Contents/MacOS/Google Chrome Canary',
+]
+const PATH_CHROMES = ['google-chrome', 'google-chrome-stable', 'chromium', 'chromium-browser', 'chrome']
+const UPDATER_KEYS = ['KSProductID', 'KSUpdateURL', 'KSChannelID', 'KSVersion']
+const PRIVATE_BUNDLE_ID = 'dev.stacks.testing.chrome'
+
+/** The Chrome to drive: `CHROME_PATH`, else the first installed one found. Null when there is none. */
+export function findChrome(): string | null {
+  if (process.env.CHROME_PATH) return process.env.CHROME_PATH
+  if (process.platform === 'darwin') {
+    const found = MAC_CHROMES.find(path => existsSync(path))
+    if (found) return found
+  }
+  for (const name of PATH_CHROMES) {
+    const found = Bun.which(name)
+    if (found) return found
+  }
+  return null
+}
+
+/** The `.app` bundle an executable inside `Contents/MacOS/` belongs to, or null. */
+function appBundleOf(executable: string): string | null {
+  const match = /^(.*?\.app)\/Contents\/MacOS\/[^/]+$/.exec(executable)
+  return match ? match[1]! : null
+}
+
+function plist(info: string, command: string): { ok: boolean, out: string } {
+  const result = Bun.spawnSync(['/usr/libexec/PlistBuddy', '-c', command, info], { stdout: 'pipe', stderr: 'pipe' })
+  return { ok: result.exitCode === 0, out: result.stdout.toString().trim() }
+}
+
+/** True when this Chrome would be killed by GoogleUpdater (it still carries the updater's keys). */
+export function chromeHasUpdater(executable: string): boolean {
+  const app = appBundleOf(executable)
+  if (!app || process.platform !== 'darwin') return false
+  const info = join(app, 'Contents/Info.plist')
+  return existsSync(info) && UPDATER_KEYS.some(key => plist(info, `Print :${key}`).ok)
+}
+
+export interface PreparedChrome {
+  /** The executable to launch. */
+  executable: string
+  /** The cloned `.app`. */
+  app: string
+  /** Reused from an earlier run rather than cloned now. */
+  reused: boolean
+}
+
+/**
+ * A private clone of a macOS Chrome that GoogleUpdater leaves alone (see the
+ * module docs): `cp -cR`, the `KS*` keys deleted from `Info.plist`, its own
+ * `CFBundleIdentifier`, `codesign --force --deep --sign -`. Kept in
+ * `directory` (default a per-version folder in the temp directory) and
+ * reused while its version matches the source's.
+ */
+export function prepareMacChrome(options: { source?: string, directory?: string } = {}): PreparedChrome {
+  if (process.platform !== 'darwin') throw new Error('prepareMacChrome is for macOS; elsewhere launch Chrome as installed')
+  const source = options.source ?? MAC_CHROMES[0]!
+  const sourceApp = appBundleOf(source)
+  if (!sourceApp || !existsSync(sourceApp)) throw new Error(`No Chrome app bundle at ${source}`)
+  const sourceInfo = join(sourceApp, 'Contents/Info.plist')
+  const version = plist(sourceInfo, 'Print :CFBundleShortVersionString').out || 'unknown'
+  const executableName = plist(sourceInfo, 'Print :CFBundleExecutable').out || 'Google Chrome'
+  const directory = options.directory ?? join(tmpdir(), `stacks-chrome-${version.replace(/[^\w.-]/g, '_')}`)
+  const app = join(directory, 'Chrome.app')
+  const executable = join(app, 'Contents/MacOS', executableName)
+  const info = join(app, 'Contents/Info.plist')
+
+  if (existsSync(executable) && plist(info, 'Print :CFBundleIdentifier').out === PRIVATE_BUNDLE_ID
+    && plist(info, 'Print :CFBundleShortVersionString').out === version)
+    return { executable, app, reused: true }
+
+  // Build beside the final path and move it in, so a run killed half-way
+  // never leaves a half-signed app that a later run would reuse.
+  mkdirSync(directory, { recursive: true })
+  const staging = mkdtempSync(join(directory, 'staging-'))
+  const staged = join(staging, 'Chrome.app')
+  const run = (command: string[], what: string) => {
+    const result = Bun.spawnSync(command, { stdout: 'pipe', stderr: 'pipe' })
+    if (result.exitCode !== 0) throw new Error(`${what} failed: ${result.stderr.toString().trim()}`)
+  }
+  try {
+    run(['/bin/cp', '-cR', sourceApp, staged], 'Cloning Chrome')
+    const stagedInfo = join(staged, 'Contents/Info.plist')
+    for (const key of UPDATER_KEYS) plist(stagedInfo, `Delete :${key}`)
+    run(['/usr/libexec/PlistBuddy', '-c', `Set :CFBundleIdentifier ${PRIVATE_BUNDLE_ID}`, stagedInfo], 'Renaming the Chrome bundle')
+    run(['codesign', '--force', '--deep', '--sign', '-', staged], 'Re-signing Chrome')
+    rmSync(app, { recursive: true, force: true })
+    renameSync(staged, app)
+  }
+  finally {
+    rmSync(staging, { recursive: true, force: true })
+  }
+  return { executable, app, reused: false }
+}
+

package/ide/vscode/package.json

@@ -2,7 +2,7 @@
   "publisher": "Stacks",
   "name": "vscode-stacks",
   "displayName": "Stacks",
-  "version": "0.75.308",
+  "version": "0.75.310",
   "description": "Stacks, built into VS Code: stx templates, pickier linting and formatting, encrypted env files, the dev server preview and every buddy command. No other extensions required.",
   "license": "MIT",
   "funding": "https://github.com/sponsors/chrisbbreuer",

package/package.json

@@ -2,7 +2,7 @@
   "name": "@stacksjs/defaults",
   "type": "module",
   "sideEffects": false,
-  "version": "0.75.308",
+  "version": "0.75.310",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/stacksjs/stacks.git",
@@ -45,7 +45,7 @@
   "dependencies": {
     "@iconify-json/f7": "^1.2.2",
     "@iconify-json/hugeicons": "^1.2.35",
-    "@stacksjs/mobile": "0.75.308",
+    "@stacksjs/mobile": "0.75.310",
     "@stacksjs/sanitizer": "0.2.691",
     "@stacksjs/stx": "0.2.691",
     "@xterm/addon-fit": "^0.11.0",