@stacksjs/defaults 0.73.3 → 0.74.0

package/app/Actions/Auth/GenerateTwoFactorSecretAction.ts

@@ -2,7 +2,6 @@ import { Action } from '@stacksjs/actions'
 import { generateTwoFactorSetup, stashPendingTwoFactorSecret } from '@stacksjs/auth'
 import { config } from '@stacksjs/config'
 import { response } from '@stacksjs/router'
-import { toSvg } from 'ts-qr-codes'
 
 export default new Action({
   name: 'GenerateTwoFactorSecretAction',
@@ -14,7 +13,11 @@ export default new Action({
       return response.unauthorized('Unauthorized')
 
     const appName = config.app?.name || 'Stacks'
-    const { secret, uri } = generateTwoFactorSetup(user.email ?? '', appName)
+
+    // `qr` is an SVG string of `uri`, rendered by @stacksjs/auth so an app that
+    // overrides this action still gets one. Clients that render their own QR
+    // code have `uri`; clients that offer manual entry have `secret`.
+    const { secret, uri, qr } = generateTwoFactorSetup(user.email ?? '', appName)
 
     // Not persisted to users.two_factor_secret until EnableTwoFactorAction
     // verifies a code produced from it — but stashed server-side now so
@@ -22,15 +25,6 @@ export default new Action({
     // two-factor.ts's doc comment for why.
     await stashPendingTwoFactorSecret(user.id as number, secret)
 
-    // Rendered here rather than left to the client. Every authenticator flow
-    // needs the URI as a QR code, and a caller that has to find its own
-    // encoder either ships one to the browser or, more often, falls back to
-    // asking the user to type a 32-character secret by hand.
-    //
-    // SVG so it stays sharp at any size and can be inlined into a page or an
-    // email; the URI is still returned for clients that render their own.
-    const qr = toSvg(uri, { size: 240, title: 'Two-factor authentication setup' })
-
     return response.json({ secret, uri, qr })
   },
 })

package/ide/vscode/package.json

@@ -2,7 +2,7 @@
   "publisher": "Stacks",
   "name": "vscode-stacks",
   "displayName": "Stacks",
-  "version": "0.73.3",
+  "version": "0.74.0",
   "description": "A modern Stacks development environment.",
   "license": "MIT",
   "funding": "https://github.com/sponsors/chrisbbreuer",

package/package.json

@@ -2,7 +2,7 @@
   "name": "@stacksjs/defaults",
   "type": "module",
   "sideEffects": false,
-  "version": "0.73.3",
+  "version": "0.74.0",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/stacksjs/stacks.git",
@@ -48,14 +48,14 @@
       "default": "./dist/*.js"
     }
   },
+  "scripts": {
+    "build": "bun build.ts"
+  },
   "dependencies": {
     "@iconify-json/f7": "^1.2.2",
     "@iconify-json/hugeicons": "^1.2.27",
-    "@stacksjs/mobile": "^0.73.3",
+    "@stacksjs/mobile": "^0.74.0",
     "@stacksjs/sanitizer": "^0.2.113",
     "ts-qr-codes": "^0.1.8"
-  },
-  "scripts": {
-    "build": "bun build.ts"
   }
 }