@stacksjs/browser-extension 0.70.146 → 0.70.148

package/README.md

@@ -43,15 +43,34 @@ email to the publisher account. Firefox reads `AMO_JWT_ISSUER` and
 `firefoxAddons.license` and `firefoxAddons.categories` are configured.
 
 For tag-driven publication, call Stacks' reusable workflow from the extension
-repository instead of duplicating store orchestration:
+repository instead of duplicating store orchestration. Expose the optional
+manual inputs so a failed or missing GitHub Release can be repaired without
+resubmitting builds to the browser stores:
 
 ```yaml
+on:
+  workflow_dispatch:
+    inputs:
+      github-release-only:
+        description: Build packages and create or repair the GitHub Release only
+        type: boolean
+        default: false
+      release-tag:
+        description: Existing tag to repair; defaults to v<package.json version>
+        type: string
+        required: false
+  push:
+    tags:
+      - 'v*'
+
 jobs:
   publish:
-    uses: stacksjs/stacks/.github/workflows/browser-extension-release.yml@v0.70.142
+    uses: stacksjs/stacks/.github/workflows/browser-extension-release.yml@v0.70.147
     with:
       chrome-publisher-id: ${{ vars.CHROME_WEB_STORE_PUBLISHER_ID }}
       safari-enabled: ${{ vars.ENABLE_SAFARI_PUBLISH == 'true' }}
+      publish-stores: ${{ !inputs.github-release-only }}
+      release-tag: ${{ inputs.release-tag || '' }}
     secrets:
       CHROME_WEB_STORE_SERVICE_ACCOUNT_JSON: ${{ secrets.CHROME_WEB_STORE_SERVICE_ACCOUNT_JSON }}
       AMO_JWT_ISSUER: ${{ secrets.AMO_JWT_ISSUER }}
@@ -62,8 +81,11 @@ jobs:
 ```
 
 It packages every configured target, publishes Chrome and Firefox in
-independent jobs, optionally uploads Safari with stable Xcode, and creates the
-GitHub Release only after the enabled stores succeed.
+independent jobs, optionally uploads Safari with stable Xcode, and creates an
+idempotent GitHub Release with checksummed packages as soon as validation
+succeeds. Store failures cannot suppress the GitHub Release. A manual run with
+`github-release-only` skips every store and creates or repairs the release for
+the requested existing tag.
 
 ## Safari
 

package/dist/app-store-connect.d.ts

@@ -61,6 +61,9 @@ export declare interface SafariAppStoreVersionResult {
   created: boolean
   updated: boolean
   id: string
+  status?: 'ready' | 'deferred' | 'published'
+  appStoreState?: string
+  reason?: string
 }
 export declare interface SafariBuildAttachmentResult {
   platform: SafariPlatform

package/dist/app-store-connect.js

@@ -153,7 +153,13 @@ const editableVersionStates = new Set([
   "PREPARE_FOR_SUBMISSION",
   "DEVELOPER_REJECTED",
   "REJECTED",
-  "METADATA_REJECTED"
+  "METADATA_REJECTED",
+  "INVALID_BINARY"
+]), releasedVersionStates = new Set([
+  "READY_FOR_DISTRIBUTION",
+  "READY_FOR_SALE",
+  "DEVELOPER_REMOVED_FROM_SALE",
+  "REMOVED_FROM_SALE"
 ]);
 function appStorePlatform(platform) {
   return platform === "ios" ? "IOS" : "MAC_OS";
@@ -194,19 +200,43 @@ async function ensureConfiguredAppStoreVersions(client, appId, platforms, versio
   for (const platform of [...new Set(platforms)]) {
     const applePlatform = appStorePlatform(platform), exact = versions.find((item) => item.attributes.platform === applePlatform && item.attributes.versionString === version);
     if (exact) {
-      results.push({ platform, version, created: !1, updated: !1, id: exact.id });
+      const appStoreState = exact.attributes.appStoreState, status = editableVersionStates.has(appStoreState) ? "ready" : releasedVersionStates.has(appStoreState) ? "published" : "deferred";
+      results.push({
+        platform,
+        version,
+        created: !1,
+        updated: !1,
+        id: exact.id,
+        status,
+        appStoreState,
+        ...status === "deferred" ? { reason: `Safari ${platform} version ${version} is already ${appStoreState}` } : {}
+      });
       continue;
     }
     const editable = versions.find((item) => item.attributes.platform === applePlatform && editableVersionStates.has(item.attributes.appStoreState));
     if (editable) {
       const updated = await client.updateAppStoreVersion(editable.id, version);
       editable.attributes.versionString = version;
-      results.push({ platform, version, created: !1, updated: !0, id: updated.id });
+      results.push({ platform, version, created: !1, updated: !0, id: updated.id, status: "ready", appStoreState: updated.attributes.appStoreState });
+      continue;
+    }
+    const blocking = versions.find((item) => item.attributes.platform === applePlatform && !releasedVersionStates.has(item.attributes.appStoreState));
+    if (blocking) {
+      results.push({
+        platform,
+        version,
+        created: !1,
+        updated: !1,
+        id: blocking.id,
+        status: "deferred",
+        appStoreState: blocking.attributes.appStoreState,
+        reason: `Safari ${platform} version ${version} is queued behind ${blocking.attributes.versionString} (${blocking.attributes.appStoreState})`
+      });
       continue;
     }
     const created = await client.createAppStoreVersion(appId, applePlatform, version);
     versions.push(created);
-    results.push({ platform, version, created: !0, updated: !1, id: created.id });
+    results.push({ platform, version, created: !0, updated: !1, id: created.id, status: "ready", appStoreState: created.attributes.appStoreState });
   }
   return results;
 }

package/dist/chrome-web-store.d.ts

@@ -2,7 +2,7 @@ import type { ChromeWebStoreConfig, ExtensionConfig } from './types';
 /** Build the RS256 assertion Google exchanges for a short-lived OAuth token. */
 export declare function chromeWebStoreServiceAccountAssertion(serviceAccount: GoogleServiceAccount, now?: unknown): string;
 /** Build, package, upload, and optionally submit an existing Chrome Web Store item. */
-export declare function publishChromeExtension(config: ExtensionConfig, options: ChromeWebStorePublishOptions): Promise<{ packagePath: string, upload: ChromeUploadResult, publish?: ChromePublishResult }>;
+export declare function publishChromeExtension(config: ExtensionConfig, options: ChromeWebStorePublishOptions): Promise<ChromeWebStorePublishResult>;
 export declare interface GoogleServiceAccount {
   client_email: string
   private_key: string
@@ -39,6 +39,23 @@ export declare interface ChromePublishResult {
   state: string
   warningInfo?: { warnings?: Array<{ reason: string, description: string }> }
 }
+export declare interface ChromeDeferredPublishResult {
+  state: string
+  submittedVersion?: string
+  reason: string
+}
+export declare interface ChromePublishedVersionResult {
+  state: string
+  version: string
+  reason: string
+}
+export declare interface ChromeWebStorePublishResult {
+  packagePath: string
+  upload?: ChromeUploadResult
+  publish?: ChromePublishResult
+  deferred?: ChromeDeferredPublishResult
+  alreadyPublished?: ChromePublishedVersionResult
+}
 export declare interface ChromeWebStorePublishOptions extends ChromeWebStoreClientOptions {
   version: string
   cwd?: string

package/dist/chrome-web-store.js

@@ -121,10 +121,38 @@ export class ChromeWebStoreClient {
     throw Error("[browser-extension] Chrome Web Store package processing timed out");
   }
 }
+function pendingReview(status) {
+  if (status.submittedItemRevisionStatus?.state !== "PENDING_REVIEW")
+    return;
+  const submittedVersion = status.submittedItemRevisionStatus.distributionChannels?.[0]?.crxVersion;
+  return {
+    state: status.submittedItemRevisionStatus.state,
+    submittedVersion,
+    reason: submittedVersion ? `Chrome Web Store version ${submittedVersion} is already pending review` : "A Chrome Web Store revision is already pending review"
+  };
+}
+function publishedVersion(status, version) {
+  const published = status.publishedItemRevisionStatus;
+  if (!published || !["PUBLISHED", "PUBLISHED_TO_TESTERS"].includes(published.state))
+    return;
+  if (!published.distributionChannels?.some((channel) => channel.crxVersion === version))
+    return;
+  return {
+    state: published.state,
+    version,
+    reason: `Chrome Web Store version ${version} is already ${published.state.toLowerCase().replaceAll("_", " ")}`
+  };
+}
 export async function publishChromeExtension(config, options) {
   if (!config.chromeWebStore)
     throw Error("[browser-extension] Chrome publishing needs chromeWebStore.publisherId and chromeWebStore.itemId in config/extension.ts");
-  const cwd = options.cwd ?? process.cwd(), packagePath = options.packagePath ?? await packageExtension(config, { target: "chrome", version: options.version, cwd }), client = new ChromeWebStoreClient(options), upload = await client.upload(config.chromeWebStore, packagePath);
+  const cwd = options.cwd ?? process.cwd(), packagePath = options.packagePath ?? await packageExtension(config, { target: "chrome", version: options.version, cwd }), client = new ChromeWebStoreClient(options), status = await client.fetchStatus(config.chromeWebStore), alreadyPublished = publishedVersion(status, options.version);
+  if (alreadyPublished)
+    return { packagePath, alreadyPublished };
+  const deferred = pendingReview(status);
+  if (deferred)
+    return { packagePath, deferred };
+  const upload = await client.upload(config.chromeWebStore, packagePath);
   if (upload.uploadState === "IN_PROGRESS")
     await client.waitForUpload(config.chromeWebStore);
   else if (upload.uploadState !== "SUCCEEDED")

package/dist/safari.d.ts

@@ -120,6 +120,8 @@ export declare interface SafariPublishResult {
   exportPath: string
   buildNumber: string
   artifacts: SafariPublishedArtifact[]
+  deferred: Array<{ platform: SafariPlatform, version: string, state?: string, reason: string }>
+  alreadyPublished: Array<{ platform: SafariPlatform, version: string, state?: string }>
   attachments: Array<{ platform: SafariPlatform, versionId: string, buildId: string, buildNumber: string }>
   appStoreSubmission?: {
     versions: Array<{ platform: SafariPlatform, versionId: string, localizationId: string }>

package/dist/safari.js

@@ -329,20 +329,36 @@ export async function publishSafariApp(config, options) {
     throw Error("[browser-extension] Safari publishing needs at least one platform");
   const { AppStoreConnectClient, attachSafariBuilds, provisionSafariApp } = await import("./app-store-connect"), provisioned = await provisionSafariApp(config, {
     ...auth,
-    version: options.version,
+    version: options.validateOnly ? void 0 : options.version,
     platforms
   });
   if (!provisioned.appRecord.exists)
     throw Error("[browser-extension] the App Store Connect app record is missing; create it once in App Store Connect before publishing");
+  const publishablePlatforms = options.validateOnly ? platforms : platforms.filter((platform) => provisioned.appStoreVersions.some((version) => version.platform === platform && version.status !== "deferred" && version.status !== "published")), deferred = provisioned.appStoreVersions.filter((version) => version.status === "deferred").map((version) => ({
+    platform: version.platform,
+    version: version.version,
+    state: version.appStoreState,
+    reason: version.reason ?? `Safari ${version.platform} publication is deferred`
+  })), alreadyPublished = provisioned.appStoreVersions.filter((version) => version.status === "published").map((version) => ({ platform: version.platform, version: version.version, state: version.appStoreState }));
+  if (!publishablePlatforms.length)
+    return {
+      archivePath: "",
+      exportPath: "",
+      buildNumber,
+      artifacts: [],
+      attachments: [],
+      deferred,
+      alreadyPublished
+    };
   if (options.build !== !1)
     await buildExtension(config, { target: "safari", version: options.version, cwd });
-  const appName = safariAppName(config), dir = safariProjectDir(cwd, options.dir), buildDir = join(dir, "build"), universal = platforms.includes("ios");
+  const appName = safariAppName(config), dir = safariProjectDir(cwd, options.dir), buildDir = join(dir, "build"), universal = publishablePlatforms.includes("ios");
   let project, projectCwd;
   if (universal) {
     const generated = await createSafariUniversalProject(config, {
       ...options,
       build: !1,
-      platforms
+      platforms: publishablePlatforms
     });
     project = generated.project;
     projectCwd = generated.dir;
@@ -354,7 +370,7 @@ export async function publishSafariApp(config, options) {
   const authArgs = xcodeAuthArgs(auth);
   await mkdir(buildDir, { recursive: !0 });
   const method = options.validateOnly ? "validation" : "app-store-connect", artifacts = [];
-  for (const platform of platforms) {
+  for (const platform of publishablePlatforms) {
     const suffix = universal ? `-${platform}` : "", archivePath = join(buildDir, `${appName}${suffix}.xcarchive`), exportPath = join(buildDir, `${options.validateOnly ? "validation" : "upload"}${suffix}`), plistPath = join(buildDir, `ExportOptions.${method}${suffix}.plist`), scheme = universal ? `${appName} (${platform === "ios" ? "iOS" : "macOS"})` : appName, destination = platform === "ios" ? "generic/platform=iOS" : "generic/platform=macOS";
     await rm(archivePath, { recursive: !0, force: !0 });
     await rm(exportPath, { recursive: !0, force: !0 });
@@ -391,7 +407,7 @@ export async function publishSafariApp(config, options) {
     ], projectCwd, `Safari ${platform} export`);
     artifacts.push({ platform, archivePath, exportPath });
   }
-  const attachments = options.validateOnly ? [] : await attachSafariBuilds(new AppStoreConnectClient(auth), provisioned.appRecord.id, provisioned.appStoreVersions, buildNumber, {
+  const attachments = options.validateOnly ? [] : await attachSafariBuilds(new AppStoreConnectClient(auth), provisioned.appRecord.id, provisioned.appStoreVersions.filter((version) => version.status !== "deferred" && version.status !== "published"), buildNumber, {
     timeoutMs: options.processingTimeoutMs,
     pollIntervalMs: options.processingPollIntervalMs
   }), appStoreSubmission = !options.validateOnly && config.safariAppStore ? await (await import("./app-store-submission")).prepareSafariAppStoreSubmission(new AppStoreConnectClient(auth), config, provisioned.appRecord.id, attachments.map((attachment) => ({
@@ -404,6 +420,8 @@ export async function publishSafariApp(config, options) {
     exportPath: firstArtifact.exportPath,
     buildNumber,
     artifacts,
+    deferred,
+    alreadyPublished,
     attachments,
     appStoreSubmission: appStoreSubmission ? { versions: appStoreSubmission.versions, reviewSubmissionIds: appStoreSubmission.reviewSubmissionIds } : void 0
   };

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@stacksjs/browser-extension",
   "type": "module",
-  "version": "0.70.146",
+  "version": "0.70.148",
   "description": "Build MV3 browser extensions (Chrome, Firefox, Safari) the Stacks way — manifest, content/background scripts, DNR rules, packaging, Safari container app, all config-driven.",
   "author": "Chris Breuer",
   "contributors": [