@stackoverflow/stacks 1.4.1 → 1.5.0

package/lib/css/components/spinner.less

@@ -1,36 +1,39 @@
-//
-//  STACK OVERFLOW
-//  SPINNER
-//
-//  This CSS comes from Stacks, our CSS & Pattern library for rapidly building
-//  Stack Overflow. For documentation of all these classes and how to contribute,
-//  visit https://stackoverflow.design/
-//
-//  TABLE OF CONTENTS
-//  • BASE STYLE
-//
-//  ============================================================================
-//  $   SPINNER BASE STYLE
-//  ----------------------------------------------------------------------------
-
 .s-spinner {
-    position: relative;
-    width: var(--su-static24);
-    height: var(--su-static24);
-    text-align: left; // When within a parent that has text-align: center, the spinner's entire container spins, not just the spinner. Let's force text-align left so things spin internally.
+    --_sp-baw: calc(var(--su-static1) * 3); // 3px
+    --_sp-size: var(--su-static24);
+
+    // MODIFIERS
+    &&__xs {
+        --_sp-baw: var(--su-static1);
+        --_sp-size: var(--su-static12);
+    }
+    &&__sm {
+        --_sp-baw: var(--su-static2);
+        --_sp-size: var(--su-static16);
+    }
+    &&__md {
+        --_sp-baw: var(--su-static4);
+        --_sp-size: var(--su-static32);
+    }
+    &&__lg {
+        --_sp-baw: var(--su-static6);
+        --_sp-size: var(--su-static48);
+    }
 
+    // CHILD ELEMENTS
     &:before,
     &:after {
+        border: var(--_sp-baw) solid currentColor;
+
+        border-radius: var(--br-circle);
         content: '';
+        height: 100%;
         position: absolute;
         width: 100%;
-        height: 100%;
-        border: 3px solid currentColor;
-        border-radius: var(--br-circle);
     }
     &:before {
         opacity: 0.25;
-        transform: rotate(90deg); // (*)
+        transform: rotate(90deg); // [1]
     }
     &:after {
         border-top-color: transparent;
@@ -39,99 +42,43 @@
         animation: s-spinner-rotate 0.9s infinite cubic-bezier(0.5, 0.1, 0.5, 0.9);
     }
 
-    &.s-spinner__xs {
-        width: var(--su-static12);
-        height: var(--su-static12);
-        &:before,
-        &:after {
-            border-width: 1px;
-        }
-    }
-
-    &.s-spinner__sm {
-        width: var(--su-static16);
-        height: var(--su-static16);
-        &:before,
-        &:after {
-            border-width: var(--su-static2);
-        }
-    }
-
-    &.s-spinner__md {
-        width: var(--su-static32);
-        height: var(--su-static32);
-        &:before,
-        &:after {
-            border-width: var(--su-static4);
-        }
-    }
-
-    &.s-spinner__lg {
-        width: var(--su-static48);
-        height: var(--su-static48);
-        &:before,
-        &:after {
-            border-width: var(--su-static6);
-        }
-    }
+    height: var(--_sp-size);
+    width: var(--_sp-size);
 
-    // Cross-browser fixes. These are all practically no-ops, so we could just specify them
-    // without browser hacks, but that would be punishing non-broken browsers with extra
-    // unnecessary compositing work.
-    &,
-    &:before,
-    &:after {
-        // Safari: At least at 1dpp resolution, Safari crops the transformed elements
-        // too aggressively, leading to a very visible flat edge part of the circle.
-        // This invisible box shadow increases the area that the effects work on and thus
-        // makes the circle round again.
-        //
-        // Targeting only Safari:
-        // https://browserstrangeness.bitbucket.io/css_hacks.html#safari
-        @media not all and (min-resolution: 0.001dpcm) {
-            @supports (-webkit-appearance:none) and (stroke-color:transparent) {
-                box-shadow: 0 0 0 2px transparent;
-            }
-        }
-    }
+    position: relative;
+    text-align: left; // [2]
 }
 
 .is-loading {
-    position: relative;
-    padding-left: 2.2em;
+    --_li-offset: 0.6em;
+    --_il-size: 1.23076923em;
 
-    &:before {
+    &:before,
+    &:after {
+        border-radius: var(--br-circle);
+        border-style: solid;
+        border-width: var(--su-static2);
         content: "";
+        height: var(--_il-size);
+        left: var(--_li-offset);
         position: absolute;
-        opacity: 0.3;
-        left: 0.6em;
-        top: calc(50% - 0.6em);
-        width: 1.23076923em;
-        height: 1.23076923em;
-        border-width: 2px;
-        border-style: solid;
+        top: calc(50% - var(--_li-offset));
+        width: var(--_il-size);
+    }
+    &:before {
         border-color: currentColor;
-        border-radius: var(--br-circle);
+        opacity: 0.3;
     }
-
     &:after {
-        content: "";
-        position: absolute;
-        left: 0.6em;
-        top: calc(50% - 0.6em);
-        width: 1.23076923em;
-        height: 1.23076923em;
-        border-width: 2px;
-        border-style: solid;
+        animation: s-spinner-rotate 0.9s infinite cubic-bezier(0.5, 0.1, 0.5, 0.9);
         border-color: transparent;
         border-left-color: currentColor;
-        border-radius: var(--br-circle);
-        animation: s-spinner-rotate 0.9s infinite
-            cubic-bezier(0.5, 0.1, 0.5, 0.9);
-        // see _stacks-spinner.less for an explanation of the following two
-        filter: invert(0); // (*)
-        transform-origin: 50% 50% 1px; // (*)
+        filter: invert(0); // [1]
+        transform-origin: 50% 50% 1px; // [1]
     }
+
+    padding-left: 2.2em;
+    position: relative;
 }
 
 // Keyframes
@@ -142,4 +89,7 @@
     to {
         transform: rotate(360deg);
     }
-}
+}
+
+// [1] no-op to reduce wobble in Edge. More info: https://github.com/StackExchange/Stacks/blob/d2af26aca06c47e3f1f7a638e49b221a9e28e450/lib/css/components/_stacks-spinner.less#L16-L26
+// [2] When within a parent that has text-align: center, the spinner's entire container spins, not just the spinner. Let's force text-align left so things spin internally.

package/lib/css/components/tags.less

@@ -23,6 +23,23 @@
         text-decoration: none;
     });
 
+    // STATES
+    &.is-selected {
+        &,
+        a&,
+        a&:active,
+        a&:hover,
+        a&:focus {
+            background-color: var(--_ta-bg-selected);
+            border-color: var(--_ta-bc-selected);
+            color: var(--_ta-fc-selected);
+
+            .highcontrast-mode({
+                border-color: currentColor;
+            });
+        }
+    }
+
     // MODIFIERS
     // Sizes
     &&__xs {
@@ -157,7 +174,6 @@
         max-width: calc(var(--su-static16) + var(--su-static2));
     }
 
-
     // INTERACTION
     a&:not(.is-selected) {
         &:hover,
@@ -172,22 +188,6 @@
             });
         }
     }
-    // Selected
-    &.is-selected {
-        &,
-        a&,
-        a&:active,
-        a&:hover,
-        a&:focus {
-            background-color: var(--_ta-bg-selected);
-            border-color: var(--_ta-bc-selected);
-            color: var(--_ta-fc-selected);
-
-            .highcontrast-mode({
-                border-color: currentColor;
-            });
-        }
-    }
 
     background-color: var(--_ta-bg);
     border: var(--su-static1) solid var(--_ta-bc);

package/lib/css/components/toggle-switches.less

@@ -1,145 +1,94 @@
-//
-//  STACK OVERFLOW
-//  TOGGLE SWITCHES
-//
-//  This CSS comes from Stacks, our CSS & Pattern library for rapidly building
-//  Stack Overflow. For documentation of all these classes and how to contribute,
-//  visit https://stackoverflow.design/
-//
-//  ============================================================================
-//  $   BASE STYLE
-//  ----------------------------------------------------------------------------
 .s-toggle-switch {
-    position: relative;
-
-    input[type="checkbox"] {
-        // Hide the checkbox underneath the .s-toggle-switch--indicator.
-        margin: 0; // guard against production adding 5px of margin to these
-        opacity: 0;
-        position: absolute;
-        left: 0;
-        top: 0;
-        width: 44px;
-        height: 24px;
-        cursor: pointer;
-
-        + .s-toggle-switch--indicator {
-            pointer-events: none;
-            outline: 0;
-            display: block;
-            width: 44px;
-            height: 24px;
-            position: relative;
-            background: var(--black-300);
-            border-radius: 1000px;
-            padding: 3px;
-            transition: left 0.2s ease;
-
-            &:after,
-            &:before {
-                position: relative;
-                display: block;
-                content: "";
-                width: 50%;
-                height: 100%;
-            }
-
-            &:after {
-                left: 0;
-                border-radius: 50%;
-                background: @white;
-                transition: left 0.1s ease;
-
-                .highcontrast-mode({
-                    background: var(--white);
-                });
-            }
-
-            &:before {
-                display: none;
-            }
-        }
-
-        &:checked + .s-toggle-switch--indicator {
-            background: var(--green-400);
-
-            &:after {
-                left: 50%;
+    --_ts-bg: var(--black-300);
+    --_ts-bg-ps: left center;
+    --_ts-bs-color: transparent;
+    // multiple
+    --_ts-multiple-bg: unset;
+    --_ts-multiple-fc: var(--black-500);
+
+    // TODO split single and multiple toggle into two seperate components
+    &&__multiple {
+        input[type="radio"] {
+            &:checked {
+                + label {
+                    &.s-toggle-switch--label-off {
+                        --_ts-multiple-bg: var(--black-500);
+                        --_ts-multiple-fc: var(--white);
+                        .dark-mode({ --_ts-multiple-bg: var(--black-350); });
+                    }
+                    &:not(.s-toggle-switch--label-off) {
+                        --_ts-multiple-bg: var(--green-400);
+                        --_ts-multiple-fc: @white;
+                        .highcontrast-mode({ --_ts-multiple-fc: var(--white); });
+                    }
+                }
+                &:focus + label {
+                    --_ts-bs-color: var(--focus-ring-success);
+                    &.s-toggle-switch--label-off { --_ts-bs-color: var(--focus-ring-muted); }
+                }
             }
-        }
-
-        &:focus + .s-toggle-switch--indicator {
-            box-shadow: 0 0 0 var(--su-static4) var(--focus-ring-muted);
-        }
-
-        &:checked:focus + .s-toggle-switch--indicator {
-            box-shadow: 0 0 0 var(--su-static4) var(--focus-ring-success);
-        }
-    }
 
-    &.s-toggle-switch__multiple {
-        display: flex;
-        align-items: stretch;
-
-        //  First hide the radio buttons
-        input[type="radio"] {
-            position: absolute;
             left: -999em;
-            opacity: 0;
             margin: 0;
+            opacity: 0;
+            position: absolute;
         }
-
-        //  Next modifications to option cells
         label {
-            //  Style the base label
-            width: 100%;
-            margin: 0;
-            padding: 0.5em 0.7em;
+            background-color: var(--_ts-multiple-bg);
+            box-shadow: 0 0 0 var(--su-static4) var(--_ts-bs-color);
+            color: var(--_ts-multiple-fc);
+
             border-radius: 1000px;
-            color: var(--black-500);
+            cursor: pointer;
             font-size: var(--fs-body1);
             font-weight: 400;
             line-height: 1;
+            margin: 0;
+            padding: 0.5em 0.7em;
             text-align: center;
             white-space: nowrap;
-            cursor: pointer;
-
+            width: 100%;
             -webkit-touch-callout: none;
             -webkit-user-select: none;
             user-select: none;
         }
 
-        //  If the input is selected, style its label accordingly.
-        input[type="radio"]:checked {
-            + label {
-                &.s-toggle-switch--label-off {
-                    background-color: var(--black-500);
-                    color: var(--white);
-
-                    .dark-mode({
-                        background-color: var(--black-350);
-                        // color: var(--black);
-                    });
-                }
+        align-items: stretch;
+        display: flex;
+    }
 
-                // Color activated options green
-                &:not(.s-toggle-switch--label-off) {
-                    background-color: var(--green-400);
-                    color: @white;
+    input[type="checkbox"], // TODO DEPRECATED: drop support for nested input[type="checkbox"]
+    input[type="checkbox"]& {
+        &:checked {
+            --_ts-bg: var(--green-400);
+            --_ts-bg-ps: right center;
 
-                    .highcontrast-mode({
-                        color: var(--white);
-                    });
-                }
+            &:focus {
+                --_ts-bs-color: var(--focus-ring-success);
             }
+        }
+        &:focus {
+            --_ts-bs-color: var(--focus-ring-muted);
+            outline: none;
+        }
+        &[disabled] {
+            cursor: default;
+        }
 
-            &:focus + label.s-toggle-switch--label-off {
-                box-shadow: 0 0 0 var(--su-static4) var(--focus-ring-muted);
-            }
+        background-color: var(--_ts-bg);
+        background-position: var(--_ts-bg-ps);
+        box-shadow: 0 0 0 var(--su-static4) var(--_ts-bs-color);
 
-            &:focus + label:not(.s-toggle-switch--label-off) {
-                box-shadow: 0 0 0 var(--su-static4) var(--focus-ring-success);
-            }
-        }
+        appearance: none;
+        background-image: url("data:image/svg+xml,%3csvg xmlns='http://www.w3.org/2000/svg' viewBox='-4 -4 8 8'%3e%3ccircle r='3' fill='%23fff'/%3e%3c/svg%3e"); // The white dot within the toggle
+        background-size: contain;
+        background-repeat: no-repeat;
+        border-radius: 1000px;
+        cursor: pointer;
+        height: var(--su-static24);
+        margin: 0; // guard against production adding 5px of margin to these
+        transition: background-position 0.2s ease;
+        vertical-align: top;
+        width: calc(var(--su-static48) - var(--su-static4));
     }
 }

package/lib/css/components/uploader.less

@@ -1,28 +1,20 @@
-//
-//  STACK OVERFLOW
-//  FILE UPLOAD -- DYNAMIC PARTS
-//
-//  This CSS comes from Stacks, our CSS & Pattern library for rapidly building
-//  Stack Overflow. For documentation of all these classes and how to contribute,
-//  visit https://stackoverflow.design/
-
 .s-uploader {
     --_up-bg: var(--black-025);
     --_up-bg-focus: var(--black-050);
     --_up-bg-bc: var(--black-150);
     --_up-focus-ring-color: var(--focus-ring);
-    // Static custom properties (not redefined but repeated enough to warrant a custom property)
     --_up-bg-b-image: url("data:image/svg+xml,%3csvg width='100%25' height='100%25' xmlns='http://www.w3.org/2000/svg'%3e%3crect width='100%25' height='100%25' fill='none' rx='5' ry='5' stroke='%23000000' stroke-width='8' stroke-dasharray='7%2c 22' stroke-dashoffset='0' stroke-linecap='square'/%3e%3c/svg%3e");
 
+    // CONTEXTUAL STYLES
     .highcontrast-mode({ --_up-bg-bc-hc: var(--black-400); });
 
-    // MODIFIERS
-    &.is-active {
-        --_up-bg: var(--black-050);
-        --_up-bg-bc: var(--black-200);
-    }
-    &.is-disabled {
-        opacity: var(--_o-disabled-static);
+    // STATES
+    &.has-error,
+    &.has-success,
+    &.has-warning {
+        .s-link {
+            color: var(--_up-link-fc);
+        }
     }
     &.has-error {
         --_up-bg: var(--red-050);
@@ -48,21 +40,28 @@
         --_up-focus-ring-color: var(--focus-ring-warning);
         --_up-link-fc: var(--yellow-900);
     }
-    &.has-error,
-    &.has-success,
-    &.has-warning {
-        .s-link {
-            color: var(--_up-link-fc);
-        }
+    &.is-active {
+        --_up-bg: var(--black-050);
+        --_up-bg-bc: var(--black-200);
+    }
+    &.is-disabled {
+        opacity: var(--_o-disabled-static);
     }
 
+
     //  CHILD ELEMENTS
-    // This is for safari shadow DOM
-    // see https://github.com/StackExchange/Stacks/pull/690#issuecomment-861028193
-    input[type="file"]::file-selector-button {
-        cursor: pointer;
-    }
     & &--container {
+        &:before { // Add the dashed border as an SVG background mask
+            -webkit-mask-image: var(--_up-bg-b-image);
+            mask-image: var(--_up-bg-b-image);
+            background-color: var(--_up-bg-bc-hc-state, var(--_up-bg-bc-hc, var(--_up-bg-bc)));
+            content: '';
+            border-radius: var(--br-lg);
+            display: block;
+            position: absolute;
+            inset: 0;
+        }
+
         align-items: center;
         background-color: var(--_up-bg);
         border-radius: var(--br-lg);
@@ -73,20 +72,13 @@
         padding: var(--su8) var(--su16);
         position: relative;
         text-align: center;
-
-        // Add the dashed border as an SVG background mask
-        &:before {
-            -webkit-mask-image: var(--_up-bg-b-image);
-            mask-image: var(--_up-bg-b-image);
-            background-color: var(--_up-bg-bc-hc-state, var(--_up-bg-bc-hc, var(--_up-bg-bc)));
-            content: '';
-            border-radius: var(--br-lg);
-            display: block;
-            position: absolute;
-            inset: 0;
-        }
     }
     & &--input {
+        &:focus:focus-visible + .s-uploader--container {
+            background-color: var(--_up-bg-focus);
+            box-shadow: 0 0 0 var(--su-static4) var(--_up-focus-ring-color);
+        }
+
         cursor: pointer;
         height: 100%;
         inset: 0;
@@ -94,26 +86,12 @@
         position: absolute;
         width: 100%;
         z-index: var(--zi-selected);
-
-        &:focus:focus-visible + .s-uploader--container {
-            background-color: var(--_up-bg-focus);
-            box-shadow: 0 0 0 var(--su-static4) var(--_up-focus-ring-color);
-        }
     }
     & &--preview {
         max-width: 100%;
         pointer-events: none;
     }
     & &--preview-thumbnail {
-        background-color: var(--white);
-        border-radius: var(--br-sm);
-        box-shadow: var(--bs-md);
-        max-height: var(--su-static128);
-        max-width: 100%;
-        overflow: hidden;
-        text-overflow: ellipsis;
-        white-space: nowrap;
-
         .highcontrast-mode({ border: 1px solid var(--black); });
 
         &:is(img) {
@@ -124,11 +102,17 @@
         &:not(img) {
             padding: var(--su16);
         }
+
+        background-color: var(--white);
+        border-radius: var(--br-sm);
+        box-shadow: var(--bs-md);
+        max-height: var(--su-static128);
+        max-width: 100%;
+        overflow: hidden;
+        text-overflow: ellipsis;
+        white-space: nowrap;
     }
     & &--previews {
-        max-width: 100%;
-        text-align: left;
-
         &.has-multiple {
             display: block;
             height: auto;
@@ -151,7 +135,6 @@
                     white-space: nowrap;
                 }
             }
-
             .s-uploader--preview-thumbnail {
                 color: transparent;
                 height: var(--su-static32);
@@ -168,6 +151,9 @@
                 }
             }
         }
+
+        max-width: 100%;
+        text-align: left;
     }
     & &--previews-heading {
         color: var(--black-900);
@@ -181,6 +167,11 @@
         top: var(--su8);
         z-index: var(--zi-active);
     }
+    // This is for safari shadow DOM
+    // see https://github.com/StackExchange/Stacks/pull/690#issuecomment-861028193
+    input[type="file"]::file-selector-button {
+        cursor: pointer;
+    }
 
     position: relative;
 }