@stackonward/cli 0.0.1 → 1.0.1

package/dist/resources/templates/go-backend/pkg/apierror/http_response_test.go

@@ -0,0 +1,216 @@
+package apierror
+
+import (
+	"net/http"
+	"reflect"
+	"testing"
+)
+
+func TestDecodeHTTPResponsePreservesCanonicalErrorDetail(t *testing.T) {
+	tests := []struct {
+		name        string
+		status      int
+		contentType string
+		body        string
+		want        ErrorDetail
+	}{
+		{
+			name:        "client error with charset and field detail",
+			status:      http.StatusUnprocessableEntity,
+			contentType: "application/json; charset=utf-8",
+			body: `{
+				"error": {
+					"type": "validation_error",
+					"code": "invalid_parameters",
+					"message": "Request validation failed",
+					"param": "email",
+					"errors": [{"field": "email", "message": "must be valid"}]
+				}
+			}`,
+			want: ErrorDetail{
+				Type: "validation_error", Code: "invalid_parameters", Message: "Request validation failed", Param: "email",
+				Errors: []FieldError{{Field: "email", Message: "must be valid"}},
+			},
+		},
+		{
+			name:        "server error",
+			status:      http.StatusServiceUnavailable,
+			contentType: "application/json",
+			body:        `{"error":{"type":"api_error","code":"service_unavailable","message":"Service is unavailable"}}`,
+			want:        ErrorDetail{Type: "api_error", Code: "service_unavailable", Message: "Service is unavailable"},
+		},
+	}
+
+	for _, test := range tests {
+		t.Run(test.name, func(t *testing.T) {
+			fallback := New(http.StatusBadGateway, TypeAPI, "dependency_contract_invalid", "Invalid platform error response")
+			err := DecodeHTTPResponse(test.status, headersWithContentType(test.contentType), []byte(test.body), fallback)
+			if err.Status != test.status || !reflect.DeepEqual(err.Detail, test.want) {
+				t.Fatalf("decoded error = %#v, want status=%d detail=%#v", err, test.status, test.want)
+			}
+		})
+	}
+}
+
+func TestDecodeHTTPResponseProjectsValidatedRetryAfter(t *testing.T) {
+	tests := []struct {
+		name             string
+		status           int
+		retryAfterValues []string
+		want             string
+	}{
+		{name: "429 without header", status: http.StatusTooManyRequests},
+		{name: "503 without header", status: http.StatusServiceUnavailable},
+		{name: "429 delta seconds", status: http.StatusTooManyRequests, retryAfterValues: []string{"120"}, want: "120"},
+		{name: "429 delta seconds with optional whitespace", status: http.StatusTooManyRequests, retryAfterValues: []string{"\t120 "}, want: "120"},
+		{name: "503 zero delta seconds", status: http.StatusServiceUnavailable, retryAfterValues: []string{"0"}, want: "0"},
+		{
+			name:             "503 IMF fixdate",
+			status:           http.StatusServiceUnavailable,
+			retryAfterValues: []string{"Sun, 06 Nov 1994 08:49:37 GMT"},
+			want:             "Sun, 06 Nov 1994 08:49:37 GMT",
+		},
+		{
+			name:             "503 obsolete RFC850 date",
+			status:           http.StatusServiceUnavailable,
+			retryAfterValues: []string{"Sunday, 06-Nov-94 08:49:37 GMT"},
+			want:             "Sun, 06 Nov 1994 08:49:37 GMT",
+		},
+		{
+			name:             "503 ANSI C asctime date",
+			status:           http.StatusServiceUnavailable,
+			retryAfterValues: []string{"Sun Nov  6 08:49:37 1994"},
+			want:             "Sun, 06 Nov 1994 08:49:37 GMT",
+		},
+		{name: "unrelated client error ignores malformed value", status: http.StatusBadRequest, retryAfterValues: []string{"soon"}},
+		{name: "unrelated gateway error ignores multiple values", status: http.StatusBadGateway, retryAfterValues: []string{"120", "240"}},
+	}
+
+	body := []byte(`{"error":{"type":"api_error","code":"upstream_error","message":"Upstream request failed"}}`)
+	for _, test := range tests {
+		t.Run(test.name, func(t *testing.T) {
+			headers := headersWithContentType("application/json")
+			for _, value := range test.retryAfterValues {
+				headers.Add("Retry-After", value)
+			}
+			err := DecodeHTTPResponse(test.status, headers, body, nil)
+			if err.Status != test.status {
+				t.Fatalf("decoded status = %d, want %d", err.Status, test.status)
+			}
+			if got := err.HTTPResponseMetadata().RetryAfter(); got != test.want {
+				t.Fatalf("RetryAfter = %q, want %q", got, test.want)
+			}
+		})
+	}
+}
+
+func TestDecodeHTTPResponseRejectsInvalidRetryAfter(t *testing.T) {
+	tests := []struct {
+		name             string
+		status           int
+		retryAfterValues []string
+	}{
+		{name: "empty value", status: http.StatusTooManyRequests, retryAfterValues: []string{""}},
+		{name: "whitespace value", status: http.StatusTooManyRequests, retryAfterValues: []string{" \t"}},
+		{name: "malformed value", status: http.StatusTooManyRequests, retryAfterValues: []string{"soon"}},
+		{name: "negative value", status: http.StatusTooManyRequests, retryAfterValues: []string{"-1"}},
+		{name: "decimal value", status: http.StatusTooManyRequests, retryAfterValues: []string{"1.5"}},
+		{name: "duplicate values", status: http.StatusTooManyRequests, retryAfterValues: []string{"120", "120"}},
+		{name: "multiple values", status: http.StatusServiceUnavailable, retryAfterValues: []string{"120", "240"}},
+		{name: "combined delta values", status: http.StatusTooManyRequests, retryAfterValues: []string{"120, 240"}},
+		{
+			name:   "combined date values",
+			status: http.StatusServiceUnavailable,
+			retryAfterValues: []string{
+				"Sun, 06 Nov 1994 08:49:37 GMT, Sun, 06 Nov 1994 08:49:38 GMT",
+			},
+		},
+	}
+
+	body := []byte(`{"error":{"type":"api_error","code":"upstream_error","message":"Upstream request failed"}}`)
+	for _, test := range tests {
+		t.Run(test.name, func(t *testing.T) {
+			headers := headersWithContentType("application/json")
+			for _, value := range test.retryAfterValues {
+				headers.Add("Retry-After", value)
+			}
+			fallback := New(http.StatusBadGateway, TypeAPI, "dependency_contract_invalid", "Invalid platform error response")
+			decoded := DecodeHTTPResponse(test.status, headers, body, fallback)
+
+			if decoded != fallback {
+				t.Fatalf("decoded error = %#v, want explicit fallback %#v", decoded, fallback)
+			}
+			if got := decoded.HTTPResponseMetadata().RetryAfter(); got != "" {
+				t.Fatalf("fallback RetryAfter = %q, want empty", got)
+			}
+		})
+	}
+}
+
+func TestDecodeHTTPResponseRejectsNonCanonicalResponse(t *testing.T) {
+	tests := []struct {
+		name        string
+		status      int
+		contentType string
+		body        string
+	}{
+		{name: "missing content type", status: http.StatusBadRequest, body: `{"error":{"type":"api_error","code":"upstream_failed","message":"upstream failed"}}`},
+		{name: "problem media type", status: http.StatusBadRequest, contentType: "application/problem+json", body: `{"error":{"type":"api_error","code":"upstream_failed","message":"upstream failed"}}`},
+		{name: "vendor media type", status: http.StatusBadRequest, contentType: "application/vnd.onex+json", body: `{"error":{"type":"api_error","code":"upstream_failed","message":"upstream failed"}}`},
+		{name: "malformed media type", status: http.StatusBadRequest, contentType: "application/json; charset", body: `{"error":{"type":"api_error","code":"upstream_failed","message":"upstream failed"}}`},
+		{name: "non error status", status: http.StatusMultipleChoices, contentType: "application/json", body: `{"error":{"type":"api_error","code":"upstream_failed","message":"upstream failed"}}`},
+		{name: "missing envelope", status: http.StatusBadRequest, contentType: "application/json", body: `{"message":"upstream failed"}`},
+		{name: "null envelope", status: http.StatusBadRequest, contentType: "application/json", body: `{"error":null}`},
+		{name: "case variant envelope property", status: http.StatusBadRequest, contentType: "application/json", body: `{"Error":{"type":"api_error","code":"upstream_failed","message":"upstream failed"}}`},
+		{name: "duplicate envelope property", status: http.StatusBadRequest, contentType: "application/json", body: `{"error":{"type":"api_error","code":"upstream_failed","message":"upstream failed"},"error":{"type":"api_error","code":"upstream_failed","message":"upstream failed"}}`},
+		{name: "unknown envelope property", status: http.StatusBadRequest, contentType: "application/json", body: `{"error":{"type":"api_error","code":"upstream_failed","message":"upstream failed"},"status":400}`},
+		{name: "direct problem details", status: http.StatusBadRequest, contentType: "application/json", body: `{"type":"urn:problem","status":400,"title":"Bad Request"}`},
+		{name: "case variant detail property", status: http.StatusBadRequest, contentType: "application/json", body: `{"error":{"Type":"api_error","code":"upstream_failed","message":"upstream failed"}}`},
+		{name: "duplicate detail property", status: http.StatusBadRequest, contentType: "application/json", body: `{"error":{"type":"api_error","code":"first","code":"second","message":"upstream failed"}}`},
+		{name: "unknown detail property", status: http.StatusBadRequest, contentType: "application/json", body: `{"error":{"type":"api_error","code":"upstream_failed","message":"upstream failed","status":400}}`},
+		{name: "missing type", status: http.StatusBadRequest, contentType: "application/json", body: `{"error":{"code":"upstream_failed","message":"upstream failed"}}`},
+		{name: "missing code", status: http.StatusBadRequest, contentType: "application/json", body: `{"error":{"type":"api_error","message":"upstream failed"}}`},
+		{name: "missing message", status: http.StatusBadRequest, contentType: "application/json", body: `{"error":{"type":"api_error","code":"upstream_failed"}}`},
+		{name: "blank type", status: http.StatusBadRequest, contentType: "application/json", body: `{"error":{"type":" ","code":"upstream_failed","message":"upstream failed"}}`},
+		{name: "blank code", status: http.StatusBadRequest, contentType: "application/json", body: `{"error":{"type":"api_error","code":"\t","message":"upstream failed"}}`},
+		{name: "blank message", status: http.StatusBadRequest, contentType: "application/json", body: `{"error":{"type":"api_error","code":"upstream_failed","message":"\n"}}`},
+		{name: "empty param", status: http.StatusBadRequest, contentType: "application/json", body: `{"error":{"type":"api_error","code":"upstream_failed","message":"upstream failed","param":""}}`},
+		{name: "blank param", status: http.StatusBadRequest, contentType: "application/json", body: `{"error":{"type":"api_error","code":"upstream_failed","message":"upstream failed","param":" "}}`},
+		{name: "null param", status: http.StatusBadRequest, contentType: "application/json", body: `{"error":{"type":"api_error","code":"upstream_failed","message":"upstream failed","param":null}}`},
+		{name: "null errors", status: http.StatusBadRequest, contentType: "application/json", body: `{"error":{"type":"api_error","code":"upstream_failed","message":"upstream failed","errors":null}}`},
+		{name: "non array errors", status: http.StatusBadRequest, contentType: "application/json", body: `{"error":{"type":"api_error","code":"upstream_failed","message":"upstream failed","errors":{}}}`},
+		{name: "unknown field error property", status: http.StatusBadRequest, contentType: "application/json", body: `{"error":{"type":"api_error","code":"upstream_failed","message":"upstream failed","errors":[{"field":"email","message":"invalid","code":"invalid"}]}}`},
+		{name: "case variant field error property", status: http.StatusBadRequest, contentType: "application/json", body: `{"error":{"type":"api_error","code":"upstream_failed","message":"upstream failed","errors":[{"Field":"email","message":"invalid"}]}}`},
+		{name: "duplicate field error property", status: http.StatusBadRequest, contentType: "application/json", body: `{"error":{"type":"api_error","code":"upstream_failed","message":"upstream failed","errors":[{"field":"email","field":"name","message":"invalid"}]}}`},
+		{name: "missing field error field", status: http.StatusBadRequest, contentType: "application/json", body: `{"error":{"type":"api_error","code":"upstream_failed","message":"upstream failed","errors":[{"message":"invalid"}]}}`},
+		{name: "blank field error field", status: http.StatusBadRequest, contentType: "application/json", body: `{"error":{"type":"api_error","code":"upstream_failed","message":"upstream failed","errors":[{"field":" ","message":"invalid"}]}}`},
+		{name: "blank field error message", status: http.StatusBadRequest, contentType: "application/json", body: `{"error":{"type":"api_error","code":"upstream_failed","message":"upstream failed","errors":[{"field":"email","message":" "}]}}`},
+		{name: "trailing json", status: http.StatusBadRequest, contentType: "application/json", body: `{"error":{"type":"api_error","code":"upstream_failed","message":"upstream failed"}} {}`},
+		{name: "malformed json", status: http.StatusBadRequest, contentType: "application/json", body: `{"error":`},
+	}
+
+	for _, test := range tests {
+		t.Run(test.name, func(t *testing.T) {
+			fallback := New(http.StatusBadGateway, TypeAPI, "dependency_contract_invalid", "Invalid platform error response")
+			err := DecodeHTTPResponse(test.status, headersWithContentType(test.contentType), []byte(test.body), fallback)
+			if err != fallback {
+				t.Fatalf("decoded error = %#v, want explicit fallback %#v", err, fallback)
+			}
+		})
+	}
+}
+
+func TestDecodeHTTPResponseUsesInternalFallbackWhenNoneProvided(t *testing.T) {
+	err := DecodeHTTPResponse(http.StatusBadRequest, headersWithContentType("text/plain"), []byte("bad request"), nil)
+	if err.Status != http.StatusInternalServerError || err.Detail.Code != CodeInternalError {
+		t.Fatalf("decoded fallback = %#v", err)
+	}
+}
+
+func headersWithContentType(contentType string) http.Header {
+	headers := make(http.Header)
+	if contentType != "" {
+		headers.Set("Content-Type", contentType)
+	}
+	return headers
+}

package/dist/resources/templates/go-backend/scripts/check-openapi-clean-deletion.sh

@@ -0,0 +1,54 @@
+#!/usr/bin/env bash
+
+set -euo pipefail
+
+BACKEND_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
+
+fail_if_matches() {
+  local label="$1"
+  shift
+  local output
+  local status=0
+  output="$(rg -n "$@")" || status=$?
+  if [[ "$status" -gt 1 ]]; then
+    echo "${label}: scanner failed with exit ${status}" >&2
+    exit "$status"
+  fi
+  if [[ -n "$output" ]]; then
+    echo "${label}:" >&2
+    printf '%s\n' "$output" >&2
+    exit 1
+  fi
+}
+
+fail_if_matches "Swaggo imports remain" 'github\.com/swaggo/' "$BACKEND_DIR" --glob '*.go' --glob 'go.mod' --glob 'go.sum'
+fail_if_matches "Swagger-only apierror imports remain" '^\s*_\s+"[^"]+/pkg/apierror"' "$BACKEND_DIR" --glob '*.go'
+fail_if_matches "Swagger annotations remain" '^\s*//\s*@[[:alpha:]]' "$BACKEND_DIR" --glob '*.go'
+fail_if_matches "Swagger-only struct tags remain" '(^|[[:space:]`])(swaggertype|example|format):"' "$BACKEND_DIR" --glob '*.go'
+fail_if_matches "Swagger runtime registry reads remain" 'swag\.ReadDoc' "$BACKEND_DIR" --glob '*.go'
+fail_if_matches "Retired Swagger commands remain" 'make swag|generate-swagger|swagger_route_inventory' \
+  "$BACKEND_DIR/Makefile" "$BACKEND_DIR/CLAUDE.md" "$BACKEND_DIR/.claude/docs" \
+  --glob '!**/worktrees/**'
+fail_if_matches "Retired Swagger guidance remains" 'Swagger/security|Swagger/API docs' \
+  "$BACKEND_DIR/CLAUDE.md" "$BACKEND_DIR/.claude/docs"
+fail_if_matches "Retired Swagger documentation pipelines remain" \
+  'swaggo/swag|CMS_SWAGGER_URL|/swagger/doc\.json|Go Swagger' "$BACKEND_DIR/docs" --glob '*.md'
+
+for path in \
+  "$BACKEND_DIR/scripts/generate-swagger.sh" \
+  "$BACKEND_DIR/scripts/swagger_route_inventory.py" \
+  "$BACKEND_DIR/scripts/swagger_route_inventory_test.py" \
+  "$BACKEND_DIR/.claude/docs/swagger.md"
+do
+  if [[ -e "$path" ]]; then
+    echo "retired Swagger artifact remains: ${path#"$BACKEND_DIR/"}" >&2
+    exit 1
+  fi
+done
+
+if find "$BACKEND_DIR/cmd" -type f \( -name 'swagger.json' -o -name 'swagger.yaml' \) -print -quit | grep -q .; then
+  echo "retired Swagger generated artifacts remain under cmd" >&2
+  exit 1
+fi
+
+echo "OpenAPI clean-deletion gate passed"

package/dist/resources/templates/go-backend/scripts/test-migrations.sh

@@ -0,0 +1,32 @@
+#!/usr/bin/env bash
+set -euo pipefail
+backend_root="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
+probe_name="backend-migrations-${RANDOM}-$$"
+cleanup() { docker rm -f "$probe_name" >/dev/null 2>&1 || true; }
+trap cleanup EXIT
+# 仅创建独立测试容器，避免测试连接产品数据库。
+docker run -d --name "$probe_name" -e POSTGRES_HOST_AUTH_METHOD=trust -e POSTGRES_DB=migrations_test postgres:16-alpine >/dev/null
+ready=false
+for ((attempt=0; attempt<30; attempt++)); do
+  if docker exec "$probe_name" pg_isready -h 127.0.0.1 -U postgres -d migrations_test >/dev/null 2>&1; then
+    ready=true
+    break
+  fi
+  sleep 1
+done
+if [[ "$ready" != true ]]; then
+  docker logs "$probe_name"
+  exit 1
+fi
+migration_files=("$backend_root"/migrations/*.up.sql)
+for migration in "${migration_files[@]}"; do
+  docker exec -i "$probe_name" psql -q -U postgres -d migrations_test -v ON_ERROR_STOP=1 < "$migration"
+done
+for ((index=${#migration_files[@]}-1; index>=0; index--)); do
+  migration="${migration_files[$index]%.up.sql}.down.sql"
+  docker exec -i "$probe_name" psql -q -U postgres -d migrations_test -v ON_ERROR_STOP=1 < "$migration"
+done
+for migration in "${migration_files[@]}"; do
+  docker exec -i "$probe_name" psql -q -U postgres -d migrations_test -v ON_ERROR_STOP=1 < "$migration"
+done
+docker exec -i "$probe_name" psql -q -U postgres -d migrations_test -v ON_ERROR_STOP=1 < "$backend_root/tests/infrastructure.sql"

package/dist/resources/templates/go-backend/tests/infrastructure.sql

@@ -0,0 +1,69 @@
+BEGIN;
+
+DO $$
+DECLARE
+    table_count integer;
+BEGIN
+    SELECT count(*) INTO table_count FROM information_schema.tables
+    WHERE table_schema = 'public' AND table_name IN (
+        'sys_access_logs', 'sys_login_logs', 'sys_audit_logs', 'sys_operation_logs',
+        'sys_audit_event_inbox', 'sys_outbox_events', 'sys_outbox_event_deliveries',
+        'sys_command_replay_records'
+    );
+    IF table_count <> 8 THEN
+        RAISE EXCEPTION 'infrastructure tables are incomplete';
+    END IF;
+
+    INSERT INTO sys_command_replay_records (
+        namespace, command_scope, idempotency_key, request_hash, expires_at
+    ) VALUES ('company.product.action', 'actor', 'request-1', repeat('a', 64), now() + interval '1 hour');
+    BEGIN
+        INSERT INTO sys_command_replay_records (
+            namespace, command_scope, idempotency_key, request_hash, expires_at
+        ) VALUES ('company.product.action', 'actor', 'request-1', repeat('a', 64), now() + interval '1 hour');
+        RAISE EXCEPTION 'duplicate command was accepted';
+    EXCEPTION WHEN unique_violation THEN NULL;
+    END;
+    BEGIN
+        UPDATE sys_command_replay_records SET status = 'failed'
+        WHERE namespace = 'company.product.action';
+        RAISE EXCEPTION 'incomplete failed command was accepted';
+    EXCEPTION WHEN check_violation THEN NULL;
+    END;
+
+    INSERT INTO sys_outbox_events (aggregate_type, aggregate_id, event_type, payload, outbox_ref)
+    VALUES ('resource', 'resource-1', 'resource.created', '{}', 'obx_abcdefgh1234');
+    BEGIN
+        UPDATE sys_outbox_events SET outbox_ref = 'obx_abcdefgh5678'
+        WHERE outbox_ref = 'obx_abcdefgh1234';
+        RAISE EXCEPTION 'outbox identity mutation was accepted';
+    EXCEPTION WHEN check_violation THEN NULL;
+    END;
+    BEGIN
+        UPDATE sys_outbox_events SET schema_version = 'resource.v2'
+        WHERE outbox_ref = 'obx_abcdefgh1234';
+        RAISE EXCEPTION 'outbox schema version mutation was accepted';
+    EXCEPTION WHEN object_not_in_prerequisite_state THEN NULL;
+    END;
+
+    INSERT INTO sys_operation_logs (actor_type, operation_action, record_status)
+    VALUES ('system', 'resource.update', 'started');
+    UPDATE sys_operation_logs SET record_status = 'completed'
+    WHERE operation_action = 'resource.update';
+    BEGIN
+        DELETE FROM sys_operation_logs WHERE operation_action = 'resource.update';
+        RAISE EXCEPTION 'operation log deletion was accepted';
+    EXCEPTION WHEN raise_exception THEN
+        IF SQLERRM <> 'sys_operation_logs are append-only' THEN RAISE; END IF;
+    END;
+    BEGIN
+        UPDATE sys_operation_logs SET record_status = 'started'
+        WHERE operation_action = 'resource.update';
+        RAISE EXCEPTION 'finalized operation log mutation was accepted';
+    EXCEPTION WHEN raise_exception THEN
+        IF SQLERRM <> 'sys_operation_logs only allow started to completed transition' THEN RAISE; END IF;
+    END;
+END
+$$;
+
+ROLLBACK;