@stackforge-eu/factur-x 1.4.4 → 1.4.6

package/CHANGELOG.md

@@ -7,6 +7,25 @@ and this project adheres to [Semantic Versioning](https://semver.org/).
 
 ## [Unreleased]
 
+## [1.4.6] — 2026-11-14
+
+- **Fixed MINIMUM XML failing XSD validation when optional party fields are
+  set.** `buildXml` wrote a party's `id`, `globalId`,
+  `legalOrganization.tradingName` and `electronicAddress` in every profile,
+  but the MINIMUM schema allows none of them. They are now dropped for
+  MINIMUM, like `address` and `contact` already were, and still written from
+  BASIC WL upwards (#28).
+
+## [1.4.5] — 2026-11-14
+
+- **Fixed derived line net amount ignoring `basisQuantity`.** When a line
+  omits `lineTotal`, `buildXml` and the BR-CO-10 check in `validateInput`
+  computed it as `quantity * unitPrice`, so a price per 100 units produced a
+  line total 100× too high and a correct `totals.lineTotal` was rejected. The
+  amount is now `quantity * unitPrice / basisQuantity` (EN 16931 BT-131),
+  rounded per line in both places. Reported by @trackoor (#26).
+- **`validateInput` rejects a `basisQuantity` that is not greater than zero.**
+
 ## [1.4.4] — 2026-11-09
 
 - **Fixed header reference element order.** `buildXml` emitted
@@ -291,6 +310,8 @@ This element is not expected`. Reordered the three blocks in
 - Deno compatibility test suite
 
 [Unreleased]: https://github.com/StackForge-EU/factur-x/commits/main
+[1.4.6]: https://github.com/StackForge-EU/factur-x/compare/v1.4.5...v1.4.6
+[1.4.5]: https://github.com/StackForge-EU/factur-x/compare/v1.4.4...v1.4.5
 [1.4.4]: https://github.com/StackForge-EU/factur-x/compare/v1.4.3...v1.4.4
 [1.4.3]: https://github.com/StackForge-EU/factur-x/compare/v1.4.2...v1.4.3
 [1.4.2]: https://github.com/StackForge-EU/factur-x/compare/v1.4.1...v1.4.2

package/dist/index.cjs

@@ -289,6 +289,9 @@ function toCents(n) {
 function roundHalfUp(n) {
   return toCents(n) / 100;
 }
+function deriveLineNet(line) {
+  return roundHalfUp(line.quantity * line.unitPrice / (line.basisQuantity ?? 1));
+}
 
 // src/core/xml-builder.ts
 var PROFILE_LEVEL = {
@@ -352,11 +355,12 @@ function buildContact(c) {
 }
 function buildParty(p, profile) {
   let x = "";
-  if (p.id) {
+  const beyondMinimum = atLeast(profile, "BASIC_WL" /* BASIC_WL */);
+  if (p.id && beyondMinimum) {
     const ids = Array.isArray(p.id) ? p.id : [p.id];
     for (const id of ids) x += tag("ram:ID", escapeXml(id));
   }
-  if (p.globalId) {
+  if (p.globalId && beyondMinimum) {
     x += tag("ram:GlobalID", escapeXml(p.globalId.value), { schemeID: p.globalId.schemeID });
   }
   x += tag("ram:Name", escapeXml(p.name));
@@ -371,13 +375,13 @@ function buildParty(p, profile) {
         p.legalOrganization.schemeID ? { schemeID: p.legalOrganization.schemeID } : void 0
       );
     }
-    if (p.legalOrganization.tradingName)
+    if (p.legalOrganization.tradingName && beyondMinimum)
       lo += tag("ram:TradingBusinessName", escapeXml(p.legalOrganization.tradingName));
     x += tag("ram:SpecifiedLegalOrganization", lo);
   }
   if (p.contact && atLeast(profile, "EN16931" /* EN16931 */)) x += buildContact(p.contact);
-  if (p.address && atLeast(profile, "BASIC_WL" /* BASIC_WL */)) x += buildAddress(p.address);
-  if (p.electronicAddress)
+  if (p.address && beyondMinimum) x += buildAddress(p.address);
+  if (p.electronicAddress && beyondMinimum)
     x += tag(
       "ram:URIUniversalCommunication",
       tag("ram:URIID", escapeXml(p.electronicAddress.value), {
@@ -451,7 +455,7 @@ function buildLineItem(line, profile) {
       tx += tag("ram:RateApplicablePercent", line.vatRatePercent.toString());
     settle += tag("ram:ApplicableTradeTax", tx);
   }
-  const lineTotal = line.lineTotal ?? roundHalfUp(line.quantity * line.unitPrice);
+  const lineTotal = line.lineTotal ?? deriveLineNet(line);
   settle += tag(
     "ram:SpecifiedTradeSettlementLineMonetarySummation",
     tag("ram:LineTotalAmount", fmtAmt(lineTotal))
@@ -879,6 +883,14 @@ function validateInput(input, profile, flavor) {
         if (line.unitPrice == null) {
           addError(errors, `lines[${i}].unitPrice`, "Line unit price is required", "BASIC" /* BASIC */);
         }
+        if (line.basisQuantity != null && !(line.basisQuantity > 0)) {
+          addError(
+            errors,
+            `lines[${i}].basisQuantity`,
+            "Line price base quantity (BT-149) must be greater than zero",
+            "BASIC" /* BASIC */
+          );
+        }
       });
     }
   }
@@ -975,8 +987,8 @@ function validateInput(input, profile, flavor) {
   }
   if (req("BASIC" /* BASIC */) && input.totals && input.lines) {
     const sumLineNets = input.lines.reduce((sum, l) => {
-      const lineNet = l.lineTotal ?? (typeof l.quantity === "number" && typeof l.unitPrice === "number" ? l.quantity * l.unitPrice : 0);
-      return sum + lineNet;
+      const lineNet = l.lineTotal ?? deriveLineNet(l);
+      return sum + (Number.isFinite(lineNet) ? lineNet : 0);
     }, 0);
     if (input.totals.lineTotal != null) {
       if (amountsDiffer(input.totals.lineTotal, sumLineNets)) {

package/dist/index.d.cts

@@ -596,7 +596,8 @@ interface InvoiceLineInput {
      */
     basisQuantityUnitCode?: UnitCode | (string & Record<never, never>);
     /**
-     * Line total (net) — can be derived from `quantity * unitPrice`.
+     * Line total (net). Derived as `quantity * unitPrice / (basisQuantity ?? 1)`,
+     * rounded to two decimals, when omitted.
      * @see EN 16931 BT-131
      */
     lineTotal?: number;

package/dist/index.d.ts

@@ -596,7 +596,8 @@ interface InvoiceLineInput {
      */
     basisQuantityUnitCode?: UnitCode | (string & Record<never, never>);
     /**
-     * Line total (net) — can be derived from `quantity * unitPrice`.
+     * Line total (net). Derived as `quantity * unitPrice / (basisQuantity ?? 1)`,
+     * rounded to two decimals, when omitted.
      * @see EN 16931 BT-131
      */
     lineTotal?: number;

package/dist/index.js

@@ -259,6 +259,9 @@ function toCents(n) {
 function roundHalfUp(n) {
   return toCents(n) / 100;
 }
+function deriveLineNet(line) {
+  return roundHalfUp(line.quantity * line.unitPrice / (line.basisQuantity ?? 1));
+}
 
 // src/core/xml-builder.ts
 var PROFILE_LEVEL = {
@@ -322,11 +325,12 @@ function buildContact(c) {
 }
 function buildParty(p, profile) {
   let x = "";
-  if (p.id) {
+  const beyondMinimum = atLeast(profile, "BASIC_WL" /* BASIC_WL */);
+  if (p.id && beyondMinimum) {
     const ids = Array.isArray(p.id) ? p.id : [p.id];
     for (const id of ids) x += tag("ram:ID", escapeXml(id));
   }
-  if (p.globalId) {
+  if (p.globalId && beyondMinimum) {
     x += tag("ram:GlobalID", escapeXml(p.globalId.value), { schemeID: p.globalId.schemeID });
   }
   x += tag("ram:Name", escapeXml(p.name));
@@ -341,13 +345,13 @@ function buildParty(p, profile) {
         p.legalOrganization.schemeID ? { schemeID: p.legalOrganization.schemeID } : void 0
       );
     }
-    if (p.legalOrganization.tradingName)
+    if (p.legalOrganization.tradingName && beyondMinimum)
       lo += tag("ram:TradingBusinessName", escapeXml(p.legalOrganization.tradingName));
     x += tag("ram:SpecifiedLegalOrganization", lo);
   }
   if (p.contact && atLeast(profile, "EN16931" /* EN16931 */)) x += buildContact(p.contact);
-  if (p.address && atLeast(profile, "BASIC_WL" /* BASIC_WL */)) x += buildAddress(p.address);
-  if (p.electronicAddress)
+  if (p.address && beyondMinimum) x += buildAddress(p.address);
+  if (p.electronicAddress && beyondMinimum)
     x += tag(
       "ram:URIUniversalCommunication",
       tag("ram:URIID", escapeXml(p.electronicAddress.value), {
@@ -421,7 +425,7 @@ function buildLineItem(line, profile) {
       tx += tag("ram:RateApplicablePercent", line.vatRatePercent.toString());
     settle += tag("ram:ApplicableTradeTax", tx);
   }
-  const lineTotal = line.lineTotal ?? roundHalfUp(line.quantity * line.unitPrice);
+  const lineTotal = line.lineTotal ?? deriveLineNet(line);
   settle += tag(
     "ram:SpecifiedTradeSettlementLineMonetarySummation",
     tag("ram:LineTotalAmount", fmtAmt(lineTotal))
@@ -849,6 +853,14 @@ function validateInput(input, profile, flavor) {
         if (line.unitPrice == null) {
           addError(errors, `lines[${i}].unitPrice`, "Line unit price is required", "BASIC" /* BASIC */);
         }
+        if (line.basisQuantity != null && !(line.basisQuantity > 0)) {
+          addError(
+            errors,
+            `lines[${i}].basisQuantity`,
+            "Line price base quantity (BT-149) must be greater than zero",
+            "BASIC" /* BASIC */
+          );
+        }
       });
     }
   }
@@ -945,8 +957,8 @@ function validateInput(input, profile, flavor) {
   }
   if (req("BASIC" /* BASIC */) && input.totals && input.lines) {
     const sumLineNets = input.lines.reduce((sum, l) => {
-      const lineNet = l.lineTotal ?? (typeof l.quantity === "number" && typeof l.unitPrice === "number" ? l.quantity * l.unitPrice : 0);
-      return sum + lineNet;
+      const lineNet = l.lineTotal ?? deriveLineNet(l);
+      return sum + (Number.isFinite(lineNet) ? lineNet : 0);
     }, 0);
     if (input.totals.lineTotal != null) {
       if (amountsDiffer(input.totals.lineTotal, sumLineNets)) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@stackforge-eu/factur-x",
-  "version": "1.4.4",
+  "version": "1.4.6",
   "type": "module",
   "description": "Embed Factur-X, ZUGFeRD, and XRechnung structured invoice XML into PDF/A-3 documents",
   "keywords": [
@@ -41,7 +41,7 @@
     "type": "git",
     "url": "git+https://github.com/StackForge-EU/factur-x.git"
   },
-  "homepage": "https://www.stack-forge.eu",
+  "homepage": "https://factur-x.deployo.eu",
   "bugs": {
     "url": "https://github.com/StackForge-EU/factur-x/issues"
   },