@stackforge-eu/factur-x 1.4.2 → 1.4.3

package/CHANGELOG.md

@@ -7,6 +7,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/).
 
 ## [Unreleased]
 
+## [1.4.3] — 2026-09-28
+
+- **Fixed half-cent rounding.** `Math.round(n * 100) / 100` turns
+  `402.50 × 19%` (`76.475`) into `76.47`, because `76.475 * 100` is
+  `7647.499999999999`, so `validateInput` rejected the correctly rounded
+  `76.48` (BR-CO-17). Amounts are now rounded half away from zero on a
+  noise-free value and compared in integer cents, in the validator and in
+  the XML builder alike. Reported by @johannesspohr (#21).
+
 ## [1.4.2] — 2026-09-25
 
 - **Fixed the embedded XML MIME type back to `text/xml`.** 1.2.1 switched the
@@ -265,6 +274,7 @@ This element is not expected`. Reordered the three blocks in
 - Deno compatibility test suite
 
 [Unreleased]: https://github.com/StackForge-EU/factur-x/commits/main
+[1.4.3]: https://github.com/StackForge-EU/factur-x/compare/v1.4.2...v1.4.3
 [1.4.2]: https://github.com/StackForge-EU/factur-x/compare/v1.4.1...v1.4.2
 [1.4.1]: https://github.com/StackForge-EU/factur-x/compare/v1.4.0...v1.4.1
 [1.4.0]: https://github.com/StackForge-EU/factur-x/compare/v1.3.1...v1.4.0

package/dist/index.cjs

@@ -281,6 +281,15 @@ function resolveBusinessProcessUrn(input, flavor) {
   return FLAVOR_CONFIGS[flavor].businessProcessUrn;
 }
 
+// src/core/rounding.ts
+function toCents(n) {
+  const cents = Math.round(Number((Math.abs(n) * 100).toPrecision(15)));
+  return n < 0 ? -cents : cents;
+}
+function roundHalfUp(n) {
+  return toCents(n) / 100;
+}
+
 // src/core/xml-builder.ts
 var PROFILE_LEVEL = {
   MINIMUM: 0,
@@ -305,7 +314,7 @@ function fmtAmt(n) {
   if (!Number.isFinite(n)) {
     throw new Error(`Invalid amount value: ${n}. Expected a finite number.`);
   }
-  return n.toFixed(2);
+  return roundHalfUp(n).toFixed(2);
 }
 function fmtPrice(n) {
   if (!Number.isFinite(n)) {
@@ -442,7 +451,7 @@ function buildLineItem(line, profile) {
       tx += tag("ram:RateApplicablePercent", line.vatRatePercent.toString());
     settle += tag("ram:ApplicableTradeTax", tx);
   }
-  const lineTotal = line.lineTotal ?? Math.round(line.quantity * line.unitPrice * 100) / 100;
+  const lineTotal = line.lineTotal ?? roundHalfUp(line.quantity * line.unitPrice);
   settle += tag(
     "ram:SpecifiedTradeSettlementLineMonetarySummation",
     tag("ram:LineTotalAmount", fmtAmt(lineTotal))
@@ -927,8 +936,8 @@ function validateInput(input, profile, flavor) {
   if (req("BASIC_WL" /* BASIC_WL */) && input.totals) {
     const t = input.totals;
     if (t.taxBasisTotal != null && t.taxTotal != null && t.grandTotal != null) {
-      const expected = round2(t.taxBasisTotal + t.taxTotal);
-      if (Math.abs(round2(t.grandTotal) - expected) > 0.01) {
+      const expected = roundHalfUp(t.taxBasisTotal + t.taxTotal);
+      if (amountsDiffer(t.grandTotal, expected)) {
         addError(
           errors,
           "totals.grandTotal",
@@ -943,8 +952,8 @@ function validateInput(input, profile, flavor) {
     if (t.grandTotal != null && t.duePayableAmount != null) {
       const prepaid = t.prepaidAmount ?? 0;
       const rounding = t.roundingAmount ?? 0;
-      const expected = round2(t.grandTotal - prepaid + rounding);
-      if (Math.abs(round2(t.duePayableAmount) - expected) > 0.01) {
+      const expected = roundHalfUp(t.grandTotal - prepaid + rounding);
+      if (amountsDiffer(t.duePayableAmount, expected)) {
         addError(
           errors,
           "totals.duePayableAmount",
@@ -959,8 +968,8 @@ function validateInput(input, profile, flavor) {
     if (t.lineTotal != null && t.taxBasisTotal != null) {
       const allowance = t.allowanceTotal ?? 0;
       const charge = t.chargeTotal ?? 0;
-      const expected = round2(t.lineTotal - allowance + charge);
-      if (Math.abs(round2(t.taxBasisTotal) - expected) > 0.01) {
+      const expected = roundHalfUp(t.lineTotal - allowance + charge);
+      if (amountsDiffer(t.taxBasisTotal, expected)) {
         addError(
           errors,
           "totals.taxBasisTotal",
@@ -976,11 +985,11 @@ function validateInput(input, profile, flavor) {
       return sum + lineNet;
     }, 0);
     if (input.totals.lineTotal != null) {
-      if (Math.abs(round2(input.totals.lineTotal) - round2(sumLineNets)) > 0.01) {
+      if (amountsDiffer(input.totals.lineTotal, sumLineNets)) {
         addError(
           errors,
           "totals.lineTotal",
-          `lineTotal ${input.totals.lineTotal} does not equal \u03A3 line nets (${round2(sumLineNets)}) (BR-CO-10).`,
+          `lineTotal ${input.totals.lineTotal} does not equal \u03A3 line nets (${roundHalfUp(sumLineNets)}) (BR-CO-10).`,
           "BASIC" /* BASIC */
         );
       }
@@ -988,11 +997,11 @@ function validateInput(input, profile, flavor) {
   }
   if (req("BASIC_WL" /* BASIC_WL */) && input.totals?.taxTotal != null && input.vatBreakdown) {
     const sumVat = input.vatBreakdown.reduce((s, v) => s + (v.taxAmount ?? 0), 0);
-    if (Math.abs(round2(input.totals.taxTotal) - round2(sumVat)) > 0.01) {
+    if (amountsDiffer(input.totals.taxTotal, sumVat)) {
       addError(
         errors,
         "totals.taxTotal",
-        `taxTotal ${input.totals.taxTotal} does not equal \u03A3 vatBreakdown.taxAmount (${round2(sumVat)}) (BR-CO-14).`,
+        `taxTotal ${input.totals.taxTotal} does not equal \u03A3 vatBreakdown.taxAmount (${roundHalfUp(sumVat)}) (BR-CO-14).`,
         "BASIC_WL" /* BASIC_WL */
       );
     }
@@ -1000,8 +1009,8 @@ function validateInput(input, profile, flavor) {
   if (req("BASIC_WL" /* BASIC_WL */) && input.vatBreakdown) {
     input.vatBreakdown.forEach((vb, i) => {
       if (vb.taxableAmount != null && vb.taxAmount != null && vb.ratePercent != null) {
-        const expected = round2(vb.taxableAmount * vb.ratePercent / 100);
-        if (Math.abs(round2(vb.taxAmount) - expected) > 0.01) {
+        const expected = roundHalfUp(vb.taxableAmount * vb.ratePercent / 100);
+        if (amountsDiffer(vb.taxAmount, expected)) {
           addError(
             errors,
             `vatBreakdown[${i}].taxAmount`,
@@ -1084,8 +1093,8 @@ function validateInput(input, profile, flavor) {
     errors
   };
 }
-function round2(n) {
-  return Math.round(n * 100) / 100;
+function amountsDiffer(actual, expected) {
+  return Math.abs(toCents(actual) - toCents(expected)) > 1;
 }
 function isValidIban(iban) {
   const normalized = iban.replace(/\s+/g, "").toUpperCase();

package/dist/index.js

@@ -251,6 +251,15 @@ function resolveBusinessProcessUrn(input, flavor) {
   return FLAVOR_CONFIGS[flavor].businessProcessUrn;
 }
 
+// src/core/rounding.ts
+function toCents(n) {
+  const cents = Math.round(Number((Math.abs(n) * 100).toPrecision(15)));
+  return n < 0 ? -cents : cents;
+}
+function roundHalfUp(n) {
+  return toCents(n) / 100;
+}
+
 // src/core/xml-builder.ts
 var PROFILE_LEVEL = {
   MINIMUM: 0,
@@ -275,7 +284,7 @@ function fmtAmt(n) {
   if (!Number.isFinite(n)) {
     throw new Error(`Invalid amount value: ${n}. Expected a finite number.`);
   }
-  return n.toFixed(2);
+  return roundHalfUp(n).toFixed(2);
 }
 function fmtPrice(n) {
   if (!Number.isFinite(n)) {
@@ -412,7 +421,7 @@ function buildLineItem(line, profile) {
       tx += tag("ram:RateApplicablePercent", line.vatRatePercent.toString());
     settle += tag("ram:ApplicableTradeTax", tx);
   }
-  const lineTotal = line.lineTotal ?? Math.round(line.quantity * line.unitPrice * 100) / 100;
+  const lineTotal = line.lineTotal ?? roundHalfUp(line.quantity * line.unitPrice);
   settle += tag(
     "ram:SpecifiedTradeSettlementLineMonetarySummation",
     tag("ram:LineTotalAmount", fmtAmt(lineTotal))
@@ -897,8 +906,8 @@ function validateInput(input, profile, flavor) {
   if (req("BASIC_WL" /* BASIC_WL */) && input.totals) {
     const t = input.totals;
     if (t.taxBasisTotal != null && t.taxTotal != null && t.grandTotal != null) {
-      const expected = round2(t.taxBasisTotal + t.taxTotal);
-      if (Math.abs(round2(t.grandTotal) - expected) > 0.01) {
+      const expected = roundHalfUp(t.taxBasisTotal + t.taxTotal);
+      if (amountsDiffer(t.grandTotal, expected)) {
         addError(
           errors,
           "totals.grandTotal",
@@ -913,8 +922,8 @@ function validateInput(input, profile, flavor) {
     if (t.grandTotal != null && t.duePayableAmount != null) {
       const prepaid = t.prepaidAmount ?? 0;
       const rounding = t.roundingAmount ?? 0;
-      const expected = round2(t.grandTotal - prepaid + rounding);
-      if (Math.abs(round2(t.duePayableAmount) - expected) > 0.01) {
+      const expected = roundHalfUp(t.grandTotal - prepaid + rounding);
+      if (amountsDiffer(t.duePayableAmount, expected)) {
         addError(
           errors,
           "totals.duePayableAmount",
@@ -929,8 +938,8 @@ function validateInput(input, profile, flavor) {
     if (t.lineTotal != null && t.taxBasisTotal != null) {
       const allowance = t.allowanceTotal ?? 0;
       const charge = t.chargeTotal ?? 0;
-      const expected = round2(t.lineTotal - allowance + charge);
-      if (Math.abs(round2(t.taxBasisTotal) - expected) > 0.01) {
+      const expected = roundHalfUp(t.lineTotal - allowance + charge);
+      if (amountsDiffer(t.taxBasisTotal, expected)) {
         addError(
           errors,
           "totals.taxBasisTotal",
@@ -946,11 +955,11 @@ function validateInput(input, profile, flavor) {
       return sum + lineNet;
     }, 0);
     if (input.totals.lineTotal != null) {
-      if (Math.abs(round2(input.totals.lineTotal) - round2(sumLineNets)) > 0.01) {
+      if (amountsDiffer(input.totals.lineTotal, sumLineNets)) {
         addError(
           errors,
           "totals.lineTotal",
-          `lineTotal ${input.totals.lineTotal} does not equal \u03A3 line nets (${round2(sumLineNets)}) (BR-CO-10).`,
+          `lineTotal ${input.totals.lineTotal} does not equal \u03A3 line nets (${roundHalfUp(sumLineNets)}) (BR-CO-10).`,
           "BASIC" /* BASIC */
         );
       }
@@ -958,11 +967,11 @@ function validateInput(input, profile, flavor) {
   }
   if (req("BASIC_WL" /* BASIC_WL */) && input.totals?.taxTotal != null && input.vatBreakdown) {
     const sumVat = input.vatBreakdown.reduce((s, v) => s + (v.taxAmount ?? 0), 0);
-    if (Math.abs(round2(input.totals.taxTotal) - round2(sumVat)) > 0.01) {
+    if (amountsDiffer(input.totals.taxTotal, sumVat)) {
       addError(
         errors,
         "totals.taxTotal",
-        `taxTotal ${input.totals.taxTotal} does not equal \u03A3 vatBreakdown.taxAmount (${round2(sumVat)}) (BR-CO-14).`,
+        `taxTotal ${input.totals.taxTotal} does not equal \u03A3 vatBreakdown.taxAmount (${roundHalfUp(sumVat)}) (BR-CO-14).`,
         "BASIC_WL" /* BASIC_WL */
       );
     }
@@ -970,8 +979,8 @@ function validateInput(input, profile, flavor) {
   if (req("BASIC_WL" /* BASIC_WL */) && input.vatBreakdown) {
     input.vatBreakdown.forEach((vb, i) => {
       if (vb.taxableAmount != null && vb.taxAmount != null && vb.ratePercent != null) {
-        const expected = round2(vb.taxableAmount * vb.ratePercent / 100);
-        if (Math.abs(round2(vb.taxAmount) - expected) > 0.01) {
+        const expected = roundHalfUp(vb.taxableAmount * vb.ratePercent / 100);
+        if (amountsDiffer(vb.taxAmount, expected)) {
           addError(
             errors,
             `vatBreakdown[${i}].taxAmount`,
@@ -1054,8 +1063,8 @@ function validateInput(input, profile, flavor) {
     errors
   };
 }
-function round2(n) {
-  return Math.round(n * 100) / 100;
+function amountsDiffer(actual, expected) {
+  return Math.abs(toCents(actual) - toCents(expected)) > 1;
 }
 function isValidIban(iban) {
   const normalized = iban.replace(/\s+/g, "").toUpperCase();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@stackforge-eu/factur-x",
-  "version": "1.4.2",
+  "version": "1.4.3",
   "type": "module",
   "description": "Embed Factur-X, ZUGFeRD, and XRechnung structured invoice XML into PDF/A-3 documents",
   "keywords": [