@stackforge-eu/factur-x 1.0.6 → 1.0.8

package/CHANGELOG.md

@@ -7,6 +7,41 @@ and this project adheres to [Semantic Versioning](https://semver.org/).
 
 ## [Unreleased]
 
+## [1.0.8] — 2026-05-27
+
+- **PDF trailer was missing the `/ID` entry required by PDF/A-3.** ISO 19005-3
+  (and PDF 1.7 §14.4) require the trailer dictionary to carry an `/ID` array of
+  two byte strings: the first immutable identifier of the original document,
+  the second updated on every modification. `pdf-lib` initializes
+  `trailerInfo = {}` and never writes one on save, so veraPDF and the FNFE-MPE
+  Factur-X profile rejected every PDF this library produced as non-conformant.
+  Added `ensureIdTrailer` in `src/core/embed.ts` which runs after the first
+  `pdfDoc.save()` when `addPdfA3Metadata` is on: it computes an MD5 over the
+  serialized bytes (per PDF 1.7 §14.4 — uniqueness, not cryptographic strength,
+  is what matters), preserves any pre-existing first identifier, and writes the
+  pair before re-saving. Regression tests added in `tests/embed.test.ts`
+  covering both the no-existing-trailer and existing-trailer paths (thanks
+  @sco-indy, #3).
+
+## [1.0.7] — 2026-05-27
+
+- **`fx:ConformanceLevel` in the XMP metadata used the raw `Profile` enum
+  identifier instead of the Factur-X / ZUGFeRD spec label.** The XMP packet
+  emitted `EN16931` / `BASIC_WL` where the spec requires `EN 16931` /
+  `BASIC WL`, so strict ZUGFeRD / Factur-X validators (Mustangproject, the
+  FNFE-MPE check tool, veraPDF's Factur-X profile) rejected every PDF this
+  library produced even though the embedded CII XML was correct. Added a
+  `Profile` → XMP-label mapping and routed `buildXmpMetadata` through it in
+  `src/core/embed.ts` (thanks @sco-indy, #2).
+- **`flavor: Flavor.XRECHNUNG` still advertised `EN 16931` in the XMP packet.**
+  Hybrid XRechnung PDFs carry the EN16931 profile internally but per ZUGFeRD
+  2.x §2.4.4 must declare `XRECHNUNG` as the conformance level so the KoSIT /
+  ZUGFeRD validators route them through the XRechnung schematron set rather
+  than the vanilla Factur-X one. `resolveXmpConformanceLevel` in
+  `src/core/embed.ts` now special-cases the XRechnung flavor; the existing
+  `toXRechnung` → XML flow is unaffected. Regression test added in
+  `tests/embed.test.ts` covering all five profiles and the XRechnung flavor.
+
 ## [1.0.6] — 2026-05-23
 
 - **`SpecifiedTradeSettlementPaymentMeans` emitted its child elements in the
@@ -94,6 +129,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/).
 - Deno compatibility test suite
 
 [Unreleased]: https://github.com/StackForge-EU/factur-x/commits/main
+[1.0.8]: https://github.com/StackForge-EU/factur-x/compare/v1.0.7...v1.0.8
+[1.0.7]: https://github.com/StackForge-EU/factur-x/compare/v1.0.6...v1.0.7
 [1.0.6]: https://github.com/StackForge-EU/factur-x/compare/v1.0.5...v1.0.6
 [1.0.5]: https://github.com/StackForge-EU/factur-x/compare/v1.0.4...v1.0.5
 [1.0.4]: https://github.com/StackForge-EU/factur-x/compare/v1.0.3...v1.0.4

package/dist/index.cjs

@@ -4,6 +4,7 @@ var fs = require('fs');
 var path = require('path');
 var url = require('url');
 var console = require('console');
+var crypto = require('crypto');
 var pdfLib = require('pdf-lib');
 
 function _interopDefault (e) { return e && e.__esModule ? e : { default: e }; }
@@ -1111,6 +1112,28 @@ var AF_RELATIONSHIP_MAP = {
   Data: pdfLib.AFRelationship.Data,
   Source: pdfLib.AFRelationship.Source
 };
+var XMP_CONFORMANCE_LEVEL = {
+  ["MINIMUM" /* MINIMUM */]: "MINIMUM",
+  ["BASIC_WL" /* BASIC_WL */]: "BASIC WL",
+  ["BASIC" /* BASIC */]: "BASIC",
+  ["EN16931" /* EN16931 */]: "EN 16931",
+  ["EXTENDED" /* EXTENDED */]: "EXTENDED"
+};
+function resolveXmpConformanceLevel(profile, flavor) {
+  if (flavor === "xrechnung" /* XRECHNUNG */) return "XRECHNUNG";
+  return XMP_CONFORMANCE_LEVEL[profile];
+}
+function ensureIdTrailer(pdfDoc, pdfContentBytes) {
+  const existingIdTrailer = pdfDoc.context.trailerInfo.ID;
+  const currentContentHash = pdfLib.PDFHexString.of(crypto.createHash("md5").update(pdfContentBytes).digest("hex"));
+  const hasValidIdTrailer = existingIdTrailer instanceof pdfLib.PDFArray && existingIdTrailer.size() === 2;
+  if (hasValidIdTrailer) {
+    const existingFirstId = existingIdTrailer.lookup(0);
+    pdfDoc.context.trailerInfo.ID = pdfDoc.context.obj([existingFirstId, currentContentHash]);
+  } else {
+    pdfDoc.context.trailerInfo.ID = pdfDoc.context.obj([currentContentHash, currentContentHash]);
+  }
+}
 function ensureOutputIntent(pdfDoc, iccBytes, identifier) {
   const existing = pdfDoc.catalog.lookup(pdfLib.PDFName.of("OutputIntents"));
   if (existing instanceof pdfLib.PDFArray && existing.size() > 0) return;
@@ -1375,7 +1398,7 @@ async function embedFacturX(options) {
       createDate: isoDate,
       modifyDate: isoDate,
       documentFileName: flavorConfig.attachmentFilename,
-      conformanceLevel: profile
+      conformanceLevel: resolveXmpConformanceLevel(profile, flavor)
     });
     const xmpBytes = new TextEncoder().encode(xmpXml);
     const metadataStream = pdfDoc.context.stream(xmpBytes, {
@@ -1386,9 +1409,13 @@ async function embedFacturX(options) {
     const metadataRef = pdfDoc.context.register(metadataStream);
     pdfDoc.catalog.set(pdfLib.PDFName.of("Metadata"), metadataRef);
   }
-  const resultPdf = await pdfDoc.save();
+  let pdfContentBytes = await pdfDoc.save();
+  if (addPdfA3Metadata) {
+    ensureIdTrailer(pdfDoc, pdfContentBytes);
+    pdfContentBytes = await pdfDoc.save();
+  }
   return {
-    pdf: resultPdf,
+    pdf: pdfContentBytes,
     xml,
     ...validation ? { validation } : {},
     ...xsdValidation ? { xsdValidation } : {}

package/dist/index.js

@@ -2,7 +2,8 @@ import * as fs from 'fs';
 import * as path from 'path';
 import { fileURLToPath } from 'url';
 import console from 'console';
-import { AFRelationship, PDFDocument, PDFName, PDFArray, PDFDict, PDFStream, PDFRawStream, decodePDFRawStream, PDFString, PDFRef, PDFHexString } from 'pdf-lib';
+import { createHash } from 'crypto';
+import { AFRelationship, PDFDocument, PDFName, PDFArray, PDFDict, PDFStream, PDFRawStream, decodePDFRawStream, PDFString, PDFHexString, PDFRef } from 'pdf-lib';
 
 // src/types/input.ts
 var DocumentTypeCode = /* @__PURE__ */ ((DocumentTypeCode2) => {
@@ -1081,6 +1082,28 @@ var AF_RELATIONSHIP_MAP = {
   Data: AFRelationship.Data,
   Source: AFRelationship.Source
 };
+var XMP_CONFORMANCE_LEVEL = {
+  ["MINIMUM" /* MINIMUM */]: "MINIMUM",
+  ["BASIC_WL" /* BASIC_WL */]: "BASIC WL",
+  ["BASIC" /* BASIC */]: "BASIC",
+  ["EN16931" /* EN16931 */]: "EN 16931",
+  ["EXTENDED" /* EXTENDED */]: "EXTENDED"
+};
+function resolveXmpConformanceLevel(profile, flavor) {
+  if (flavor === "xrechnung" /* XRECHNUNG */) return "XRECHNUNG";
+  return XMP_CONFORMANCE_LEVEL[profile];
+}
+function ensureIdTrailer(pdfDoc, pdfContentBytes) {
+  const existingIdTrailer = pdfDoc.context.trailerInfo.ID;
+  const currentContentHash = PDFHexString.of(createHash("md5").update(pdfContentBytes).digest("hex"));
+  const hasValidIdTrailer = existingIdTrailer instanceof PDFArray && existingIdTrailer.size() === 2;
+  if (hasValidIdTrailer) {
+    const existingFirstId = existingIdTrailer.lookup(0);
+    pdfDoc.context.trailerInfo.ID = pdfDoc.context.obj([existingFirstId, currentContentHash]);
+  } else {
+    pdfDoc.context.trailerInfo.ID = pdfDoc.context.obj([currentContentHash, currentContentHash]);
+  }
+}
 function ensureOutputIntent(pdfDoc, iccBytes, identifier) {
   const existing = pdfDoc.catalog.lookup(PDFName.of("OutputIntents"));
   if (existing instanceof PDFArray && existing.size() > 0) return;
@@ -1345,7 +1368,7 @@ async function embedFacturX(options) {
       createDate: isoDate,
       modifyDate: isoDate,
       documentFileName: flavorConfig.attachmentFilename,
-      conformanceLevel: profile
+      conformanceLevel: resolveXmpConformanceLevel(profile, flavor)
     });
     const xmpBytes = new TextEncoder().encode(xmpXml);
     const metadataStream = pdfDoc.context.stream(xmpBytes, {
@@ -1356,9 +1379,13 @@ async function embedFacturX(options) {
     const metadataRef = pdfDoc.context.register(metadataStream);
     pdfDoc.catalog.set(PDFName.of("Metadata"), metadataRef);
   }
-  const resultPdf = await pdfDoc.save();
+  let pdfContentBytes = await pdfDoc.save();
+  if (addPdfA3Metadata) {
+    ensureIdTrailer(pdfDoc, pdfContentBytes);
+    pdfContentBytes = await pdfDoc.save();
+  }
   return {
-    pdf: resultPdf,
+    pdf: pdfContentBytes,
     xml,
     ...validation ? { validation } : {},
     ...xsdValidation ? { xsdValidation } : {}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@stackforge-eu/factur-x",
-  "version": "1.0.6",
+  "version": "1.0.8",
   "type": "module",
   "description": "Embed Factur-X, ZUGFeRD, and XRechnung structured invoice XML into PDF/A-3 documents",
   "keywords": [