@stackforge-eu/factur-x 1.0.4 → 1.0.6

package/CHANGELOG.md

@@ -7,6 +7,33 @@ and this project adheres to [Semantic Versioning](https://semver.org/).
 
 ## [Unreleased]
 
+## [1.0.6] — 2026-05-23
+
+- **`SpecifiedTradeSettlementPaymentMeans` emitted its child elements in the
+  wrong order.** The EN16931 / CII XSD `TradeSettlementPaymentMeansType`
+  sequence requires `PayerPartyDebtorFinancialAccount` before
+  `PayeePartyCreditorFinancialAccount` and
+  `PayeeSpecifiedCreditorFinancialInstitution`, but the builder appended the
+  debtor account last. Any invoice combining a SEPA direct debit
+  (`payment.meansCode = "59"`) with `payment.debtorIban` plus a payee
+  IBAN/BIC failed XSD validation with `Element 'PayerPartyDebtorFinancialAccount':
+  This element is not expected`. Reordered the three blocks in
+  `src/core/xml-builder.ts`; regression test added in
+  `tests/xml-builder.test.ts`.
+
+## [1.0.5] — 2026-05-12
+
+- **`ChargeIndicator`'s inner `Indicator` element was emitted in the wrong XML
+  namespace.** The XSD requires `udt:Indicator` (UnqualifiedDataType:100) but
+  the builder emitted `ram:Indicator` (ReusableAggregateBusinessInformationEntity:100).
+  The XSD rejected every invoice carrying a `SpecifiedTradeAllowanceCharge`,
+  and the BASIC schematron's `udt:Indicator='true'/'false'` predicates silently
+  matched nothing — so every downstream sum over allowances/charges (BR-S-08,
+  BR-CO-11, BR-CO-14) computed zero on the allowance/charge side and tripped.
+  Affects every caller that uses `allowancesCharges`; previously masked because
+  the test suite only exercised allowance presence, never XSD round-trip with
+  one. Regression test added in `tests/xsd-validator.test.ts`.
+
 ## [1.0.4] — 2026-05-05
 
 ### Fixed
@@ -67,6 +94,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/).
 - Deno compatibility test suite
 
 [Unreleased]: https://github.com/StackForge-EU/factur-x/commits/main
+[1.0.6]: https://github.com/StackForge-EU/factur-x/compare/v1.0.5...v1.0.6
+[1.0.5]: https://github.com/StackForge-EU/factur-x/compare/v1.0.4...v1.0.5
 [1.0.4]: https://github.com/StackForge-EU/factur-x/compare/v1.0.3...v1.0.4
 [1.0.3]: https://github.com/StackForge-EU/factur-x/compare/v1.0.2...v1.0.3
 [1.0.2]: https://github.com/StackForge-EU/factur-x/compare/v1.0.1...v1.0.2

package/dist/index.cjs

@@ -415,7 +415,7 @@ function buildLineItem(line, profile) {
   );
 }
 function buildAllowanceCharge(ac) {
-  let x = tag("ram:ChargeIndicator", tag("ram:Indicator", ac.isCharge ? "true" : "false"));
+  let x = tag("ram:ChargeIndicator", tag("udt:Indicator", ac.isCharge ? "true" : "false"));
   if (ac.percent !== void 0) x += tag("ram:CalculationPercent", ac.percent.toString());
   if (ac.baseAmount !== void 0) x += tag("ram:BasisAmount", fmtAmt(ac.baseAmount));
   x += tag("ram:ActualAmount", fmtAmt(ac.amount));
@@ -591,6 +591,11 @@ function buildXml(input, profile, flavor) {
     sett += tag("ram:PayeeTradeParty", buildParty(input.payee, profile));
   if (payment?.meansCode && atLeast(profile, "BASIC_WL" /* BASIC_WL */)) {
     let pm = tag("ram:TypeCode", escapeXml(payment.meansCode));
+    if (payment.debtorIban)
+      pm += tag(
+        "ram:PayerPartyDebtorFinancialAccount",
+        tag("ram:IBANID", escapeXml(payment.debtorIban))
+      );
     if (payment.iban || payment.accountId || payment.accountName) {
       let acct = "";
       if (payment.iban) acct += tag("ram:IBANID", escapeXml(payment.iban));
@@ -604,11 +609,6 @@ function buildXml(input, profile, flavor) {
         "ram:PayeeSpecifiedCreditorFinancialInstitution",
         tag("ram:BICID", escapeXml(payment.bic))
       );
-    if (payment.debtorIban)
-      pm += tag(
-        "ram:PayerPartyDebtorFinancialAccount",
-        tag("ram:IBANID", escapeXml(payment.debtorIban))
-      );
     sett += tag("ram:SpecifiedTradeSettlementPaymentMeans", pm);
   }
   if (input.vatBreakdown && atLeast(profile, "BASIC_WL" /* BASIC_WL */))

package/dist/index.js

@@ -385,7 +385,7 @@ function buildLineItem(line, profile) {
   );
 }
 function buildAllowanceCharge(ac) {
-  let x = tag("ram:ChargeIndicator", tag("ram:Indicator", ac.isCharge ? "true" : "false"));
+  let x = tag("ram:ChargeIndicator", tag("udt:Indicator", ac.isCharge ? "true" : "false"));
   if (ac.percent !== void 0) x += tag("ram:CalculationPercent", ac.percent.toString());
   if (ac.baseAmount !== void 0) x += tag("ram:BasisAmount", fmtAmt(ac.baseAmount));
   x += tag("ram:ActualAmount", fmtAmt(ac.amount));
@@ -561,6 +561,11 @@ function buildXml(input, profile, flavor) {
     sett += tag("ram:PayeeTradeParty", buildParty(input.payee, profile));
   if (payment?.meansCode && atLeast(profile, "BASIC_WL" /* BASIC_WL */)) {
     let pm = tag("ram:TypeCode", escapeXml(payment.meansCode));
+    if (payment.debtorIban)
+      pm += tag(
+        "ram:PayerPartyDebtorFinancialAccount",
+        tag("ram:IBANID", escapeXml(payment.debtorIban))
+      );
     if (payment.iban || payment.accountId || payment.accountName) {
       let acct = "";
       if (payment.iban) acct += tag("ram:IBANID", escapeXml(payment.iban));
@@ -574,11 +579,6 @@ function buildXml(input, profile, flavor) {
         "ram:PayeeSpecifiedCreditorFinancialInstitution",
         tag("ram:BICID", escapeXml(payment.bic))
       );
-    if (payment.debtorIban)
-      pm += tag(
-        "ram:PayerPartyDebtorFinancialAccount",
-        tag("ram:IBANID", escapeXml(payment.debtorIban))
-      );
     sett += tag("ram:SpecifiedTradeSettlementPaymentMeans", pm);
   }
   if (input.vatBreakdown && atLeast(profile, "BASIC_WL" /* BASIC_WL */))

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@stackforge-eu/factur-x",
-  "version": "1.0.4",
+  "version": "1.0.6",
   "type": "module",
   "description": "Embed Factur-X, ZUGFeRD, and XRechnung structured invoice XML into PDF/A-3 documents",
   "keywords": [