@ssheleg/agent-sync 1.3.3 → 1.3.4

package/CHANGELOG.md

@@ -3,6 +3,22 @@
 All notable changes to this project are documented here.
 This project adheres to [Semantic Versioning](https://semver.org/).
 
+## 1.3.4 — 2026-07-29
+
+### Fixed
+- **`release` reported success for a lease it did not release, and cleared the
+  board claim on the way.** The lease plane refused correctly — a lease held by
+  another run stayed held, and `_git_release` printed a note saying so — but the
+  command printed `released <key>` over the top of it and exited 0, and
+  `write_claim` had already blanked the claim cell before the refusal was
+  reached. The result was the board advertising a task as free while the lease
+  still held it: the exact disagreement a lease exists to prevent, manufactured
+  by the tool. Ownership is now checked **first**, in whichever plane arbitrates
+  it; nothing is written when the answer is no; the command exits non-zero and
+  says who holds it. Both lease modes were affected.
+- A regression check covers it in `local` and `git` mode, and was probed against
+  the old code in both before being trusted.
+
 ## 1.3.3 — 2026-07-29
 
 ### Fixed

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@ssheleg/agent-sync",
-  "version": "1.3.3",
-  "description": "Let concurrent coding agents share one project without colliding — leases with TTL, race-free id reservation, a run journal and a generated board, over a pluggable knowledge cloud.",
+  "version": "1.3.4",
+  "description": "Let concurrent coding agents share one project without colliding \u2014 leases with TTL, race-free id reservation, a run journal and a generated board, over a pluggable knowledge cloud.",
   "bin": {
     "agent-sync": "bin/agent-sync.js"
   },

package/plugins/agent-sync/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "agent-sync",
-  "version": "1.3.3",
-  "description": "Coordination layer for multi-agent repositories — leases with TTL, race-free ID reservation, a run journal, a cross-repo signal feed and a generated board, over a pluggable knowledge cloud.",
+  "version": "1.3.4",
+  "description": "Coordination layer for multi-agent repositories \u2014 leases with TTL, race-free ID reservation, a run journal, a cross-repo signal feed and a generated board, over a pluggable knowledge cloud.",
   "author": {
     "name": "appvillis-com"
   },

package/plugins/agent-sync/skills/agent-sync/SKILL.md

@@ -4,7 +4,7 @@ description: "Use when several coding agents work one repository at the same tim
 compatibility: "Requires the task-pipeline skill for its stages (npx sshlg-skills install). Needs python3 3.9+ (stdlib only, HTTP included - nothing to pip install) and bash for the hooks. The knowledge backend is configured per project; with none configured it degrades to git-file leases. Enforcement hooks are Claude Code only - on other agents the same checks run as a self-check."
 license: MIT
 metadata:
-  version: "1.3.3"
+  version: "1.3.4"
   author: appvillis-com
 ---
 

package/plugins/agent-sync/skills/agent-sync/scripts/agent_sync.py

@@ -32,7 +32,7 @@ from datetime import datetime, timezone
 from pathlib import Path
 from typing import Any
 
-VERSION = "1.3.3"
+VERSION = "1.3.4"
 
 CONFIG_PATH = Path(".claude/agent-sync.json")
 ENV_FILE = Path(".env.agent-sync")
@@ -960,7 +960,36 @@ class Sync:
         marker.parent.mkdir(parents=True, exist_ok=True)
         marker.write_text(now_iso())
 
-    def release(self, key: str) -> None:
+    def _lease_holder(self, key: str) -> str | None:
+        """Who holds this lease right now, in whichever plane arbitrates it."""
+        if self.lease_mode == "git":
+            sha, held = self._git_read_lease(key)
+            return held.get("run") if sha else None
+        lock = self._local_lock(key)
+        if not lock.exists():
+            return None
+        try:
+            return json.loads(lock.read_text()).get("run")
+        except (json.JSONDecodeError, OSError):
+            return None
+
+    def release(self, key: str) -> bool:
+        """Release only what this run holds, and say so plainly when it does not.
+
+        This used to clear the board claim and report success unconditionally. The lease
+        plane refused correctly — `_git_release` prints a note and returns — but the
+        caller printed "released" over the top of it and exited 0, and `write_claim` had
+        already blanked the claim cell on the way in. The board then said the task was
+        free while the lease said it was taken: the exact disagreement a lease exists to
+        prevent, manufactured by the tool. Ownership is therefore checked FIRST, and
+        nothing is written when the answer is no.
+        """
+        holder = self._lease_holder(key)
+        if holder is not None and holder != self.rid:
+            print(f"note: {key} is held by {holder}, not this run — nothing released",
+                  file=sys.stderr)
+            return False
+
         for n in self.write_claim(key, None):
             print(f"  {n}")
         if self.lease_mode == "git":
@@ -978,6 +1007,7 @@ class Sync:
                                         fmt_line("release", key, self.rid))
             except Fail as exc:
                 print(f"note: released locally, not published ({exc})", file=sys.stderr)
+        return True
 
     def held(self) -> list[str]:
         d = self.root / STATE_DIR / "leases"
@@ -2008,7 +2038,11 @@ def cmd_renew(args: argparse.Namespace) -> int:
 
 
 def cmd_release(args: argparse.Namespace) -> int:
-    Sync().release(args.key)
+    # Exit non-zero when nothing was released. A caller that scripts `release` in a
+    # cleanup path has no other way to learn the lease is still out there.
+    if not Sync().release(args.key):
+        print(f"NOT released: {args.key} is held by another run", file=sys.stderr)
+        return 1
     print(f"released {args.key}")
     return 0