@squiz/job-runner-lib 1.66.1

package/src/domains/manifest/services/ComponentFunctionService.ts

@@ -0,0 +1,178 @@
+import path from 'node:path/posix';
+import { ManifestModel, Manifest } from '../ManifestModel';
+import { BadRequestError, never } from '@squiz/dx-common-lib';
+import { MANIFEST_MODELS } from '@squiz/dx-json-schema-lib';
+import {
+  ComponentSchemaValidationService,
+  ComponentSchemaValidationServiceFactory,
+} from './ComponentSchemaValidationService';
+import {
+  ComponentInputValidationService,
+  ComponentInputValidationServiceFactory,
+} from './ComponentInputValidationService';
+
+type FunctionOutputTypes = ManifestModel['functions'][number]['output'];
+type ComponentFunction = MANIFEST_MODELS.v1.ComponentFunction;
+type HtmlStaticFile = MANIFEST_MODELS.v1.HtmlStaticFile;
+
+export class ComponentFunctionService {
+  private schemaValidationService: ComponentSchemaValidationService = ComponentSchemaValidationServiceFactory.create();
+  private inputValidationService: ComponentInputValidationService = ComponentInputValidationServiceFactory.create();
+
+  static buildFileUrl(
+    filepath: string,
+    manifest: Manifest,
+    params: { _componentSet: string } | { _previewKey: string },
+    rootUrl: string,
+  ): string {
+    try {
+      // URL.canParse is added in node 19.9. Instead catch an invalid URL error
+      const url = new URL(filepath);
+      return url.href;
+    } catch (_) {
+      const searchParams = new URLSearchParams(params);
+      const normalizedFilepath = path
+        .normalize(filepath)
+        .replace(/^[/.]+/, '')
+        .replace(/\?.*$/, '');
+      return `${rootUrl.replace(/\/$/, '')}/s/${manifest.id}/${normalizedFilepath}?${searchParams.toString()}`;
+    }
+  }
+
+  public getFunctionDefinitionFromManifest(functionName: string, manifest: Manifest): ComponentFunction | undefined {
+    const componentFunctionDefinition = manifest.getModel().functions.find((f) => f.name === functionName);
+
+    return componentFunctionDefinition;
+  }
+
+  public prepareComponentFunctionForWebResponse(
+    func: ComponentFunction,
+    manifest: Manifest,
+    componentSet: string,
+    rootUrl: string,
+  ): ComponentFunction {
+    if (func.output.responseType === 'html') {
+      func.output.staticFiles = func.output.staticFiles?.map((f: HtmlStaticFile) => ({
+        ...f,
+        file: {
+          ...f.file,
+          filepath: ComponentFunctionService.buildFileUrl(
+            f.file.filepath,
+            manifest,
+            { _componentSet: componentSet },
+            rootUrl,
+          ),
+        },
+      }));
+    }
+
+    return func;
+  }
+
+  public prepareManifestForWebResponse(manifest: Manifest, componentSet: string, rootUrl: string): ManifestModel {
+    const manifestModel = manifest.getModel();
+    const manifestForWeb: ManifestModel = {
+      ...manifestModel,
+      functions: manifestModel.functions.map((f) =>
+        this.prepareComponentFunctionForWebResponse(f, manifest, componentSet, rootUrl),
+      ),
+    };
+    return manifestForWeb;
+  }
+
+  public prepareComponentFunctionForPreview(
+    func: ComponentFunction,
+    manifest: Manifest,
+    previewKey: string,
+    rootUrl: string,
+  ): ComponentFunction {
+    if (func.output.responseType === 'html') {
+      func.output.staticFiles = func.output.staticFiles?.map((f: HtmlStaticFile) => ({
+        ...f,
+        file: {
+          ...f.file,
+          filepath: ComponentFunctionService.buildFileUrl(
+            f.file.filepath,
+            manifest,
+            { _previewKey: previewKey },
+            rootUrl,
+          ),
+        },
+      }));
+    }
+    return func;
+  }
+
+  public prepareManifestForPreview(manifest: Manifest, previewKey: string, rootUrl: string): ManifestModel {
+    const manifestModel = manifest.getModel();
+    const manifestForPreview: ManifestModel = {
+      ...manifestModel,
+      functions: manifestModel.functions.map((f) =>
+        this.prepareComponentFunctionForPreview(f, manifest, previewKey, rootUrl),
+      ),
+    };
+
+    return manifestForPreview;
+  }
+
+  /**
+   * Asserts the provided input matches the input schema of the component function before
+   * any resolution through the render pipeline.
+   * @param input Input value which has not been resolved through render pipeline
+   * @param componentFunctionDefinition
+   */
+  public assertInputValidForComponentFunction(input: unknown, componentFunctionDefinition: ComponentFunction) {
+    if (input === undefined) {
+      throw new BadRequestError(`input value for ${componentFunctionDefinition.name} cannot be undefined`);
+    }
+
+    this.schemaValidationService.validateInput(input, componentFunctionDefinition.input);
+  }
+
+  /**
+   * Asserts the provided input matches the input schema of the component function after
+   * resolution through the render pipeline.
+   * @param input Input value which has been resolved through render pipeline
+   * @param componentFunctionDefinition
+   */
+  public assertRenderInputValidForComponentFunction(input: unknown, componentFunctionDefinition: ComponentFunction) {
+    if (input === undefined) {
+      throw new BadRequestError(`input value for ${componentFunctionDefinition.name} cannot be undefined`);
+    }
+    this.inputValidationService.validateInput(input, componentFunctionDefinition.input);
+  }
+
+  public assertOutputValidForComponentFunction(output: unknown, componentFunctionDefinition: ComponentFunction) {
+    if (componentFunctionDefinition === undefined) {
+      throw new Error(`input value for ${componentFunctionDefinition} cannot be undefined`);
+    }
+    if (output === undefined) {
+      throw new Error(`input value for ${componentFunctionDefinition.name} cannot be undefined`);
+    }
+
+    const outputSchema = this.getOutputValidationSchema(componentFunctionDefinition.output);
+    this.schemaValidationService.validateInput(output, outputSchema);
+  }
+
+  protected getOutputValidationSchema(func: FunctionOutputTypes): object {
+    const responseType = func.responseType;
+
+    switch (responseType) {
+      case 'html':
+        return { type: 'string', minLength: 0 };
+
+      case 'json': {
+        const jsonFunc = func;
+
+        if (jsonFunc.definition) {
+          return jsonFunc.definition;
+        }
+
+        throw new Error('definition is missing for the json');
+      }
+
+      default:
+        never(responseType);
+    }
+  }
+}

package/src/domains/manifest/services/ComponentInputValidationService.ts

@@ -0,0 +1,22 @@
+import {
+  JSONSchemaService,
+  SquizImageType,
+  SquizLinkType,
+  TypeResolver,
+  ComponentInputFormattedTextType,
+  ComponentInputMetaSchema,
+} from '@squiz/dx-json-schema-lib';
+
+export type ComponentInputValidationService = JSONSchemaService<
+  SquizImageType | ComponentInputFormattedTextType | SquizLinkType,
+  never
+>;
+
+export class ComponentInputValidationServiceFactory {
+  public static create(): ComponentInputValidationService {
+    return new JSONSchemaService(
+      new TypeResolver([SquizImageType, ComponentInputFormattedTextType, SquizLinkType]),
+      ComponentInputMetaSchema,
+    );
+  }
+}

package/src/domains/manifest/services/ComponentSchemaValidationService.ts

@@ -0,0 +1,22 @@
+import {
+  JSONSchemaService,
+  SquizImageType,
+  SquizLinkType,
+  TypeResolver,
+  ManifestV1MetaSchema,
+  BaseFormattedTextType,
+} from '@squiz/dx-json-schema-lib';
+
+export type ComponentSchemaValidationService = JSONSchemaService<
+  SquizImageType | SquizLinkType | BaseFormattedTextType,
+  never
+>;
+
+export class ComponentSchemaValidationServiceFactory {
+  public static create(): ComponentSchemaValidationService {
+    return new JSONSchemaService(
+      new TypeResolver([SquizImageType, BaseFormattedTextType, SquizLinkType]),
+      ManifestV1MetaSchema,
+    );
+  }
+}

package/src/domains/manifest/services/JobFunctionService.spec.ts

@@ -0,0 +1,165 @@
+/* eslint-disable @typescript-eslint/no-non-null-assertion */
+import { ManifestModel } from '../ManifestModel';
+import { JobFunctionService } from './JobFunctionService';
+import { ManifestV1 } from '../ManifestV1';
+import { MANIFEST_MODELS } from '@squiz/dx-json-schema-lib';
+
+type ComponentFunction = MANIFEST_MODELS.v1.ComponentFunction;
+
+describe('JobFunctionService', () => {
+  const service = new JobFunctionService();
+  const manifestPath = '';
+  const manifestModel: ManifestModel = {
+    $schema: './manifest-schemas/v1.json',
+
+    name: 'hello',
+    version: '1.0.1',
+    namespace: 'foo',
+    displayName: 'some display name',
+    description: 'some description',
+
+    mainFunction: 'hello',
+
+    functions: [
+      {
+        entry: 'whatever.js',
+        name: 'hello',
+
+        input: {
+          type: 'object',
+          properties: {
+            hello: { type: 'string' },
+          },
+
+          required: ['hello'],
+        },
+
+        output: {
+          responseType: 'html',
+        },
+
+        queryParameters: {
+          foo: {
+            required: false,
+          },
+        },
+      },
+
+      {
+        entry: 'whatever.js',
+        name: 'static-files',
+
+        input: {
+          type: 'object',
+          properties: {
+            hello: { type: 'string' },
+          },
+
+          required: ['hello'],
+        },
+
+        output: {
+          responseType: 'html',
+
+          staticFiles: [
+            {
+              file: {
+                filepath: './something.png',
+              },
+              location: 'header',
+            },
+
+            {
+              file: {
+                filepath: './sub/sub-dir.png',
+              },
+              location: 'header',
+            },
+
+            {
+              file: {
+                filepath: './sub/../sub-dir-transverse-up.png',
+              },
+              location: 'header',
+            },
+
+            {
+              file: {
+                filepath: '../sub-dir-transverse-up-past-root.png',
+              },
+              location: 'header',
+            },
+
+            {
+              file: {
+                filepath: '/absolute/path.png',
+              },
+              location: 'header',
+            },
+            {
+              file: {
+                filepath: 'no-prefix.png',
+              },
+              location: 'header',
+            },
+          ],
+        },
+      },
+
+      {
+        entry: 'whatever.js',
+        name: 'hello-json',
+
+        input: {
+          type: 'object',
+          properties: {
+            hello: { type: 'string' },
+          },
+
+          required: ['hello'],
+        },
+
+        output: {
+          responseType: 'json',
+          definition: {
+            type: 'object',
+            properties: {
+              prop: { type: 'string' },
+              obj: { type: 'object', properties: { 'sub-prop': { type: 'number' } }, required: ['sub-prop'] },
+            },
+            additionalProperties: false,
+            required: ['prop', 'obj'],
+          },
+        },
+      },
+    ],
+  };
+
+  describe('assertInputValidForJobFunction', () => {
+    const manifest = new ManifestV1(JSON.parse(JSON.stringify(manifestModel)), manifestPath);
+    const jobFunc = manifest.getModel().functions.find((f) => f.name === 'hello') as ComponentFunction;
+
+    it('should validate the input for the job function', (): void => {
+      const input = {
+        // required property
+        hello: 'world',
+      };
+
+      expect(() => service.assertInputValidForJobFunction(input, jobFunc)).not.toThrow();
+    });
+
+    it("should throw an error if the input to a component function doesn't meet the schema", () => {
+      const input = {};
+
+      expect(() => service.assertInputValidForJobFunction(input, jobFunc)).toThrowErrorMatchingInlineSnapshot(
+        `"failed validation: The required property \`hello\` is missing at \`#\`"`,
+      );
+    });
+
+    it('should throw an error if input is undefined', () => {
+      expect(() => service.assertInputValidForJobFunction(undefined, jobFunc)).toThrowErrorMatchingInlineSnapshot(
+        `"input value for hello cannot be undefined"`,
+      );
+    });
+  });
+});

package/src/domains/manifest/services/JobFunctionService.ts

@@ -0,0 +1,25 @@
+import { BadRequestError } from '@squiz/dx-common-lib';
+import { MANIFEST_MODELS } from '@squiz/dx-json-schema-lib';
+import {
+  ComponentSchemaValidationService,
+  ComponentSchemaValidationServiceFactory,
+} from './ComponentSchemaValidationService';
+
+type JobFunction = MANIFEST_MODELS.JobV1.JobFunction;
+
+export class JobFunctionService {
+  private schemaValidationService: ComponentSchemaValidationService = ComponentSchemaValidationServiceFactory.create();
+
+  /**
+   * Asserts the provided input matches the input schema of the job function
+   * @param input
+   * @param jobFunctionDefinition
+   */
+  public assertInputValidForJobFunction(input: unknown, jobFunctionDefinition: JobFunction) {
+    if (input === undefined) {
+      throw new BadRequestError(`input value for ${jobFunctionDefinition.name} cannot be undefined`);
+    }
+
+    this.schemaValidationService.validateInput(input, jobFunctionDefinition.input);
+  }
+}

package/src/domains/manifest/services/ManifestServiceForDev.spec.ts

@@ -0,0 +1,199 @@
+import { getLogger } from '@squiz/dx-logger-lib';
+import path from 'path';
+import { ManifestServiceForDev } from './ManifestServiceForDev';
+import fs from 'fs-extra';
+
+const COMPONENT_ROOT = process.env.DATA_MOUNT_POINT!;
+
+const logger = getLogger({ name: 'test', format: 'json' });
+
+const warnSpy = jest.spyOn(logger, 'warn');
+
+describe('ManifestServiceForDev', () => {
+  const service = new ManifestServiceForDev(COMPONENT_ROOT, logger);
+
+  beforeAll(() => {
+    if (fs.existsSync(path.join(COMPONENT_ROOT, 'unit-test-components/test-component/1.1.4/bad-dir'))) {
+      fs.rmSync(path.join(COMPONENT_ROOT, 'unit-test-components/test-component/1.1.4/bad-dir'), { recursive: true });
+    }
+  });
+
+  it('finds a component in subdirectory including version', async () => {
+    const componentDirectory = path.resolve(COMPONENT_ROOT, 'unit-test-components', 'test-component', '1.0.0');
+    const resolvedComponents = await service.getManifestPath('unit-test-components', 'test-component', '1.0.0');
+    expect(resolvedComponents).toEqual(path.join(componentDirectory, 'manifest.json'));
+  });
+
+  it('finds a component in a sub directory not including version', async () => {
+    const componentDirectory = path.resolve(COMPONENT_ROOT, 'unit-test-components', 'no-version-struct');
+    const resolvedComponents = await service.getManifestPath('unit-test-components', 'no-version-struct', '1.0.0');
+    expect(resolvedComponents).toEqual(path.join(componentDirectory, 'manifest.json'));
+  });
+
+  it('finds all components in the root directory', async () => {
+    const resolvedComponents = await service.listAllComponentManifests();
+
+    const allowedPrefixes = [
+      'test-component',
+      'test-environment-variables',
+      'test-malicious-code',
+      'test-npm-modules',
+      'test-static-files',
+    ];
+
+    expect(
+      resolvedComponents
+        .filter((a) => allowedPrefixes.some((b) => a.getName().startsWith(`unit-test-components/${b}`)))
+        .map((a) => `${a.getName()} ${a.getVersion()}`)
+        .sort(),
+    ).toEqual([
+      'unit-test-components/test-component 0.0.0',
+      'unit-test-components/test-component 1.0.0',
+      'unit-test-components/test-component 1.0.10',
+      'unit-test-components/test-component 1.0.3',
+      'unit-test-components/test-component 1.0.4',
+      'unit-test-components/test-component 1.0.5',
+      'unit-test-components/test-component 1.0.6',
+      'unit-test-components/test-component 1.0.7',
+      'unit-test-components/test-component 1.0.8',
+      'unit-test-components/test-component 1.0.9',
+      'unit-test-components/test-component 1.1.0',
+      'unit-test-components/test-component 1.1.2',
+      'unit-test-components/test-component 1.1.4',
+      'unit-test-components/test-component 1.2.0',
+      'unit-test-components/test-component 1.3.0',
+      'unit-test-components/test-environment-variables 1.0.0',
+      'unit-test-components/test-environment-variables 1.0.1',
+      'unit-test-components/test-environment-variables 1.0.2',
+      'unit-test-components/test-environment-variables 1.0.3',
+      'unit-test-components/test-environment-variables 1.0.4',
+      'unit-test-components/test-malicious-code 1.0.0',
+      'unit-test-components/test-malicious-code 1.1.0',
+      'unit-test-components/test-malicious-code 1.2.0',
+      'unit-test-components/test-malicious-code 1.3.0',
+      'unit-test-components/test-npm-modules 1.0.0',
+      'unit-test-components/test-npm-modules 2.0.0',
+      'unit-test-components/test-npm-modules 3.0.0',
+      'unit-test-components/test-npm-modules 3.1.0',
+      'unit-test-components/test-static-files 1.0.0',
+      'unit-test-components/test-static-files 1.0.1',
+      'unit-test-components/test-static-files 1.0.2',
+      'unit-test-components/test-static-files 1.0.3',
+      'unit-test-components/test-static-files 1.0.4',
+      'unit-test-components/test-static-files 1.0.5',
+      'unit-test-components/test-static-files 1.0.6',
+      'unit-test-components/test-static-files 1.0.7',
+      'unit-test-components/test-static-files 1.0.8',
+    ]);
+  });
+
+  it('should find log warnings on all manifests that fail validation', async () => {
+    await service.listAllComponentManifests();
+
+    expect(
+      warnSpy.mock.calls
+        .filter((a) => {
+          // Get rid of the random fixtures
+          const message = a[0] as unknown as string;
+          return !message.includes('/fixtures/');
+        })
+        .map((a) => {
+          const message = a[0] as unknown as string;
+          // get rid of user specific paths from test snapshot
+          return message.replace(COMPONENT_ROOT, '');
+        })
+        .sort(),
+    ).toMatchInlineSnapshot(`
+      [
+        "found manifest /dx-team/cornponent/0.0.3/manifest.json, but failed to load manifest because: Invalid preview data for preview "render-with-data": failed validation: Value \`[{"tag":"p","type":"tag","children":[{"type":"text","value":"This is some "},{"type":"text","value":"text"}]}]\` in \`#/my-prop/formattedText\` does not match any given oneof schema,
+      Value \`{"text":[{"tag":"p","type":"tag","children":[{"type":"text","value":"This is some "},{"type":"text","value":"text"}]}]}\` in \`#/my-prop/arr\` does not match any given oneof schema",
+        "found manifest /unit-test-components/test-component/1.0.2/manifest.json, but failed schema validation because: Could not determine manifest version. Your manifest must have a $schema property defined.",
+        "found manifest /unit-test-components/test-component/1.0.3/manifest.json, but failed to load manifest because: "main's" entry file "missing-entry-file.js" is inaccessible",
+        "found manifest /unit-test-components/test-component/1.0.5/manifest.json, but failed to load manifest because: "test-component 1.0.5" main function could not be found in function list",
+        "found manifest /unit-test-components/test-component/1.0.6/manifest.json, but failed to load manifest because: access to component "file-accessing-outside-parent-func's" entry file "../1.0.4/render-json.js" outside the parent directory in "test-component 1.0.6" is not allowed",
+        "found manifest /unit-test-components/test-component/1.1.1/manifest.json, but failed schema validation because: failed validation: Value in \`#/functions/0/name\` should match \`^[a-z][a-z0-9_\\-]+$\`, but received \`invalid-function-name-!!!!\`",
+        "found manifest /unit-test-components/test-component/1.1.2/manifest.json, but failed to load manifest because: function main-output-has-static defines static files but manifest has no staticFiles.locationRoot defined",
+        "found manifest /unit-test-components/test-component/1.1.4/manifest.json, but failed to load manifest because: static root bad-dir from "test-component 1.1.4" is not accessible",
+        "found manifest /unit-test-components/test-component/1.2.0/manifest.json, but failed to load manifest because: Invalid preview data for preview "test-preview": failed validation: The required property \`something\` is missing at \`#\`",
+        "found manifest /unit-test-components/test-icon-component/1.0.1/manifest.json, but failed schema validation because: failed validation: Expected given value \`not_a_valid_id\` in #/icon/id\` to be one of \`[10k, 10mp, 11mp, 123, 12mp, ... 2233 more]\`,
+      Value \`{"type":"hex","value":"(255,255,255)"}\` in \`#/icon/color\` does not match any given oneof schema",
+        "found manifest /unit-test-components/test-icon-component/1.0.2/manifest.json, but failed schema validation because: failed validation: Expected given value \`not_a_valid_id\` in #/icon/id\` to be one of \`[10k, 10mp, 11mp, 123, 12mp, ... 2233 more]\`,
+      The required property \`color\` is missing at \`#/icon\`",
+        "found manifest /unit-test-components/test-load/1.0.7/manifest.json, but failed to load manifest because: Invalid preview data for preview "preview1": Unknown Preview Configuration Type",
+        "found manifest /unit-test-components/test-preview-component/1.0.0/manifest.json, but failed to load manifest because: Invalid preview data for preview "invalid-preview-data": failed validation: Expected \`not-an-integer\` (string) in \`#/integerValue\` to be of type \`number\`,
+      The required property \`nested\` is missing at \`#\`",
+        "found manifest /unit-test-components/test-preview-component/1.0.7/manifest.json, but failed to load manifest because: Invalid preview data for preview "preview-json-doesnt-exist": Preview inputData file "missing.json" does not exist",
+        "found manifest /unit-test-components/test-preview-component/1.1.0/manifest.json, but failed to load manifest because: Invalid preview data for preview "preview-inline": failed validation: Value \`[{"type":"tag","tag":"p","children":[{"type":"text","value":"This is a paragraph"},{"type":"tag","tag":"span","children":[{"type":"text","value":" with a span"}]}]}]\` in \`#/formattedText\` does not match any given oneof schema",
+        "found manifest /unit-test-components/test-preview-component/1.1.2/manifest.json, but failed to load manifest because: Mocked URI object file "./non-existent-uri.json" does not exist",
+        "found manifest /unit-test-components/test-preview-component/1.1.3/manifest.json, but failed to load manifest because: Mocked URI object file "../1.0.0/manifest.json" is outside the component directory",
+        "found manifest /unit-test-components/test-preview-component/1.2.1/manifest.json, but failed to load manifest because: Invalid preview data for preview "preview-js-doesnt-exist": Preview inputData file "missing.js" does not exist",
+        "found manifest /unit-test-components/test-preview-component/1.2.2/manifest.json, but failed to load manifest because: Invalid preview data for preview "preview-json-doesnt-exist": Preview inputData file "missing.json" does not exist",
+        "found manifest /unit-test-components/test-preview-component/1.2.3/manifest.json, but failed to load manifest because: Invalid preview data for preview "preview-json-outside-of-root": Preview inputData file "../preview-data.json" is outside the component directory",
+        "found manifest /unit-test-components/test-static-files/1.0.2/manifest.json, but failed to load manifest because: "main's" static file "static-files-library/static-file-does-not-exist.js" is inaccessible",
+        "found manifest /unit-test-components/test-static-files/1.0.3/manifest.json, but failed to load manifest because: access to a static file locationRoot outside the parent directory in "test-static-files 1.0.3" is not allowed",
+        "found manifest /unit-test-components/test-static-files/1.0.4/manifest.json, but failed to load manifest because: access to a static file "../../static-files-library/static-library-file.js" for "main" outside the parent directory in "test-static-files 1.0.4" is not allowed",
+        "found manifest /unit-test-components/test-static-files/1.0.5/manifest.json, but failed to load manifest because: function main defines static files but manifest has no staticFiles.locationRoot defined",
+        "found manifest /unit-test-components/test-static-files/1.0.6/manifest.json, but failed to load manifest because: function main defines static files but manifest has no staticFiles.locationRoot defined",
+        "found manifest /unit-test-components/test-static-files/1.0.8/manifest.json, but failed to load manifest because: function main defines static files but manifest has no staticFiles.locationRoot defined",
+      ]
+    `);
+  });
+
+  describe('Manifest refreshes correctly', () => {
+    it('should update data on loadManifest when given manifest data is valid', async () => {
+      const manifestPath = await service.getManifestPath('refresh-test-components', 'test-refresh', '1.0.0');
+      const componentDirectory = path.resolve(COMPONENT_ROOT, 'unit-test-components', 'test-refresh', '1.0.0');
+      const originalManifestData = fs.readFileSync(componentDirectory + '/manifest.json', 'utf8');
+      const newManifestData = fs.readFileSync(componentDirectory + '/manifest-modified.json', 'utf8');
+      fs.writeFileSync(manifestPath, newManifestData);
+      const manifest = await service.loadManifest('refresh-test-components', 'test-refresh', '1.0.0');
+      expect(manifest.getName()).toEqual('refresh-test-components/test-refresh');
+      expect(manifest.getVersion()).toEqual('1.0.0');
+      expect(manifest.getModel()).toMatchInlineSnapshot(`
+        {
+          "$schema": "http://localhost:3000/schemas/v1.json#",
+          "description": "some-description-modified",
+          "displayName": "some-display-name-modified",
+          "functions": [
+            {
+              "entry": "main.js",
+              "input": {
+                "properties": {
+                  "something": {
+                    "type": "string",
+                  },
+                },
+                "required": [
+                  "something",
+                ],
+                "type": "object",
+              },
+              "name": "main-modified",
+              "output": {
+                "responseType": "html",
+              },
+            },
+          ],
+          "mainFunction": "main-modified",
+          "name": "test-refresh",
+          "namespace": "refresh-test-components",
+          "version": "1.0.0",
+        }
+      `);
+      fs.writeFileSync(manifestPath, originalManifestData);
+    });
+    it('should not update data correctly on loadManifest when given manifest data is invalid', async () => {
+      const manifestPath = await service.getManifestPath('refresh-test-components', 'test-refresh', '1.0.1');
+      const componentDirectory = path.resolve(COMPONENT_ROOT, 'unit-test-components', 'test-refresh', '1.0.1');
+      const originalManifestData = fs.readFileSync(componentDirectory + '/manifest.json', 'utf8');
+      const newManifestData = fs.readFileSync(componentDirectory + '/manifest-invalid.json', 'utf8');
+      fs.writeFileSync(manifestPath, newManifestData);
+      await expect(
+        service.loadManifest('refresh-test-components', 'test-refresh', '1.0.1'),
+      ).rejects.toThrowErrorMatchingInlineSnapshot(
+        `""test-refresh 1.0.1" main function could not be found in function list"`,
+      );
+      fs.writeFileSync(manifestPath, originalManifestData);
+    });
+  });
+});