@squiz/formatted-text-editor 1.66.2 → 1.66.3

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (4) hide show
  1. package/CHANGELOG.md +6 -0
  2. package/lib/utils/createToolbarPositioner.js +3 -1
  3. package/package.json +1 -1
  4. package/src/utils/createToolbarPositioner.ts +3 -1
package/CHANGELOG.md CHANGED
@@ -1,5 +1,11 @@
1
1
  # Change Log
2
2
 
3
+ ## 1.66.3
4
+
5
+ ### Patch Changes
6
+
7
+ - 7234d6c: Fixed FTE popover menu from having unusual positioning in certain circumstances
8
+
3
9
  ## 1.66.2
4
10
 
5
11
  ### Patch Changes
package/lib/utils/createToolbarPositioner.js CHANGED
@@ -86,7 +86,9 @@ const createToolbarPositioner = ({ types }) => {
86
86
  const headerBarBottom = (headerBarRects?.top ?? 0) + headerBarHeight;
87
87
  // If floating toolbar will overlap fixed toolbar, set position to under selection
88
88
  const isOverlapping = headerBarBottom + headerBarHeight > topmost;
89
- const y = isOverlapping ? bottommost + 62 : top; // FIXME: need to calculate rather than hard-code
89
+ // This is a good bottom position instead of it being on top of the toolbar when there is an overlap
90
+ const bottomPosition = parent.scrollTop + bottommost - parentRect.top + 62;
91
+ const y = isOverlapping ? bottomPosition : top;
90
92
  return { rect, y, x: left, height, width, visible };
91
93
  },
92
94
  });
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@squiz/formatted-text-editor",
3
- "version": "1.66.2",
3
+ "version": "1.66.3",
4
4
  "main": "lib/index.js",
5
5
  "types": "lib/index.d.ts",
6
6
  "private": false,
package/src/utils/createToolbarPositioner.ts CHANGED
@@ -118,7 +118,9 @@ export const createToolbarPositioner = ({ types }: ToolbarPositionerProps) => {
118
118
 
119
119
  // If floating toolbar will overlap fixed toolbar, set position to under selection
120
120
  const isOverlapping = headerBarBottom + headerBarHeight > topmost;
121
- const y = isOverlapping ? bottommost + 62 : top; // FIXME: need to calculate rather than hard-code
121
+ // This is a good bottom position instead of it being on top of the toolbar when there is an overlap
122
+ const bottomPosition = parent.scrollTop + bottommost - parentRect.top + 62;
123
+ const y = isOverlapping ? bottomPosition : top;
122
124
 
123
125
  return { rect, y, x: left, height, width, visible };
124
126
  },