@squiz/dxp-cli-next 5.29.1 → 5.30.0-develop.1

package/lib/page/layouts/deploy/deploy.js

@@ -51,6 +51,11 @@ const createDeployCommand = () => {
         try {
             const layout = yield (0, definitions_1.loadLayoutDefinition)(layoutFile);
             if (layout !== undefined) {
+                // Pre-deployment validation: check zones match between YAML and template
+                const zoneValidationError = validateZoneConsistency(layout);
+                if (zoneValidationError) {
+                    throw new Error(zoneValidationError);
+                }
                 const response = yield uploadLayout(apiService.client, layout, contentServiceUrl, options.dryRun);
                 if (!options.dryRun) {
                     exports.logger.info(`Layout "${layout.name}" version ${response.data.version} deployed successfully.`);
@@ -106,3 +111,48 @@ function maybeGetApplicationConfig() {
         catch (_a) { }
     });
 }
+/**
+ * Validates that zones defined in YAML match zones used in the Handlebars template
+ * @param layout The layout definition containing zones and template
+ * @returns Error message if validation fails, null if validation passes
+ */
+function validateZoneConsistency(layout) {
+    const yamlZones = Object.keys(layout.zones || {});
+    const template = layout.template;
+    // If no template is provided, skip validation
+    if (!template) {
+        return null;
+    }
+    // Extract zone references from Handlebars template
+    // Look for patterns like {{#each zones.zoneName}}, {{zones.zoneName}}, {{#if zones.zoneName}}
+    const zonePattern = /\{\{(?:#(?:each|if)\s+)?zones\.(\w+)/g;
+    const templateZones = new Set();
+    let match;
+    // Loop through the template and extract the zone names
+    while ((match = zonePattern.exec(template)) !== null) {
+        templateZones.add(match[1]);
+    }
+    // Convert the set to an array
+    const templateZoneArray = Array.from(templateZones);
+    // Find zones defined in YAML but not used in template
+    const unusedYamlZones = yamlZones.filter(zone => !templateZones.has(zone));
+    // Find zones used in template but not defined in YAML
+    const undefinedTemplateZones = templateZoneArray.filter(zone => !yamlZones.includes(zone));
+    // Create an array of errors
+    const errors = [];
+    // Add the unused zones to the errors
+    if (unusedYamlZones.length > 0) {
+        errors.push(`Zones defined in YAML but not used in template: ${unusedYamlZones.join(', ')}`);
+    }
+    // Add the undefined zones to the errors
+    if (undefinedTemplateZones.length > 0) {
+        errors.push(`Zones used in template but not defined in YAML: ${undefinedTemplateZones.join(', ')}`);
+    }
+    // If there are errors, return the errors
+    if (errors.length > 0) {
+        return `Zone consistency validation failed:\n${errors
+            .map(err => `  - ${err}`)
+            .join('\n')}`;
+    }
+    return null;
+}

package/lib/page/layouts/deploy/deploy.spec.js

@@ -92,7 +92,13 @@ describe('deployCommand', () => {
     it('deploys a layout successfully', () => __awaiter(void 0, void 0, void 0, function* () {
         const file = './src/__tests__/layouts/page-layout.yaml';
         const dxpBaseUrl = 'http://dxp-base-url.com';
-        const mockLayout = { name: 'Test Layout' };
+        const mockLayout = {
+            name: 'Test Layout',
+            zones: {
+                content: { displayName: 'Content', description: 'Main content' },
+            },
+            template: '<div>{{zones.content}}</div>',
+        };
         const mockResponse = { name: 'Test Layout', version: '12345' };
         definitions_1.loadLayoutDefinition.mockResolvedValue(mockLayout);
         (0, nock_1.default)(dxpBaseUrl + '/__dxp/service/components-content')
@@ -107,7 +113,13 @@ describe('deployCommand', () => {
         const file = './src/__tests__/layout.yaml';
         const dxpBaseUrl = 'http://dxp-base-url.com';
         const dryRun = true;
-        const mockLayout = { name: 'Test Layout' };
+        const mockLayout = {
+            name: 'Test Layout',
+            zones: {
+                content: { displayName: 'Content', description: 'Main content' },
+            },
+            template: '<div>{{zones.content}}</div>',
+        };
         const mockResponse = { name: 'Test Layout', version: '12345' };
         definitions_1.loadLayoutDefinition.mockResolvedValue(mockLayout);
         (0, nock_1.default)(dxpBaseUrl + '/__dxp/service/components-content')
@@ -159,4 +171,40 @@ describe('deployCommand', () => {
         yield program.parseAsync(createMockArgs({ contentServiceUrl }));
         expect(errorSpy).toHaveBeenCalledWith(expect.stringContaining('An unknown error occurred'));
     }));
+    describe('zone consistency validation', () => {
+        it('should handle zone consistency validation errors where zones are used but not defined in the layout', () => __awaiter(void 0, void 0, void 0, function* () {
+            const file = './src/__tests__/layout.yaml';
+            const dxpBaseUrl = 'http://dxp-base-url.com';
+            // Mock layout with zones that don't match the template
+            const mockLayout = {
+                name: 'Test Layout',
+                zones: {
+                    col1: { displayName: 'Column 1', description: 'The first column' },
+                },
+                template: '{{zones.col1}} {{zones.col2}}', // col2 is used but not defined in zones
+            };
+            definitions_1.loadLayoutDefinition.mockResolvedValue(mockLayout);
+            const program = (0, deploy_1.default)();
+            errorSpy = jest.spyOn(program, 'error').mockImplementation();
+            yield program.parseAsync(createMockArgs({ config: file, dxpBaseUrl }));
+            expect(errorSpy).toHaveBeenCalledWith(expect.stringMatching(/Zone consistency validation failed[\s\S]*Zones used in template but not defined in YAML: col2/));
+        }));
+        it('should handle zone consistency validation errors where zones are defined but not used in the template', () => __awaiter(void 0, void 0, void 0, function* () {
+            const file = './src/__tests__/layout.yaml';
+            const dxpBaseUrl = 'http://dxp-base-url.com';
+            const mockLayout = {
+                name: 'Test Layout',
+                zones: {
+                    col1: { displayName: 'Column 1', description: 'The first column' },
+                    col2: { displayName: 'Column 2', description: 'The second column' }, // col2 is defined but not used in the template
+                },
+                template: '{{zones.col1}}',
+            };
+            definitions_1.loadLayoutDefinition.mockResolvedValue(mockLayout);
+            const program = (0, deploy_1.default)();
+            errorSpy = jest.spyOn(program, 'error').mockImplementation();
+            yield program.parseAsync(createMockArgs({ config: file, dxpBaseUrl }));
+            expect(errorSpy).toHaveBeenCalledWith(expect.stringMatching(/Zone consistency validation failed[\s\S]*Zones defined in YAML but not used in template: col2/));
+        }));
+    });
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@squiz/dxp-cli-next",
-  "version": "5.29.1",
+  "version": "5.30.0-develop.1",
   "repository": {
     "url": "https://gitlab.squiz.net/dxp/dxp-cli-next"
   },