@squiz/dxp-cli-next 2.11.1-test-ub9.1 → 2.11.1

package/lib/__tests__/cmp/dev-mode.spec.js

@@ -27,28 +27,4 @@ describe('cmp dev', () => {
         const opts = program.opts();
         expect(opts.port).toStrictEqual(3000);
     });
-    it.each(['3000', '3001', '65535', '1024'])('correctly parses the port (%s)', (attemptedPort) => __awaiter(void 0, void 0, void 0, function* () {
-        const program = (0, dev_mode_1.buildDevModeCommand)()
-            .exitOverride()
-            .action(() => { });
-        program.parse(['node', 'dxp-cli', 'dev', '--port', attemptedPort]);
-        const opts = program.opts();
-        expect(typeof opts.port).toStrictEqual('number');
-    }));
-    it.each([
-        'hello_world',
-        '3_000',
-        '65_535',
-        '1000',
-        '100',
-        '1_000_000',
-        '1000000',
-        'abc_1000',
-        '1000arst',
-    ])('errors when port (%s) is not a number between 1000-65535', attemptedPort => {
-        const program = (0, dev_mode_1.buildDevModeCommand)()
-            .exitOverride()
-            .action(() => { });
-        expect(() => program.parse(['node', 'dxp-cli', 'dev', '--port', attemptedPort])).toThrowError('Port must be a number between 1024-65535');
-    });
 });

package/lib/cmp/dev-mode.js

@@ -12,8 +12,6 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.buildDevModeCommand = void 0;
 const commander_1 = require("commander");
 const component_cli_lib_1 = require("@squiz/component-cli-lib");
-const MIN_PORT = 1024;
-const MAX_PORT = 65535;
 const buildDevModeCommand = () => new commander_1.Command()
     .name('dev')
     .description('A local component runner for developing new components')
@@ -25,15 +23,7 @@ The logs are currently \`bunyan\` formatted and should be piped into the bunyan
     .argument('<source>', 'folder containing the template files in development')
     .addOption(new commander_1.Option('-p, --port <number>', 'Define port the webserver runs on')
     .default(3000)
-    .argParser(v => {
-    const parsedPort = Number(v);
-    if (isNaN(parsedPort) ||
-        MIN_PORT > parsedPort ||
-        parsedPort > MAX_PORT) {
-        throw new commander_1.InvalidArgumentError(`Port must be a number between ${MIN_PORT}-${MAX_PORT}`);
-    }
-    return parsedPort;
-}))
+    .argParser(v => parseInt(v)))
     .action((source, options) => __awaiter(void 0, void 0, void 0, function* () {
     yield (0, component_cli_lib_1.startDevelopmentRender)(source, options);
 }));

package/lib/dxp.js

@@ -3,16 +3,11 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-const validateNodeVersion = require('../scripts/validateNodeVersion');
-const cli_color_1 = __importDefault(require("cli-color"));
-if (validateNodeVersion() === true) {
-    console.error(cli_color_1.default.red('You are running an older version of node(${process.version}). Please install node v16 or higher'));
-    // eslint-disable-next-line no-process-exit
-    process.exit(1);
-}
 const commander_1 = __importDefault(require("commander"));
 const update_notifier_1 = __importDefault(require("update-notifier"));
 const pkg = require('../package.json');
+const cli_color_1 = __importDefault(require("cli-color"));
+validateNodeVersion();
 (0, update_notifier_1.default)({ pkg, updateCheckInterval: 1 }).notify({
     isGlobal: true,
 });
@@ -33,3 +28,14 @@ program
     program.help();
 })
     .parse(process.argv);
+function validateNodeVersion() {
+    const nodeVersionParts = process.versions.node
+        .split('.')
+        .map(part => Number(part));
+    const [nodeVersion] = nodeVersionParts;
+    if (nodeVersion < 16) {
+        console.error(cli_color_1.default.red(`You are running an older version of node(${process.version}). Please install node v16 or higher`));
+        // eslint-disable-next-line no-process-exit
+        process.exit(1);
+    }
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@squiz/dxp-cli-next",
-  "version": "2.11.1-test-ub9.1",
+  "version": "2.11.1",
   "repository": {
     "url": "https://gitlab.squiz.net/developer-experience/dxp-cli-next"
   },
@@ -22,12 +22,10 @@
     "semantic-release": "semantic-release",
     "test:watch": "jest --watch",
     "test": "jest --coverage",
-    "typecheck": "tsc --noEmit",
-    "preinstall": "node preinstall-script.js",
-    "prestart": "node preinstall-script.js"
+    "typecheck": "tsc --noEmit"
   },
   "engines": {
-    "node": ">=16.0"
+    "node": ">=14.0"
   },
   "keywords": [
     "cli",
@@ -80,7 +78,6 @@
       "path": "./node_modules/cz-conventional-changelog"
     }
   },
-  "engineStrict": true,
   "lint-staged": {
     "*.ts": "eslint --cache --cache-location .eslintcache --fix"
   },
@@ -90,10 +87,6 @@
       {
         "name": "develop",
         "prerelease": true
-      },
-      {
-        "name": "test-*",
-        "prerelease": true
       }
     ],
     "plugins": [