@squiz/component-cli-lib 1.12.0-alpha.2 → 1.12.0-alpha.21

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@squiz/component-cli-lib",
-  "version": "1.12.0-alpha.2",
+  "version": "1.12.0-alpha.21",
   "description": "",
   "main": "lib/index.js",
   "scripts": {
@@ -12,31 +12,31 @@
   "author": "",
   "license": "ISC",
   "devDependencies": {
-    "@squiz/component-lib": "1.12.0-alpha.2",
-    "@squiz/component-web-api-lib": "1.12.0-alpha.2",
-    "@squiz/dx-common-lib": "1.12.0-alpha.2",
-    "@squiz/dx-json-schema-lib": "1.12.0-alpha.2",
-    "@squiz/dx-logger-lib": "1.12.0-alpha.2",
-    "@squiz/virus-scanner-lib": "1.12.0-alpha.2",
+    "@squiz/component-lib": "1.12.0-alpha.21",
+    "@squiz/component-web-api-lib": "1.12.0-alpha.21",
+    "@squiz/dx-common-lib": "1.12.0-alpha.21",
+    "@squiz/dx-json-schema-lib": "1.12.0-alpha.21",
+    "@squiz/dx-logger-lib": "1.12.0-alpha.21",
+    "@squiz/virus-scanner-lib": "1.12.0-alpha.21",
     "@types/cli-color": "2.0.2",
-    "@types/express": "4.17.14",
+    "@types/express": "4.17.17",
     "@types/jest": "28.1.8",
     "@types/node": "17.0.27",
     "@types/supertest": "2.0.12",
     "dotenv": "16.0.3",
-    "jest": "28.1.3",
+    "jest": "29.4.1",
     "ts-jest": "28.0.8",
     "ts-loader": "9.3.1",
     "ts-node": "10.9.1",
     "typescript": "4.9.4"
   },
   "dependencies": {
-    "@squiz/render-runtime-lib": "1.12.0-alpha.2",
+    "@squiz/render-runtime-lib": "1.12.0-alpha.21",
     "archiver": "5.3.1",
-    "axios": "0.27.2",
+    "axios": "1.3.2",
     "cli-color": "^2.0.2",
     "open": "^8.4.0",
     "supertest": "^6.2.3"
   },
-  "gitHead": "7c4f0ca35f3e24b4e5af3798313843e5177cbc7d"
+  "gitHead": "52e0baca629d181674d9dcd5a83087c1f1f0b324"
 }

package/src/component-dev.integration.spec.ts

@@ -31,34 +31,43 @@ describe('component-dev', () => {
     });
 
     describe('definition routes', () => {
-      const server = startDevelopmentRender(TestHelpers.getTestComponentFolder(), { port: 0, noBrowser: true });
-      const request = () => supertest(server);
-      routeTests.definition(request, 'http://localhost:0');
-      afterAll(() => {
-        server.close();
-      });
+      routeTests.definition(() => request, 'http://localhost:0');
     });
 
     describe('static routes', () => {
-      const server = startDevelopmentRender(TestHelpers.getTestComponentFolder(), { port: 0, noBrowser: true });
-      const request = () => supertest(server);
-      routeTests.static(request);
-      afterAll(() => {
-        server.close();
-      });
+      routeTests.static(() => request);
     });
 
     describe('render routes', () => {
-      const server = startDevelopmentRender(TestHelpers.getTestComponentFolder(), { port: 0, noBrowser: true });
-      const request = () => supertest(server);
-      routeTests.render(request, 'http://localhost:0');
-      afterAll(() => {
-        server.close();
-      });
+      routeTests.render(() => request, 'http://localhost:0');
     });
 
     describe('preview tests', () => {
       routeTests.preview(() => request, 'http://localhost:0');
     });
+
+    describe('user experience', () => {
+      describe('on navigation to a component without preview from home page it should still try and render by default', () => {
+        it('should successfully try to render a component with a dummy set', async () => {
+          const listingResponse = await request.get('/');
+          // Component with no preview
+          expect(listingResponse.text).toContain(
+            '/r/unit-test-components/test-component/1.0.0?_componentSet=local-development-only',
+          );
+
+          const renderResponse = await request.get(
+            '/r/unit-test-components/test-component/1.0.0?_componentSet=local-development-only',
+          );
+
+          expect(renderResponse.statusCode).not.toEqual(200);
+
+          const withInputResponse = await request.get(
+            '/r/unit-test-components/test-component/1.0.0?_componentSet=local-development-only&something=my-value',
+          );
+
+          expect(withInputResponse.statusCode).toEqual(200);
+        });
+      });
+    });
   });
 });

package/src/integration-tests/upload-and-render-component.integration.spec.ts

@@ -181,7 +181,8 @@ describe('uploading a component', () => {
         testFilesDir,
       );
 
-      const uploadedComponent = '<a href="/r/smoke-test-components/cmp-static-file-test/1.0.0">1.0.0</a>';
+      const uploadedComponent =
+        '<a href="/r/smoke-test-components/cmp-static-file-test/1.0.0?_componentSet=local-development-only">1.0.0</a>';
       const get = await supertest(configObj.renderServiceUrl).get('/');
       expect(get.status).toEqual(200);
       expect((get as any)?.res?.text).toContain(uploadedComponent);