@spzhongwin/skill-logger-plugin 1.0.14 → 1.0.16

package/src/hooks.test.ts

@@ -1,251 +1,228 @@
-import { describe, it } from "node:test";
-import assert from "node:assert/strict";
-import { Hooks } from "./hooks.ts";
-import { ActiveSkills } from "./active-skills.ts";
-import { buildIndex } from "./matcher.ts";
-import type { Reporter } from "./reporter.ts";
-import type { ConfigSync } from "./config-sync.ts";
-import type { SkillEvent, SkillStandardConfig } from "./types.ts";
-
-const sampleConfigs: SkillStandardConfig[] = [
-  {
-    skillName: "model-usage",
-    version: "1.0.0",
-    functions: [
-      { id: "usage_current", name: "当前用量", match: { type: "script", script: "scripts/model_usage.py", argRules: [{ flag: "--mode", value: "current" }] } },
-    ],
-  },
-];
-
-const tick = () => new Promise((r) => setImmediate(r));
-
-function setup() {
-  const captured: SkillEvent[] = [];
-  const reporter = { appendEvent: async (e: SkillEvent) => void captured.push(e) } as unknown as Reporter;
-  const index = buildIndex(sampleConfigs);
-  const lazy: string[] = [];
-  const configSync = {
-    getIndex: () => index,
-    lazyCheck: async (name: string) => void lazy.push(name),
-    resolveSkillName: () => undefined,
-    getVersion: () => undefined,
-  } as unknown as ConfigSync;
-  const activeSkills = new ActiveSkills();
-  const hooks = new Hooks(reporter, configSync, activeSkills, () => ({}));
-  return { hooks, captured, lazy, activeSkills };
-}
-
-describe("Hooks 端到端串联", () => {
-  it("read SKILL.md → skill_trigger + 标记激活 + 懒拉", async () => {
-    const { hooks, captured, lazy, activeSkills } = setup();
-    hooks.onBeforeToolCall(
-      { toolName: "read", params: { path: "/e/skills/model-usage/SKILL.md" } },
-      { sessionId: "s1", agentId: "main" }
-    );
-    await tick();
-    assert.equal(captured.length, 1);
-    assert.equal(captured[0].event_type, "skill_trigger");
-    assert.equal(captured[0].skill_name, "model-usage");
-    assert.equal(captured[0].invoke_mode, "inline");
-    assert.deepEqual(lazy, ["model-usage"]);
-    assert.ok(activeSkills.getActive("s1").has("model-usage"));
-  });
-
-  it("skill 工具直调（command-dispatch: tool）→ skill_trigger(tool)", async () => {
-    const { hooks, captured, activeSkills } = setup();
-    hooks.onBeforeToolCall({ toolName: "skill", params: { skill: "model-usage" } }, { sessionId: "s1" });
-    await tick();
-    assert.equal(captured.length, 1);
-    assert.equal(captured[0].event_type, "skill_trigger");
-    assert.equal(captured[0].invoke_mode, "tool");
-    assert.ok(activeSkills.getActive("s1").has("model-usage"));
-  });
-
-  it("skill 工具直调有 toolCallId 时 after 报错 → 补记 function_call(error)", async () => {
-    const { hooks, captured } = setup();
-    hooks.onBeforeToolCall(
-      { toolName: "skill", params: { skill: "model-usage" }, toolCallId: "skill-t1" },
-      { sessionId: "s1" }
-    );
-    hooks.onAfterToolCall({ toolCallId: "skill-t1", errorMessage: "skill failed", elapsedMs: 9 });
-    await tick();
-
-    assert.equal(captured.length, 2);
-    assert.equal(captured[0].event_type, "skill_trigger");
-    const call = captured[1];
-    assert.equal(call.event_type, "function_call");
-    assert.equal(call.skill_name, "model-usage");
-    assert.equal(call.invoke_tool, "skill");
-    assert.equal(call.status, "error");
-    assert.equal(call.error_message, "skill failed");
-    assert.equal(call.duration_ms, 9);
-  });
-
-  it("after 未到达：flushAllPending 补记 unknown", async () => {
-    const { hooks, captured } = setup();
-    hooks.onBeforeToolCall(
-      { toolName: "exec", params: { command: "python /e/skills/model-usage/scripts/model_usage.py --mode current" }, toolCallId: "t9" },
-      { sessionId: "s1" }
-    );
-    await tick();
-    assert.equal(captured.length, 0);
-    await hooks.flushAllPending();
-    await tick();
-    assert.equal(captured.length, 1);
-    assert.equal(captured[0].status, "unknown");
-    assert.equal(captured[0].function_id, "usage_current");
-  });
-
-  it("session_end 补记该 session 残留 pending 并清激活", async () => {
-    const { hooks, captured, activeSkills } = setup();
-    hooks.onBeforeToolCall({ toolName: "read", params: { path: "/e/skills/model-usage/SKILL.md" } }, { sessionId: "s1" });
-    hooks.onBeforeToolCall(
-      { toolName: "exec", params: { command: "python /e/skills/model-usage/scripts/model_usage.py --mode current" }, toolCallId: "t10" },
-      { sessionId: "s1" }
-    );
-    await tick();
-    captured.length = 0;
-    hooks.onSessionEnd({ sessionId: "s1" });
-    await tick();
-    assert.equal(captured.filter((e) => e.status === "unknown").length, 1);
-    assert.deepEqual([...activeSkills.getActive("s1")], []);
-  });
-
-  it("exec 命中 → 暂存，after 成功 → function_call(success)", async () => {
-    const { hooks, captured } = setup();
-    hooks.onBeforeToolCall(
-      { toolName: "exec", params: { command: "python /e/skills/model-usage/scripts/model_usage.py --mode current" }, toolCallId: "t1" },
-      { sessionId: "s1" }
-    );
-    await tick();
-    assert.equal(captured.length, 0); // 等 after
-
-    hooks.onAfterToolCall({ toolCallId: "t1", durationMs: 42 });
-    await tick();
-    assert.equal(captured.length, 1);
-    const ev = captured[0];
-    assert.equal(ev.event_type, "function_call");
-    assert.equal(ev.function_id, "usage_current");
-    assert.equal(ev.match_type, "script");
-    assert.equal(ev.status, "success");
-    assert.equal(ev.duration_ms, 42);
-    assert.equal(ev.args?.mode, "current");
-  });
-
-  it("after 带 error → function_call(error)", async () => {
-    const { hooks, captured } = setup();
-    hooks.onBeforeToolCall(
-      { toolName: "exec", params: { command: "python /e/skills/model-usage/scripts/model_usage.py --mode current" }, toolCallId: "t2" },
-      { sessionId: "s1" }
-    );
-    await tick();
-    hooks.onAfterToolCall({ toolCallId: "t2", error: "boom" });
-    await tick();
-    assert.equal(captured[0].status, "error");
-    assert.equal(captured[0].error_message, "boom");
-  });
-
-  it("after 的结构化错误与失败状态也会归为 error", async () => {
-    const { hooks, captured } = setup();
-    hooks.onBeforeToolCall(
-      { toolName: "exec", params: { command: "python /e/skills/model-usage/scripts/model_usage.py --mode current" }, toolCallId: "t4" },
-      { sessionId: "s1" }
-    );
-    await tick();
-    hooks.onAfterToolCall({ toolCallId: "t4", status: "failed", message: "process failed", duration_ms: 7 });
-    await tick();
-    assert.equal(captured[0].status, "error");
-    assert.equal(captured[0].error_message, "process failed");
-    assert.equal(captured[0].duration_ms, 7);
-  });
-
-  it("after 的嵌套 result 失败信号会提取 stderr", async () => {
-    const { hooks, captured } = setup();
-    hooks.onBeforeToolCall(
-      { toolName: "exec", params: { command: "python /e/skills/model-usage/scripts/model_usage.py --mode current" }, toolCallId: "t6" },
-      { sessionId: "s1" }
-    );
-    await tick();
-    hooks.onAfterToolCall({ toolCallId: "t6", result: { ok: false, stderr: "stderr failed" } });
-    await tick();
-    assert.equal(captured[0].status, "error");
-    assert.equal(captured[0].error_message, "stderr failed");
-  });
-
-  it("未匹配 exec 但会话中只有一个激活 skill → 等 after 补记状态和错误", async () => {
-    const { hooks, captured } = setup();
-    hooks.onBeforeToolCall({ toolName: "read", params: { path: "/e/skills/model-usage/SKILL.md" } }, { sessionId: "s1" });
-    await tick();
-    captured.length = 0;
-
-    hooks.onBeforeToolCall(
-      { toolName: "exec", params: { command: "custom command --bad" }, toolCallId: "t5" },
-      { sessionId: "s1" }
-    );
-    await tick();
-    assert.equal(captured.length, 0);
-
-    hooks.onAfterToolCall({ toolCallId: "t5", error: { message: "custom failed" }, durationMs: 11 });
-    await tick();
-    assert.equal(captured.length, 1);
-    assert.equal(captured[0].event_type, "function_call");
-    assert.equal(captured[0].skill_name, "model-usage");
-    assert.equal(captured[0].invoke_tool, "exec");
-    assert.equal(captured[0].command, "custom command --bad");
-    assert.equal(captured[0].status, "error");
-    assert.equal(captured[0].error_message, "custom failed");
-    assert.equal(captured[0].duration_ms, 11);
-  });
-
-  it("report_skill_error 手动上报会记录 error 事件并携带会话 appKey", async () => {
-    const { hooks, captured } = setup();
-    hooks.onMessageReceived({ content: "appKey: abcdef123456" }, { sessionId: "s1" });
-    hooks.onManualErrorRecord(
-      {
-        skill_name: "model-usage",
-        tool_name: "usage_current",
-        error_message: "manual failure",
-        input_args: "--mode current",
-      },
-      { sessionId: "s1", agentId: "main", runId: "r1" }
-    );
-    await tick();
-    assert.equal(captured.length, 1);
-    assert.equal(captured[0].event_type, "function_call");
-    assert.equal(captured[0].skill_name, "model-usage");
-    assert.equal(captured[0].invoke_tool, "report_skill_error");
-    assert.equal(captured[0].status, "error");
-    assert.equal(captured[0].error_message, "manual failure");
-    assert.equal(captured[0].app_key, "abcdef123456");
-    assert.deepEqual(captured[0].args, { raw_args: "--mode current" });
-  });
-
-  it("未命中且默认配置 → 不记录", async () => {
-    const { hooks, captured } = setup();
-    hooks.onBeforeToolCall({ toolName: "exec", params: { command: "ls -la" }, toolCallId: "t3" }, { sessionId: "s1" });
-    hooks.onAfterToolCall({ toolCallId: "t3" });
-    await tick();
-    assert.equal(captured.length, 0);
-  });
-});
-
-describe("插件模块图可加载", () => {
-  it("import index.ts 并 register 注册全部生命周期 hook", async () => {
-    const mod = await import("./index.ts");
-    const registered: string[] = [];
-    mod.default.register({ on: (name: string) => registered.push(name) });
-    assert.deepEqual(
-      registered.sort(),
-      [
-        "after_tool_call",
-        "before_install",
-        "before_prompt_build",
-        "before_tool_call",
-        "gateway_start",
-        "gateway_stop",
-        "message_received",
-        "session_end",
-      ]
-    );
-  });
-});
+import { describe, it } from "node:test";
+import assert from "node:assert/strict";
+import { Hooks } from "./hooks.ts";
+import { ActiveSkills } from "./active-skills.ts";
+import { buildIndex } from "./matcher.ts";
+import type { Reporter } from "./reporter.ts";
+import type { ConfigSync } from "./config-sync.ts";
+import type { SkillEvent, SkillStandardConfig } from "./types.ts";
+
+const sampleConfigs: SkillStandardConfig[] = [
+  {
+    skillName: "model-usage",
+    version: "1.0.0",
+    functions: [
+      { id: "usage_current", name: "当前用量", match: { type: "script", script: "scripts/model_usage.py", argRules: [{ flag: "--mode", value: "current" }] } },
+    ],
+  },
+];
+
+const tick = () => new Promise((r) => setImmediate(r));
+
+function setup() {
+  const captured: SkillEvent[] = [];
+  const reporter = { appendEvent: async (e: SkillEvent) => void captured.push(e) } as unknown as Reporter;
+  const index = buildIndex(sampleConfigs);
+  const lazy: string[] = [];
+  const configSync = {
+    getIndex: () => index,
+    lazyCheck: async (name: string) => void lazy.push(name),
+    resolveSkillName: () => undefined,
+    getVersion: () => undefined,
+  } as unknown as ConfigSync;
+  const activeSkills = new ActiveSkills();
+  const hooks = new Hooks(reporter, configSync, activeSkills, () => ({}));
+  return { hooks, captured, lazy, activeSkills };
+}
+
+describe("Hooks 端到端串联", () => {
+  it("read SKILL.md → skill_trigger + 标记激活 + 懒拉", async () => {
+    const { hooks, captured, lazy, activeSkills } = setup();
+    hooks.onBeforeToolCall(
+      { toolName: "read", params: { path: "/e/skills/model-usage/SKILL.md" } },
+      { sessionId: "s1", agentId: "main" }
+    );
+    await tick();
+    assert.equal(captured.length, 1);
+    assert.equal(captured[0].event_type, "skill_trigger");
+    assert.equal(captured[0].skill_name, "model-usage");
+    assert.equal(captured[0].invoke_mode, "inline");
+    assert.deepEqual(lazy, ["model-usage"]);
+    assert.ok(activeSkills.getActive("s1").has("model-usage"));
+  });
+
+  it("skill 工具直调（command-dispatch: tool）→ skill_trigger(tool)", async () => {
+    const { hooks, captured, activeSkills } = setup();
+    hooks.onBeforeToolCall({ toolName: "skill", params: { skill: "model-usage" } }, { sessionId: "s1" });
+    await tick();
+    assert.equal(captured.length, 1);
+    assert.equal(captured[0].event_type, "skill_trigger");
+    assert.equal(captured[0].invoke_mode, "tool");
+    assert.ok(activeSkills.getActive("s1").has("model-usage"));
+  });
+
+  it("skill 工具直调有 toolCallId 时 after 报错 → 补记 function_call(error)", async () => {
+    const { hooks, captured } = setup();
+    hooks.onBeforeToolCall(
+      { toolName: "skill", params: { skill: "model-usage" }, toolCallId: "skill-t1" },
+      { sessionId: "s1" }
+    );
+    hooks.onAfterToolCall({ toolCallId: "skill-t1", errorMessage: "skill failed", elapsedMs: 9 });
+    await tick();
+
+    assert.equal(captured.length, 2);
+    assert.equal(captured[0].event_type, "skill_trigger");
+    const call = captured[1];
+    assert.equal(call.event_type, "function_call");
+    assert.equal(call.skill_name, "model-usage");
+    assert.equal(call.invoke_tool, "skill");
+    assert.equal(call.status, "error");
+    assert.equal(call.error_message, "skill failed");
+    assert.equal(call.duration_ms, 9);
+  });
+
+  it("after 未到达：flushAllPending 补记 unknown", async () => {
+    const { hooks, captured } = setup();
+    hooks.onBeforeToolCall(
+      { toolName: "exec", params: { command: "python /e/skills/model-usage/scripts/model_usage.py --mode current" }, toolCallId: "t9" },
+      { sessionId: "s1" }
+    );
+    await tick();
+    assert.equal(captured.length, 0);
+    await hooks.flushAllPending();
+    await tick();
+    assert.equal(captured.length, 1);
+    assert.equal(captured[0].status, "unknown");
+    assert.equal(captured[0].function_id, "usage_current");
+  });
+
+  it("session_end 补记该 session 残留 pending 并清激活", async () => {
+    const { hooks, captured, activeSkills } = setup();
+    hooks.onBeforeToolCall({ toolName: "read", params: { path: "/e/skills/model-usage/SKILL.md" } }, { sessionId: "s1" });
+    hooks.onBeforeToolCall(
+      { toolName: "exec", params: { command: "python /e/skills/model-usage/scripts/model_usage.py --mode current" }, toolCallId: "t10" },
+      { sessionId: "s1" }
+    );
+    await tick();
+    captured.length = 0;
+    hooks.onSessionEnd({ sessionId: "s1" });
+    await tick();
+    assert.equal(captured.filter((e) => e.status === "unknown").length, 1);
+    assert.deepEqual([...activeSkills.getActive("s1")], []);
+  });
+
+  it("exec 命中 → 暂存，after 成功 → function_call(success)", async () => {
+    const { hooks, captured } = setup();
+    hooks.onBeforeToolCall(
+      { toolName: "exec", params: { command: "python /e/skills/model-usage/scripts/model_usage.py --mode current" }, toolCallId: "t1" },
+      { sessionId: "s1" }
+    );
+    await tick();
+    assert.equal(captured.length, 0); // 等 after
+
+    hooks.onAfterToolCall({ toolCallId: "t1", durationMs: 42 });
+    await tick();
+    assert.equal(captured.length, 1);
+    const ev = captured[0];
+    assert.equal(ev.event_type, "function_call");
+    assert.equal(ev.function_id, "usage_current");
+    assert.equal(ev.match_type, "script");
+    assert.equal(ev.status, "success");
+    assert.equal(ev.duration_ms, 42);
+    assert.equal(ev.args?.mode, "current");
+  });
+
+  it("after 带 error → function_call(error)", async () => {
+    const { hooks, captured } = setup();
+    hooks.onBeforeToolCall(
+      { toolName: "exec", params: { command: "python /e/skills/model-usage/scripts/model_usage.py --mode current" }, toolCallId: "t2" },
+      { sessionId: "s1" }
+    );
+    await tick();
+    hooks.onAfterToolCall({ toolCallId: "t2", error: "boom" });
+    await tick();
+    assert.equal(captured[0].status, "error");
+    assert.equal(captured[0].error_message, "boom");
+  });
+
+  it("after 的结构化错误与失败状态也会归为 error", async () => {
+    const { hooks, captured } = setup();
+    hooks.onBeforeToolCall(
+      { toolName: "exec", params: { command: "python /e/skills/model-usage/scripts/model_usage.py --mode current" }, toolCallId: "t4" },
+      { sessionId: "s1" }
+    );
+    await tick();
+    hooks.onAfterToolCall({ toolCallId: "t4", status: "failed", message: "process failed", duration_ms: 7 });
+    await tick();
+    assert.equal(captured[0].status, "error");
+    assert.equal(captured[0].error_message, "process failed");
+    assert.equal(captured[0].duration_ms, 7);
+  });
+
+  it("after 的嵌套 result 失败信号会提取 stderr", async () => {
+    const { hooks, captured } = setup();
+    hooks.onBeforeToolCall(
+      { toolName: "exec", params: { command: "python /e/skills/model-usage/scripts/model_usage.py --mode current" }, toolCallId: "t6" },
+      { sessionId: "s1" }
+    );
+    await tick();
+    hooks.onAfterToolCall({ toolCallId: "t6", result: { ok: false, stderr: "stderr failed" } });
+    await tick();
+    assert.equal(captured[0].status, "error");
+    assert.equal(captured[0].error_message, "stderr failed");
+  });
+
+  it("未匹配 exec 但会话中只有一个激活 skill → 等 after 补记状态和错误", async () => {
+    const { hooks, captured } = setup();
+    hooks.onBeforeToolCall({ toolName: "read", params: { path: "/e/skills/model-usage/SKILL.md" } }, { sessionId: "s1" });
+    await tick();
+    captured.length = 0;
+
+    hooks.onBeforeToolCall(
+      { toolName: "exec", params: { command: "custom command --bad" }, toolCallId: "t5" },
+      { sessionId: "s1" }
+    );
+    await tick();
+    assert.equal(captured.length, 0);
+
+    hooks.onAfterToolCall({ toolCallId: "t5", error: { message: "custom failed" }, durationMs: 11 });
+    await tick();
+    assert.equal(captured.length, 1);
+    assert.equal(captured[0].event_type, "function_call");
+    assert.equal(captured[0].skill_name, "model-usage");
+    assert.equal(captured[0].invoke_tool, "exec");
+    assert.equal(captured[0].command, "custom command --bad");
+    assert.equal(captured[0].status, "error");
+    assert.equal(captured[0].error_message, "custom failed");
+    assert.equal(captured[0].duration_ms, 11);
+  });
+
+  it("未命中且默认配置 → 不记录", async () => {
+    const { hooks, captured } = setup();
+    hooks.onBeforeToolCall({ toolName: "exec", params: { command: "ls -la" }, toolCallId: "t3" }, { sessionId: "s1" });
+    hooks.onAfterToolCall({ toolCallId: "t3" });
+    await tick();
+    assert.equal(captured.length, 0);
+  });
+});
+
+describe("插件模块图可加载", () => {
+  it("import index.ts 并 register 注册全部生命周期 hook", async () => {
+    const mod = await import("./index.ts");
+    const registered: string[] = [];
+    mod.default.register({ on: (name: string) => registered.push(name) });
+    assert.deepEqual(
+      registered.sort(),
+      [
+        "after_tool_call",
+        "before_install",
+        "before_prompt_build",
+        "before_tool_call",
+        "gateway_start",
+        "gateway_stop",
+        "message_received",
+        "session_end",
+      ]
+    );
+  });
+});