@spscommerce/eslint-config-typescript 0.0.4 → 0.0.8

package/lib/rules/bestPractices.js

@@ -237,9 +237,12 @@ exports.bestPractices = {
     "@typescript-eslint/no-magic-numbers": [
         "error",
         {
-            ignore: [0,
+            ignore: [
+                -1,
+                0,
                 1,
-                2],
+                2,
+            ],
             ignoreArrayIndexes: true,
         },
     ],
@@ -443,8 +446,9 @@ exports.bestPractices = {
     /**
      * disallow use of void operator
      * https://eslint.org/docs/rules/no-void
+     * Typing for this rule config seems to be incorrect
      */
-    "no-void": "error",
+    "no-void": ["error", { allowAsStatement: true }],
     /**
      * disallow usage of configurable warning terms in comments: e.g. todo
      * https://eslint.org/docs/rules/no-warning-comments

package/lib/rules/possibleErrors.js

@@ -93,8 +93,9 @@ exports.possibleErrors = {
     /**
      * disallow double-negation boolean casts in a boolean context ✅ 🔧
      * https://eslint.org/docs/rules/no-extra-boolean-cast
+     * Disabled because it conflicts with @typescript-eslint/strict-boolean-expressions
      */
-    "no-extra-boolean-cast": "error",
+    "no-extra-boolean-cast": "off",
     /**
      * disallow unnecessary parentheses 🔧
      * https://eslint.org/docs/rules/no-extra-parens

package/lib/rules/stylisticIssues.js

@@ -106,8 +106,9 @@ exports.stylisticIssues = {
     /**
      * enforce consistent line breaks inside function parentheses 🔧
      * https://eslint.org/docs/rules/function-paren-newline
+     * Disabled because it results in conflicts with Prettier
      */
-    "function-paren-newline": ["error", "consistent"],
+    "function-paren-newline": "off",
     /**
      * Blacklist certain identifiers to prevent them being used
      * https://eslint.org/docs/rules/id-blacklist
@@ -132,8 +133,9 @@ exports.stylisticIssues = {
     /**
      * Enforce the location of arrow function bodies with implicit returns 🔧
      * https://eslint.org/docs/rules/implicit-arrow-linebreak
+     * Disabled because it results in conflicts with Prettier
      */
-    "implicit-arrow-linebreak": "error",
+    "implicit-arrow-linebreak": "off",
     /**
      * this option sets a specific tab width for your code 🔧
      * https://eslint.org/docs/rules/indent
@@ -417,10 +419,9 @@ exports.stylisticIssues = {
     /**
      * Requires operator at the beginning of the line in multiline statements 🔧
      * https://eslint.org/docs/rules/operator-linebreak
+     * Disabled because it results in conflicts with Prettier
      */
-    "operator-linebreak": ["error",
-        "before",
-        { overrides: { "=": "none" } }],
+    "operator-linebreak": "off",
     /**
      * disallow padding within blocks 🔧
      * https://eslint.org/docs/rules/padded-blocks

package/lib/rules/typescript.js

@@ -111,10 +111,7 @@ exports.typescript = {
      * Requires expressions of type void to appear in statement position 🔧 💭
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-confusing-void-expression.md
      */
-    "@typescript-eslint/no-confusing-void-expression": [
-        "error",
-        { "ignoreArrowShorthand": true }
-    ],
+    "@typescript-eslint/no-confusing-void-expression": ["error", { ignoreArrowShorthand: true }],
     /**
      * Disallow the delete operator with computed key expressions 🔧
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-dynamic-delete.md
@@ -284,8 +281,10 @@ exports.typescript = {
     /**
      * Prefers a non-null assertion over explicit type cast when possible 🔧 💭
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/non-nullable-type-assertion-style.md
+     * Disabled because it enforces use of postfix ! operator, which is banned by
+     * @typescript-eslint/no-non-null-assertion (a recommended rule)
      */
-    "@typescript-eslint/non-nullable-type-assertion-style": "error",
+    "@typescript-eslint/non-nullable-type-assertion-style": "off",
     /**
      * Prefer usage of as const over literal type ✅ 🔧
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/prefer-as-const.md
@@ -328,18 +327,18 @@ exports.typescript = {
      * Enforce the usage of the nullish coalescing operator instead of logical chaining 💭
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/prefer-nullish-coalescing.md
      */
-    "@typescript-eslint/prefer-nullish-coalescing": "off",
+    "@typescript-eslint/prefer-nullish-coalescing": "error",
     /**
      * Prefer using concise optional chain expressions instead of chained logical ands
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/prefer-optional-chain.md
      */
-    "@typescript-eslint/prefer-optional-chain": "off",
+    "@typescript-eslint/prefer-optional-chain": "error",
     /**
      * Requires that private members are marked as `readonly` if
      * they're never modified outside of the constructor 🔧 💭
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/prefer-readonly.md
      */
-    "@typescript-eslint/prefer-readonly": "off",
+    "@typescript-eslint/prefer-readonly": "error",
     /**
      * Requires that function parameters are typed as `readonly`
      * to prevent accidental mutation of inputs 💭
@@ -350,7 +349,7 @@ exports.typescript = {
      * Prefer using type parameter when calling `Array#reduce` instead of casting 🔧 💭
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/prefer-reduce-type-parameter.md
      */
-    "@typescript-eslint/prefer-reduce-type-parameter": "off",
+    "@typescript-eslint/prefer-reduce-type-parameter": "error",
     /**
      * Enforce that `RegExp#exec` is used instead of `String#match`
      * if no global flag is provided ✅ 🔧 💭
@@ -361,18 +360,18 @@ exports.typescript = {
      * Enforce that `this` is used when only `this` type is returned 🔧 💭
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/prefer-return-this-type.md
      */
-    "@typescript-eslint/prefer-return-this-type": "off",
+    "@typescript-eslint/prefer-return-this-type": "error",
     /**
      * Enforce the use of `String#startsWith` and `String#endsWith` instead
      * of other equivalent methods of checking substrings 🔧 💭
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/prefer-string-starts-ends-with.md
      */
-    "@typescript-eslint/prefer-string-starts-ends-with": "off",
+    "@typescript-eslint/prefer-string-starts-ends-with": "error",
     /**
      * Recommends using `@ts-expect-error` over `@ts-ignore` 🔧
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/prefer-ts-expect-error.md
      */
-    "@typescript-eslint/prefer-ts-expect-error": "off",
+    "@typescript-eslint/prefer-ts-expect-error": "error",
     /**
      * Requires any function or method that returns a Promise to be marked async 🔧 💭
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/promise-function-async.md
@@ -382,7 +381,7 @@ exports.typescript = {
      * Requires `Array#sort` calls to always provide a `compareFunction` 💭
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/require-array-sort-compare.md
      */
-    "@typescript-eslint/require-array-sort-compare": "off",
+    "@typescript-eslint/require-array-sort-compare": "error",
     /**
      * When adding two variables, operands must both be of type number or of type string ✅ 💭
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/restrict-plus-operands.md
@@ -397,17 +396,17 @@ exports.typescript = {
      * Enforces that members of a type union/intersection are sorted alphabetically 🔧
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/sort-type-union-intersection-members.md
      */
-    "@typescript-eslint/sort-type-union-intersection-members": "off",
+    "@typescript-eslint/sort-type-union-intersection-members": "error",
     /**
      * Restricts the types allowed in boolean expressions 🔧 💭
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/strict-boolean-expressions.md
      */
-    "@typescript-eslint/strict-boolean-expressions": "off",
+    "@typescript-eslint/strict-boolean-expressions": "error",
     /**
      * Exhaustiveness checking in switch with union type 💭
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/switch-exhaustiveness-check.md
      */
-    "@typescript-eslint/switch-exhaustiveness-check": "off",
+    "@typescript-eslint/switch-exhaustiveness-check": "error",
     /**
      * Sets preference level for triple slash directives versus ES6-style import declarations ✅
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/triple-slash-reference.md
@@ -417,7 +416,7 @@ exports.typescript = {
      * Require consistent spacing around type annotations 🔧
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/type-annotation-spacing.md
      */
-    "@typescript-eslint/type-annotation-spacing": "off",
+    "@typescript-eslint/type-annotation-spacing": "error",
     /**
      * Requires type annotations to exist
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/typedef.md
@@ -427,11 +426,11 @@ exports.typescript = {
      * Enforces unbound methods are called with their expected scope ✅ 💭
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/unbound-method.md
      */
-    "@typescript-eslint/unbound-method": "off",
+    "@typescript-eslint/unbound-method": ["error", { ignoreStatic: true }],
     /**
      * Warns for any two overloads that could be unified into
      * one by using a union or an optional/rest parameter
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/unified-signatures.md
      */
-    "@typescript-eslint/unified-signatures": "off",
+    "@typescript-eslint/unified-signatures": "warn",
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@spscommerce/eslint-config-typescript",
-  "version": "0.0.4",
+  "version": "0.0.8",
   "description": "SPS official linter configuration for TypeScript.",
   "main": "lib/index.js",
   "scripts": {