@spscommerce/eslint-config-typescript 0.0.12-rc.2 → 0.0.12-rc.3

package/lib/index.js

@@ -13,7 +13,7 @@ const config = {
         project: "./tsconfig.json",
     },
     plugins: [
-        "@typescript-eslint", "import",
+        "@typescript-eslint", "import", "@stylistic"
     ],
     settings: {
         "import/extensions": [".ts", ".tsx"],
@@ -42,4 +42,5 @@ const config = {
         ...typescript_1.typescript,
     },
 };
+typescript_1.typescript.rules;
 module.exports = config;

package/lib/rules/bestPractices.js

@@ -199,6 +199,11 @@ exports.bestPractices = {
      */
     "no-implied-eval": "off",
     "@typescript-eslint/no-implied-eval": "error",
+    /**
+     * disallow assignment to imported bindings
+     * https://eslint.org/docs/rules/no-import-assign
+     */
+    "no-import-assign": "error",
     /**
      * disallow this keywords outside of classes or class-like objects
      * https://eslint.org/docs/rules/no-invalid-this
@@ -400,7 +405,7 @@ exports.bestPractices = {
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-throw-literal.md
      */
     "no-throw-literal": "off",
-    "@typescript-eslint/no-throw-literal": "error",
+    "@typescript-eslint/only-throw-error": "error",
     /**
      * disallow unmodified conditions of loops
      * https://eslint.org/docs/rules/no-unmodified-loop-condition
@@ -418,6 +423,11 @@ exports.bestPractices = {
      * https://eslint.org/docs/rules/no-unused-labels
      */
     "no-unused-labels": "error",
+    /**
+     * disallow useless backreferences in regular expressions
+     * https://eslint.org/docs/rules/no-useless-backreference
+     */
+    "no-useless-backreference": "error",
     /**
      * disallow unnecessary .call() and .apply()
      * https://eslint.org/docs/rules/no-useless-call
@@ -459,6 +469,11 @@ exports.bestPractices = {
      * https://eslint.org/docs/rules/no-with
      */
     "no-with": "error",
+    /**
+     * require `Object.hasOwn` instead of `Object.prototype.hasOwnProperty.call`
+     * https://eslint.org/docs/rules/prefer-object-has-own
+     */
+    "prefer-object-has-own": "error",
     /**
      * require using Error objects as Promise rejection reasons
      * https://eslint.org/docs/rules/prefer-promise-reject-errors

package/lib/rules/es6.js

@@ -28,6 +28,11 @@ exports.es6 = {
      * https://eslint.org/docs/rules/generator-star-spacing
      */
     "generator-star-spacing": ["error", { before: false, after: true }],
+    /**
+     * enforce logical assignment operators
+     * https://eslint.org/docs/rules/logical-assignment-operators
+     */
+    "logical-assignment-operators": "error",
     /**
      * disallow modifying variables of class declarations ✅
      * https://eslint.org/docs/rules/no-class-assign
@@ -137,6 +142,11 @@ exports.es6 = {
         {
             enforceForRenamedProperties: false,
         }],
+    /**
+     * prefer exponentiation operator
+     * https://eslint.org/docs/rules/prefer-exponentiation-operator
+     */
+    "prefer-exponentiation-operator": "error",
     /**
      * disallow parseInt() in favor of binary, octal, and hexadecimal literals 🔧
      * https://eslint.org/docs/rules/prefer-numeric-literals

package/lib/rules/possibleErrors.js

@@ -106,10 +106,8 @@ exports.possibleErrors = {
     /**
      * disallow unnecessary semicolons ✅ 🔧
      * https://eslint.org/docs/rules/no-extra-semi
-     * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-extra-semi.md
      */
-    "no-extra-semi": "off",
-    "@typescript-eslint/no-extra-semi": "error",
+    "no-extra-semi": "error",
     /**
      * disallow overwriting functions written as function declarations ✅
      * https://eslint.org/docs/rules/no-func-assign

package/lib/rules/stylisticIssues.js

@@ -28,8 +28,7 @@ exports.stylisticIssues = {
      * https://eslint.org/docs/rules/brace-style
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/brace-style.md
      */
-    "brace-style": "off",
-    "@typescript-eslint/brace-style": "error",
+    "@stylistic/brace-style": "error",
     /**
      * require camel case names
      * https://eslint.org/docs/rules/camelcase
@@ -45,15 +44,13 @@ exports.stylisticIssues = {
      * https://eslint.org/docs/rules/comma-dangle
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/comma-dangle.md
      */
-    "comma-dangle": "off",
-    "@typescript-eslint/comma-dangle": ["error", "always-multiline"],
+    "@stylistic/comma-dangle": ["error", "always-multiline"],
     /**
      * enforce spacing before/after comma 🔧
      * https://eslint.org/docs/rules/comma-spacing
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/comma-spacing.md
      */
-    "comma-spacing": "off",
-    "@typescript-eslint/comma-spacing": "error",
+    "@stylistic/comma-spacing": "error",
     /**
      * enforce one true comma style 🔧
      * https://eslint.org/docs/rules/comma-style
@@ -80,8 +77,7 @@ exports.stylisticIssues = {
      * https://eslint.org/docs/rules/func-call-spacing
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/func-call-spacing.md
      */
-    "func-call-spacing": "off",
-    "@typescript-eslint/func-call-spacing": "error",
+    "@stylistic/func-call-spacing": "error",
     /**
      * requires function names to match the name of the
      * variable or property to which they are assigned
@@ -136,13 +132,6 @@ exports.stylisticIssues = {
      * Disabled because it results in conflicts with Prettier
      */
     "implicit-arrow-linebreak": "off",
-    /**
-     * this option sets a specific tab width for your code 🔧
-     * https://eslint.org/docs/rules/indent
-     * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/indent.md
-     */
-    indent: "off",
-    "@typescript-eslint/indent": ["error", 2],
     /**
      * specify whether double or single quotes should be used in JSX attributes 🔧
      * https://eslint.org/docs/rules/jsx-quotes
@@ -158,8 +147,7 @@ exports.stylisticIssues = {
      * https://eslint.org/docs/rules/keyword-spacing
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/keyword-spacing.md
      */
-    "keyword-spacing": "off",
-    "@typescript-eslint/keyword-spacing": "error",
+    "@stylistic/keyword-spacing": "error",
     /**
      * enforce position of line comments
      * https://eslint.org/docs/rules/line-comment-position
@@ -180,8 +168,7 @@ exports.stylisticIssues = {
      * https://eslint.org/docs/rules/lines-between-class-members
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/lines-between-class-members.md
      */
-    "lines-between-class-members": "off",
-    "@typescript-eslint/lines-between-class-members": "error",
+    "@stylistic/lines-between-class-members": "error",
     /**
      * specify the maximum depth that blocks can be nested
      * https://eslint.org/docs/rules/max-depth
@@ -393,8 +380,7 @@ exports.stylisticIssues = {
      * https://eslint.org/docs/rules/object-curly-spacing
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/object-curly-spacing.md
      */
-    "object-curly-spacing": "off",
-    "@typescript-eslint/object-curly-spacing": ["error", "always"],
+    "@stylistic/object-curly-spacing": ["error", "always"],
     /**
      * enforce "same line" or "multiple line" on object properties. 🔧
      * https://eslint.org/docs/rules/object-property-newline
@@ -466,8 +452,7 @@ exports.stylisticIssues = {
      * https://eslint.org/docs/rules/quotes
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/quotes.md
      */
-    quotes: "off",
-    "@typescript-eslint/quotes": ["error",
+    "@stylistic/quotes": ["error",
         "double",
         { avoidEscape: true }],
     /**
@@ -475,8 +460,7 @@ exports.stylisticIssues = {
      * https://eslint.org/docs/rules/
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/semi.md
      */
-    semi: "off",
-    "@typescript-eslint/semi": "error",
+    "@stylistic/semi": "error",
     /**
      * enforce spacing before and after semicolons 🔧
      * https://eslint.org/docs/rules/semi-spacing
@@ -507,8 +491,7 @@ exports.stylisticIssues = {
      * https://eslint.org/docs/rules/space-before-function-paren
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/space-before-function-paren.md
      */
-    "space-before-function-paren": "off",
-    "@typescript-eslint/space-before-function-paren": [
+    "@stylistic/space-before-function-paren": [
         "error",
         {
             anonymous: "always",
@@ -526,8 +509,7 @@ exports.stylisticIssues = {
      * https://eslint.org/docs/rules/space-infix-ops
      * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/space-infix-ops.md
      */
-    "space-infix-ops": "off",
-    "@typescript-eslint/space-infix-ops": "error",
+    "@stylistic/space-infix-ops": "error",
     /**
      * Require or disallow spaces before/after unary operators 🔧
      * https://eslint.org/docs/rules/space-unary-ops

package/lib/rules/typescript.js

@@ -28,13 +28,6 @@ exports.typescript = {
      * https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/ban-tslint-comment.md
      */
     "@typescript-eslint/ban-tslint-comment": "off",
-    /**
-     * Bans specific types from being used ✅ 🔧
-     * https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/ban-types.md
-     * The default config you get if you enable this recommended rule without specifying your own
-     * should be reviewed.
-     */
-    "@typescript-eslint/ban-types": "error",
     /**
      * Ensures that literals on classes are exposed in a consistent style 🔧
      * https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/class-literal-property-style.md
@@ -80,7 +73,7 @@ exports.typescript = {
      * Require a specific member delimiter style for interfaces and type literals 🔧
      * https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/member-delimiter-style.md
      */
-    "@typescript-eslint/member-delimiter-style": "error",
+    "@stylistic/member-delimiter-style": "error",
     /**
      * Require a consistent member declaration order
      * https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/member-ordering.md
@@ -122,6 +115,11 @@ exports.typescript = {
      * https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/no-empty-interface.md
      */
     "@typescript-eslint/no-empty-interface": "error",
+    /**
+     * Disallow usage of the `object` type with an object literal
+     * as a type annotation ✅
+     */
+    "@typescript-eslint/no-empty-object-type": "error",
     /**
      * Disallow usage of the `any` type ✅ 🔧
      * https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/no-explicit-any.md
@@ -253,6 +251,10 @@ exports.typescript = {
      * https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/no-unsafe-call.md
      */
     "@typescript-eslint/no-unsafe-call": "error",
+    /**
+     * Disallows member access on `any` typed variables ✅ 💭
+     */
+    "@typescript-eslint/no-unsafe-function-type": "error",
     /**
      * Disallows member access on `any` typed variables ✅ 💭
      * https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/no-unsafe-member-access.md
@@ -268,6 +270,10 @@ exports.typescript = {
      * https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/no-var-requires.md
      */
     "@typescript-eslint/no-var-requires": "error",
+    /**
+     * Disallow using confusing built-in primitive class wrappers.
+     */
+    "@typescript-eslint/no-wrapper-object-types": "error",
     /**
      * Prefers a non-null assertion over explicit type cast when possible 🔧 💭
      * https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/non-nullable-type-assertion-style.md
@@ -401,7 +407,7 @@ exports.typescript = {
      * Require consistent spacing around type annotations 🔧
      * https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/type-annotation-spacing.md
      */
-    "@typescript-eslint/type-annotation-spacing": "error",
+    "@stylistic/type-annotation-spacing": "error",
     /**
      * Requires type annotations to exist
      * https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/typedef.md

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@spscommerce/eslint-config-typescript",
-  "version": "0.0.12-rc.2",
+  "version": "0.0.12-rc.3",
   "description": "SPS official linter configuration for TypeScript.",
   "main": "lib/index.js",
   "scripts": {
@@ -38,6 +38,8 @@
     "eslint-plugin-import": "^2.31.0"
   },
   "devDependencies": {
+    "@stylistic/eslint-plugin": "^3.1.0",
+    "@types/eslint": "^8.56.10",
     "@typescript-eslint/eslint-plugin": "^8.24.0",
     "@typescript-eslint/parser": "^8.24.0",
     "eslint-import-resolver-typescript": "^3.7.0",