@sprucelabs/spruce-cli 14.30.11 → 14.30.15

package/src/__tests__/behavioral/DeployingToSandbox.test.ts

@@ -21,7 +21,7 @@ export default class DeployingToSandboxTest extends AbstractCliTest {
 	protected static async beforeEach() {
 		await super.beforeEach()
 
-		const personFixture = this.getPersonFixture()
+		const personFixture = this.people
 		await personFixture.loginAsDemoPerson(this.sandboxDemoNumber)
 	}
 

package/src/__tests__/behavioral/InstallingASkillAtAnOrg.test.ts

@@ -28,7 +28,7 @@ export default class InstallingASkillAtAnOrgTest extends AbstractCliTest {
 			name: 'my amazing skill',
 		})
 
-		await this.getPersonFixture().logout()
+		await this.people.logout()
 
 		await this.Cli()
 
@@ -145,8 +145,6 @@ export default class InstallingASkillAtAnOrgTest extends AbstractCliTest {
 	}
 
 	private static async login() {
-		await this.getPersonFixture().loginAsDemoPerson(
-			process.env.DEMO_NUMBER_INSTALL_SKILL
-		)
+		await this.people.loginAsDemoPerson(process.env.DEMO_NUMBER_INSTALL_SKILL)
 	}
 }

package/src/__tests__/behavioral/LoggingInAsASkill.test.ts

@@ -12,14 +12,12 @@ export default class LoggingInAsASkillTest extends AbstractSkillTest {
 	protected static async beforeAll() {
 		await super.beforeAll()
 
-		await this.getPersonFixture().loginAsDemoPerson(
-			process.env.DEMO_NUMBER_LOGIN_AS_SKILL
-		)
+		await this.people.loginAsDemoPerson(process.env.DEMO_NUMBER_LOGIN_AS_SKILL)
 
 		const skillFixture = this.getSkillFixture()
 		await skillFixture.clearAllSkills()
 
-		await this.getPersonFixture().logout()
+		await this.people.logout()
 	}
 
 	@test()
@@ -50,7 +48,7 @@ export default class LoggingInAsASkillTest extends AbstractSkillTest {
 	}
 
 	private static async login() {
-		const person = await this.getPersonFixture().loginAsDemoPerson(
+		const person = await this.people.loginAsDemoPerson(
 			process.env.DEMO_NUMBER_LOGIN_AS_SKILL
 		)
 

package/src/__tests__/behavioral/RegisteringEventsOnBoot.test.ts

@@ -14,9 +14,7 @@ export default class RegisteringEventsOnBootTest extends AbstractEventTest {
 	protected static async beforeEach() {
 		await super.beforeEach()
 
-		await this.getPersonFixture().loginAsDemoPerson(
-			process.env.DEMO_NUMBER_EVENTS_ON_BOOT
-		)
+		await this.people.loginAsDemoPerson(process.env.DEMO_NUMBER_EVENTS_ON_BOOT)
 	}
 
 	@test()

package/src/__tests__/behavioral/RegisteringGlobalEvents.test.ts

@@ -18,9 +18,7 @@ export default class RegisteringGlobalEventsTest extends AbstractSkillTest {
 	protected static async beforeAll() {
 		await super.beforeAll()
 
-		await this.getPersonFixture().loginAsDemoPerson(
-			process.env.DEMO_NUMBER_GLOBAL_EVENTS
-		)
+		await this.people.loginAsDemoPerson(process.env.DEMO_NUMBER_GLOBAL_EVENTS)
 
 		await this.resetAccount()
 

package/src/__tests__/behavioral/RegisteringSkillViewOnBoot.test.ts

@@ -50,9 +50,7 @@ export default class RegisteringSkillViewOnBootTest extends AbstractSkillTest {
 	}
 
 	protected static async registerCurrentSkillAndInstallToOrg() {
-		await this.getPersonFixture().loginAsDemoPerson(
-			process.env.DEMO_NUMBER_VIEWS_ON_BOOT
-		)
+		await this.people.loginAsDemoPerson(process.env.DEMO_NUMBER_VIEWS_ON_BOOT)
 		const skillFixture = this.getSkillFixture()
 		const orgFixture = this.getOrganizationFixture()
 

package/src/__tests__/behavioral/organization/CreatingAnOrg.test.ts

@@ -15,7 +15,7 @@ export default class CreatingAnOrgTest extends AbstractCliTest {
 
 		await this.FeatureFixture().installCachedFeatures('organizations')
 
-		await this.getPersonFixture().loginAsDemoPerson()
+		await this.people.loginAsDemoPerson()
 
 		const results = await this.Action('organization', 'create').execute({
 			nameReadable: 'My new org',

package/src/__tests__/behavioral/person/SeeWhoIsLoggedIn.test.ts

@@ -21,7 +21,7 @@ export default class SeeWhoIsLoggedInTest extends AbstractCliTest {
 	@test()
 	protected static async canSeeWhoIsLoggedIn() {
 		await this.FeatureFixture().installCachedFeatures('skills')
-		await this.getPersonFixture().loginAsDemoPerson()
+		await this.people.loginAsDemoPerson()
 
 		const results = await this.Action('person', 'whoami').execute({})
 

package/src/__tests__/behavioral/skill/RegisteringASkill.test.ts

@@ -1,3 +1,4 @@
+import { MercuryClientFactory } from '@sprucelabs/mercury-client'
 import { eventResponseUtil } from '@sprucelabs/spruce-event-utils'
 import { test, assert } from '@sprucelabs/test'
 import { errorAssertUtil } from '@sprucelabs/test-utils'
@@ -26,10 +27,32 @@ export default class RegisteringASkillTest extends AbstractCliTest {
 		)
 	}
 
+	@test()
+	protected static async returnsErrorWhenRegistrationFails() {
+		MercuryClientFactory.setIsTestMode(true)
+
+		await this.people.loginAsDemoPerson()
+		await this.FeatureFixture().installCachedFeatures('skills')
+		const slug = `my-new-skill-${new Date().getTime()}`
+
+		const client = await this.connectToApi()
+		await client.on('register-skill::v2020_12_25', (() => {
+			assert.fail('what the!!??')
+		}) as any)
+
+		const results = await this.Action('skill', 'register').execute({
+			nameReadable: 'My great skill',
+			nameKebab: slug,
+		})
+
+		assert.isTruthy(results.errors)
+		assert.doesInclude(results.errors[0].message, 'what the!!??')
+	}
+
 	@test()
 	protected static async canRegisterSkill() {
 		await this.FeatureFixture().installCachedFeatures('skills')
-		await this.getPersonFixture().loginAsDemoPerson()
+		await this.people.loginAsDemoPerson()
 
 		const slug = `my-new-skill-${new Date().getTime()}`
 		const results = await this.Action('skill', 'register').execute({

package/src/__tests__/behavioral/views/SettingUpViews.test.ts

@@ -24,7 +24,7 @@ export default class SettingUpViewsTest extends AbstractCliTest {
 			},
 		])
 
-		await this.getPersonFixture().loginAsDemoPerson()
+		await this.people.loginAsDemoPerson()
 
 		const dependencies = this.Service('dependency').get()
 		assert.isLength(dependencies, 1)

package/src/__tests__/implementation/SkillStore.test.ts

@@ -66,7 +66,7 @@ export default class SkillStoreTest extends AbstractCliTest {
 		await this.FeatureFixture().installCachedFeatures('skills')
 
 		const slug = `awesome-skill-${new Date().getTime()}`
-		await this.getPersonFixture().loginAsDemoPerson()
+		await this.people.loginAsDemoPerson()
 
 		const skillStore = this.Store('skill')
 

package/src/tests/AbstractCliTest.ts

@@ -1,4 +1,5 @@
 import pathUtil from 'path'
+import { MercuryClientFactory } from '@sprucelabs/mercury-client'
 import { SchemaRegistry } from '@sprucelabs/schema'
 import { diskUtil } from '@sprucelabs/spruce-skill-utils'
 import { templates } from '@sprucelabs/spruce-templates'
@@ -104,6 +105,7 @@ export default abstract class AbstractCliTest extends AbstractSpruceTest {
 		SkillStore.clearCurrentSkill()
 		EventStore.clearCache()
 		CommandService.clearMockResponses()
+		MercuryClientFactory.reset()
 	}
 
 	protected static async afterEach() {
@@ -231,7 +233,7 @@ export default abstract class AbstractCliTest extends AbstractSpruceTest {
 		return this.mercuryFixture
 	}
 
-	protected static getPersonFixture() {
+	protected static get people() {
 		if (!this.personFixture) {
 			this.personFixture = new PersonFixture(
 				this.getMercuryFixture().getApiClientFactory()
@@ -285,7 +287,7 @@ export default abstract class AbstractCliTest extends AbstractSpruceTest {
 	protected static getOrganizationFixture() {
 		if (!this.organizationFixture) {
 			this.organizationFixture = new OrganizationFixture(
-				this.getPersonFixture(),
+				this.people,
 				this.StoreFactory()
 			)
 		}
@@ -296,7 +298,7 @@ export default abstract class AbstractCliTest extends AbstractSpruceTest {
 	protected static getSkillFixture() {
 		if (!this.skillFixture) {
 			this.skillFixture = new SkillFixture(
-				this.getPersonFixture(),
+				this.people,
 				this.StoreFactory(),
 				this.getMercuryFixture().getApiClientFactory()
 			)