@sprucelabs/spruce-cli 14.28.8 → 14.29.3

package/src/__tests__/behavioral/stores/KeepingDataStoresInSync.test.ts

@@ -1,6 +1,7 @@
 import { diskUtil } from '@sprucelabs/spruce-skill-utils'
 import { test, assert } from '@sprucelabs/test'
 import { errorAssertUtil } from '@sprucelabs/test-utils'
+import { FeatureActionResponse } from '../../../features/features.types'
 import AbstractSkillTest from '../../../tests/AbstractSkillTest'
 import testUtil from '../../../tests/utilities/test.utility'
 
@@ -44,20 +45,48 @@ export default class KeepingDataStoresInSyncTest extends AbstractSkillTest {
 
 	@test()
 	protected static async generatesValidTypeFile() {
-		await this.Action('store', 'create').execute({
+		const results = await this.Action('store', 'create').execute({
 			nameReadable: 'Bid',
 			nameReadablePlural: 'Bids',
 			namePascal: 'Bid',
 		})
 
+		await this.validateFiles(results)
+	}
+
+	@test()
+	protected static async fileIsValidAfterSync() {
 		const results = await this.syncStores()
 
+		await this.validateFiles(results)
+	}
+
+	@test()
+	protected static async canAddSecondStore() {
+		const results = await this.Action('store', 'create').execute({
+			nameReadable: 'Person',
+			nameReadablePlural: 'People',
+			namePascal: 'Person',
+		})
+
+		await this.validateFiles(results)
+	}
+
+	private static async validateFiles(results: FeatureActionResponse) {
 		const typesFile = testUtil.assertFileByNameInGeneratedFiles(
 			'stores.types.ts',
 			results.files
 		)
 
-		await this.Service('typeChecker').check(typesFile)
+		const mapFile = testUtil.assertFileByNameInGeneratedFiles(
+			'stores.ts',
+			results.files
+		)
+
+		await Promise.all([
+			this.Service('typeChecker').check(typesFile),
+			this.Service('typeChecker').check(mapFile),
+		])
 	}
 
 	private static async syncStores() {

package/src/__tests__/behavioral/tests/CreatingATest.test.ts

@@ -1,4 +1,5 @@
 import { test, assert } from '@sprucelabs/test'
+import LintService from '../../../services/LintService'
 import AbstractTestTest from '../../../tests/AbstractTestTest'
 import testUtil from '../../../tests/utilities/test.utility'
 
@@ -30,6 +31,7 @@ export default class CreatingBehavioralTestsTest extends AbstractTestTest {
 		'AbstractStoreTest (requires install)'
 	)
 	protected static async canCreateBehavioralTest(testName: string) {
+		LintService.enableLinting()
 		await this.installTests()
 		const promise = this.Action('test', 'create').execute({
 			type: 'behavioral',

package/src/__tests__/behavioral/views/TestingViewControllers.test.ts

@@ -1,11 +1,17 @@
 import { diskUtil } from '@sprucelabs/spruce-skill-utils'
 import { test, assert } from '@sprucelabs/test'
+import LintService from '../../../services/LintService'
 import AbstractSkillTest from '../../../tests/AbstractSkillTest'
 import testUtil from '../../../tests/utilities/test.utility'
 
 export default class TestingViewControllersTest extends AbstractSkillTest {
 	protected static skillCacheKey = 'viewsWithTests'
 
+	protected static async beforeEach() {
+		await super.beforeEach()
+		LintService.enableLinting()
+	}
+
 	@test()
 	protected static async showsNotInstalled() {
 		const viewFeature = this.cli.getFeature('view')

package/src/__tests__/implementation/AuthService.test.ts

@@ -70,11 +70,13 @@ export default class AuthServiceTest extends AbstractCliTest {
 
 	@test()
 	protected static getCurrentSkillReturnsNull() {
+		this.writePackageJson()
 		assert.isNull(this.auth.getCurrentSkill())
 	}
 
 	@test()
 	protected static canSetCurrentSkill() {
+		this.writePackageJson()
 		const skill = {
 			id: '123467aaoeuaoeu',
 			apiKey: 'taco',
@@ -86,4 +88,8 @@ export default class AuthServiceTest extends AbstractCliTest {
 
 		assert.isEqualDeep(this.auth.getCurrentSkill(), skill)
 	}
+
+	private static writePackageJson() {
+		diskUtil.writeFile(this.resolvePath('package.json'), '{}')
+	}
 }

package/src/__tests__/implementation/EventStore.test.ts

@@ -29,6 +29,7 @@ export default class EventStoreTest extends AbstractEventTest {
 	public static async beforeEach() {
 		await super.beforeEach()
 		this.createAction = this.Action<CreateAction>('event', 'create')
+		diskUtil.writeFile(this.resolvePath('package.json'), '{}')
 	}
 
 	@test()

package/src/__tests__/implementation/LintService.test.ts

@@ -0,0 +1,34 @@
+import { test, assert } from '@sprucelabs/test'
+import CommandService from '../../services/CommandService'
+import LintService from '../../services/LintService'
+import AbstractCliTest from '../../tests/AbstractCliTest'
+
+export default class LintServiceTest extends AbstractCliTest {
+	@test()
+	protected static async throwsWhenLintReturnsMessage() {
+		LintService.enableLinting()
+
+		await this.FeatureFixture().installCachedFeatures('skills')
+
+		CommandService.setMockResponse(/node/, {
+			code: 0,
+			stdout: `[{"filePath":"/Users/taylorromero/Development/SpruceLabs/spruce-appointments-skill/src/.spruce/stores/stores.types.ts","messages":[{"fatal":false,"severity":1,"message":"File ignored by default.  Use a negated ignore pattern (like \\"--ignore-pattern '!<relative/path/to/filename>'\\") to override."}],"errorCount":1,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":[]}]\n`,
+		})
+
+		await assert.doesThrowAsync(() => this.Service('lint').fix('./go'))
+	}
+
+	@test()
+	protected static async worksWhenNoMessagesReturned() {
+		LintService.enableLinting()
+
+		await this.FeatureFixture().installCachedFeatures('skills')
+
+		CommandService.setMockResponse(/node/, {
+			code: 0,
+			stdout: `[{"filePath":"/Users/taylorromero/Development/SpruceLabs/spruce-appointments-skill/src/.spruce/stores/stores.types.ts","messages":[{"fatal":false,"severity":1,"message":"File ignored by default.  Use a negated ignore pattern (like \\"--ignore-pattern '!<relative/path/to/filename>'\\") to override."}],"errorCount":0,"warningCount":1,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":[]}]\n`,
+		})
+
+		await this.Service('lint').fix('./go')
+	}
+}

package/src/__tests__/implementation/StoreFeature.test.ts

@@ -0,0 +1,40 @@
+import { test, assert } from '@sprucelabs/test'
+import CommandService from '../../services/CommandService'
+import AbstractCliTest from '../../tests/AbstractCliTest'
+
+export default class StoreFeatureTest extends AbstractCliTest {
+	@test()
+	protected static async syncsOnWillExecute() {
+		await this.FeatureFixture().installCachedFeatures('stores')
+
+		CommandService.setMockResponse(/yarn/, {
+			code: 0,
+		})
+
+		let hitCount = 0
+		const emitter = this.getEmitter()
+		await emitter.on(
+			'feature.will-execute',
+			async ({ featureCode, actionCode }) => {
+				if (featureCode === 'store' && actionCode === 'sync') {
+					hitCount++
+				}
+			}
+		)
+
+		await emitter.emit('feature.will-execute', {
+			featureCode: 'node',
+			actionCode: 'upgrade',
+		})
+
+		assert.isEqual(hitCount, 1)
+
+		await emitter.emit('feature.did-execute', {
+			featureCode: 'node',
+			actionCode: 'upgrade',
+			results: {},
+		})
+
+		assert.isEqual(hitCount, 1)
+	}
+}

package/src/errors/SpruceError.ts

@@ -68,12 +68,16 @@ export default class SpruceError extends AbstractSpruceError<ErrorOptions> {
 				break
 
 			case 'LINT_FAILED':
-				message = `Lint failed on pattern ${options.pattern}.`
+				message = options.friendlyMessage
 
-				if (options.originalError) {
-					message += `\n\nOriginal error:${
-						options.originalError.stack ?? options.originalError.message
-					}`
+				if (!message) {
+					message = `Lint failed on pattern ${options.pattern}.`
+
+					if (options.originalError) {
+						message += `\n\nOriginal error:${
+							options.originalError.stack ?? options.originalError.message
+						}`
+					}
 				}
 
 				break

package/src/features/event/EventFeature.ts

@@ -3,6 +3,7 @@ import { diskUtil } from '@sprucelabs/spruce-skill-utils'
 import syncEventActionSchema from '#spruce/schemas/spruceCli/v2020_07_22/syncEventOptions.schema'
 import TerminalInterface from '../../interfaces/TerminalInterface'
 import { FileDescription } from '../../types/cli.types'
+import actionUtil from '../../utilities/action.utility'
 import AbstractFeature, {
 	FeatureDependency,
 	FeatureOptions,
@@ -73,6 +74,11 @@ export default class EventFeature extends AbstractFeature {
 
 	public async afterPackageInstall() {
 		diskUtil.createDir(diskUtil.resolvePath(this.cwd, 'src', 'events'))
+		const isSkillInstalled = await this.featureInstaller.isInstalled('skill')
+		if (isSkillInstalled) {
+			return await this.Action('event', 'sync.listeners').execute({})
+		}
+
 		return {}
 	}
 
@@ -82,19 +88,21 @@ export default class EventFeature extends AbstractFeature {
 	}): Promise<FeatureActionResponse> {
 		const { featureCode, actionCode } = payload
 
+		let results: FeatureActionResponse = {}
+
 		if (!this.initiatingAction) {
 			EventStore.clearCache()
 			const combined = this.combineCodes(featureCode, actionCode)
 			this.initiatingAction = combined
 		}
 
-		const isInstalled = await this.featureInstaller.isInstalled('event')
-
 		if (featureCode === 'node' || featureCode === 'upgrade') {
 			const settings = this.Service('eventSettings')
 			settings.clearListenerCache()
 		}
 
+		const isInstalled = await this.featureInstaller.isInstalled('event')
+
 		if (
 			isInstalled &&
 			(featureCode === 'event' ||
@@ -102,10 +110,19 @@ export default class EventFeature extends AbstractFeature {
 				actionCode === 'login') &&
 			actionCode !== 'setRemote'
 		) {
-			return this.appendRemoteToResultsOrPrompt()
+			const remoteResults = await this.appendRemoteToResultsOrPrompt()
+
+			results = actionUtil.mergeActionResults(results, remoteResults)
 		}
 
-		return {}
+		if (featureCode === 'node' && actionCode === 'upgrade' && isInstalled) {
+			const syncResults = await this.Action('event', 'sync.listeners').execute(
+				{}
+			)
+			results = actionUtil.mergeActionResults(results, syncResults)
+		}
+
+		return results
 	}
 
 	private async handleDidExecute(payload: {

package/src/features/event/actions/ListenAction.ts

@@ -151,8 +151,8 @@ export default class ListenAction extends AbstractAction<OptionsSchema> {
 					templateItems.responsePayloadSchemaTemplateItem
 			}
 
-			const generator = this.Writer('event')
-			const results = await generator.writeListener(resolvedDestination, {
+			const writer = this.Writer('event')
+			response.files = await writer.writeListener(resolvedDestination, {
 				...normalizedOptions,
 				version: resolvedVersion,
 				eventName,
@@ -168,7 +168,9 @@ export default class ListenAction extends AbstractAction<OptionsSchema> {
 				schemaTypesLookupDir: resolvedSchemaTypesLookupDir,
 			})
 
-			response.files = results
+			const syncResults = await this.syncListeners()
+
+			response = actionUtil.mergeActionResults(syncResults, response)
 
 			if (isSkillEvent) {
 				const syncOptions = normalizeSchemaValues(
@@ -191,6 +193,10 @@ export default class ListenAction extends AbstractAction<OptionsSchema> {
 		}
 	}
 
+	private async syncListeners() {
+		return this.Action('event', 'sync.listeners').execute({})
+	}
+
 	private async collectEvent(
 		contracts: EventContract[],
 		namespace: string

package/src/features/event/actions/SyncListenersAction.ts

@@ -0,0 +1,38 @@
+import { buildSchema } from '@sprucelabs/schema'
+import { diskUtil } from '@sprucelabs/spruce-skill-utils'
+import AbstractAction from '../../AbstractAction'
+import ListenerTemplateItemBuilder from '../builders/ListenerTemplateItemBuilder'
+
+const syncListenersOptionScheam = buildSchema({
+	id: 'syncListenersOptions',
+	fields: {},
+})
+
+type OptionsSchema = typeof syncListenersOptionScheam
+
+export default class SyncListenerAction extends AbstractAction<OptionsSchema> {
+	public optionsSchema: OptionsSchema = syncListenersOptionScheam
+	public invocationMessage = 'Syncing listeners... 🎧'
+	public commandAliases = ['sync.listeners']
+
+	public async execute() {
+		const listeners = await this.Store('listener').loadListeners()
+		const builder = new ListenerTemplateItemBuilder()
+
+		const templateItems = builder.buildTemplateItems({
+			listeners,
+			cwd: this.cwd,
+		})
+
+		const files = await this.Writer('event').writeListenerMap(
+			diskUtil.resolveHashSprucePath(this.cwd, 'events'),
+			{
+				listeners: templateItems,
+			}
+		)
+
+		return {
+			files,
+		}
+	}
+}

package/src/features/event/builders/ListenerTemplateItemBuilder.ts

@@ -0,0 +1,27 @@
+import pathUtil from 'path'
+import { diskUtil } from '@sprucelabs/spruce-skill-utils'
+import { ListenerTemplateItem } from '@sprucelabs/spruce-templates'
+import { Listener } from '../stores/ListenerStore'
+
+export default class ListenerTemplateItemBuilder {
+	public buildTemplateItems(options: { listeners: Listener[]; cwd: string }) {
+		const destination = diskUtil.resolveHashSprucePath(
+			options.cwd,
+			'events',
+			'listeners.ts'
+		)
+
+		const listeners: ListenerTemplateItem[] = []
+
+		for (const match of options.listeners) {
+			listeners.push({
+				...match,
+				path: pathUtil
+					.relative(pathUtil.dirname(destination), match.path)
+					.replace('.ts', ''),
+			})
+		}
+
+		return listeners
+	}
+}

package/src/features/event/stores/EventStore.ts

@@ -76,7 +76,7 @@ export default class EventStore extends AbstractStore {
 		try {
 			contracts = await this.fetchRemoteContracts(namespaces)
 		} catch (err: any) {
-			const error = err.options.responseErrors[0]
+			const error = err.options.responseErrors?.[0] ?? err
 			throw error
 		}
 

package/src/features/event/stores/ListenerStore.ts

@@ -0,0 +1,32 @@
+import { eventDiskUtil } from '@sprucelabs/spruce-event-utils'
+import { diskUtil } from '@sprucelabs/spruce-skill-utils'
+import { ListenerTemplateItem } from '@sprucelabs/spruce-templates'
+import globby from 'globby'
+import AbstractStore from '../../../stores/AbstractStore'
+
+export type Listener = ListenerTemplateItem & {
+	path: string
+}
+
+export default class ListenerStore extends AbstractStore {
+	public name = 'listener'
+
+	public async loadListeners() {
+		const matches = await globby(
+			diskUtil.resolvePath(this.cwd, 'src', 'listeners', '**/*.listener.ts')
+		)
+
+		const listeners: Listener[] = []
+
+		for (const match of matches) {
+			const listener = eventDiskUtil.splitPathToListener(match)
+
+			listeners.push({
+				...listener,
+				path: match,
+			})
+		}
+
+		return listeners
+	}
+}

package/src/features/event/writers/EventWriter.ts

@@ -9,6 +9,7 @@ import {
 import {
 	EventContractTemplateItem,
 	EventListenerOptions,
+	ListenerTemplateItem,
 } from '@sprucelabs/spruce-templates'
 import { GeneratedFile } from '../../../types/cli.types'
 import AbstractWriter from '../../../writers/AbstractWriter'
@@ -182,6 +183,24 @@ export default class EventWriter extends AbstractWriter {
 		return results
 	}
 
+	public async writeListenerMap(
+		destinationDir: string,
+		options: {
+			listeners: ListenerTemplateItem[]
+		}
+	) {
+		const destination = diskUtil.resolvePath(destinationDir, 'listeners.ts')
+		const contents = this.templates.listeners({ listeners: options.listeners })
+
+		const results = await this.writeFileIfChangedMixinResults(
+			destination,
+			contents,
+			'An object holding all your data stores for easy import!'
+		)
+
+		return results
+	}
+
 	public async writeEvent(
 		destinationDir: string,
 		options: {

package/src/features/node/NodeFeature.ts

@@ -59,12 +59,13 @@ export default class NodeFeature<
 			return {}
 		})
 	}
+
 	private async handleUpgrade(): Promise<FeatureActionResponse> {
 		try {
 			this.ui.startLoading('Cleaning build...')
 			await this.Service('command').execute('yarn clean.build')
 
-			this.ui.startLoading('Rebuilding...')
+			this.ui.startLoading('Building for development...')
 			await this.Service('command').execute('yarn build.dev')
 
 			return {

package/src/features/skill/SkillFeature.ts

@@ -196,7 +196,7 @@ export default class SkillFeature<
 
 		if (isInstalled && featureCode === 'node' && actionCode === 'upgrade') {
 			const updater = new Updater(this, this.emitter)
-			const files = await updater.updateFiles(upgradeOptions as any)
+			const files = await updater.updateFiles(upgradeOptions ?? {})
 			return {
 				files,
 			}

package/src/features/skill/stores/SkillStore.ts

@@ -71,6 +71,7 @@ export default class SkillStore extends AbstractStore {
 
 		if (currentSkill) {
 			const client = await this.connectToApi({ shouldAuthAsCurrentSkill: true })
+
 			const response = await client.emit('get-skill::v2020_12_25', {
 				target: {
 					skillId: currentSkill.id,
@@ -85,6 +86,7 @@ export default class SkillStore extends AbstractStore {
 				isRegistered: true,
 				apiKey: currentSkill.apiKey,
 			}
+
 			return SkillStore.currentSkill as CurrentSkill
 		}
 
@@ -133,12 +135,11 @@ export default class SkillStore extends AbstractStore {
 		if (isRegistered) {
 			throw new SpruceError({
 				code: 'GENERIC',
-				friendlyMessage: `You can't change the namespace of a skill that is registered.`,
+				friendlyMessage: `You can't set the namespace of a skill that is registered.`,
 			})
 		}
 
-		const pkg = this.Service('pkg')
-		pkg.set({ path: 'skill.namespace', value: namesUtil.toKebab(namespace) })
+		this.Service('auth').updateCurrentSkillNamespace(namespace)
 	}
 
 	private getEventNamespaceForNotRegistered() {

package/src/features/store/StoreFeature.ts

@@ -37,8 +37,8 @@ export default class StoreFeature extends AbstractFeature {
 			this.registerAbstractTestClassHandler.bind(this)
 		)
 		void this.emitter.on(
-			'feature.did-execute',
-			this.didExecuterHandler.bind(this)
+			'feature.will-execute',
+			this.handleWillExecute.bind(this)
 		)
 	}
 
@@ -55,7 +55,7 @@ export default class StoreFeature extends AbstractFeature {
 		}
 	}
 
-	private async didExecuterHandler(payload: {
+	private async handleWillExecute(payload: {
 		featureCode: string
 		actionCode: string
 	}) {
@@ -70,7 +70,10 @@ export default class StoreFeature extends AbstractFeature {
 				ui: this.ui,
 				headline: 'Resyncing data stores...',
 			})
-			return this.Action('store', 'sync').execute({})
+
+			const results = await this.Action('store', 'sync').execute({})
+
+			return results
 		}
 
 		return {}

package/src/schemas/v2020_07_22/personWithToken.builder.ts

@@ -1,4 +1,5 @@
 import { buildSchema } from '@sprucelabs/schema'
+// eslint-disable-next-line spruce/prohibit-import-of-schema-in-builders
 import personSchema from '#spruce/schemas/spruce/v2020_07_22/person.schema'
 
 export default buildSchema({

package/src/services/AuthService.ts

@@ -1,7 +1,8 @@
 import { SpruceSchemas } from '@sprucelabs/mercury-types'
 import { normalizeSchemaValues, validateSchemaValues } from '@sprucelabs/schema'
-import { EnvService } from '@sprucelabs/spruce-skill-utils'
+import { EnvService, namesUtil } from '@sprucelabs/spruce-skill-utils'
 import personWithTokenSchema from '#spruce/schemas/spruceCli/v2020_07_22/personWithToken.schema'
+import PkgService from './PkgService'
 
 type PersonWithToken = SpruceSchemas.SpruceCli.v2020_07_22.PersonWithToken
 
@@ -16,9 +17,11 @@ const LOGGED_IN_PERSON_KEY = 'LOGGED_IN_PERSON'
 
 export default class AuthService {
 	private env: EnvService
+	private pkg: PkgService
 
-	public constructor(envService: EnvService) {
+	public constructor(envService: EnvService, pkgService: PkgService) {
 		this.env = envService
+		this.pkg = pkgService
 	}
 
 	public getLoggedInPerson(): PersonWithToken | null {
@@ -51,7 +54,7 @@ export default class AuthService {
 		const id = this.env.get('SKILL_ID') as string
 		const apiKey = this.env.get('SKILL_API_KEY') as string
 		const name = this.env.get('SKILL_NAME') as string
-		const slug = this.env.get('SKILL_SLUG') as string
+		const slug = this.pkg.get('skill.namespace') as string
 
 		if (id && apiKey) {
 			return {
@@ -69,13 +72,20 @@ export default class AuthService {
 		this.env.unset('SKILL_ID')
 		this.env.unset('SKILL_API_KEY')
 		this.env.unset('SKILL_NAME')
-		this.env.unset('SKILL_SLUG')
 	}
 
 	public updateCurrentSkill(skill: SkillAuth) {
 		this.env.set('SKILL_ID', skill.id)
 		this.env.set('SKILL_API_KEY', skill.apiKey)
 		this.env.set('SKILL_NAME', skill.name)
-		this.env.set('SKILL_SLUG', skill.slug)
+
+		this.updateCurrentSkillNamespace(skill.slug)
+	}
+
+	public updateCurrentSkillNamespace(namespace: string) {
+		this.pkg.set({
+			path: 'skill.namespace',
+			value: namesUtil.toKebab(namespace),
+		})
 	}
 }

package/src/services/GameService.ts

@@ -20,6 +20,7 @@ export default class GameService {
 
 	public async play(introductionSentences: string[] = []) {
 		const sentencesToPlay = [...introductionSentences]
+		await this.ui.stopLoading()
 		this.killed = false
 
 		while (sentencesToPlay.length > 0) {