@sprucelabs/spruce-cli 14.24.4 → 14.24.8

package/src/__tests__/behavioral/RegisteringEventsOnBoot.test.ts

@@ -4,7 +4,6 @@ import {
 } from '@sprucelabs/spruce-event-utils'
 import { namesUtil, versionUtil } from '@sprucelabs/spruce-skill-utils'
 import { test, assert } from '@sprucelabs/test'
-import EventStore from '../../features/event/stores/EventStore'
 import AbstractEventTest from '../../tests/AbstractEventTest'
 
 const EVENT_NAME_READABLE = 'did book appointment'
@@ -20,7 +19,7 @@ export default class RegisteringEventsOnBootTest extends AbstractEventTest {
 		)
 	}
 
-	@test.only()
+	@test()
 	protected static async registeringEventsOnBoot() {
 		const { skill2, currentSkill } =
 			await this.seedDummySkillRegisterCurrentSkillAndInstallToOrg()
@@ -42,8 +41,6 @@ export default class RegisteringEventsOnBootTest extends AbstractEventTest {
 			apiKey: skill2.apiKey,
 		})
 
-		EventStore.clearCache()
-
 		const contractResults = await this.Store('event', {
 			apiClientFactory: async () => client,
 		}).fetchEventContracts()
@@ -64,25 +61,25 @@ export default class RegisteringEventsOnBootTest extends AbstractEventTest {
 		const namespace = namesUtil.toPascal(currentSkill.slug)
 		const sig = eventContractUtil.getSignatureByName(contracts[1], name)
 
-		assert.doesInclude(sig, {
-			emitPayloadSchema: {
-				id: 'didBookAppointmentEmitTargetAndPayload',
-				version,
-				namespace,
-			},
-			responsePayloadSchema: {
-				id: 'myFantasticallyAmazingEventResponsePayload',
-				version,
-				namespace,
-			},
-			emitPermissionContract: {
-				id: 'myFantasticallyAmazingEventEmitPermissions',
-				name: 'my fantastically amazing event',
-			},
-			listenPermissionContract: {
-				id: 'myFantasticallyAmazingEventListenPermissions',
-				name: 'my fantastically amazing event',
-			},
+		assert.doesInclude(sig.emitPayloadSchema, {
+			id: 'didBookAppointmentEmitTargetAndPayload',
+			version,
+			namespace,
+		})
+
+		assert.doesInclude(sig.responsePayloadSchema, {
+			id: 'myFantasticallyAmazingEventResponsePayload',
+			version,
+			namespace,
+		})
+		assert.doesInclude(sig.emitPermissionContract, {
+			id: 'myFantasticallyAmazingEventEmitPermissions',
+			name: 'my fantastically amazing event',
+		})
+
+		assert.doesInclude(sig.listenPermissionContract, {
+			id: 'myFantasticallyAmazingEventListenPermissions',
+			name: 'my fantastically amazing event',
 		})
 	}
 }

package/src/__tests__/behavioral/events/KeepingEventsInSync2.test.ts

@@ -16,7 +16,6 @@ import {
 	versionUtil,
 } from '@sprucelabs/spruce-skill-utils'
 import { test, assert } from '@sprucelabs/test'
-import EventStore from '../../../features/event/stores/EventStore'
 import { generateEventContractFileName } from '../../../features/event/writers/EventWriter'
 import { FeatureActionResponse } from '../../../features/features.types'
 import AbstractEventTest from '../../../tests/AbstractEventTest'
@@ -34,8 +33,8 @@ export default class KeepingEventsInSyncTest extends AbstractEventTest {
 		return versionUtil.generateVersion()
 	}
 
-	@test()
-	protected static async syncingSchemasWithBrokenConnectionStopsWithError() {
+	@test.skip('find how to simulate connection errors')
+	protected static async syncingSchemasWithDisconnectedStopsWithError() {
 		await this.FeatureFixture().installCachedFeatures('events')
 
 		await this.syncCoreEventsPretendingToBeMercuryTypes()
@@ -55,8 +54,6 @@ export default class KeepingEventsInSyncTest extends AbstractEventTest {
 
 		await client.disconnect()
 
-		EventStore.clearCache()
-
 		const results2 = await this.Action('schema', 'sync').execute({})
 
 		assert.isTruthy(results2.errors)

package/src/__tests__/behavioral/skill/UpgradingASkill.test.ts

@@ -191,30 +191,53 @@ export default class UpgradingASkillTest extends AbstractCliTest {
 		assert.isEqual(passedHealth.skill.status, 'passed')
 	}
 
-	@test('Upgrades error.plugin', 'error.plugin.ts', 'errors')
-	@test('Upgrades schema.plugin', 'schema.plugin.ts', 'schemas')
 	@test(
-		'Upgrades conversation.plugin',
+		'Upgrades error.plugin (even if skill is broken)',
+		'error.plugin.ts',
+		'errors'
+	)
+	@test(
+		'Upgrades schema.plugin (even if skill is broken)',
+		'schema.plugin.ts',
+		'schemas'
+	)
+	@test(
+		'Upgrades conversation.plugin (even if skill is broken)',
 		'conversation.plugin.ts',
-		'conversation'
+		'conversation',
+		false
+	)
+	@test(
+		'Upgrades view.plugin (even if skill is broken)',
+		'view.plugin.ts',
+		'views',
+		false
 	)
-	protected static async upgradesPlugins(pluginName: string, cacheKey: string) {
+	protected static async upgradesPlugins(
+		pluginName: string,
+		cacheKey: string,
+		shouldMockYarn = true
+	) {
 		await this.FeatureFixture().installCachedFeatures(cacheKey)
 
-		CommandService.setMockResponse(/yarn/, { code: 0 })
+		shouldMockYarn && CommandService.setMockResponse(/yarn/, { code: 0 })
 
 		const pluginPath = this.resolveHashSprucePath(`features/${pluginName}`)
 		const originalContents = diskUtil.readFile(pluginPath)
 
-		diskUtil.writeFile(pluginPath, '')
+		diskUtil.writeFile(pluginPath, 'aoeuaoeuaoeuaoeu')
 
 		const results = await this.Action('node', 'upgrade').execute({})
 
+		assert.isFalsy(results.errors)
+
 		testUtil.assertFileByNameInGeneratedFiles(pluginName, results.files)
 
 		const updatedContents = diskUtil.readFile(pluginPath)
 
 		assert.isEqual(updatedContents, originalContents)
+
+		assert.doesInclude(results.summaryLines ?? [], 'Rebuild Complete')
 	}
 
 	@test()

package/src/__tests__/behavioral/skill/UpgradingASkill2.test.ts

@@ -84,7 +84,7 @@ export default class UpgradingASkill2Test extends AbstractCliTest {
 	}
 
 	@test()
-	protected static async callsCleanAndBuildDev() {
+	protected static async callsCleanFixLintAndBuildDev() {
 		await this.FeatureFixture().installCachedFeatures('skills')
 
 		let wasCleanBuildCalled = false
@@ -92,6 +92,7 @@ export default class UpgradingASkill2Test extends AbstractCliTest {
 			return {}
 		}
 
+		let wasFixLintCalled = false
 		CommandService.setMockResponse('yarn clean.build', {
 			code: 0,
 			callback: () => {
@@ -99,6 +100,13 @@ export default class UpgradingASkill2Test extends AbstractCliTest {
 			},
 		})
 
+		CommandService.setMockResponse('yarn fix.lint', {
+			code: 0,
+			callback: () => {
+				wasFixLintCalled = true
+			},
+		})
+
 		let wasBuildDevCalled = false
 
 		CommandService.setMockResponse('yarn build.dev', {
@@ -113,6 +121,7 @@ export default class UpgradingASkill2Test extends AbstractCliTest {
 		assert.isFalsy(results.errors)
 		assert.isTrue(wasCleanBuildCalled)
 		assert.isTrue(wasBuildDevCalled)
+		assert.isTrue(wasFixLintCalled)
 	}
 
 	@test()

package/src/features/error/ErrorFeature.ts

@@ -73,7 +73,9 @@ export default class ErrorFeature extends AbstractFeature {
 		actionCode: string
 	}) {
 		const { featureCode, actionCode } = payload
+
 		const isInstalled = await this.featureInstaller.isInstalled('error')
+
 		const isSkillInstalled = await this.featureInstaller.isInstalled('skill')
 
 		if (isInstalled && featureCode === 'node' && actionCode === 'upgrade') {

package/src/features/error/writers/ErrorWriter.ts

@@ -135,7 +135,7 @@ export default class ErrorWriter extends AbstractWriter {
 		return results
 	}
 
-	public writePlugin(cwd: string) {
+	public async writePlugin(cwd: string) {
 		const destination = diskUtil.resolveHashSprucePath(
 			cwd,
 			'features',
@@ -150,6 +150,8 @@ export default class ErrorWriter extends AbstractWriter {
 			'Supports your skill with Error generation and handling.'
 		)
 
+		await this.lint(destination)
+
 		return results
 	}
 }

package/src/features/event/EventFeature.ts

@@ -9,6 +9,7 @@ import AbstractFeature, {
 } from '../AbstractFeature'
 import { FeatureActionResponse, FeatureCode } from '../features.types'
 import EventContractBuilder from './builders/EventContractBuilder'
+import EventStore from './stores/EventStore'
 
 declare module '../../features/features.types' {
 	interface FeatureMap {
@@ -49,6 +50,7 @@ export default class EventFeature extends AbstractFeature {
 
 	public readonly fileDescriptions: FileDescription[] = []
 	private contractBuilder?: EventContractBuilder
+	private initiatingAction?: string
 
 	public constructor(options: FeatureOptions) {
 		super(options)
@@ -74,26 +76,18 @@ export default class EventFeature extends AbstractFeature {
 		return {}
 	}
 
-	private async handleDidExecute(payload: {
-		featureCode: string
-		actionCode: string
-	}) {
-		const { featureCode, actionCode } = payload
-		const isInstalled = await this.featureInstaller.isInstalled('event')
-
-		if (isInstalled && featureCode === 'node' && actionCode === 'upgrade') {
-			return this.Action('event', 'sync').execute({})
-		}
-
-		return {}
-	}
-
 	private async handleWillExecute(payload: {
 		featureCode: string
 		actionCode: string
 	}): Promise<FeatureActionResponse> {
 		const { featureCode, actionCode } = payload
 
+		if (!this.initiatingAction) {
+			EventStore.clearCache()
+			const combined = this.combineCodes(featureCode, actionCode)
+			this.initiatingAction = combined
+		}
+
 		const isInstalled = await this.featureInstaller.isInstalled('event')
 
 		if (featureCode === 'node' || featureCode === 'upgrade') {
@@ -114,6 +108,30 @@ export default class EventFeature extends AbstractFeature {
 		return {}
 	}
 
+	private async handleDidExecute(payload: {
+		featureCode: string
+		actionCode: string
+	}) {
+		const { featureCode, actionCode } = payload
+		const isInstalled = await this.featureInstaller.isInstalled('event')
+
+		let results = {}
+
+		if (isInstalled && featureCode === 'node' && actionCode === 'upgrade') {
+			results = this.Action('event', 'sync').execute({})
+		}
+
+		if (this.initiatingAction === this.combineCodes(featureCode, actionCode)) {
+			EventStore.clearCache()
+		}
+
+		return results
+	}
+
+	private combineCodes(featureCode: string, actionCode: string) {
+		return `${featureCode}.${actionCode}`
+	}
+
 	private async appendRemoteToResultsOrPrompt(): Promise<FeatureActionResponse> {
 		const remote = this.Service('remote')
 		const r = remote.getRemote()

package/src/features/event/stores/EventStore.ts

@@ -56,6 +56,12 @@ const eventFileNamesImportKeyMap = {
 export default class EventStore extends AbstractStore {
 	public name = 'event'
 	protected static contractCache: Record<string, any> = {}
+	private static localEventCache?: SpruceSchemas.Mercury.v2020_12_25.EventContract
+
+	public static clearCache() {
+		EventStore.localEventCache = undefined
+		EventStore.contractCache = {}
+	}
 
 	public async fetchEventContracts(options?: {
 		localNamespace?: string
@@ -89,10 +95,6 @@ export default class EventStore extends AbstractStore {
 		}
 	}
 
-	public static clearCache() {
-		EventStore.contractCache = {}
-	}
-
 	private async fetchRemoteContracts(namespaces?: string[]) {
 		const key = namespaces?.join('|') ?? '_'
 
@@ -133,6 +135,10 @@ export default class EventStore extends AbstractStore {
 		localNamespace: string,
 		didUpdateHandler?: InternalUpdateHandler
 	): Promise<EventContract | null> {
+		if (EventStore.localEventCache) {
+			return EventStore.localEventCache
+		}
+
 		const localMatches = await globby(
 			diskUtil.resolvePath(
 				this.cwd,
@@ -254,6 +260,8 @@ export default class EventStore extends AbstractStore {
 
 			validateEventContract(cleaned)
 
+			EventStore.localEventCache = cleaned
+
 			return cleaned
 		}
 

package/src/features/node/NodeFeature.ts

@@ -5,7 +5,7 @@ import nodeFeatureOptionsSchema from '#spruce/schemas/spruceCli/v2020_07_22/node
 import { FileDescription, GeneratedFile } from '../../types/cli.types'
 import ScriptUpdater from '../../updaters/ScriptUpdater'
 import AbstractFeature, { FeatureDependency } from '../AbstractFeature'
-import { FeatureCode } from '../features.types'
+import { ActionOptions, FeatureCode } from '../features.types'
 import universalDevDependencies from '../universalDevDependencies'
 import universalFileDescriptions from '../universalFileDescriptions'
 import universalScripts from '../universalScripts'
@@ -44,6 +44,39 @@ export default class NodeFeature<
 
 	public actionsDir = diskUtil.resolvePath(__dirname, 'actions')
 
+	public constructor(options: ActionOptions) {
+		super(options)
+
+		void this.emitter.on('feature.did-execute', async (payload) => {
+			if (payload.featureCode === 'node' && payload.actionCode === 'upgrade') {
+				try {
+					this.ui.startLoading('Cleaning build...')
+					await this.Service('command').execute('yarn clean.build')
+
+					this.ui.startLoading('Applying lint rules to all files...')
+					await this.Service('command').execute('yarn fix.lint')
+
+					this.ui.startLoading('Rebuilding...')
+					await this.Service('command').execute('yarn build.dev')
+
+					return {
+						summaryLines: [
+							'Build folder cleared.',
+							'Lint rules applied.',
+							'Rebuild Complete',
+						],
+					}
+				} catch (err) {
+					return {
+						errors: [err],
+					}
+				}
+			}
+
+			return {}
+		})
+	}
+
 	public async beforePackageInstall(options: Options) {
 		const destination = this.resolveDestination(options)
 

package/src/features/node/actions/UpgradeAction.ts

@@ -32,22 +32,13 @@ export default class UpgradeAction extends AbstractAction<OptionsSchema> {
 
 			const dependencyResults = await this.reInstallPackageDependencies()
 
-			await this.Service('command').execute('yarn clean.build')
-			await this.Service('command').execute('yarn build.dev')
-
-			let results = {
-				summaryLines: ['Build folder cleared.', 'Build complete.'],
-			}
-
-			results = actionUtil.mergeActionResults(results, dependencyResults, {
+			return actionUtil.mergeActionResults(dependencyResults, {
 				headline: 'Upgrade',
 			})
-
-			return results
 		} finally {
 			InFlightEntertainment.stop()
 
-			this.ui.renderHero('Finishing upgrade')
+			this.ui.renderHero('Upgrade')
 		}
 	}
 

package/src/features/test/actions/TestAction.ts

@@ -199,7 +199,10 @@ export default class TestAction extends AbstractAction<OptionsSchema> {
 	private doWeCareAboutThisFileChanging(path: string) {
 		const ext = pathUtil.extname(path)
 
-		if (path.search('testDirsAndFiles') > -1) {
+		if (
+			path.search('testDirsAndFiles') > -1 ||
+			path.search('.change_cache') > -1
+		) {
 			return false
 		}
 

package/src/interfaces/TerminalInterface.ts

@@ -204,11 +204,6 @@ export default class TerminalInterface implements GraphicsInterface {
 			lines: summaryLines,
 		})
 
-		if (errors.length > 0) {
-			this.renderHeadline('Errors')
-			errors.forEach((err) => this.renderError(err))
-		}
-
 		if (packagesInstalled.length > 0) {
 			const table = new Table({
 				head: ['Name', 'Dev'],
@@ -255,6 +250,11 @@ export default class TerminalInterface implements GraphicsInterface {
 			})
 		}
 
+		if (errors.length > 0) {
+			this.renderHeadline('Errors')
+			errors.forEach((err) => this.renderError(err))
+		}
+
 		if (results.totalTime) {
 			this.renderLine(
 				`Total time: ${durationUtil.msToFriendly(results.totalTime)}`