@sproutsocial/seeds-react-menu 1.10.8 → 1.11.0

package/.turbo/turbo-build.log

@@ -1,6 +1,6 @@
 yarn run v1.22.22
 $ tsup --dts
-CLI Building entry: {"index":"src/index.ts","v2/index":"src/v2/index.ts"}
+CLI Building entry: {"index":"src/index.ts","v2/index":"src/v2/index.ts","v3/index":"src/v3/index.ts"}
 CLI Using tsconfig: tsconfig.json
 CLI tsup v8.5.0
 CLI Using tsup config: /home/runner/_work/seeds/seeds/seeds-react/seeds-react-menu/tsup.config.ts
@@ -8,22 +8,28 @@ $ tsup --dts
 CLI Cleaning output folder
 CJS Build start
 ESM Build start
-CJS dist/index.js        91.85 KB
-CJS dist/v2/index.js     73.13 KB
-CJS dist/index.js.map    178.96 KB
-CJS dist/v2/index.js.map 152.10 KB
-CJS ⚡️ Build success in 61ms
-ESM dist/esm/index.js              72.73 KB
+CJS dist/v3/index.js     29.22 KB
+CJS dist/index.js        92.62 KB
+CJS dist/v2/index.js     73.18 KB
+CJS dist/v3/index.js.map 133.01 KB
+CJS dist/index.js.map    180.20 KB
+CJS dist/v2/index.js.map 152.19 KB
+CJS ⚡️ Build success in 67ms
+ESM dist/esm/v3/index.js           23.19 KB
 ESM dist/esm/chunk-ROQATIB7.js     9.15 KB
-ESM dist/esm/v2/index.js           62.59 KB
-ESM dist/esm/index.js.map          154.97 KB
+ESM dist/esm/index.js              73.57 KB
+ESM dist/esm/v2/index.js           62.63 KB
 ESM dist/esm/chunk-ROQATIB7.js.map 22.93 KB
-ESM dist/esm/v2/index.js.map       132.48 KB
-ESM ⚡️ Build success in 62ms
+ESM dist/esm/v3/index.js.map       131.96 KB
+ESM dist/esm/index.js.map          156.22 KB
+ESM dist/esm/v2/index.js.map       132.57 KB
+ESM ⚡️ Build success in 67ms
 DTS Build start
-DTS ⚡️ Build success in 5339ms
-DTS dist/index.d.ts     39.09 KB
+DTS ⚡️ Build success in 6626ms
+DTS dist/index.d.ts     39.08 KB
 DTS dist/v2/index.d.ts  5.55 KB
-DTS dist/index.d.mts    39.09 KB
+DTS dist/v3/index.d.ts  16.64 KB
+DTS dist/index.d.mts    39.08 KB
 DTS dist/v2/index.d.mts 5.55 KB
-Done in 6.05s.
+DTS dist/v3/index.d.mts 16.64 KB
+Done in 7.36s.

package/CHANGELOG.md

@@ -1,5 +1,27 @@
 # @sproutsocial/seeds-react-menu
 
+## 1.11.0
+
+### Minor Changes
+
+- 2f3fa65: Add new base-ui combobox
+
+## 1.10.9
+
+### Patch Changes
+
+- 31b0eb1: [DS-4271] Fix invalid ARIA emitted by `MenuGroup` and `MenuItem`.
+
+  - `MenuGroup` no longer sets `role="group"` on its outer `<li>` (axe
+    `aria-allowed-role`). The group role and `aria-labelledby` now live on
+    the inner `<ul>`, which also resolves the axe `list` and
+    `aria-required-parent` violations.
+  - `MenuItem` strips `aria-selected` from the props returned by
+    downshift's `getItemProps` when used as a `menuitem` (ActionMenu).
+    `aria-selected` is only valid on `role="option"`; for menu items it
+    failed axe `aria-allowed-attr`. Listbox menus (`SingleSelectMenu`,
+    `MultiSelectMenu`) are unchanged.
+
 ## 1.10.8
 
 ### Patch Changes

package/dist/esm/index.js

@@ -144,22 +144,26 @@ var MenuItem = ({
   });
   const item = itemsMap[id] || { index: 0, id };
   const highlighted = highlightedIndex === item?.index;
+  const downshiftItemProps = getItemProps?.({
+    ...isListbox ? {} : { role: "menuitem" },
+    item,
+    index: item.index,
+    // The disabled prop no longer supported in downshift. Use isItemDisabled instead.
+    // disabled,
+    onClick,
+    onKeyDown,
+    ref: innerRef
+  }) ?? {};
+  if (!isListbox && "aria-selected" in downshiftItemProps) {
+    delete downshiftItemProps["aria-selected"];
+  }
   return hiddenItemsMap[item.id] ? /* @__PURE__ */ jsx2(Fragment, {}) : /* @__PURE__ */ jsx2(MenuItemContainer, { role: "none", children: /* @__PURE__ */ jsx2(
     StyledMenuItem,
     {
       id,
       $highlighted: highlighted,
       $active: active,
-      ...getItemProps?.({
-        ...isListbox ? {} : { role: "menuitem" },
-        item,
-        index: item.index,
-        // The disabled prop no longer supported in downshift. Use isItemDisabled instead.
-        // disabled,
-        onClick,
-        onKeyDown,
-        ref: innerRef
-      }),
+      ...downshiftItemProps,
       as: isListbox ? void 0 : href ? "a" : "button",
       type: href ? void 0 : "button",
       href,
@@ -599,20 +603,37 @@ var MenuGroup = ({
   if (!children) {
     return null;
   }
-  return /* @__PURE__ */ jsxs3(
-    StyledMenuGroup,
-    {
-      role: "group",
-      id,
-      isSingleSelect,
-      "aria-labelledby": title ? titleId : void 0,
-      color: color3,
-      ...rest,
-      children: [
-        title && /* @__PURE__ */ jsx8(StyledTitle, { role: "heading", as: titleAs, id: titleId, children: title }),
-        /* @__PURE__ */ jsx8(StyledMenuGroupUl, { children })
-      ]
-    }
+  return (
+    // role="none" on the outer <li>: this wrapper is purely visual (it exists
+    // for the border-bottom divider between groups in the parent menu <ul>).
+    // The ARIA group semantics live on the inner <ul> below — axe rejects
+    // role="group" on <li>, and a native <ul> here would trigger the `list`
+    // rule because its children are <li role="none"> menuitem wrappers.
+    //
+    // TODO(DS-4273): drop the list-based DOM entirely (MenuContent/MenuGroup
+    // as <div>, no <ul>/<li>, no role="none" wrappers). This is the followup
+    // to DS-4271's minimal ARIA patch.
+    /* @__PURE__ */ jsxs3(
+      StyledMenuGroup,
+      {
+        role: "none",
+        id,
+        isSingleSelect,
+        color: color3,
+        ...rest,
+        children: [
+          title && /* @__PURE__ */ jsx8(StyledTitle, { role: "heading", as: titleAs, id: titleId, children: title }),
+          /* @__PURE__ */ jsx8(
+            StyledMenuGroupUl,
+            {
+              role: "group",
+              "aria-labelledby": title ? titleId : void 0,
+              children
+            }
+          )
+        ]
+      }
+    )
   );
 };
 MenuGroup.__MENU_PRIMITIVE_TYPE = "MenuGroup";