@sproutboat/toolchain 0.4.14 → 0.4.15

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @sproutboat/toolchain
 
+## 0.4.15
+
+### Patch Changes
+
+- c9f84ac: Raise Porffor's per-coroutine fiber stack from 256 KiB to 8 MiB. A large async handler compiled at -O0 (`sproutboat dev`) overflowed it within a few nested awaits and died with SIGBUS on its first request (baronunread/sproutboat#178). Only touched pages cost memory.
+
 ## 0.4.14
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sproutboat/toolchain",
-  "version": "0.4.14",
+  "version": "0.4.15",
   "license": "MIT",
   "type": "module",
   "repository": {

package/src/acquire.test.ts

@@ -27,7 +27,8 @@ async function fixture(): Promise<{ archive: string; sha256: string }> {
       "    return 0;\n" +
       "  }\n" +
       "  return -1;\n" +
-      "}\n",
+      "}\n" +
+      "#define PORF_CORO_STACK_SIZE (256u * 1024u)\n",
     "compiler/index.js": "      ...darwinReleaseCompileArgs,\n        uSocketsArchive,\n        '-lm'\n",
     "compiler/precompile.js":
       "const fs = require('node:fs');\n" +

package/src/patch.test.ts

@@ -35,6 +35,9 @@ int porf_native_fetch_read_value(jsval value, const char** out_buf, size_t* out_
 
   return -1;
 }
+
+#define PORF_CORO_STACK_SIZE (256u * 1024u)
+#define PORF_CORO_MAX 16384
 `;
 
 // Porffor's compiler/uwebsockets.js, trimmed to the parts the patch touches:
@@ -289,6 +292,10 @@ test("#165: render.js routes console output to stderr, unbuffered, idempotently"
       "int porf_native_fetch_read_value(jsval value, const char** out_buf, size_t* out_len, char** out_owned) {",
     );
 
+    // #178: fiber stacks big enough for -O0 frames in a few nested awaits.
+    expect(once).toContain("#define PORF_CORO_STACK_SIZE (8u * 1024u * 1024u)");
+    expect(once).not.toContain("(256u * 1024u)");
+
     await patchRenderJs(root);
     expect(await readFile(join(root, "compiler/render.js"), "utf8")).toBe(once);
   } finally {

package/src/patch.ts

@@ -131,6 +131,24 @@ const READ_RAW_INJECT =
   READ_RAW_ANCHOR;
 const READ_RAW_MARKER = "porf_native_fetch_read_raw_bytes(jsval value";
 
+/**
+ * baronunread/sproutboat#178: every async function runs on its own fiber
+ * stack, and alpha-10 fixes those at 256 KiB. A large handler compiled at -O0
+ * (what `sproutboat dev` builds) spends ~40 KiB of stack per call into the
+ * biggest generated functions, so a few nested awaits run off the end into
+ * the guard page and the sprout dies with SIGBUS on its first request, no log.
+ * -O3 frames are smaller, which only raises the threshold: a deep enough
+ * async chain hits it in a release build too.
+ *
+ * Match a thread's usual 8 MiB. The reservation is MAP_NORESERVE with a guard
+ * page, so only touched pages cost memory and a shallow handler pays nothing.
+ */
+const CORO_STACK_ANCHOR = "#define PORF_CORO_STACK_SIZE (256u * 1024u)";
+const CORO_STACK_INJECT =
+  "// sproutboat #178: 256 KiB overflows -O0 frames in a few nested awaits.\n" +
+  "#define PORF_CORO_STACK_SIZE (8u * 1024u * 1024u)";
+const CORO_STACK_MARKER = "sproutboat #178";
+
 /**
  * render.js full-block replacements: `[marker, anchor, inject, what]`, each a
  * complete swap of the matched region (unlike `RENDER_EDITS`, which only ever
@@ -139,6 +157,7 @@ const READ_RAW_MARKER = "porf_native_fetch_read_raw_bytes(jsval value";
 const RENDER_REPLACEMENTS = [
   [BYTESTRING_MARKER, BYTESTRING_ANCHOR, BYTESTRING_INJECT, "bytestring UTF-8 encoding (#172)"],
   [READ_RAW_MARKER, READ_RAW_ANCHOR, READ_RAW_INJECT, "raw bytestring passthrough function (#176)"],
+  [CORO_STACK_MARKER, CORO_STACK_ANCHOR, CORO_STACK_INJECT, "coroutine stack size (#178)"],
 ] as const;
 
 // #15 — no `--port` flag: Porffor's native-fetch entry point calls