@sproutboat/runtime 0.17.0 → 0.17.1

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @sproutboat/runtime
 
+## 0.17.1
+
+### Patch Changes
+
+- 3dabc97: Scheduled, queue and Durable Object alarm triggers answer `204` with no body again. The prelude built that reply as `new Response("", { status: 204 })`, which the Fetch-spec `Response` of 0.17.0 rejects (an empty string is still a body), so the first cron or alarm failed, and on the alarm path the error took the server down.
+
 ## 0.17.0
 
 ### Minor Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sproutboat/runtime",
-  "version": "0.17.0",
+  "version": "0.17.1",
   "license": "MIT",
   "type": "module",
   "repository": {

package/src/native-fetch-prelude.js

@@ -5080,7 +5080,7 @@ async function __sb204WithDrain(res, tasks) {
     __sbLogUncaught("scheduled/alarm", error);
   }
   await __sbDrainWaitUntil(tasks);
-  return new Response("", { status: 204 });
+  return new Response(null, { status: 204 });
 }
 
 async function __sbQueueWithDrain(result, tasks) {
@@ -5179,10 +5179,10 @@ globalThis.__sbEntry = function (handlers, request) {
     } catch (error) {
       // #179 — same rule as fetch: don't let a throw here crash the process.
       __sbLogUncaught("scheduled", error);
-      return new Response("", { status: 204 });
+      return new Response(null, { status: 204 });
     }
     if (__sbTasks.length || (__sres && __sbIsFn(__sres.then))) return __sb204WithDrain(__sres, __sbTasks);
-    return new Response("", { status: 204 });
+    return new Response(null, { status: 204 });
   }
 
   if (trigger === "queue") {
@@ -5214,12 +5214,12 @@ globalThis.__sbEntry = function (handlers, request) {
     } catch (error) {
       // #179 — same rule as fetch: don't let a throw here crash the process.
       __sbLogUncaught("alarm", error);
-      return new Response("", { status: 204 });
+      return new Response(null, { status: 204 });
     }
     // Was fire-and-forget before: an async `alarm()` and any `state.waitUntil()`
     // it queued were both dropped the moment 204 went out. Await both.
     if (inst.__sbTasks.length || (__ares && __sbIsFn(__ares.then))) return __sb204WithDrain(__ares, inst.__sbTasks);
-    return new Response("", { status: 204 });
+    return new Response(null, { status: 204 });
   }
 
   return new Response("unknown trigger", { status: 400 });

package/test/native-waituntil.ts

@@ -15,7 +15,11 @@ const handler = `export default {async fetch(request, env, ctx) {
     return new Response("scheduled");
   }
   if (path === "/state") return new Response(String(globalThis.__done));
+  if (path === "/cron") return new Response(String(globalThis.__cron));
   return new Response("ok");
+},
+async scheduled(event, env, ctx) {
+  ctx.waitUntil(new Promise((resolve) => setTimeout(() => { globalThis.__cron = event.cron; resolve(); }, 50)));
 }};`;
 
 function freePort(): number {
@@ -59,7 +63,7 @@ try {
   const port = freePort();
   server = Bun.spawn([binary], {
     cwd: workdir,
-    env: { ...process.env, PORT: String(port) },
+    env: { ...process.env, PORT: String(port), SB_BROKER_TOKEN: "native-test-token" },
     stdout: "ignore",
     stderr: "inherit",
   });
@@ -82,7 +86,18 @@ try {
   assert.equal(await (await fetch(`http://127.0.0.1:${port}/state`)).text(), "pending");
   await Bun.sleep(700);
   assert.equal(await (await fetch(`http://127.0.0.1:${port}/state`)).text(), "done");
-  console.log(`Native waitUntil runs after the response (${Math.round(elapsed)} ms) and completes`);
+  // A trigger answers 204 with no body. new Response("", { status: 204 }) throws under the
+  // Fetch-spec Response, and the prelude used it: the first cron or alarm took the server down.
+  const cron = await fetch(`http://127.0.0.1:${port}/`, {
+    method: "POST",
+    headers: { "x-sb-trigger": "scheduled", "x-sb-token": "native-test-token", "content-type": "application/json" },
+    body: JSON.stringify({ cron: "*/5 * * * *", scheduledTime: Date.now() }),
+  });
+  assert.equal(cron.status, 204);
+  assert.equal(await cron.text(), "");
+  assert.equal(await (await fetch(`http://127.0.0.1:${port}/cron`)).text(), "*/5 * * * *");
+  assert.equal(server.exitCode, null, "the server exited after a scheduled trigger");
+  console.log(`Native waitUntil runs after the response (${Math.round(elapsed)} ms) and completes; scheduled() answers 204`);
 } finally {
   if (server) {
     server.kill(9);